* [PATCH 00/22] Random ARM randconfig fixes in drivers
@ 2014-05-08 14:46 Arnd Bergmann
[not found] ` <1399560990-1402858-1-git-send-email-arnd@arndb.de>
2014-05-08 16:41 ` [PATCH 00/22] Random ARM randconfig fixes in drivers Guenter Roeck
0 siblings, 2 replies; 10+ messages in thread
From: Arnd Bergmann @ 2014-05-08 14:46 UTC (permalink / raw)
To: linux-arm-kernel
Cc: linux-kernel, Arnd Bergmann, bhelgaas, dwmw2, dmitry.torokhov,
balbi, gregkh, plagnioj, jic23, josh.wu, kishon, linus.walleij,
broonie, mturquette, nicolas.ferre, ohad, linux, tony,
vinod.koul, wim, wsa, dmaengine, linux-i2c, linux-ide, linux-iio,
linux-input, linux-mtd, linux-pci, linux-samsung-soc, linux-sh,
linux-watchdog, netdev
These are a bunch of fixes I had to do to get all randconfig
configurations on ARM working. Most of these are really old
bugs, but there are also some new ones. I don't think any of
them require a backport to linux-stable.
I have checked that they are all still required on yesterday's
linux-next kernel. Please apply on the appropriate trees unless
there are objections.
Patch numbers are per subsystem, which I thought is less confusing
than numbering them 1-22 when they are all totall independent.
Arnd Bergmann (22):
mdio_bus: fix devm_mdiobus_alloc_size export
phy: kona2: use 'select GENERIC_PHY' in Kconfig
phy: exynos: fix SATA phy license typo
dmaengine: omap: hide filter_fn for built-in drivers
dmaengine: sa11x0: remove broken #ifdef
mtd/onenand: fix build warning for dma type
mtd: orion-nand: fix build error with ARMv4
clk/versatile: export symbols for impd1
bus/omap_l3: avoid sync initcall for modules
bus/arm-cci: add dependency on OF && CPU_V7
watchdog: iop_wdt only builds for mach-iop13xx
mpilib: use 'static inline' for mpi-inline.h
ata: pata_at91 only works on sam9
i2c/nuc900: fix ancient build error
iio: always select ANON_INODES
iio:adc: at91 requires the input subsystem
pci: rcar host needs OF
input: fix ps2/serio module dependency
input: atmel-wm97xx: only build for AVR32
misc: atmel_pwm: only build for supported platforms
remoteproc: da8xx: don't select CMA on no-MMU
regulator: arizona-ldo1: add missing #include
drivers/ata/Kconfig | 2 +-
drivers/bus/Kconfig | 2 +-
drivers/bus/omap_l3_noc.c | 4 ++++
drivers/bus/omap_l3_smx.c | 4 ++++
drivers/clk/versatile/clk-icst.c | 1 +
drivers/clk/versatile/clk-impd1.c | 2 ++
drivers/dma/sa11x0-dma.c | 4 ----
drivers/i2c/busses/i2c-nuc900.c | 2 +-
drivers/iio/Kconfig | 1 +
drivers/iio/adc/Kconfig | 1 +
drivers/input/keyboard/Kconfig | 2 +-
drivers/input/mouse/Kconfig | 2 +-
drivers/input/touchscreen/Kconfig | 2 +-
drivers/misc/Kconfig | 3 ++-
drivers/mtd/nand/orion_nand.c | 5 +++++
drivers/mtd/onenand/samsung.c | 8 ++++----
drivers/net/phy/mdio_bus.c | 2 +-
drivers/pci/host/Kconfig | 2 +-
drivers/phy/Kconfig | 2 +-
drivers/phy/phy-exynos5250-sata.c | 2 +-
drivers/regulator/arizona-ldo1.c | 1 +
drivers/remoteproc/Kconfig | 2 +-
drivers/watchdog/Kconfig | 2 +-
include/linux/omap-dma.h | 2 +-
lib/mpi/mpi-inline.h | 2 +-
lib/mpi/mpi-internal.h | 8 --------
26 files changed, 39 insertions(+), 31 deletions(-)
--
1.8.3.2
Cc: bhelgaas@google.com
Cc: dwmw2@infradead.org
Cc: dmitry.torokhov@gmail.com
Cc: balbi@ti.com
Cc: gregkh@linuxfoundation.org
Cc: plagnioj@jcrosoft.com
Cc: jic23@kernel.org
Cc: josh.wu@atmel.com
Cc: kishon@ti.com
Cc: linus.walleij@linaro.org
Cc: broonie@kernel.org
Cc: mturquette@linaro.org
Cc: nicolas.ferre@atmel.com
Cc: ohad@wizery.com
Cc: linux@arm.linux.org.uk
Cc: tony@atomide.com
Cc: vinod.koul@intel.com
Cc: wim@iguana.be
Cc: wsa@the-dreams.de
Cc: dmaengine@vger.kernel.org
Cc: linux-i2c@vger.kernel.org
Cc: linux-ide@vger.kernel.org
Cc: linux-iio@vger.kernel.org
Cc: linux-input@vger.kernel.org
Cc: linux-mtd@lists.infradead.org
Cc: linux-pci@vger.kernel.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: linux-sh@vger.kernel.org
Cc: linux-watchdog@vger.kernel.org
Cc: netdev@vger.kernel.org
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] pci: rcar host needs OF
[not found] ` <1399560990-1402858-1-git-send-email-arnd@arndb.de>
@ 2014-05-08 14:56 ` Arnd Bergmann
2014-05-08 15:06 ` Ben Dooks
2014-05-27 22:54 ` Bjorn Helgaas
0 siblings, 2 replies; 10+ messages in thread
From: Arnd Bergmann @ 2014-05-08 14:56 UTC (permalink / raw)
To: linux-arm-kernel
Cc: linux-kernel, Arnd Bergmann, Bjorn Helgaas, Magnus Damm,
linux-pci, linux-sh
The pci-rcar driver is enabled for compile tests, and this has
now shown that the driver cannot build without CONFIG_OF,
following the inclusion of f8f2fe7355fb "PCI: rcar: Use new OF
interrupt mapping when possible":
drivers/built-in.o: In function `rcar_pci_map_irq':
:(.text+0x1cc7c): undefined reference to `of_irq_parse_and_map_pci'
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Magnus Damm <damm@opensource.se>
Cc: linux-pci@vger.kernel.org
Cc: linux-sh@vger.kernel.org
---
drivers/pci/host/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
index fbbef0b..4675f47 100644
--- a/drivers/pci/host/Kconfig
+++ b/drivers/pci/host/Kconfig
@@ -27,7 +27,7 @@ config PCI_TEGRA
config PCI_RCAR_GEN2
bool "Renesas R-Car Gen2 Internal PCI controller"
- depends on ARCH_SHMOBILE || (ARM && COMPILE_TEST)
+ depends on ARCH_SHMOBILE || (ARM && OF && COMPILE_TEST)
help
Say Y here if you want internal PCI support on R-Car Gen2 SoC.
There are 3 internal PCI controllers available with a single
--
1.8.3.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] pci: rcar host needs OF
2014-05-08 14:56 ` [PATCH] pci: rcar host needs OF Arnd Bergmann
@ 2014-05-08 15:06 ` Ben Dooks
2014-05-08 15:16 ` Geert Uytterhoeven
2014-05-27 22:54 ` Bjorn Helgaas
1 sibling, 1 reply; 10+ messages in thread
From: Ben Dooks @ 2014-05-08 15:06 UTC (permalink / raw)
To: Arnd Bergmann, linux-arm-kernel
Cc: linux-kernel, Bjorn Helgaas, Magnus Damm, linux-pci, linux-sh
On 08/05/14 15:56, Arnd Bergmann wrote:
> The pci-rcar driver is enabled for compile tests, and this has
> now shown that the driver cannot build without CONFIG_OF,
> following the inclusion of f8f2fe7355fb "PCI: rcar: Use new OF
> interrupt mapping when possible":
>
> drivers/built-in.o: In function `rcar_pci_map_irq':
> :(.text+0x1cc7c): undefined reference to `of_irq_parse_and_map_pci'
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Magnus Damm <damm@opensource.se>
> Cc: linux-pci@vger.kernel.org
> Cc: linux-sh@vger.kernel.org
> ---
> drivers/pci/host/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index fbbef0b..4675f47 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -27,7 +27,7 @@ config PCI_TEGRA
>
> config PCI_RCAR_GEN2
> bool "Renesas R-Car Gen2 Internal PCI controller"
> - depends on ARCH_SHMOBILE || (ARM && COMPILE_TEST)
> + depends on ARCH_SHMOBILE || (ARM && OF && COMPILE_TEST)
> help
> Say Y here if you want internal PCI support on R-Car Gen2 SoC.
> There are 3 internal PCI controllers available with a single
>
This driver /should/ be able to be built for just the platform case
so it sounds like f8f2fe7355fb stopped this but no-one has yet to
notice.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] pci: rcar host needs OF
2014-05-08 15:06 ` Ben Dooks
@ 2014-05-08 15:16 ` Geert Uytterhoeven
2014-05-08 15:21 ` Arnd Bergmann
0 siblings, 1 reply; 10+ messages in thread
From: Geert Uytterhoeven @ 2014-05-08 15:16 UTC (permalink / raw)
To: Ben Dooks
Cc: Arnd Bergmann, linux-arm-kernel, linux-kernel, Bjorn Helgaas,
Magnus Damm, linux-pci, Linux-sh list
On Thu, May 8, 2014 at 5:06 PM, Ben Dooks <ben.dooks@codethink.co.uk> wrote:
> On 08/05/14 15:56, Arnd Bergmann wrote:
>>
>> The pci-rcar driver is enabled for compile tests, and this has
>> now shown that the driver cannot build without CONFIG_OF,
>> following the inclusion of f8f2fe7355fb "PCI: rcar: Use new OF
>> interrupt mapping when possible":
>>
>> drivers/built-in.o: In function `rcar_pci_map_irq':
>> :(.text+0x1cc7c): undefined reference to `of_irq_parse_and_map_pci'
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Cc: Bjorn Helgaas <bhelgaas@google.com>
>> Cc: Magnus Damm <damm@opensource.se>
>> Cc: linux-pci@vger.kernel.org
>> Cc: linux-sh@vger.kernel.org
>> ---
>> drivers/pci/host/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
>> index fbbef0b..4675f47 100644
>> --- a/drivers/pci/host/Kconfig
>> +++ b/drivers/pci/host/Kconfig
>> @@ -27,7 +27,7 @@ config PCI_TEGRA
>>
>> config PCI_RCAR_GEN2
>> bool "Renesas R-Car Gen2 Internal PCI controller"
>> - depends on ARCH_SHMOBILE || (ARM && COMPILE_TEST)
>> + depends on ARCH_SHMOBILE || (ARM && OF && COMPILE_TEST)
>> help
>> Say Y here if you want internal PCI support on R-Car Gen2 SoC.
>> There are 3 internal PCI controllers available with a single
>>
>
> This driver /should/ be able to be built for just the platform case
> so it sounds like f8f2fe7355fb stopped this but no-one has yet to
> notice.
You mean include/linux/of_pci.h should provide a dummy version of
of_irq_parse_and_map_pci() returning 0 in case OF=n?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] pci: rcar host needs OF
2014-05-08 15:16 ` Geert Uytterhoeven
@ 2014-05-08 15:21 ` Arnd Bergmann
2014-05-09 6:59 ` Arnd Bergmann
0 siblings, 1 reply; 10+ messages in thread
From: Arnd Bergmann @ 2014-05-08 15:21 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Ben Dooks, linux-arm-kernel, linux-kernel, Bjorn Helgaas,
Magnus Damm, linux-pci, Linux-sh list
On Thursday 08 May 2014 17:16:32 Geert Uytterhoeven wrote:
> On Thu, May 8, 2014 at 5:06 PM, Ben Dooks <ben.dooks@codethink.co.uk> wrote:
> > On 08/05/14 15:56, Arnd Bergmann wrote:
> >>
> >> The pci-rcar driver is enabled for compile tests, and this has
> >> now shown that the driver cannot build without CONFIG_OF,
> >> following the inclusion of f8f2fe7355fb "PCI: rcar: Use new OF
> >> interrupt mapping when possible":
> >>
> >> drivers/built-in.o: In function `rcar_pci_map_irq':
> >> :(.text+0x1cc7c): undefined reference to `of_irq_parse_and_map_pci'
> >>
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >> Cc: Bjorn Helgaas <bhelgaas@google.com>
> >> Cc: Magnus Damm <damm@opensource.se>
> >> Cc: linux-pci@vger.kernel.org
> >> Cc: linux-sh@vger.kernel.org
> >> ---
> >> drivers/pci/host/Kconfig | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> >> index fbbef0b..4675f47 100644
> >> --- a/drivers/pci/host/Kconfig
> >> +++ b/drivers/pci/host/Kconfig
> >> @@ -27,7 +27,7 @@ config PCI_TEGRA
> >>
> >> config PCI_RCAR_GEN2
> >> bool "Renesas R-Car Gen2 Internal PCI controller"
> >> - depends on ARCH_SHMOBILE || (ARM && COMPILE_TEST)
> >> + depends on ARCH_SHMOBILE || (ARM && OF && COMPILE_TEST)
> >> help
> >> Say Y here if you want internal PCI support on R-Car Gen2 SoC.
> >> There are 3 internal PCI controllers available with a single
> >>
> >
> > This driver /should/ be able to be built for just the platform case
> > so it sounds like f8f2fe7355fb stopped this but no-one has yet to
> > notice.
>
> You mean include/linux/of_pci.h should provide a dummy version of
> of_irq_parse_and_map_pci() returning 0 in case OF=n?
Good idea, I'll give this patch some testing in the randconfig builder,
replacing the one above.
Arnd
diff --git a/include/linux/of_pci.h b/include/linux/of_pci.h
index 1a1f5ff..b6f2621 100644
--- a/include/linux/of_pci.h
+++ b/include/linux/of_pci.h
@@ -7,7 +7,6 @@
struct pci_dev;
struct of_phandle_args;
int of_irq_parse_pci(const struct pci_dev *pdev, struct of_phandle_args *out_irq);
-int of_irq_parse_and_map_pci(const struct pci_dev *dev, u8 slot, u8 pin);
struct device_node;
struct device_node *of_pci_find_child_device(struct device_node *parent,
@@ -19,11 +18,14 @@ int of_pci_parse_bus_range(struct device_node *node, struct resource *res);
int of_pci_msi_chip_add(struct msi_chip *chip);
void of_pci_msi_chip_remove(struct msi_chip *chip);
struct msi_chip *of_pci_find_msi_chip_by_node(struct device_node *of_node);
+int of_irq_parse_and_map_pci(const struct pci_dev *dev, u8 slot, u8 pin);
#else
static inline int of_pci_msi_chip_add(struct msi_chip *chip) { return -EINVAL; }
static inline void of_pci_msi_chip_remove(struct msi_chip *chip) { }
static inline struct msi_chip *
of_pci_find_msi_chip_by_node(struct device_node *of_node) { return NULL; }
+static inline int
+of_irq_parse_and_map_pci(const struct pci_dev *dev, u8 slot, u8 pin) { return 0; }
#endif
#endif
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 00/22] Random ARM randconfig fixes in drivers
2014-05-08 14:46 [PATCH 00/22] Random ARM randconfig fixes in drivers Arnd Bergmann
[not found] ` <1399560990-1402858-1-git-send-email-arnd@arndb.de>
@ 2014-05-08 16:41 ` Guenter Roeck
2014-05-09 11:48 ` Arnd Bergmann
1 sibling, 1 reply; 10+ messages in thread
From: Guenter Roeck @ 2014-05-08 16:41 UTC (permalink / raw)
To: Arnd Bergmann
Cc: linux-arm-kernel, linux-kernel, bhelgaas, dwmw2, dmitry.torokhov,
balbi, gregkh, plagnioj, jic23, josh.wu, kishon, linus.walleij,
broonie, mturquette, nicolas.ferre, ohad, linux, tony,
vinod.koul, wim, wsa, dmaengine, linux-i2c, linux-ide, linux-iio,
linux-input, linux-mtd, linux-pci, linux-samsung-soc, linux-sh,
linux-watchdog, netdev
On Thu, May 08, 2014 at 04:46:51PM +0200, Arnd Bergmann wrote:
> These are a bunch of fixes I had to do to get all randconfig
> configurations on ARM working. Most of these are really old
> bugs, but there are also some new ones. I don't think any of
> them require a backport to linux-stable.
>
> I have checked that they are all still required on yesterday's
> linux-next kernel. Please apply on the appropriate trees unless
> there are objections.
>
Is this series of patches also going to fix arm:allmodconfig ?
Thanks,
Guenter
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] pci: rcar host needs OF
2014-05-08 15:21 ` Arnd Bergmann
@ 2014-05-09 6:59 ` Arnd Bergmann
0 siblings, 0 replies; 10+ messages in thread
From: Arnd Bergmann @ 2014-05-09 6:59 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Geert Uytterhoeven, Linux-sh list, linux-pci, linux-kernel,
Magnus Damm, Ben Dooks, Bjorn Helgaas
On Thursday 08 May 2014 17:21:54 Arnd Bergmann wrote:
> On Thursday 08 May 2014 17:16:32 Geert Uytterhoeven wrote:
> > On Thu, May 8, 2014 at 5:06 PM, Ben Dooks <ben.dooks@codethink.co.uk> wrote:
> > >> @@ -27,7 +27,7 @@ config PCI_TEGRA
> > >>
> > >> config PCI_RCAR_GEN2
> > >> bool "Renesas R-Car Gen2 Internal PCI controller"
> > >> - depends on ARCH_SHMOBILE || (ARM && COMPILE_TEST)
> > >> + depends on ARCH_SHMOBILE || (ARM && OF && COMPILE_TEST)
> > >> help
> > >> Say Y here if you want internal PCI support on R-Car Gen2 SoC.
> > >> There are 3 internal PCI controllers available with a single
> > >>
> > >
> > > This driver /should/ be able to be built for just the platform case
> > > so it sounds like f8f2fe7355fb stopped this but no-one has yet to
> > > notice.
> >
> > You mean include/linux/of_pci.h should provide a dummy version of
> > of_irq_parse_and_map_pci() returning 0 in case OF=n?
>
> Good idea, I'll give this patch some testing in the randconfig builder,
> replacing the one above.
The first version was flawed, I submitted a new patch "[PATCH] of/irq:
provide int of_irq_parse_and_map_pci wrapper" now.
Arnd
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 00/22] Random ARM randconfig fixes in drivers
2014-05-08 16:41 ` [PATCH 00/22] Random ARM randconfig fixes in drivers Guenter Roeck
@ 2014-05-09 11:48 ` Arnd Bergmann
0 siblings, 0 replies; 10+ messages in thread
From: Arnd Bergmann @ 2014-05-09 11:48 UTC (permalink / raw)
To: Guenter Roeck
Cc: linux-arm-kernel, linux-kernel, bhelgaas, dwmw2, dmitry.torokhov,
balbi, gregkh, plagnioj, jic23, josh.wu, kishon, linus.walleij,
broonie, mturquette, nicolas.ferre, ohad, linux, tony,
vinod.koul, wim, wsa, dmaengine, linux-i2c, linux-ide, linux-iio,
linux-input, linux-mtd, linux-pci, linux-samsung-soc, linux-sh,
linux-watchdog, netdev
On Thursday 08 May 2014, Guenter Roeck wrote:
> On Thu, May 08, 2014 at 04:46:51PM +0200, Arnd Bergmann wrote:
> > These are a bunch of fixes I had to do to get all randconfig
> > configurations on ARM working. Most of these are really old
> > bugs, but there are also some new ones. I don't think any of
> > them require a backport to linux-stable.
> >
> > I have checked that they are all still required on yesterday's
> > linux-next kernel. Please apply on the appropriate trees unless
> > there are objections.
> >
> Is this series of patches also going to fix arm:allmodconfig ?
Possibly, I haven't checked in a while. I'm unfortunately sitting on
about 200 other patches in the same branch, which together fix all
build errors in any configuration I encountered.
I should really do some allmodconfig/allnoconfig/allyesconfig
builds without my series again, and prioritize sending out the
ones required for that.
Arnd
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] pci: rcar host needs OF
2014-05-08 14:56 ` [PATCH] pci: rcar host needs OF Arnd Bergmann
2014-05-08 15:06 ` Ben Dooks
@ 2014-05-27 22:54 ` Bjorn Helgaas
2014-05-28 1:37 ` Jingoo Han
1 sibling, 1 reply; 10+ messages in thread
From: Bjorn Helgaas @ 2014-05-27 22:54 UTC (permalink / raw)
To: Arnd Bergmann
Cc: linux-arm-kernel, linux-kernel, Magnus Damm, linux-pci, linux-sh
On Thu, May 08, 2014 at 04:56:25PM +0200, Arnd Bergmann wrote:
> The pci-rcar driver is enabled for compile tests, and this has
> now shown that the driver cannot build without CONFIG_OF,
> following the inclusion of f8f2fe7355fb "PCI: rcar: Use new OF
> interrupt mapping when possible":
>
> drivers/built-in.o: In function `rcar_pci_map_irq':
> :(.text+0x1cc7c): undefined reference to `of_irq_parse_and_map_pci'
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Magnus Damm <damm@opensource.se>
> Cc: linux-pci@vger.kernel.org
> Cc: linux-sh@vger.kernel.org
If I understand correctly, this patch was superceded by this one:
"[PATCH] of/irq: provide int of_irq_parse_and_map_pci wrapper"
and you aren't expecting me to do anything. Let me know if otherwise.
> ---
> drivers/pci/host/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index fbbef0b..4675f47 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -27,7 +27,7 @@ config PCI_TEGRA
>
> config PCI_RCAR_GEN2
> bool "Renesas R-Car Gen2 Internal PCI controller"
> - depends on ARCH_SHMOBILE || (ARM && COMPILE_TEST)
> + depends on ARCH_SHMOBILE || (ARM && OF && COMPILE_TEST)
> help
> Say Y here if you want internal PCI support on R-Car Gen2 SoC.
> There are 3 internal PCI controllers available with a single
> --
> 1.8.3.2
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] pci: rcar host needs OF
2014-05-27 22:54 ` Bjorn Helgaas
@ 2014-05-28 1:37 ` Jingoo Han
0 siblings, 0 replies; 10+ messages in thread
From: Jingoo Han @ 2014-05-28 1:37 UTC (permalink / raw)
To: 'Bjorn Helgaas', 'Arnd Bergmann'
Cc: linux-arm-kernel, linux-kernel, 'Magnus Damm',
linux-pci, linux-sh, 'Jingoo Han'
On Wednesday, May 28, 2014 7:54 AM, Bjorn Helgaas wrote:
> On Thu, May 08, 2014 at 04:56:25PM +0200, Arnd Bergmann wrote:
> > The pci-rcar driver is enabled for compile tests, and this has
> > now shown that the driver cannot build without CONFIG_OF,
> > following the inclusion of f8f2fe7355fb "PCI: rcar: Use new OF
> > interrupt mapping when possible":
> >
> > drivers/built-in.o: In function `rcar_pci_map_irq':
> > :(.text+0x1cc7c): undefined reference to `of_irq_parse_and_map_pci'
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Cc: Bjorn Helgaas <bhelgaas@google.com>
> > Cc: Magnus Damm <damm@opensource.se>
> > Cc: linux-pci@vger.kernel.org
> > Cc: linux-sh@vger.kernel.org
>
> If I understand correctly, this patch was superceded by this one:
>
> "[PATCH] of/irq: provide int of_irq_parse_and_map_pci wrapper"
>
> and you aren't expecting me to do anything. Let me know if otherwise.
Yes, right. I checked that the build error was resolved by the above
mentioned patch.
Best regards,
Jingoo Han
>
> > ---
> > drivers/pci/host/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> > index fbbef0b..4675f47 100644
> > --- a/drivers/pci/host/Kconfig
> > +++ b/drivers/pci/host/Kconfig
> > @@ -27,7 +27,7 @@ config PCI_TEGRA
> >
> > config PCI_RCAR_GEN2
> > bool "Renesas R-Car Gen2 Internal PCI controller"
> > - depends on ARCH_SHMOBILE || (ARM && COMPILE_TEST)
> > + depends on ARCH_SHMOBILE || (ARM && OF && COMPILE_TEST)
> > help
> > Say Y here if you want internal PCI support on R-Car Gen2 SoC.
> > There are 3 internal PCI controllers available with a single
> > --
> > 1.8.3.2
> >
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-05-28 1:37 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-08 14:46 [PATCH 00/22] Random ARM randconfig fixes in drivers Arnd Bergmann
[not found] ` <1399560990-1402858-1-git-send-email-arnd@arndb.de>
2014-05-08 14:56 ` [PATCH] pci: rcar host needs OF Arnd Bergmann
2014-05-08 15:06 ` Ben Dooks
2014-05-08 15:16 ` Geert Uytterhoeven
2014-05-08 15:21 ` Arnd Bergmann
2014-05-09 6:59 ` Arnd Bergmann
2014-05-27 22:54 ` Bjorn Helgaas
2014-05-28 1:37 ` Jingoo Han
2014-05-08 16:41 ` [PATCH 00/22] Random ARM randconfig fixes in drivers Guenter Roeck
2014-05-09 11:48 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).