From: Richard Zhu <hongxing.zhu@nxp.com>
To: l.stach@pengutronix.de, bhelgaas@google.com, broonie@kernel.org,
lorenzo.pieralisi@arm.com, jingoohan1@gmail.com
Cc: linux-pci@vger.kernel.org, linux-imx@nxp.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: [PATCH v4 0/6] PCI: imx6: refine codes and add compliance tests mode support
Date: Mon, 1 Nov 2021 14:17:52 +0800 [thread overview]
Message-ID: <1635747478-25562-1-git-send-email-hongxing.zhu@nxp.com> (raw)
This series patches refine pci-imx6 driver and do the following changes.
- Encapsulate the clock enable into one standalone function
- Add the error propagation from host_init
- Balance the usage of the regulator and clocks when link never came up
- Add the compliance tests mode support
Main changes from v3 to v4:
- Regarding Mark's comments, delete the regulator_is_enabled() check.
- Squash #3 and #6 of v3 patch into #5 patch of v4 set.
Main changes from v2 to v3:
- Add "Reviewed-by: Lucas Stach <l.stach@pengutronix.de>" tag into
first two patches.
- Add a Fixes tag into #3 patch.
- Split the #4 of v2 to two patches, one is clock disable codes move,
the other one is the acutal clock unbalance fix.
- Add a new host_exit() callback into dw_pcie_host_ops, then it could be
invoked to handle the unbalance issue in the error handling after
host_init() function when link is down.
- Add a new host_exit() callback for i.MX PCIe driver to handle this case
in the error handling after host_init.
Main changes from v1 to v2:
Regarding Lucas' comments.
- Move the placement of the new imx6_pcie_clk_enable() to avoid the
forward declarition.
- Seperate the second patch of v1 patch-set to three patches.
- Use the module_param to replace the kernel command line.
Regarding Bjorn's comments:
- Use the cover-letter for a multi-patch series.
- Correct the subject line, and refine the commit logs. For example,
remove the timestamp of the logs.
drivers/pci/controller/dwc/pci-imx6.c | 187 +++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------------------
drivers/pci/controller/dwc/pcie-designware-host.c | 5 ++-
drivers/pci/controller/dwc/pcie-designware.h | 1 +
3 files changed, 119 insertions(+), 74 deletions(-)
[PATCH v4 1/6] PCI: imx6: Encapsulate the clock enable into one
[PATCH v4 2/6] PCI: imx6: Add the error propagation from host_init
[PATCH v4 3/6] PCI: imx6: PCI: imx6: Move imx6_pcie_clk_disable()
[PATCH v4 4/6] PCI: dwc: Add dw_pcie_host_ops.host_exit() callback
[PATCH v4 5/6] PCI: imx6: Fix the regulator dump when link never came
[PATCH v4 6/6] PCI: imx6: Add the compliance tests mode support
next reply other threads:[~2021-11-01 6:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 6:17 Richard Zhu [this message]
2021-11-01 6:17 ` [PATCH v4 1/6] PCI: imx6: Encapsulate the clock enable into one standalone function Richard Zhu
2021-11-01 6:17 ` [PATCH v4 2/6] PCI: imx6: Add the error propagation from host_init Richard Zhu
2021-11-01 6:17 ` [PATCH v4 3/6] PCI: imx6: PCI: imx6: Move imx6_pcie_clk_disable() earlier Richard Zhu
2021-11-15 7:05 ` Hongxing Zhu
2021-11-01 6:17 ` [PATCH v4 4/6] PCI: dwc: Add dw_pcie_host_ops.host_exit() callback Richard Zhu
2021-11-01 6:17 ` [PATCH v4 5/6] PCI: imx6: Fix the regulator dump when link never came up Richard Zhu
2021-11-01 15:36 ` Mark Brown
2021-11-01 6:17 ` [PATCH v4 6/6] PCI: imx6: Add the compliance tests mode support Richard Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1635747478-25562-1-git-send-email-hongxing.zhu@nxp.com \
--to=hongxing.zhu@nxp.com \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=jingoohan1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).