From: Lukas Wunner <lukas@wunner.de>
To: Peter Wu <peter@lekensteyn.nl>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Kedar A Dongre <kedar.a.dongre@intel.com>,
Linux PCI <linux-pci@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH v2] PCI: Block power management of certain ports with slot implemented bit set
Date: Tue, 8 Jan 2019 11:16:00 +0100 [thread overview]
Message-ID: <20190108101600.5qbeks5ux6wgpbpy@wunner.de> (raw)
In-Reply-To: <20190108093507.GX2469@lahna.fi.intel.com>
Hi Peter,
On Tue, Jan 08, 2019 at 11:35:07AM +0200, Mika Westerberg wrote:
> On Mon, Jan 07, 2019 at 02:13:14PM +0100, Rafael J. Wysocki wrote:
> > On Mon, Jan 7, 2019 at 2:01 PM Mika Westerberg
> > <mika.westerberg@linux.intel.com> wrote:
> > >
> > > Gigabyte X299 DESIGNARE EX motherboard has one PCIe root port that is
> > > connected to Alpine Ridge Thunderbolt controller. This port has slot
> > > implemented bit set in the config space but other than that it is not
> > > hotplug capable in the sense we are expecting in Linux (it has
> > > dev->is_hotplug_bridge set to 0):
> > >
> > > 00:1c.4 PCI bridge: Intel Corporation 200 Series PCH PCI Express Root Port #5
> > > Bus: primary=00, secondary=05, subordinate=46, sec-latency=0
> > > Memory behind bridge: 78000000-8fffffff [size=384M]
> > > Prefetchable memory behind bridge: 00003800f8000000-00003800ffffffff [size=128M]
> > > ...
> > > Capabilities: [40] Express (v2) Root Port (Slot+), MSI 00
> > > ...
> > > SltCap: AttnBtn- PwrCtrl- MRL- AttnInd- PwrInd- HotPlug- Surprise-
> > > Slot #8, PowerLimit 25.000W; Interlock- NoCompl+
> > > SltCtl: Enable: AttnBtn- PwrFlt- MRL- PresDet- CmdCplt- HPIrq- LinkChg-
> > > Control: AttnInd Unknown, PwrInd Unknown, Power- Interlock-
> > > SltSta: Status: AttnBtn- PowerFlt- MRL- CmdCplt- PresDet- Interlock-
> > > Changed: MRL- PresDet+ LinkState+
> > >
> > > This system is using ACPI based hotplug to notify the OS that it needs
> > > to rescan the PCI bus (ACPI hotplug).
> > >
> > > If there is nothing connected to any of the Thunderbolt ports the root
> > > port will not have any runtime PM active children and is thus
> > > automatically runtime suspended pretty soon after boot by PCI PM core.
> > > Now, when a device is connected the BIOS SMI handler responsible for
> > > enumerating newly added devices is not able to find anything because the
> > > port is in D3.
> > >
> > > For this reason we block power management of PCIe root and downstream
> > > ports that have slot implemented set and have node in ACPI namespace.
> > >
> > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=202031
> > > Reported-by: Kedar A Dongre <kedar.a.dongre@intel.com>
> > > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> >
> > Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Thanks!
>
> However, I'm having second toughts about this because I remembered that
> people put a lot of effort getting discrete graphics with power resource
> attached to the root port powering off properly. If the root port
> matches the criteria in this patch it will not be able to go into D3
> anymore. It might affect others such as M.2 connected NVMe or WiFi chip
> as well. For that reason I would still prefer blacklist, at least for now.
Would this patch:
https://patchwork.ozlabs.org/patch/1021317/
break runtime D3cold for the discrete GPU on Optimus laptops such as
your Clevo P651RA? Specifically, is the Root Port above the GPU
marked "(Slot+)" in lspci -vv? (There doesn't seem to be raw lspci
output in https://github.com/Lekensteyn/acpi-stuff)
Thanks,
Lukas
next prev parent reply other threads:[~2019-01-08 10:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 13:01 [PATCH v2] PCI: Block power management of certain ports with slot implemented bit set Mika Westerberg
2019-01-07 13:13 ` Rafael J. Wysocki
2019-01-08 9:35 ` Mika Westerberg
2019-01-08 9:43 ` Rafael J. Wysocki
2019-01-08 10:16 ` Lukas Wunner [this message]
2019-01-08 10:58 ` Peter Wu
2019-01-08 12:45 ` Mika Westerberg
2019-01-08 21:00 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190108101600.5qbeks5ux6wgpbpy@wunner.de \
--to=lukas@wunner.de \
--cc=bhelgaas@google.com \
--cc=kedar.a.dongre@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=peter@lekensteyn.nl \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).