linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Manikanta Maddireddy <mmaddireddy@nvidia.com>
To: <thierry.reding@gmail.com>, <bhelgaas@google.com>,
	<robh+dt@kernel.org>, <mark.rutland@arm.com>,
	<jonathanh@nvidia.com>, <lorenzo.pieralisi@arm.com>,
	<vidyas@nvidia.com>
Cc: <linux-tegra@vger.kernel.org>, <linux-pci@vger.kernel.org>,
	<devicetree@vger.kernel.org>,
	Manikanta Maddireddy <mmaddireddy@nvidia.com>
Subject: [PATCH V3 17/29] PCI: tegra: Fix PLLE power down issue due to CLKREQ# signal
Date: Mon, 13 May 2019 23:37:32 +0530	[thread overview]
Message-ID: <20190513180744.16493-18-mmaddireddy@nvidia.com> (raw)
In-Reply-To: <20190513180744.16493-1-mmaddireddy@nvidia.com>

Disable controllers which failed to link up and configure CLKREQ# signals
of these controllers as GPIO. This is required to avoid CLKREQ# signal of
inactive controllers interfering with PLLE power down sequence.

PCIE_CLKREQ_GPIO bits are defined only in Tegra186, however programming
these bits in other SoCs doesn't cause any side effects. Program these
bits for all Tegra SoCs to avoid conditional check.

Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com>
Acked-by: Thierry Reding <treding@nvidia.com>
---
V3: No change

V2: Corrected the comment in driver

 drivers/pci/controller/pci-tegra.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c
index 9ee111062ab7..4767af9f3b88 100644
--- a/drivers/pci/controller/pci-tegra.c
+++ b/drivers/pci/controller/pci-tegra.c
@@ -160,6 +160,8 @@
 #define  AFI_PCIE_CONFIG_SM2TMS0_XBAR_CONFIG_211	(0x1 << 20)
 #define  AFI_PCIE_CONFIG_SM2TMS0_XBAR_CONFIG_411	(0x2 << 20)
 #define  AFI_PCIE_CONFIG_SM2TMS0_XBAR_CONFIG_111	(0x2 << 20)
+#define  AFI_PCIE_CONFIG_PCIE_CLKREQ_GPIO(x)		(1 << ((x) + 29))
+#define  AFI_PCIE_CONFIG_PCIE_CLKREQ_GPIO_ALL		(0x7 << 29)
 
 #define AFI_FUSE			0x104
 #define  AFI_FUSE_PCIE_T0_GEN2_DIS	(1 << 2)
@@ -741,6 +743,12 @@ static void tegra_pcie_port_disable(struct tegra_pcie_port *port)
 
 	value &= ~AFI_PEX_CTRL_REFCLK_EN;
 	afi_writel(port->pcie, value, ctrl);
+
+	/* disable PCIe port and set CLKREQ# as GPIO to allow PLLE power down */
+	value = afi_readl(port->pcie, AFI_PCIE_CONFIG);
+	value |= AFI_PCIE_CONFIG_PCIE_DISABLE(port->index);
+	value |= AFI_PCIE_CONFIG_PCIE_CLKREQ_GPIO(port->index);
+	afi_writel(port->pcie, value, AFI_PCIE_CONFIG);
 }
 
 static void tegra_pcie_port_free(struct tegra_pcie_port *port)
@@ -1153,9 +1161,12 @@ static void tegra_pcie_enable_controller(struct tegra_pcie *pcie)
 	value = afi_readl(pcie, AFI_PCIE_CONFIG);
 	value &= ~AFI_PCIE_CONFIG_SM2TMS0_XBAR_CONFIG_MASK;
 	value |= AFI_PCIE_CONFIG_PCIE_DISABLE_ALL | pcie->xbar_config;
+	value |= AFI_PCIE_CONFIG_PCIE_CLKREQ_GPIO_ALL;
 
-	list_for_each_entry(port, &pcie->ports, list)
+	list_for_each_entry(port, &pcie->ports, list) {
 		value &= ~AFI_PCIE_CONFIG_PCIE_DISABLE(port->index);
+		value &= ~AFI_PCIE_CONFIG_PCIE_CLKREQ_GPIO(port->index);
+	}
 
 	afi_writel(pcie, value, AFI_PCIE_CONFIG);
 
-- 
2.17.1


  parent reply	other threads:[~2019-05-13 18:09 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-13 18:07 [PATCH V3 00/29] Enable Tegra PCIe root port features Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 01/29] soc/tegra: pmc: Export tegra_powergate_power_on() Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 02/29] PCI: tegra: Handle failure cases in tegra_pcie_power_on() Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 03/29] PCI: tegra: Rearrange Tegra PCIe driver functions Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 04/29] PCI: tegra: Mask AFI_INTR in runtime suspend Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 05/29] PCI: tegra: Fix PCIe host power up sequence Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 06/29] PCI: tegra: Add PCIe Gen2 link speed support Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 07/29] PCI: tegra: Advertise PCIe Advanced Error Reporting (AER) capability Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 08/29] PCI: tegra: Program UPHY electrical settings for Tegra210 Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 09/29] PCI: tegra: Enable opportunistic UpdateFC and ACK Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 10/29] PCI: tegra: Disable AFI dynamic clock gating Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 11/29] PCI: tegra: Process pending DLL transactions before entering L1 or L2 Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 12/29] PCI: tegra: Enable PCIe xclk clock clamping Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 13/29] PCI: tegra: Increase the deskew retry time Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 14/29] PCI: tegra: Add SW fixup for RAW violations Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 15/29] PCI: tegra: Update flow control timer frequency in Tegra210 Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 16/29] PCI: tegra: Set target speed as Gen1 before starting LTSSM Manikanta Maddireddy
2019-05-13 18:07 ` Manikanta Maddireddy [this message]
2019-05-13 18:07 ` [PATCH V3 18/29] PCI: tegra: Program AFI_CACHE* registers only for Tegra20 Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 19/29] PCI: tegra: Change PRSNT_SENSE IRQ log to debug Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 20/29] PCI: tegra: Use legacy IRQ for port service drivers Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 21/29] PCI: tegra: Add AFI_PEX2_CTRL reg offset as part of soc struct Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 22/29] PCI: tegra: Access endpoint config only if PCIe link is up Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 23/29] dt-bindings: pci: tegra: Document PCIe DPD pinctrl optional prop Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 24/29] arm64: tegra: Add PEX DPD states as pinctrl properties Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 25/29] PCI: tegra: Put PEX CLK & BIAS pads in DPD mode Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 26/29] PCI: Add DT binding for "reset-gpios" property Manikanta Maddireddy
2019-05-14 18:23   ` Rob Herring
2019-05-13 18:07 ` [PATCH V3 27/29] PCI: OF: Add of_pci_get_reset_gpio() to parse reset-gpios from DT Manikanta Maddireddy
2019-05-14 18:31   ` Rob Herring
2019-05-16  5:50     ` Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 28/29] PCI: tegra: Add support for GPIO based PERST# Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 29/29] PCI: tegra: Change link retry log level to debug Manikanta Maddireddy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190513180744.16493-18-mmaddireddy@nvidia.com \
    --to=mmaddireddy@nvidia.com \
    --cc=bhelgaas@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=vidyas@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).