linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Manikanta Maddireddy <mmaddireddy@nvidia.com>
To: <thierry.reding@gmail.com>, <bhelgaas@google.com>,
	<robh+dt@kernel.org>, <mark.rutland@arm.com>,
	<jonathanh@nvidia.com>, <lorenzo.pieralisi@arm.com>,
	<vidyas@nvidia.com>
Cc: <linux-tegra@vger.kernel.org>, <linux-pci@vger.kernel.org>,
	<devicetree@vger.kernel.org>,
	Manikanta Maddireddy <mmaddireddy@nvidia.com>
Subject: [PATCH V3 28/29] PCI: tegra: Add support for GPIO based PERST#
Date: Mon, 13 May 2019 23:37:43 +0530	[thread overview]
Message-ID: <20190513180744.16493-29-mmaddireddy@nvidia.com> (raw)
In-Reply-To: <20190513180744.16493-1-mmaddireddy@nvidia.com>

Add support for GPIO based PERST# signal. GPIO number comes from per port
PCIe device tree node.

Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com>
---
V3: Using helper function to get reset-gpios

V2: Using standard "reset-gpio" property

 drivers/pci/controller/pci-tegra.c | 42 +++++++++++++++++++++++++-----
 1 file changed, 36 insertions(+), 6 deletions(-)

diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c
index 06b99fcbf382..b021863303f1 100644
--- a/drivers/pci/controller/pci-tegra.c
+++ b/drivers/pci/controller/pci-tegra.c
@@ -17,6 +17,7 @@
 #include <linux/debugfs.h>
 #include <linux/delay.h>
 #include <linux/export.h>
+#include <linux/gpio.h>
 #include <linux/interrupt.h>
 #include <linux/iopoll.h>
 #include <linux/irq.h>
@@ -400,6 +401,8 @@ struct tegra_pcie_port {
 	unsigned int lanes;
 
 	struct phy **phys;
+
+	struct gpio_desc *reset_gpiod;
 };
 
 struct tegra_pcie_bus {
@@ -583,15 +586,23 @@ static void tegra_pcie_port_reset(struct tegra_pcie_port *port)
 	unsigned long value;
 
 	/* pulse reset signal */
-	value = afi_readl(port->pcie, ctrl);
-	value &= ~AFI_PEX_CTRL_RST;
-	afi_writel(port->pcie, value, ctrl);
+	if (port->reset_gpiod) {
+		gpiod_set_value(port->reset_gpiod, 0);
+	} else {
+		value = afi_readl(port->pcie, ctrl);
+		value &= ~AFI_PEX_CTRL_RST;
+		afi_writel(port->pcie, value, ctrl);
+	}
 
 	usleep_range(1000, 2000);
 
-	value = afi_readl(port->pcie, ctrl);
-	value |= AFI_PEX_CTRL_RST;
-	afi_writel(port->pcie, value, ctrl);
+	if (port->reset_gpiod) {
+		gpiod_set_value(port->reset_gpiod, 1);
+	} else {
+		value = afi_readl(port->pcie, ctrl);
+		value |= AFI_PEX_CTRL_RST;
+		afi_writel(port->pcie, value, ctrl);
+	}
 }
 
 static void tegra_pcie_enable_rp_features(struct tegra_pcie_port *port)
@@ -2238,6 +2249,7 @@ static int tegra_pcie_parse_dt(struct tegra_pcie *pcie)
 		struct tegra_pcie_port *rp;
 		unsigned int index;
 		u32 value;
+		char *label;
 
 		err = of_pci_get_devfn(port);
 		if (err < 0) {
@@ -2296,6 +2308,24 @@ static int tegra_pcie_parse_dt(struct tegra_pcie *pcie)
 		if (IS_ERR(rp->base))
 			return PTR_ERR(rp->base);
 
+		label = kasprintf(GFP_KERNEL, "pex-reset-%u", index);
+		if (!label) {
+			dev_err(dev, "failed to create reset GPIO label\n");
+			return -ENOMEM;
+		}
+
+		rp->reset_gpiod = of_pci_get_reset_gpio(dev, port,
+							GPIOD_OUT_LOW, label);
+		kfree(label);
+		if (!rp->reset_gpiod) {
+			dev_dbg(dev, "missing optional reset-gpios prop\n");
+		} else if (IS_ERR(rp->reset_gpiod)) {
+			err = PTR_ERR(rp->reset_gpiod);
+			rp->reset_gpiod = NULL;
+			dev_err(dev, "failed to get reset GPIO: %d\n", err);
+			return err;
+		}
+
 		list_add_tail(&rp->list, &pcie->ports);
 	}
 
-- 
2.17.1


  parent reply	other threads:[~2019-05-13 18:09 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-13 18:07 [PATCH V3 00/29] Enable Tegra PCIe root port features Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 01/29] soc/tegra: pmc: Export tegra_powergate_power_on() Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 02/29] PCI: tegra: Handle failure cases in tegra_pcie_power_on() Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 03/29] PCI: tegra: Rearrange Tegra PCIe driver functions Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 04/29] PCI: tegra: Mask AFI_INTR in runtime suspend Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 05/29] PCI: tegra: Fix PCIe host power up sequence Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 06/29] PCI: tegra: Add PCIe Gen2 link speed support Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 07/29] PCI: tegra: Advertise PCIe Advanced Error Reporting (AER) capability Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 08/29] PCI: tegra: Program UPHY electrical settings for Tegra210 Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 09/29] PCI: tegra: Enable opportunistic UpdateFC and ACK Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 10/29] PCI: tegra: Disable AFI dynamic clock gating Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 11/29] PCI: tegra: Process pending DLL transactions before entering L1 or L2 Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 12/29] PCI: tegra: Enable PCIe xclk clock clamping Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 13/29] PCI: tegra: Increase the deskew retry time Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 14/29] PCI: tegra: Add SW fixup for RAW violations Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 15/29] PCI: tegra: Update flow control timer frequency in Tegra210 Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 16/29] PCI: tegra: Set target speed as Gen1 before starting LTSSM Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 17/29] PCI: tegra: Fix PLLE power down issue due to CLKREQ# signal Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 18/29] PCI: tegra: Program AFI_CACHE* registers only for Tegra20 Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 19/29] PCI: tegra: Change PRSNT_SENSE IRQ log to debug Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 20/29] PCI: tegra: Use legacy IRQ for port service drivers Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 21/29] PCI: tegra: Add AFI_PEX2_CTRL reg offset as part of soc struct Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 22/29] PCI: tegra: Access endpoint config only if PCIe link is up Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 23/29] dt-bindings: pci: tegra: Document PCIe DPD pinctrl optional prop Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 24/29] arm64: tegra: Add PEX DPD states as pinctrl properties Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 25/29] PCI: tegra: Put PEX CLK & BIAS pads in DPD mode Manikanta Maddireddy
2019-05-13 18:07 ` [PATCH V3 26/29] PCI: Add DT binding for "reset-gpios" property Manikanta Maddireddy
2019-05-14 18:23   ` Rob Herring
2019-05-13 18:07 ` [PATCH V3 27/29] PCI: OF: Add of_pci_get_reset_gpio() to parse reset-gpios from DT Manikanta Maddireddy
2019-05-14 18:31   ` Rob Herring
2019-05-16  5:50     ` Manikanta Maddireddy
2019-05-13 18:07 ` Manikanta Maddireddy [this message]
2019-05-13 18:07 ` [PATCH V3 29/29] PCI: tegra: Change link retry log level to debug Manikanta Maddireddy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190513180744.16493-29-mmaddireddy@nvidia.com \
    --to=mmaddireddy@nvidia.com \
    --cc=bhelgaas@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=vidyas@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).