linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] PCI: vc: fix warning: no previous prototype
@ 2019-09-11 12:40 tiantao6
  2019-09-27 13:00 ` Bjorn Helgaas
  0 siblings, 1 reply; 2+ messages in thread
From: tiantao6 @ 2019-09-11 12:40 UTC (permalink / raw)
  To: bhelgaas, linux-pci, linux-kernel; +Cc: linuxarm

From: tiantao <tiantao6@huawei.com>

drivers/pci/vc.c:351:5: warning: no previous prototype for
pci_save_vc_state [-Wmissing-prototypes]
int pci_save_vc_state(struct pci_dev *dev)

drivers/pci/vc.c:388:6: warning: no previous prototype for
pci_restore_vc_state [-Wmissing-prototypes]
void pci_restore_vc_state(struct pci_dev *dev)

drivers/pci/vc.c:412:6: warning: no previous prototype for
pci_allocate_vc_save_buffers [-Wmissing-prototypes]
void pci_allocate_vc_save_buffers(struct pci_dev *dev)

Signed-off-by: Tian Tao <tiantao6@huawei.com>
---
 drivers/pci/vc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pci/vc.c b/drivers/pci/vc.c
index b39e854..111f6d3 100644
--- a/drivers/pci/vc.c
+++ b/drivers/pci/vc.c
@@ -12,6 +12,7 @@
 #include <linux/pci.h>
 #include <linux/pci_regs.h>
 #include <linux/types.h>
+#include "pci.h"
 
 /**
  * pci_vc_save_restore_dwords - Save or restore a series of dwords
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] PCI: vc: fix warning: no previous prototype
  2019-09-11 12:40 [PATCH] PCI: vc: fix warning: no previous prototype tiantao6
@ 2019-09-27 13:00 ` Bjorn Helgaas
  0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Helgaas @ 2019-09-27 13:00 UTC (permalink / raw)
  To: tiantao6; +Cc: linux-pci, linux-kernel, linuxarm

On Wed, Sep 11, 2019 at 08:40:51PM +0800, tiantao6 wrote:
> From: tiantao <tiantao6@huawei.com>
> 
> drivers/pci/vc.c:351:5: warning: no previous prototype for
> pci_save_vc_state [-Wmissing-prototypes]
> int pci_save_vc_state(struct pci_dev *dev)
> 
> drivers/pci/vc.c:388:6: warning: no previous prototype for
> pci_restore_vc_state [-Wmissing-prototypes]
> void pci_restore_vc_state(struct pci_dev *dev)
> 
> drivers/pci/vc.c:412:6: warning: no previous prototype for
> pci_allocate_vc_save_buffers [-Wmissing-prototypes]
> void pci_allocate_vc_save_buffers(struct pci_dev *dev)
> 
> Signed-off-by: Tian Tao <tiantao6@huawei.com>

Thanks, this was fixed incidentally by ca78410403dd ("PCI: Get rid of
dev->has_secondary_link flag").

> ---
>  drivers/pci/vc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pci/vc.c b/drivers/pci/vc.c
> index b39e854..111f6d3 100644
> --- a/drivers/pci/vc.c
> +++ b/drivers/pci/vc.c
> @@ -12,6 +12,7 @@
>  #include <linux/pci.h>
>  #include <linux/pci_regs.h>
>  #include <linux/types.h>
> +#include "pci.h"
>  
>  /**
>   * pci_vc_save_restore_dwords - Save or restore a series of dwords
> -- 
> 2.7.4
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-09-27 13:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-11 12:40 [PATCH] PCI: vc: fix warning: no previous prototype tiantao6
2019-09-27 13:00 ` Bjorn Helgaas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).