From: Bjorn Helgaas <helgaas@kernel.org>
To: Ansuel Smith <ansuelsmth@gmail.com>
Cc: devicetree@vger.kernel.org, Richard Zhu <hongxing.zhu@nxp.com>,
Lucas Stach <l.stach@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Andrew Murray <amurray@thegoodpenguin.co.uk>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] drivers: pci: dwc: pci-imx6: update binding to generic name
Date: Mon, 13 Apr 2020 15:25:46 -0500 [thread overview]
Message-ID: <20200413202546.GA147401@google.com> (raw)
In-Reply-To: <20200410004738.19668-3-ansuelsmth@gmail.com>
If/when you repost this, please update the subject to match the
convention:
$ git log --oneline drivers/pci/controller/dwc/pci-imx6.c
2170a09fb4b0 PCI: imx6: Propagate errors for optional regulators
075af61c19cd PCI: imx6: Limit DBI register length
1b8df7aa7874 PCI: imx6: Allow asynchronous probing
87cb312777b5 PCI: imx6: Use usleep_range() in imx6_pcie_enable_ref_clk()
As Fabio pointed out, we can't break backward compatibility without a
good reason.
On Fri, Apr 10, 2020 at 02:47:36AM +0200, Ansuel Smith wrote:
> Rename specific bindings to generic name.
>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> ---
> drivers/pci/controller/dwc/pci-imx6.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
> index acfbd34032a8..4ac140e007b4 100644
> --- a/drivers/pci/controller/dwc/pci-imx6.c
> +++ b/drivers/pci/controller/dwc/pci-imx6.c
> @@ -1146,28 +1146,28 @@ static int imx6_pcie_probe(struct platform_device *pdev)
> }
>
> /* Grab PCIe PHY Tx Settings */
> - if (of_property_read_u32(node, "fsl,tx-deemph-gen1",
> + if (of_property_read_u32(node, "tx-deemph-gen1",
> &imx6_pcie->tx_deemph_gen1))
> imx6_pcie->tx_deemph_gen1 = 0;
>
> - if (of_property_read_u32(node, "fsl,tx-deemph-gen2-3p5db",
> + if (of_property_read_u32(node, "tx-deemph-gen2-3p5db",
> &imx6_pcie->tx_deemph_gen2_3p5db))
> imx6_pcie->tx_deemph_gen2_3p5db = 0;
>
> - if (of_property_read_u32(node, "fsl,tx-deemph-gen2-6db",
> + if (of_property_read_u32(node, "tx-deemph-gen2-6db",
> &imx6_pcie->tx_deemph_gen2_6db))
> imx6_pcie->tx_deemph_gen2_6db = 20;
>
> - if (of_property_read_u32(node, "fsl,tx-swing-full",
> + if (of_property_read_u32(node, "tx-swing-full",
> &imx6_pcie->tx_swing_full))
> imx6_pcie->tx_swing_full = 127;
>
> - if (of_property_read_u32(node, "fsl,tx-swing-low",
> + if (of_property_read_u32(node, "tx-swing-low",
> &imx6_pcie->tx_swing_low))
> imx6_pcie->tx_swing_low = 127;
>
> /* Limit link speed */
> - ret = of_property_read_u32(node, "fsl,max-link-speed",
> + ret = of_property_read_u32(node, "max-link-speed",
> &imx6_pcie->link_gen);
> if (ret)
> imx6_pcie->link_gen = 1;
> --
> 2.25.1
>
next prev parent reply other threads:[~2020-04-13 20:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-10 0:47 [PATCH 0/4] Move tx-deempth and tx swing to pci.txt Ansuel Smith
2020-04-10 0:47 ` [PATCH 1/4] devicetree: bindings: pci: document tx-deempth tx swing and rx-eq property Ansuel Smith
2020-04-13 20:29 ` Florian Fainelli
2020-04-14 12:51 ` R: " ansuelsmth
2020-04-13 20:40 ` Bjorn Helgaas
2020-04-10 0:47 ` [PATCH 2/4] drivers: pci: dwc: pci-imx6: update binding to generic name Ansuel Smith
2020-04-10 2:24 ` Fabio Estevam
2020-04-10 11:07 ` R: " ansuelsmth
2020-04-10 12:31 ` Fabio Estevam
2020-04-10 12:40 ` R: " ansuelsmth
2020-04-10 12:57 ` Fabio Estevam
2020-04-13 20:25 ` Bjorn Helgaas [this message]
2020-04-10 0:47 ` [PATCH 3/4] arm: dts: imx6: update pci " Ansuel Smith
2020-04-10 0:47 ` [PATCH 4/4] devicetree: bindings: pci: fsl,imx6q-pcie: rename tx deemph and swing Ansuel Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200413202546.GA147401@google.com \
--to=helgaas@kernel.org \
--cc=amurray@thegoodpenguin.co.uk \
--cc=ansuelsmth@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=hongxing.zhu@nxp.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).