From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Bingbu Cao <bingbu.cao@linux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Bingbu Cao <bingbu.cao@intel.com>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
iommu@lists.linux-foundation.org, dwmw2@infradead.org,
baolu.lu@linux.intel.com, joro@8bytes.org, will@kernel.org,
bhelgaas@google.com, rajatja@google.com, grundler@chromium.org,
tfiga@chromium.org, senozhatsky@chromium.org
Subject: Re: [RESEND v2] iommu/vt-d: Use passthrough mode for the Intel IPUs
Date: Tue, 20 Apr 2021 13:56:40 +0300 [thread overview]
Message-ID: <20210420105640.GI3@paasikivi.fi.intel.com> (raw)
In-Reply-To: <c9a0fc75-8b7b-e0ae-572e-8ca030a04537@linux.intel.com>
Hi Bingbu,
On Tue, Apr 20, 2021 at 06:34:26PM +0800, Bingbu Cao wrote:
> Andy,
>
> On 4/20/21 6:20 PM, Andy Shevchenko wrote:
> > On Tue, Apr 20, 2021 at 10:48:33AM +0800, Bingbu Cao wrote:
> >> Intel IPU(Image Processing Unit) has its own (IO)MMU hardware,
> >> The IPU driver allocates its own page table that is not mapped
> >> via the DMA, and thus the Intel IOMMU driver blocks access giving
> >> this error:
> >>
> >> DMAR: DRHD: handling fault status reg 3
> >> DMAR: [DMA Read] Request device [00:05.0] PASID ffffffff
> >> fault addr 76406000 [fault reason 06] PTE Read access is not set
> >>
> >> As IPU is not an external facing device which is not risky, so use
> >> IOMMU passthrough mode for Intel IPUs.
> >>
> >> Fixes: 26f5689592e2 ("media: staging/intel-ipu3: mmu: Implement driver")
> >> Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
> >> ---
> >> drivers/iommu/intel/iommu.c | 29 +++++++++++++++++++++++++++++
> >
> > This misses the changelog from v1 followed by the explanation why resent.
> >
> I noticed there was a typo in the recipient list:
> stable.vger.kernel.org -> stable@vger.kernel.org
>
> no code change for resent.
When you're submitting a patch and want it reach the stable kernels, you'll
need to add a Cc tag:
Cc: stable@vger.kernel.org
But not actually add the address to cc. I dropped stable@vger address from
distribution.
Please change this for v3.
--
Kind regards,
Sakari Ailus
next prev parent reply other threads:[~2021-04-20 11:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 2:48 [RESEND v2] iommu/vt-d: Use passthrough mode for the Intel IPUs Bingbu Cao
2021-04-20 9:13 ` Sakari Ailus
2021-04-20 17:30 ` Grant Grundler
2021-04-20 10:20 ` Andy Shevchenko
2021-04-20 10:34 ` Bingbu Cao
2021-04-20 10:56 ` Sakari Ailus [this message]
2021-04-20 11:55 ` Andy Shevchenko
2021-04-20 14:37 ` Sakari Ailus
2021-04-20 14:54 ` Andy Shevchenko
2021-04-20 15:27 ` Sakari Ailus
2021-04-20 10:21 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210420105640.GI3@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=bingbu.cao@intel.com \
--cc=bingbu.cao@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=grundler@chromium.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rajatja@google.com \
--cc=senozhatsky@chromium.org \
--cc=tfiga@chromium.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).