From: "David E. Box" <david.e.box@linux.intel.com>
To: Alexey Budankov <alexey.budankov@linux.intel.com>,
lee.jones@linaro.org, dvhart@infradead.org, andy@infradead.org,
bhelgaas@google.com, alexander.h.duyck@linux.intel.com
Cc: linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH V3 3/3] platform/x86: Intel PMT Telemetry capability driver
Date: Wed, 15 Jul 2020 16:59:02 -0700 [thread overview]
Message-ID: <245ecc65a839bd69413045ae5ee307ba03ca0869.camel@linux.intel.com> (raw)
In-Reply-To: <727a75a0-3fb5-769a-cf1f-70a2a0bab0c8@linux.intel.com>
On Wed, 2020-07-15 at 10:39 +0300, Alexey Budankov wrote:
> Hi David,
>
> On 14.07.2020 9:23, David E. Box wrote:
...
> >
> > +static int pmt_telem_open(struct inode *inode, struct file *filp)
> > +{
> > + struct pmt_telem_priv *priv;
> > + struct pmt_telem_entry *entry;
> > + struct pci_driver *pci_drv;
> > + struct pci_dev *pci_dev;
> > +
> > + if (!capable(CAP_SYS_ADMIN))
>
> Thanks for supplying these patches.
> Are there any reasons not to expose this feature to CAP_PERFMON
> privileged
> processes too that currently have access to performance monitoring
> features
> of the kernel without root/CAP_SYS_ADMIN credentials? This could be
> done by
> pefmon_capable() function call starting from v5.8+.
The new capability is well suited for this feature. I'll make the
change. Thanks.
David
next prev parent reply other threads:[~2020-07-15 23:59 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200505013206.11223-1-david.e.box@linux.intel.com>
2020-05-05 1:32 ` [PATCH 1/3] pci: Add Designated Vendor Specific Capability David E. Box
2020-05-05 8:49 ` Andy Shevchenko
2020-05-05 15:00 ` David E. Box
2020-05-05 16:34 ` Bjorn Helgaas
2020-05-05 2:31 ` [PATCH 2/3] mfd: Intel Platform Monitoring Technology support David E. Box
2020-05-05 2:31 ` [PATCH 3/3] platform/x86: Intel PMT Telemetry capability driver David E. Box
2020-05-05 13:49 ` Andy Shevchenko
2020-05-05 21:09 ` David E. Box
2020-05-08 2:33 ` David E. Box
2020-05-05 2:53 ` [PATCH 2/3] mfd: Intel Platform Monitoring Technology support Randy Dunlap
2020-05-05 14:55 ` David E. Box
2020-05-05 9:02 ` Andy Shevchenko
2020-05-05 15:15 ` David E. Box
2020-05-08 2:18 ` [PATCH v2 0/3] Intel Platform Monitoring Technology David E. Box
2020-05-08 9:59 ` Andy Shevchenko
2020-07-14 6:23 ` [PATCH V3 " David E. Box
2020-07-17 19:06 ` [PATCH V4 " David E. Box
2020-07-27 10:23 ` Andy Shevchenko
2020-07-27 16:29 ` David E. Box
2020-07-29 21:37 ` [PATCH V5 " David E. Box
2020-08-10 14:15 ` David E. Box
2020-08-10 14:42 ` Umesh A
2020-08-11 8:04 ` Lee Jones
2020-08-11 14:50 ` David E. Box
2020-07-29 21:37 ` [PATCH V5 1/3] PCI: Add defines for Designated Vendor-Specific Extended Capability David E. Box
2020-07-29 21:37 ` [PATCH V5 2/3] mfd: Intel Platform Monitoring Technology support David E. Box
2020-07-29 21:37 ` [PATCH V5 3/3] platform/x86: Intel PMT Telemetry capability driver David E. Box
2020-07-17 19:06 ` [PATCH V4 1/3] PCI: Add defines for Designated Vendor-Specific Extended Capability David E. Box
2020-07-17 20:11 ` Andy Shevchenko
2020-07-17 19:06 ` [PATCH V4 2/3] mfd: Intel Platform Monitoring Technology support David E. Box
2020-07-28 7:58 ` Lee Jones
2020-07-28 20:35 ` David E. Box
2020-07-29 22:59 ` Mark D Rustad
2020-07-30 17:53 ` David E. Box
2020-07-31 6:19 ` Lee Jones
2020-07-17 19:06 ` [PATCH V4 3/3] platform/x86: Intel PMT Telemetry capability driver David E. Box
2020-07-14 6:23 ` [PATCH V3 1/3] PCI: Add defines for Designated Vendor-Specific Capability David E. Box
2020-07-14 8:40 ` Andy Shevchenko
2020-07-16 2:55 ` Randy Dunlap
2020-07-16 15:07 ` Bjorn Helgaas
2020-07-16 15:07 ` Randy Dunlap
2020-07-16 17:18 ` Alexander Duyck
2020-07-16 18:31 ` David E. Box
2020-07-14 6:23 ` [PATCH V3 2/3] mfd: Intel Platform Monitoring Technology support David E. Box
2020-07-14 6:23 ` [PATCH V3 3/3] platform/x86: Intel PMT Telemetry capability driver David E. Box
2020-07-14 8:51 ` Andy Shevchenko
2020-07-15 7:39 ` Alexey Budankov
2020-07-15 23:59 ` David E. Box [this message]
2020-07-16 5:57 ` Alexey Budankov
2020-07-16 2:57 ` Randy Dunlap
2020-05-08 2:18 ` [PATCH v2 1/3] PCI: Add defines for Designated Vendor-Specific Capability David E. Box
2020-05-08 2:18 ` [PATCH v2 2/3] mfd: Intel Platform Monitoring Technology support David E. Box
2020-05-08 9:15 ` Andy Shevchenko
2020-05-08 2:18 ` [PATCH v2 3/3] platform/x86: Intel PMT Telemetry capability driver David E. Box
2020-05-08 9:57 ` Andy Shevchenko
2020-05-09 16:27 ` David E. Box
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=245ecc65a839bd69413045ae5ee307ba03ca0869.camel@linux.intel.com \
--to=david.e.box@linux.intel.com \
--cc=alexander.h.duyck@linux.intel.com \
--cc=alexey.budankov@linux.intel.com \
--cc=andy@infradead.org \
--cc=bhelgaas@google.com \
--cc=dvhart@infradead.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).