archive mirror
 help / color / mirror / Atom feed
From: Mikel Rychliski <>
To: Bjorn Helgaas <>
	"Alex Deucher" <>,
	"Christian König" <>,
	"David (ChunMing) Zhou" <>,
	"Matthew Garrett" <>
Subject: Re: [PATCH 2/4] PCI: Use ioremap, not phys_to_virt for platform rom
Date: Tue, 03 Mar 2020 22:20:45 -0500	[thread overview]
Message-ID: <2616060.jBR9Tdob1i@glidewell> (raw)
In-Reply-To: <>

On Tuesday, March 3, 2020 9:38:27 AM EST Bjorn Helgaas wrote:
> Cosmetics:
> s/ioremap/ioremap()/ (also in commit log)
> s/phys_to_virt/phys_to_virt()/ (also in commit log)
> s/pci_platform_rom/pci_platform_rom()/ (commit log)
> s/rom/ROM/

> This changes the interface of pci_platform_rom() (the caller is now
> responsible for doing an iounmap()).  That should be mentioned in the
> function comment, and I think the subsequent patches should be
> squashed into this one so the interface change and the caller changes
> are done simultaneously.
> Also, it looks like nvbios_platform.init() (platform_init()) needs a
> similar change?

Hi Bjorn,

Thank you for your comments. I'll make the suggested changes, add an iounmap() 
in the nouveau usage, and provide a new two-patch series.

  reply	other threads:[~2020-03-04  3:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-03  3:34 [PATCH 0/4] Fix loading of radeon BIOS from 32-bit EFI Mikel Rychliski
2020-03-03  3:34 ` [PATCH 1/4] drm/radeon: Stop directly referencing iomem Mikel Rychliski
2020-03-03  3:34 ` [PATCH 2/4] PCI: Use ioremap, not phys_to_virt for platform rom Mikel Rychliski
2020-03-03 14:38   ` Bjorn Helgaas
2020-03-04  3:20     ` Mikel Rychliski [this message]
2020-03-17 14:28   ` Christoph Hellwig
2020-03-03  3:34 ` [PATCH 3/4] drm/radeon: iounmap unused mapping Mikel Rychliski
2020-03-17 14:29   ` Christoph Hellwig
2020-03-03  3:34 ` [PATCH 4/4] drm/amdgpu: " Mikel Rychliski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2616060.jBR9Tdob1i@glidewell \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).