linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next v2] PCI: dwc: Make hisi_pcie_platform_ops static
@ 2020-04-23  3:18 Zou Wei
  2020-04-23  6:14 ` Zhou Wang
  2020-05-05 10:06 ` Lorenzo Pieralisi
  0 siblings, 2 replies; 3+ messages in thread
From: Zou Wei @ 2020-04-23  3:18 UTC (permalink / raw)
  To: wangzhou1, lorenzo.pieralisi, amurray, bhelgaas
  Cc: linux-pci, linux-kernel, Zou Wei

Fix the following sparse warning:

drivers/pci/controller/dwc/pcie-hisi.c:365:21: warning:
symbol 'hisi_pcie_platform_ops' was not declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
 drivers/pci/controller/dwc/pcie-hisi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pcie-hisi.c b/drivers/pci/controller/dwc/pcie-hisi.c
index 6d9e1b2..11f5ff7 100644
--- a/drivers/pci/controller/dwc/pcie-hisi.c
+++ b/drivers/pci/controller/dwc/pcie-hisi.c
@@ -362,7 +362,7 @@ static int hisi_pcie_platform_init(struct pci_config_window *cfg)
 	return 0;
 }
 
-struct pci_ecam_ops hisi_pcie_platform_ops = {
+static struct pci_ecam_ops hisi_pcie_platform_ops = {
 	.bus_shift    = 20,
 	.init         =  hisi_pcie_platform_init,
 	.pci_ops      = {
-- 
2.6.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next v2] PCI: dwc: Make hisi_pcie_platform_ops static
  2020-04-23  3:18 [PATCH -next v2] PCI: dwc: Make hisi_pcie_platform_ops static Zou Wei
@ 2020-04-23  6:14 ` Zhou Wang
  2020-05-05 10:06 ` Lorenzo Pieralisi
  1 sibling, 0 replies; 3+ messages in thread
From: Zhou Wang @ 2020-04-23  6:14 UTC (permalink / raw)
  To: Zou Wei, lorenzo.pieralisi, amurray, bhelgaas; +Cc: linux-pci, linux-kernel

On 2020/4/23 11:18, Zou Wei wrote:
> Fix the following sparse warning:
> 
> drivers/pci/controller/dwc/pcie-hisi.c:365:21: warning:
> symbol 'hisi_pcie_platform_ops' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>

Reviewed-by: Zhou Wang <wangzhou1@hisilicon.com>

Thanks,
Zhou

> ---
>  drivers/pci/controller/dwc/pcie-hisi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-hisi.c b/drivers/pci/controller/dwc/pcie-hisi.c
> index 6d9e1b2..11f5ff7 100644
> --- a/drivers/pci/controller/dwc/pcie-hisi.c
> +++ b/drivers/pci/controller/dwc/pcie-hisi.c
> @@ -362,7 +362,7 @@ static int hisi_pcie_platform_init(struct pci_config_window *cfg)
>  	return 0;
>  }
>  
> -struct pci_ecam_ops hisi_pcie_platform_ops = {
> +static struct pci_ecam_ops hisi_pcie_platform_ops = {
>  	.bus_shift    = 20,
>  	.init         =  hisi_pcie_platform_init,
>  	.pci_ops      = {
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next v2] PCI: dwc: Make hisi_pcie_platform_ops static
  2020-04-23  3:18 [PATCH -next v2] PCI: dwc: Make hisi_pcie_platform_ops static Zou Wei
  2020-04-23  6:14 ` Zhou Wang
@ 2020-05-05 10:06 ` Lorenzo Pieralisi
  1 sibling, 0 replies; 3+ messages in thread
From: Lorenzo Pieralisi @ 2020-05-05 10:06 UTC (permalink / raw)
  To: Zou Wei; +Cc: wangzhou1, amurray, bhelgaas, linux-pci, linux-kernel

On Thu, Apr 23, 2020 at 11:18:03AM +0800, Zou Wei wrote:
> Fix the following sparse warning:
> 
> drivers/pci/controller/dwc/pcie-hisi.c:365:21: warning:
> symbol 'hisi_pcie_platform_ops' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
>  drivers/pci/controller/dwc/pcie-hisi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to pci/dwc, thanks.

Lorenzo

> diff --git a/drivers/pci/controller/dwc/pcie-hisi.c b/drivers/pci/controller/dwc/pcie-hisi.c
> index 6d9e1b2..11f5ff7 100644
> --- a/drivers/pci/controller/dwc/pcie-hisi.c
> +++ b/drivers/pci/controller/dwc/pcie-hisi.c
> @@ -362,7 +362,7 @@ static int hisi_pcie_platform_init(struct pci_config_window *cfg)
>  	return 0;
>  }
>  
> -struct pci_ecam_ops hisi_pcie_platform_ops = {
> +static struct pci_ecam_ops hisi_pcie_platform_ops = {
>  	.bus_shift    = 20,
>  	.init         =  hisi_pcie_platform_init,
>  	.pci_ops      = {
> -- 
> 2.6.2
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-05-05 10:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-23  3:18 [PATCH -next v2] PCI: dwc: Make hisi_pcie_platform_ops static Zou Wei
2020-04-23  6:14 ` Zhou Wang
2020-05-05 10:06 ` Lorenzo Pieralisi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).