* [PATCH] PCI: iproc: move quirks to driver
@ 2019-12-11 17:45 Wei Liu
2019-12-11 22:34 ` Bjorn Helgaas
0 siblings, 1 reply; 8+ messages in thread
From: Wei Liu @ 2019-12-11 17:45 UTC (permalink / raw)
To: linux-pci; +Cc: helgaas, rjui, Wei Liu
The quirks were originally enclosed by ifdef. That made the quirks not
to be applied when respective drivers were compiled as modules.
Move the quirks to driver code to fix the issue.
Signed-off-by: Wei Liu <wei.liu@kernel.org>
---
Feel free to change the commit message as you see fit.
---
drivers/pci/controller/pcie-iproc-platform.c | 24 ++++++++++++++++++
drivers/pci/quirks.c | 26 --------------------
2 files changed, 24 insertions(+), 26 deletions(-)
diff --git a/drivers/pci/controller/pcie-iproc-platform.c b/drivers/pci/controller/pcie-iproc-platform.c
index ff0a81a632a1..4e6f7cdd9a25 100644
--- a/drivers/pci/controller/pcie-iproc-platform.c
+++ b/drivers/pci/controller/pcie-iproc-platform.c
@@ -19,6 +19,30 @@
#include "../pci.h"
#include "pcie-iproc.h"
+static void quirk_paxc_bridge(struct pci_dev *pdev)
+{
+ /*
+ * The PCI config space is shared with the PAXC root port and the first
+ * Ethernet device. So, we need to workaround this by telling the PCI
+ * code that the bridge is not an Ethernet device.
+ */
+ if (pdev->hdr_type == PCI_HEADER_TYPE_BRIDGE)
+ pdev->class = PCI_CLASS_BRIDGE_PCI << 8;
+
+ /*
+ * MPSS is not being set properly (as it is currently 0). This is
+ * because that area of the PCI config space is hard coded to zero, and
+ * is not modifiable by firmware. Set this to 2 (e.g., 512 byte MPS)
+ * so that the MPS can be set to the real max value.
+ */
+ pdev->pcie_mpss = 2;
+}
+DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0x16cd, quirk_paxc_bridge);
+DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0x16f0, quirk_paxc_bridge);
+DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd750, quirk_paxc_bridge);
+DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd802, quirk_paxc_bridge);
+DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd804, quirk_paxc_bridge);
+
static const struct of_device_id iproc_pcie_of_match_table[] = {
{
.compatible = "brcm,iproc-pcie",
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 4937a088d7d8..202837ed68c9 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -2381,32 +2381,6 @@ DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_BROADCOM,
PCI_DEVICE_ID_TIGON3_5719,
quirk_brcm_5719_limit_mrrs);
-#ifdef CONFIG_PCIE_IPROC_PLATFORM
-static void quirk_paxc_bridge(struct pci_dev *pdev)
-{
- /*
- * The PCI config space is shared with the PAXC root port and the first
- * Ethernet device. So, we need to workaround this by telling the PCI
- * code that the bridge is not an Ethernet device.
- */
- if (pdev->hdr_type == PCI_HEADER_TYPE_BRIDGE)
- pdev->class = PCI_CLASS_BRIDGE_PCI << 8;
-
- /*
- * MPSS is not being set properly (as it is currently 0). This is
- * because that area of the PCI config space is hard coded to zero, and
- * is not modifiable by firmware. Set this to 2 (e.g., 512 byte MPS)
- * so that the MPS can be set to the real max value.
- */
- pdev->pcie_mpss = 2;
-}
-DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0x16cd, quirk_paxc_bridge);
-DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0x16f0, quirk_paxc_bridge);
-DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd750, quirk_paxc_bridge);
-DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd802, quirk_paxc_bridge);
-DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd804, quirk_paxc_bridge);
-#endif
-
/*
* Originally in EDAC sources for i82875P: Intel tells BIOS developers to
* hide device 6 which configures the overflow device access containing the
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] PCI: iproc: move quirks to driver
2019-12-11 17:45 [PATCH] PCI: iproc: move quirks to driver Wei Liu
@ 2019-12-11 22:34 ` Bjorn Helgaas
2019-12-11 23:40 ` Ray Jui
2019-12-12 23:23 ` Bjorn Helgaas
0 siblings, 2 replies; 8+ messages in thread
From: Bjorn Helgaas @ 2019-12-11 22:34 UTC (permalink / raw)
To: Wei Liu; +Cc: linux-pci, rjui, Andrew Murray, Lorenzo Pieralisi
On Wed, Dec 11, 2019 at 05:45:11PM +0000, Wei Liu wrote:
> The quirks were originally enclosed by ifdef. That made the quirks not
> to be applied when respective drivers were compiled as modules.
>
> Move the quirks to driver code to fix the issue.
>
> Signed-off-by: Wei Liu <wei.liu@kernel.org>
This straddles the core and native driver boundary, so I applied it to
pci/misc for v5.6. Thanks, I think this is a great solution! It's
always nice when we can encapsulate device-specific things in a
driver.
> ---
> drivers/pci/controller/pcie-iproc-platform.c | 24 ++++++++++++++++++
> drivers/pci/quirks.c | 26 --------------------
> 2 files changed, 24 insertions(+), 26 deletions(-)
>
> diff --git a/drivers/pci/controller/pcie-iproc-platform.c b/drivers/pci/controller/pcie-iproc-platform.c
> index ff0a81a632a1..4e6f7cdd9a25 100644
> --- a/drivers/pci/controller/pcie-iproc-platform.c
> +++ b/drivers/pci/controller/pcie-iproc-platform.c
> @@ -19,6 +19,30 @@
> #include "../pci.h"
> #include "pcie-iproc.h"
>
> +static void quirk_paxc_bridge(struct pci_dev *pdev)
> +{
> + /*
> + * The PCI config space is shared with the PAXC root port and the first
> + * Ethernet device. So, we need to workaround this by telling the PCI
> + * code that the bridge is not an Ethernet device.
> + */
> + if (pdev->hdr_type == PCI_HEADER_TYPE_BRIDGE)
> + pdev->class = PCI_CLASS_BRIDGE_PCI << 8;
> +
> + /*
> + * MPSS is not being set properly (as it is currently 0). This is
> + * because that area of the PCI config space is hard coded to zero, and
> + * is not modifiable by firmware. Set this to 2 (e.g., 512 byte MPS)
> + * so that the MPS can be set to the real max value.
> + */
> + pdev->pcie_mpss = 2;
> +}
> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0x16cd, quirk_paxc_bridge);
> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0x16f0, quirk_paxc_bridge);
> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd750, quirk_paxc_bridge);
> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd802, quirk_paxc_bridge);
> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd804, quirk_paxc_bridge);
> +
> static const struct of_device_id iproc_pcie_of_match_table[] = {
> {
> .compatible = "brcm,iproc-pcie",
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 4937a088d7d8..202837ed68c9 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -2381,32 +2381,6 @@ DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_BROADCOM,
> PCI_DEVICE_ID_TIGON3_5719,
> quirk_brcm_5719_limit_mrrs);
>
> -#ifdef CONFIG_PCIE_IPROC_PLATFORM
> -static void quirk_paxc_bridge(struct pci_dev *pdev)
> -{
> - /*
> - * The PCI config space is shared with the PAXC root port and the first
> - * Ethernet device. So, we need to workaround this by telling the PCI
> - * code that the bridge is not an Ethernet device.
> - */
> - if (pdev->hdr_type == PCI_HEADER_TYPE_BRIDGE)
> - pdev->class = PCI_CLASS_BRIDGE_PCI << 8;
> -
> - /*
> - * MPSS is not being set properly (as it is currently 0). This is
> - * because that area of the PCI config space is hard coded to zero, and
> - * is not modifiable by firmware. Set this to 2 (e.g., 512 byte MPS)
> - * so that the MPS can be set to the real max value.
> - */
> - pdev->pcie_mpss = 2;
> -}
> -DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0x16cd, quirk_paxc_bridge);
> -DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0x16f0, quirk_paxc_bridge);
> -DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd750, quirk_paxc_bridge);
> -DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd802, quirk_paxc_bridge);
> -DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd804, quirk_paxc_bridge);
> -#endif
> -
> /*
> * Originally in EDAC sources for i82875P: Intel tells BIOS developers to
> * hide device 6 which configures the overflow device access containing the
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] PCI: iproc: move quirks to driver
2019-12-11 22:34 ` Bjorn Helgaas
@ 2019-12-11 23:40 ` Ray Jui
2019-12-12 0:02 ` Bjorn Helgaas
2019-12-12 23:23 ` Bjorn Helgaas
1 sibling, 1 reply; 8+ messages in thread
From: Ray Jui @ 2019-12-11 23:40 UTC (permalink / raw)
To: Bjorn Helgaas, Wei Liu; +Cc: linux-pci, rjui, Andrew Murray, Lorenzo Pieralisi
On 12/11/19 2:34 PM, Bjorn Helgaas wrote:
> On Wed, Dec 11, 2019 at 05:45:11PM +0000, Wei Liu wrote:
>> The quirks were originally enclosed by ifdef. That made the quirks not
>> to be applied when respective drivers were compiled as modules.
>>
>> Move the quirks to driver code to fix the issue.
>>
>> Signed-off-by: Wei Liu <wei.liu@kernel.org>
>
> This straddles the core and native driver boundary, so I applied it to
> pci/misc for v5.6. Thanks, I think this is a great solution! It's
> always nice when we can encapsulate device-specific things in a
> driver.
>
Opps! I was going to review and comment and you are quick, :)
I was going to say, I think it's better to keep this quirk in
"pcie-iproc.c" instead of "pcie-iproc-platform.c".
The quirk is specific to certain PCIe devices under iProc (activated
based on device ID), but should not be tied to a specific bus
architecture (i.e., platform vs BCMA).
Thanks,
Ray
>> ---
>> drivers/pci/controller/pcie-iproc-platform.c | 24 ++++++++++++++++++
>> drivers/pci/quirks.c | 26 --------------------
>> 2 files changed, 24 insertions(+), 26 deletions(-)
>>
>> diff --git a/drivers/pci/controller/pcie-iproc-platform.c b/drivers/pci/controller/pcie-iproc-platform.c
>> index ff0a81a632a1..4e6f7cdd9a25 100644
>> --- a/drivers/pci/controller/pcie-iproc-platform.c
>> +++ b/drivers/pci/controller/pcie-iproc-platform.c
>> @@ -19,6 +19,30 @@
>> #include "../pci.h"
>> #include "pcie-iproc.h"
>>
>> +static void quirk_paxc_bridge(struct pci_dev *pdev)
>> +{
>> + /*
>> + * The PCI config space is shared with the PAXC root port and the first
>> + * Ethernet device. So, we need to workaround this by telling the PCI
>> + * code that the bridge is not an Ethernet device.
>> + */
>> + if (pdev->hdr_type == PCI_HEADER_TYPE_BRIDGE)
>> + pdev->class = PCI_CLASS_BRIDGE_PCI << 8;
>> +
>> + /*
>> + * MPSS is not being set properly (as it is currently 0). This is
>> + * because that area of the PCI config space is hard coded to zero, and
>> + * is not modifiable by firmware. Set this to 2 (e.g., 512 byte MPS)
>> + * so that the MPS can be set to the real max value.
>> + */
>> + pdev->pcie_mpss = 2;
>> +}
>> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0x16cd, quirk_paxc_bridge);
>> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0x16f0, quirk_paxc_bridge);
>> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd750, quirk_paxc_bridge);
>> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd802, quirk_paxc_bridge);
>> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd804, quirk_paxc_bridge);
>> +
>> static const struct of_device_id iproc_pcie_of_match_table[] = {
>> {
>> .compatible = "brcm,iproc-pcie",
>> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
>> index 4937a088d7d8..202837ed68c9 100644
>> --- a/drivers/pci/quirks.c
>> +++ b/drivers/pci/quirks.c
>> @@ -2381,32 +2381,6 @@ DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_BROADCOM,
>> PCI_DEVICE_ID_TIGON3_5719,
>> quirk_brcm_5719_limit_mrrs);
>>
>> -#ifdef CONFIG_PCIE_IPROC_PLATFORM
>> -static void quirk_paxc_bridge(struct pci_dev *pdev)
>> -{
>> - /*
>> - * The PCI config space is shared with the PAXC root port and the first
>> - * Ethernet device. So, we need to workaround this by telling the PCI
>> - * code that the bridge is not an Ethernet device.
>> - */
>> - if (pdev->hdr_type == PCI_HEADER_TYPE_BRIDGE)
>> - pdev->class = PCI_CLASS_BRIDGE_PCI << 8;
>> -
>> - /*
>> - * MPSS is not being set properly (as it is currently 0). This is
>> - * because that area of the PCI config space is hard coded to zero, and
>> - * is not modifiable by firmware. Set this to 2 (e.g., 512 byte MPS)
>> - * so that the MPS can be set to the real max value.
>> - */
>> - pdev->pcie_mpss = 2;
>> -}
>> -DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0x16cd, quirk_paxc_bridge);
>> -DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0x16f0, quirk_paxc_bridge);
>> -DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd750, quirk_paxc_bridge);
>> -DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd802, quirk_paxc_bridge);
>> -DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd804, quirk_paxc_bridge);
>> -#endif
>> -
>> /*
>> * Originally in EDAC sources for i82875P: Intel tells BIOS developers to
>> * hide device 6 which configures the overflow device access containing the
>> --
>> 2.20.1
>>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] PCI: iproc: move quirks to driver
2019-12-11 23:40 ` Ray Jui
@ 2019-12-12 0:02 ` Bjorn Helgaas
2019-12-12 0:05 ` Ray Jui
0 siblings, 1 reply; 8+ messages in thread
From: Bjorn Helgaas @ 2019-12-12 0:02 UTC (permalink / raw)
To: Ray Jui
Cc: Bjorn Helgaas, Wei Liu, linux-pci, rjui, Andrew Murray,
Lorenzo Pieralisi
On Wed, Dec 11, 2019 at 5:40 PM Ray Jui <ray.jui@broadcom.com> wrote:
>
>
>
> On 12/11/19 2:34 PM, Bjorn Helgaas wrote:
> > On Wed, Dec 11, 2019 at 05:45:11PM +0000, Wei Liu wrote:
> >> The quirks were originally enclosed by ifdef. That made the quirks not
> >> to be applied when respective drivers were compiled as modules.
> >>
> >> Move the quirks to driver code to fix the issue.
> >>
> >> Signed-off-by: Wei Liu <wei.liu@kernel.org>
> >
> > This straddles the core and native driver boundary, so I applied it to
> > pci/misc for v5.6. Thanks, I think this is a great solution! It's
> > always nice when we can encapsulate device-specific things in a
> > driver.
> >
>
> Opps! I was going to review and comment and you are quick, :)
>
> I was going to say, I think it's better to keep this quirk in
> "pcie-iproc.c" instead of "pcie-iproc-platform.c".
>
> The quirk is specific to certain PCIe devices under iProc (activated
> based on device ID), but should not be tied to a specific bus
> architecture (i.e., platform vs BCMA).
I'm happy to move it; that's no problem.
> >> ---
> >> drivers/pci/controller/pcie-iproc-platform.c | 24 ++++++++++++++++++
> >> drivers/pci/quirks.c | 26 --------------------
> >> 2 files changed, 24 insertions(+), 26 deletions(-)
> >>
> >> diff --git a/drivers/pci/controller/pcie-iproc-platform.c b/drivers/pci/controller/pcie-iproc-platform.c
> >> index ff0a81a632a1..4e6f7cdd9a25 100644
> >> --- a/drivers/pci/controller/pcie-iproc-platform.c
> >> +++ b/drivers/pci/controller/pcie-iproc-platform.c
> >> @@ -19,6 +19,30 @@
> >> #include "../pci.h"
> >> #include "pcie-iproc.h"
> >>
> >> +static void quirk_paxc_bridge(struct pci_dev *pdev)
> >> +{
> >> + /*
> >> + * The PCI config space is shared with the PAXC root port and the first
> >> + * Ethernet device. So, we need to workaround this by telling the PCI
> >> + * code that the bridge is not an Ethernet device.
> >> + */
> >> + if (pdev->hdr_type == PCI_HEADER_TYPE_BRIDGE)
> >> + pdev->class = PCI_CLASS_BRIDGE_PCI << 8;
> >> +
> >> + /*
> >> + * MPSS is not being set properly (as it is currently 0). This is
> >> + * because that area of the PCI config space is hard coded to zero, and
> >> + * is not modifiable by firmware. Set this to 2 (e.g., 512 byte MPS)
> >> + * so that the MPS can be set to the real max value.
> >> + */
> >> + pdev->pcie_mpss = 2;
> >> +}
> >> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0x16cd, quirk_paxc_bridge);
> >> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0x16f0, quirk_paxc_bridge);
> >> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd750, quirk_paxc_bridge);
> >> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd802, quirk_paxc_bridge);
> >> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd804, quirk_paxc_bridge);
> >> +
> >> static const struct of_device_id iproc_pcie_of_match_table[] = {
> >> {
> >> .compatible = "brcm,iproc-pcie",
> >> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> >> index 4937a088d7d8..202837ed68c9 100644
> >> --- a/drivers/pci/quirks.c
> >> +++ b/drivers/pci/quirks.c
> >> @@ -2381,32 +2381,6 @@ DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_BROADCOM,
> >> PCI_DEVICE_ID_TIGON3_5719,
> >> quirk_brcm_5719_limit_mrrs);
> >>
> >> -#ifdef CONFIG_PCIE_IPROC_PLATFORM
> >> -static void quirk_paxc_bridge(struct pci_dev *pdev)
> >> -{
> >> - /*
> >> - * The PCI config space is shared with the PAXC root port and the first
> >> - * Ethernet device. So, we need to workaround this by telling the PCI
> >> - * code that the bridge is not an Ethernet device.
> >> - */
> >> - if (pdev->hdr_type == PCI_HEADER_TYPE_BRIDGE)
> >> - pdev->class = PCI_CLASS_BRIDGE_PCI << 8;
> >> -
> >> - /*
> >> - * MPSS is not being set properly (as it is currently 0). This is
> >> - * because that area of the PCI config space is hard coded to zero, and
> >> - * is not modifiable by firmware. Set this to 2 (e.g., 512 byte MPS)
> >> - * so that the MPS can be set to the real max value.
> >> - */
> >> - pdev->pcie_mpss = 2;
> >> -}
> >> -DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0x16cd, quirk_paxc_bridge);
> >> -DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0x16f0, quirk_paxc_bridge);
> >> -DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd750, quirk_paxc_bridge);
> >> -DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd802, quirk_paxc_bridge);
> >> -DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd804, quirk_paxc_bridge);
> >> -#endif
> >> -
> >> /*
> >> * Originally in EDAC sources for i82875P: Intel tells BIOS developers to
> >> * hide device 6 which configures the overflow device access containing the
> >> --
> >> 2.20.1
> >>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] PCI: iproc: move quirks to driver
2019-12-12 0:02 ` Bjorn Helgaas
@ 2019-12-12 0:05 ` Ray Jui
2019-12-12 10:33 ` Wei Liu
0 siblings, 1 reply; 8+ messages in thread
From: Ray Jui @ 2019-12-12 0:05 UTC (permalink / raw)
To: bjorn
Cc: Bjorn Helgaas, Wei Liu, linux-pci, rjui, Andrew Murray,
Lorenzo Pieralisi
On 12/11/19 4:02 PM, Bjorn Helgaas wrote:
> On Wed, Dec 11, 2019 at 5:40 PM Ray Jui <ray.jui@broadcom.com> wrote:
>>
>>
>>
>> On 12/11/19 2:34 PM, Bjorn Helgaas wrote:
>>> On Wed, Dec 11, 2019 at 05:45:11PM +0000, Wei Liu wrote:
>>>> The quirks were originally enclosed by ifdef. That made the quirks not
>>>> to be applied when respective drivers were compiled as modules.
>>>>
>>>> Move the quirks to driver code to fix the issue.
>>>>
>>>> Signed-off-by: Wei Liu <wei.liu@kernel.org>
>>>
>>> This straddles the core and native driver boundary, so I applied it to
>>> pci/misc for v5.6. Thanks, I think this is a great solution! It's
>>> always nice when we can encapsulate device-specific things in a
>>> driver.
>>>
>>
>> Opps! I was going to review and comment and you are quick, :)
>>
>> I was going to say, I think it's better to keep this quirk in
>> "pcie-iproc.c" instead of "pcie-iproc-platform.c".
>>
>> The quirk is specific to certain PCIe devices under iProc (activated
>> based on device ID), but should not be tied to a specific bus
>> architecture (i.e., platform vs BCMA).
>
> I'm happy to move it; that's no problem.
>
Thanks, Bjorn!
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] PCI: iproc: move quirks to driver
2019-12-12 0:05 ` Ray Jui
@ 2019-12-12 10:33 ` Wei Liu
0 siblings, 0 replies; 8+ messages in thread
From: Wei Liu @ 2019-12-12 10:33 UTC (permalink / raw)
To: Ray Jui
Cc: bjorn, Bjorn Helgaas, Wei Liu, linux-pci, rjui, Andrew Murray,
Lorenzo Pieralisi
On Thu, 12 Dec 2019 at 00:05, Ray Jui <ray.jui@broadcom.com> wrote:
>
>
>
> On 12/11/19 4:02 PM, Bjorn Helgaas wrote:
> > On Wed, Dec 11, 2019 at 5:40 PM Ray Jui <ray.jui@broadcom.com> wrote:
> >>
> >>
> >>
> >> On 12/11/19 2:34 PM, Bjorn Helgaas wrote:
> >>> On Wed, Dec 11, 2019 at 05:45:11PM +0000, Wei Liu wrote:
> >>>> The quirks were originally enclosed by ifdef. That made the quirks not
> >>>> to be applied when respective drivers were compiled as modules.
> >>>>
> >>>> Move the quirks to driver code to fix the issue.
> >>>>
> >>>> Signed-off-by: Wei Liu <wei.liu@kernel.org>
> >>>
> >>> This straddles the core and native driver boundary, so I applied it to
> >>> pci/misc for v5.6. Thanks, I think this is a great solution! It's
> >>> always nice when we can encapsulate device-specific things in a
> >>> driver.
> >>>
> >>
> >> Opps! I was going to review and comment and you are quick, :)
> >>
> >> I was going to say, I think it's better to keep this quirk in
> >> "pcie-iproc.c" instead of "pcie-iproc-platform.c".
> >>
> >> The quirk is specific to certain PCIe devices under iProc (activated
> >> based on device ID), but should not be tied to a specific bus
> >> architecture (i.e., platform vs BCMA).
> >
> > I'm happy to move it; that's no problem.
> >
>
> Thanks, Bjorn!
Thank you both.
Wei.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] PCI: iproc: move quirks to driver
2019-12-11 22:34 ` Bjorn Helgaas
2019-12-11 23:40 ` Ray Jui
@ 2019-12-12 23:23 ` Bjorn Helgaas
2019-12-13 0:08 ` Ray Jui
1 sibling, 1 reply; 8+ messages in thread
From: Bjorn Helgaas @ 2019-12-12 23:23 UTC (permalink / raw)
To: Wei Liu; +Cc: linux-pci, rjui, Andrew Murray, Lorenzo Pieralisi
On Wed, Dec 11, 2019 at 04:34:38PM -0600, Bjorn Helgaas wrote:
> On Wed, Dec 11, 2019 at 05:45:11PM +0000, Wei Liu wrote:
> > The quirks were originally enclosed by ifdef. That made the quirks not
> > to be applied when respective drivers were compiled as modules.
> >
> > Move the quirks to driver code to fix the issue.
> >
> > Signed-off-by: Wei Liu <wei.liu@kernel.org>
>
> This straddles the core and native driver boundary, so I applied it to
> pci/misc for v5.6. Thanks, I think this is a great solution! It's
> always nice when we can encapsulate device-specific things in a
> driver.
OK, I moved this to pcie-iproc.c:
commit 574f29036fce ("PCI: iproc: Apply quirk_paxc_bridge() for module as well as built-in")
Author: Wei Liu <wei.liu@kernel.org>
Date: Wed Dec 11 17:45:11 2019 +0000
PCI: iproc: Apply quirk_paxc_bridge() for module as well as built-in
Previously quirk_paxc_bridge() was applied when the iproc driver was
built-in, but not when it was compiled as a module.
This happened because it was under #ifdef CONFIG_PCIE_IPROC_PLATFORM:
PCIE_IPROC_PLATFORM=y causes CONFIG_PCIE_IPROC_PLATFORM to be defined, but
PCIE_IPROC_PLATFORM=m causes CONFIG_PCIE_IPROC_PLATFORM_MODULE to be
defined.
Move quirk_paxc_bridge() to pcie-iproc.c and drop the #ifdef so the quirk
is always applied, whether iproc is built-in or a module.
[bhelgaas: commit log, move to pcie-iproc.c, not pcie-iproc-platform.c]
Link: https://lore.kernel.org/r/20191211174511.89713-1-wei.liu@kernel.org
Signed-off-by: Wei Liu <wei.liu@kernel.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
diff --git a/drivers/pci/controller/pcie-iproc.c b/drivers/pci/controller/pcie-iproc.c
index 0a468c73bae3..8c7f875acf7f 100644
--- a/drivers/pci/controller/pcie-iproc.c
+++ b/drivers/pci/controller/pcie-iproc.c
@@ -1588,6 +1588,30 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd802,
DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd804,
quirk_paxc_disable_msi_parsing);
+static void quirk_paxc_bridge(struct pci_dev *pdev)
+{
+ /*
+ * The PCI config space is shared with the PAXC root port and the first
+ * Ethernet device. So, we need to workaround this by telling the PCI
+ * code that the bridge is not an Ethernet device.
+ */
+ if (pdev->hdr_type == PCI_HEADER_TYPE_BRIDGE)
+ pdev->class = PCI_CLASS_BRIDGE_PCI << 8;
+
+ /*
+ * MPSS is not being set properly (as it is currently 0). This is
+ * because that area of the PCI config space is hard coded to zero, and
+ * is not modifiable by firmware. Set this to 2 (e.g., 512 byte MPS)
+ * so that the MPS can be set to the real max value.
+ */
+ pdev->pcie_mpss = 2;
+}
+DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0x16cd, quirk_paxc_bridge);
+DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0x16f0, quirk_paxc_bridge);
+DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd750, quirk_paxc_bridge);
+DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd802, quirk_paxc_bridge);
+DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd804, quirk_paxc_bridge);
+
MODULE_AUTHOR("Ray Jui <rjui@broadcom.com>");
MODULE_DESCRIPTION("Broadcom iPROC PCIe common driver");
MODULE_LICENSE("GPL v2");
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 4937a088d7d8..202837ed68c9 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -2381,32 +2381,6 @@ DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_BROADCOM,
PCI_DEVICE_ID_TIGON3_5719,
quirk_brcm_5719_limit_mrrs);
-#ifdef CONFIG_PCIE_IPROC_PLATFORM
-static void quirk_paxc_bridge(struct pci_dev *pdev)
-{
- /*
- * The PCI config space is shared with the PAXC root port and the first
- * Ethernet device. So, we need to workaround this by telling the PCI
- * code that the bridge is not an Ethernet device.
- */
- if (pdev->hdr_type == PCI_HEADER_TYPE_BRIDGE)
- pdev->class = PCI_CLASS_BRIDGE_PCI << 8;
-
- /*
- * MPSS is not being set properly (as it is currently 0). This is
- * because that area of the PCI config space is hard coded to zero, and
- * is not modifiable by firmware. Set this to 2 (e.g., 512 byte MPS)
- * so that the MPS can be set to the real max value.
- */
- pdev->pcie_mpss = 2;
-}
-DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0x16cd, quirk_paxc_bridge);
-DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0x16f0, quirk_paxc_bridge);
-DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd750, quirk_paxc_bridge);
-DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd802, quirk_paxc_bridge);
-DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd804, quirk_paxc_bridge);
-#endif
-
/*
* Originally in EDAC sources for i82875P: Intel tells BIOS developers to
* hide device 6 which configures the overflow device access containing the
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] PCI: iproc: move quirks to driver
2019-12-12 23:23 ` Bjorn Helgaas
@ 2019-12-13 0:08 ` Ray Jui
0 siblings, 0 replies; 8+ messages in thread
From: Ray Jui @ 2019-12-13 0:08 UTC (permalink / raw)
To: Bjorn Helgaas, Wei Liu; +Cc: linux-pci, rjui, Andrew Murray, Lorenzo Pieralisi
On 2019-12-12 3:23 p.m., Bjorn Helgaas wrote:
> On Wed, Dec 11, 2019 at 04:34:38PM -0600, Bjorn Helgaas wrote:
>> On Wed, Dec 11, 2019 at 05:45:11PM +0000, Wei Liu wrote:
>>> The quirks were originally enclosed by ifdef. That made the quirks not
>>> to be applied when respective drivers were compiled as modules.
>>>
>>> Move the quirks to driver code to fix the issue.
>>>
>>> Signed-off-by: Wei Liu <wei.liu@kernel.org>
>>
>> This straddles the core and native driver boundary, so I applied it to
>> pci/misc for v5.6. Thanks, I think this is a great solution! It's
>> always nice when we can encapsulate device-specific things in a
>> driver.
>
> OK, I moved this to pcie-iproc.c:
>
Thanks a lot, Bjorn!
> commit 574f29036fce ("PCI: iproc: Apply quirk_paxc_bridge() for module as well as built-in")
> Author: Wei Liu <wei.liu@kernel.org>
> Date: Wed Dec 11 17:45:11 2019 +0000
>
> PCI: iproc: Apply quirk_paxc_bridge() for module as well as built-in
>
> Previously quirk_paxc_bridge() was applied when the iproc driver was
> built-in, but not when it was compiled as a module.
>
> This happened because it was under #ifdef CONFIG_PCIE_IPROC_PLATFORM:
> PCIE_IPROC_PLATFORM=y causes CONFIG_PCIE_IPROC_PLATFORM to be defined, but
> PCIE_IPROC_PLATFORM=m causes CONFIG_PCIE_IPROC_PLATFORM_MODULE to be
> defined.
>
> Move quirk_paxc_bridge() to pcie-iproc.c and drop the #ifdef so the quirk
> is always applied, whether iproc is built-in or a module.
>
> [bhelgaas: commit log, move to pcie-iproc.c, not pcie-iproc-platform.c]
> Link: https://lore.kernel.org/r/20191211174511.89713-1-wei.liu@kernel.org
> Signed-off-by: Wei Liu <wei.liu@kernel.org>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
>
> diff --git a/drivers/pci/controller/pcie-iproc.c b/drivers/pci/controller/pcie-iproc.c
> index 0a468c73bae3..8c7f875acf7f 100644
> --- a/drivers/pci/controller/pcie-iproc.c
> +++ b/drivers/pci/controller/pcie-iproc.c
> @@ -1588,6 +1588,30 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd802,
> DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd804,
> quirk_paxc_disable_msi_parsing);
>
> +static void quirk_paxc_bridge(struct pci_dev *pdev)
> +{
> + /*
> + * The PCI config space is shared with the PAXC root port and the first
> + * Ethernet device. So, we need to workaround this by telling the PCI
> + * code that the bridge is not an Ethernet device.
> + */
> + if (pdev->hdr_type == PCI_HEADER_TYPE_BRIDGE)
> + pdev->class = PCI_CLASS_BRIDGE_PCI << 8;
> +
> + /*
> + * MPSS is not being set properly (as it is currently 0). This is
> + * because that area of the PCI config space is hard coded to zero, and
> + * is not modifiable by firmware. Set this to 2 (e.g., 512 byte MPS)
> + * so that the MPS can be set to the real max value.
> + */
> + pdev->pcie_mpss = 2;
> +}
> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0x16cd, quirk_paxc_bridge);
> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0x16f0, quirk_paxc_bridge);
> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd750, quirk_paxc_bridge);
> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd802, quirk_paxc_bridge);
> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd804, quirk_paxc_bridge);
> +
> MODULE_AUTHOR("Ray Jui <rjui@broadcom.com>");
> MODULE_DESCRIPTION("Broadcom iPROC PCIe common driver");
> MODULE_LICENSE("GPL v2");
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 4937a088d7d8..202837ed68c9 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -2381,32 +2381,6 @@ DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_BROADCOM,
> PCI_DEVICE_ID_TIGON3_5719,
> quirk_brcm_5719_limit_mrrs);
>
> -#ifdef CONFIG_PCIE_IPROC_PLATFORM
> -static void quirk_paxc_bridge(struct pci_dev *pdev)
> -{
> - /*
> - * The PCI config space is shared with the PAXC root port and the first
> - * Ethernet device. So, we need to workaround this by telling the PCI
> - * code that the bridge is not an Ethernet device.
> - */
> - if (pdev->hdr_type == PCI_HEADER_TYPE_BRIDGE)
> - pdev->class = PCI_CLASS_BRIDGE_PCI << 8;
> -
> - /*
> - * MPSS is not being set properly (as it is currently 0). This is
> - * because that area of the PCI config space is hard coded to zero, and
> - * is not modifiable by firmware. Set this to 2 (e.g., 512 byte MPS)
> - * so that the MPS can be set to the real max value.
> - */
> - pdev->pcie_mpss = 2;
> -}
> -DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0x16cd, quirk_paxc_bridge);
> -DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0x16f0, quirk_paxc_bridge);
> -DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd750, quirk_paxc_bridge);
> -DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd802, quirk_paxc_bridge);
> -DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_BROADCOM, 0xd804, quirk_paxc_bridge);
> -#endif
> -
> /*
> * Originally in EDAC sources for i82875P: Intel tells BIOS developers to
> * hide device 6 which configures the overflow device access containing the
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-12-13 0:09 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-11 17:45 [PATCH] PCI: iproc: move quirks to driver Wei Liu
2019-12-11 22:34 ` Bjorn Helgaas
2019-12-11 23:40 ` Ray Jui
2019-12-12 0:02 ` Bjorn Helgaas
2019-12-12 0:05 ` Ray Jui
2019-12-12 10:33 ` Wei Liu
2019-12-12 23:23 ` Bjorn Helgaas
2019-12-13 0:08 ` Ray Jui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).