From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: linux-pci@vger.kernel.org, richardcochran@gmail.com,
hch@infradead.org, netdev@vger.kernel.org, bhelgaas@google.com,
helgaas@kernel.org, intel-wired-lan@lists.osuosl.org
Subject: Re: [Intel-wired-lan] [PATCH next-queue v5 3/4] igc: Enable PCIe PTM
Date: Wed, 09 Jun 2021 16:07:20 -0700 [thread overview]
Message-ID: <87k0n2vdqv.fsf@vcostago-mobl2.amr.corp.intel.com> (raw)
In-Reply-To: <d8740484-3879-1c13-65ce-82d3e71cb96c@molgen.mpg.de>
Hi Paul,
>>
>>> Regarding my comment, I did not mean returning an error but the log
>>> *level* of the message. So, `dmesg --level err` would show that message.
>>> But if there are PCI controllers not supporting that, it’s not an error,
>>> but a warning at most. So, I’d use:
>>>
>>> dev_warn(&pdev->dev, "PTM not supported by PCI bus/controller
>>> (pci_enable_ptm() failed)\n");
>>
>> I will use you suggestion for the message, but I think that warn is a
>> bit too much, info or notice seem to be better.
>
> I do not know, if modern PCI(e)(?) controllers normally support PTM or
> not. If recent controllers should support it, then a warning would be
> warranted, otherwise a notice.
>
From the Intel side, it seems that it's been supported for a few years.
So, fair enough, let's go with a warn.
Cheers,
--
Vinicius
next prev parent reply other threads:[~2021-06-09 23:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-05 0:23 [PATCH next-queue v5 0/4] igc: Add support for PCIe PTM Vinicius Costa Gomes
2021-06-05 0:23 ` [PATCH next-queue v5 1/4] Revert "PCI: Make pci_enable_ptm() private" Vinicius Costa Gomes
2021-06-05 0:23 ` [PATCH next-queue v5 2/4] PCI: Add pcie_ptm_enabled() Vinicius Costa Gomes
2021-06-05 0:23 ` [PATCH next-queue v5 3/4] igc: Enable PCIe PTM Vinicius Costa Gomes
2021-06-05 6:42 ` [Intel-wired-lan] " Paul Menzel
2021-06-08 19:02 ` Vinicius Costa Gomes
2021-06-09 6:24 ` Paul Menzel
2021-06-09 20:08 ` Vinicius Costa Gomes
2021-06-09 21:26 ` Paul Menzel
2021-06-09 23:07 ` Vinicius Costa Gomes [this message]
2021-06-09 23:20 ` Bjorn Helgaas
2021-06-10 0:04 ` Vinicius Costa Gomes
2021-06-05 0:23 ` [PATCH next-queue v5 4/4] igc: Add support for PTP getcrosststamp() Vinicius Costa Gomes
2021-06-05 6:36 ` [Intel-wired-lan] " Paul Menzel
2021-06-08 22:02 ` Vinicius Costa Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0n2vdqv.fsf@vcostago-mobl2.amr.corp.intel.com \
--to=vinicius.gomes@intel.com \
--cc=bhelgaas@google.com \
--cc=hch@infradead.org \
--cc=helgaas@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pmenzel@molgen.mpg.de \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).