From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: linux-pci@vger.kernel.org, richardcochran@gmail.com,
hch@infradead.org, netdev@vger.kernel.org, bhelgaas@google.com,
helgaas@kernel.org, intel-wired-lan@lists.osuosl.org
Subject: Re: [Intel-wired-lan] [PATCH next-queue v5 3/4] igc: Enable PCIe PTM
Date: Wed, 09 Jun 2021 13:08:22 -0700 [thread overview]
Message-ID: <87r1havm15.fsf@vcostago-mobl2.amr.corp.intel.com> (raw)
In-Reply-To: <939b8042-a313-47db-43d9-ea37e95b724b@molgen.mpg.de>
Paul Menzel <pmenzel@molgen.mpg.de> writes:
> Dear Vinicius,
>
>
> Am 08.06.21 um 21:02 schrieb Vinicius Costa Gomes:
>
>> Paul Menzel writes:
>
>>> Am 05.06.21 um 02:23 schrieb Vinicius Costa Gomes:
>>>> Enables PCIe PTM (Precision Time Measurement) support in the igc
>>>> driver. Notifies the PCI devices that PCIe PTM should be enabled.
>>>>
>>>> PCIe PTM is similar protocol to PTP (Precision Time Protocol) running
>>>> in the PCIe fabric, it allows devices to report time measurements from
>>>> their internal clocks and the correlation with the PCIe root clock.
>>>>
>>>> The i225 NIC exposes some registers that expose those time
>>>> measurements, those registers will be used, in later patches, to
>>>> implement the PTP_SYS_OFFSET_PRECISE ioctl().
>>>>
>>>> Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
>>>> ---
>>>> drivers/net/ethernet/intel/igc/igc_main.c | 6 ++++++
>>>> 1 file changed, 6 insertions(+)
>>>>
>>>> diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
>>>> index a05e6d8ec660..f23d0303e53b 100644
>>>> --- a/drivers/net/ethernet/intel/igc/igc_main.c
>>>> +++ b/drivers/net/ethernet/intel/igc/igc_main.c
>>>> @@ -12,6 +12,8 @@
>>>> #include <net/pkt_sched.h>
>>>> #include <linux/bpf_trace.h>
>>>> #include <net/xdp_sock_drv.h>
>>>> +#include <linux/pci.h>
>>>> +
>>>> #include <net/ipv6.h>
>>>>
>>>> #include "igc.h"
>>>> @@ -5864,6 +5866,10 @@ static int igc_probe(struct pci_dev *pdev,
>>>>
>>>> pci_enable_pcie_error_reporting(pdev);
>>>>
>>>> + err = pci_enable_ptm(pdev, NULL);
>>>> + if (err < 0)
>>>> + dev_err(&pdev->dev, "PTM not supported\n");
>>>> +
>>>
>>> Sorry, if I am missing something, but do all devices supported by this
>>> driver support PTM or only the i225 NIC? In that case, it wouldn’t be an
>>> error for a device not supporting PTM, would it?
>>
>> That was a very good question. I had to talk with the hardware folks.
>> All the devices supported by the igc driver should support PTM.
>
> Thank you for checking that, that is valuable information.
>
>> And just to be clear, the reason that I am not returning an error here
>> is that PTM could not be supported by the host system (think PCI
>> controller).
>
> I just checked `pci_enable_ptm()` and on success it calls
> `pci_ptm_info()` logging a message:
>
> pci_info(dev, "PTM enabled%s, %s granularity\n",
> dev->ptm_root ? " (root)" : "", clock_desc);
>
> Was that present on your system with your patch? Please add that to the
> commit message.
Yes, with my patches applied I can see this message on my systems.
Sure, will add this to the commit message.
>
> Regarding my comment, I did not mean returning an error but the log
> *level* of the message. So, `dmesg --level err` would show that message.
> But if there are PCI controllers not supporting that, it’s not an error,
> but a warning at most. So, I’d use:
>
> dev_warn(&pdev->dev, "PTM not supported by PCI bus/controller
> (pci_enable_ptm() failed)\n");
I will use you suggestion for the message, but I think that warn is a
bit too much, info or notice seem to be better.
Cheers,
--
Vinicius
next prev parent reply other threads:[~2021-06-09 20:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-05 0:23 [PATCH next-queue v5 0/4] igc: Add support for PCIe PTM Vinicius Costa Gomes
2021-06-05 0:23 ` [PATCH next-queue v5 1/4] Revert "PCI: Make pci_enable_ptm() private" Vinicius Costa Gomes
2021-06-05 0:23 ` [PATCH next-queue v5 2/4] PCI: Add pcie_ptm_enabled() Vinicius Costa Gomes
2021-06-05 0:23 ` [PATCH next-queue v5 3/4] igc: Enable PCIe PTM Vinicius Costa Gomes
2021-06-05 6:42 ` [Intel-wired-lan] " Paul Menzel
2021-06-08 19:02 ` Vinicius Costa Gomes
2021-06-09 6:24 ` Paul Menzel
2021-06-09 20:08 ` Vinicius Costa Gomes [this message]
2021-06-09 21:26 ` Paul Menzel
2021-06-09 23:07 ` Vinicius Costa Gomes
2021-06-09 23:20 ` Bjorn Helgaas
2021-06-10 0:04 ` Vinicius Costa Gomes
2021-06-05 0:23 ` [PATCH next-queue v5 4/4] igc: Add support for PTP getcrosststamp() Vinicius Costa Gomes
2021-06-05 6:36 ` [Intel-wired-lan] " Paul Menzel
2021-06-08 22:02 ` Vinicius Costa Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1havm15.fsf@vcostago-mobl2.amr.corp.intel.com \
--to=vinicius.gomes@intel.com \
--cc=bhelgaas@google.com \
--cc=hch@infradead.org \
--cc=helgaas@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pmenzel@molgen.mpg.de \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).