[PATCH v12 0/2] PCI: microchip: Add host driver for Microchip PCIe controller

[PATCH v12 0/2] PCI: microchip: Add host driver for Microchip PCIe controller

[Daire.McNamara]

This v12 patch adds support for the Microchip PCIe PolarFire PCIe
controller when configured in host (Root Complex) mode.

Updates since v11:
* Adjusted so yaml file passses make dt_binding_check without warnings

Updates since v10:
* Adjusted driver as per Rob Herring's comments, notably:
  - use common PCI_MSI_FLAGS defines
  - reduce storage of unnecessary vars in mc_pcie struct
  - switched to read/write relaxed variants
  - extended lock in msi_domain_alloc routine
  - improved 32bit safety, switched from find_first_bit() to ilog2()
  - removed unnecessary twiddle of eCAM config space

Updates since v9:
* Adjusted commit logs
* make dt_bindings_check passes

Updates since v8:
* Refactored as per Rob Herring's comments:
  - bindings in schema format
  - Adjusted licence to GPLv2.0
  - Refactored access to config space between driver and common eCAM code
  - Adopted pci_host_probe()
  - Miscellanous other improvements

Updates since v7:
* Build for 64bit RISCV architecture only

Updates since v6:
* Refactored to use common eCAM driver
* Updated to CONFIG_PCIE_MICROCHIP_HOST etc
* Formatting improvements
* Removed code for selection between bridge 0 and 1

Updates since v5:
* Fixed Kconfig typo noted by Randy Dunlap
* Updated with comments from Bjorn Helgaas

Updates since v4:
* Fix compile issues.

Updates since v3:
* Update all references to Microsemi to Microchip
* Separate MSI functionality from legacy PCIe interrupt handling functionality

Updates since v2:
* Split out DT bindings and Vendor ID updates into their own patch
  from PCIe driver.
* Updated Change Log

Updates since v1:
* Incorporate feedback from Bjorn Helgaas

Daire McNamara (2):
  PCI: microchip: Add host driver for Microchip PCIe controller
  PCI: microchip: Add host driver for Microchip PCIe controller

 .../bindings/pci/microchip,pcie-host.yaml     |  93 +++
 drivers/pci/controller/Kconfig                |   9 +
 drivers/pci/controller/Makefile               |   1 +
 drivers/pci/controller/pcie-microchip-host.c  | 683 ++++++++++++++++++
 4 files changed, 786 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml
 create mode 100644 drivers/pci/controller/pcie-microchip-host.c


base-commit: cd77006e01b3198c75fb7819b3d0ff89709539bb
-- 
2.17.1

Re: [PATCH v12 0/2] PCI: microchip: Add host driver for Microchip PCIe controller

[Bjorn Helgaas]

On Thu, Jul 02, 2020 at 03:37:12PM +0000, Daire.McNamara@microchip.com wrote:
> This v12 patch adds support for the Microchip PCIe PolarFire PCIe
> controller when configured in host (Root Complex) mode.

> Daire McNamara (2):
>   PCI: microchip: Add host driver for Microchip PCIe controller
>   PCI: microchip: Add host driver for Microchip PCIe controller

Hi Daire,

I see this in the lore archive:
https://lore.kernel.org/linux-pci/97e528fd7582186d7db4073c78d72601b2ce553f.camel@microchip.com/

but

  - It's not threaded correctly.  The 1/2 and 2/2 patches should be
    responses to the 0/2 cover letter.  The fact that they're not
    means one cannot navigate through the series on
    https://lore.kernel.org.

  - For some reason none of these made it to me directly even though
    I'm in the To: list as well as subscribed to the linux-pci list.
    They *do* appear in both patchwork and lore, and I think they both
    get things via the linux-pci list, so I don't know what's wrong.

    I did correct Rob's email address; maybe that was part of it?

  - The patches should have different subjects.  The DT binding should
    have a subject that matches the history in
    Documentation/devicetree/bindings/pci/, e.g., something like:

    dt-bindings: PCI: microchip: Add Microchip PolarFire host binding

  - The commit logs should be good English; for example, they should
    start with a capital letter.

>  .../bindings/pci/microchip,pcie-host.yaml     |  93 +++
>  drivers/pci/controller/Kconfig                |   9 +
>  drivers/pci/controller/Makefile               |   1 +
>  drivers/pci/controller/pcie-microchip-host.c  | 683 ++++++++++++++++++
>  4 files changed, 786 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml
>  create mode 100644 drivers/pci/controller/pcie-microchip-host.c
> 
> 
> base-commit: cd77006e01b3198c75fb7819b3d0ff89709539bb
> -- 
> 2.17.1
>