From: Bharat Kumar Gogada <bharatku@xilinx.com>
To: Rob Herring <robh@kernel.org>
Cc: PCI <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Michal Simek <michals@xilinx.com>
Subject: RE: [PATCH v3 1/2] dt-bindings: PCI: xilinx-cpm: Add Versal CPM5 Root Port
Date: Mon, 14 Mar 2022 04:33:18 +0000 [thread overview]
Message-ID: <BY5PR02MB694719773875D2A544EC6BD1A50F9@BY5PR02MB6947.namprd02.prod.outlook.com> (raw)
In-Reply-To: <CAL_JsqL3CSERnTihfc_CKB96bbdN2xxkb78H383pMfC_bGg+Xw@mail.gmail.com>
> On Wed, Mar 9, 2022 at 6:00 AM Bharat Kumar Gogada
> <bharat.kumar.gogada@xilinx.com> wrote:
> >
> > Xilinx Versal Premium series has CPM5 block which supports Root Port
> > functioning at Gen5 speed.
> >
> > Add support for YAML schemas documentation for Versal CPM5 Root Port
> driver.
> >
> > Signed-off-by: Bharat Kumar Gogada <bharat.kumar.gogada@xilinx.com>
> > ---
> > .../bindings/pci/xilinx-versal-cpm.yaml | 47 ++++++++++++++++---
> > 1 file changed, 40 insertions(+), 7 deletions(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml
> > b/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml
> > index 32f4641085bc..97c7229d7f91 100644
> > --- a/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml
> > +++ b/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml
> > @@ -14,17 +14,21 @@ allOf:
> >
> > properties:
> > compatible:
> > - const: xlnx,versal-cpm-host-1.00
> > + contains:
>
> Nope. That means 'compatible = "foo", "xlnx,versal-cpm-host-1.00", "bar";'
> would be valid.
>
> > + enum:
> > + - xlnx,versal-cpm-host-1.00
> > + - xlnx,versal-cpm5-host-1.00
>
> Where does 1.00 come from? My guess is you or whoever did the original
> binding just made it up. Version numbers are only used when they
> correspond to something documented for the h/w. In the case of Xilinx, that
> should be soft IP (which I assume has versioned releases) and nothing else. If
> 'versal' is not specific enough to identify a specific SoC, then add to it.
>
Agreed, will remove version numbers.
>
> > reg:
> > - items:
> > - - description: Configuration space region and bridge registers.
> > - - description: CPM system level control and status registers.
> > + description: |
> > + Should contain cpm_slcr, cfg registers location and length.
> > + For xlnx,versal-cpm5-host-1.00, it should also contain cpm_csr.
>
> Not an improvement in defining what each entry is.
Agreed, will fix this in next patch.
regards,
Bharat
next prev parent reply other threads:[~2022-03-14 4:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 12:00 [PATCH v3 0/2] Add support for Xilinx Versal CPM5 Root Port Bharat Kumar Gogada
2022-03-09 12:00 ` [PATCH v3 1/2] dt-bindings: PCI: xilinx-cpm: Add " Bharat Kumar Gogada
2022-03-10 13:24 ` Krzysztof Kozlowski
2022-03-14 4:32 ` Bharat Kumar Gogada
2022-03-10 13:33 ` Krzysztof Kozlowski
2022-03-10 19:13 ` Rob Herring
2022-03-14 4:33 ` Bharat Kumar Gogada [this message]
2022-03-09 12:00 ` [PATCH v3 2/2] PCI: xilinx-cpm: Add support for " Bharat Kumar Gogada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR02MB694719773875D2A544EC6BD1A50F9@BY5PR02MB6947.namprd02.prod.outlook.com \
--to=bharatku@xilinx.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=michals@xilinx.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).