* Re: [PATCH] xhci-pci: Set AMD Renoir USB controller to D3 when shutdown
[not found] ` <YCJJrVp2DvCzigCw@kroah.com>
@ 2021-02-10 13:13 ` Mathias Nyman
2021-02-11 12:50 ` Greg Kroah-Hartman
0 siblings, 1 reply; 4+ messages in thread
From: Mathias Nyman @ 2021-02-10 13:13 UTC (permalink / raw)
To: Greg Kroah-Hartman, Kai-Heng Feng
Cc: Aaron Ma, Alan Stern, Lee Jones, peter.chen, USB list, LKML,
Bjorn Helgaas, Linux PCI
On 9.2.2021 10.37, Greg Kroah-Hartman wrote:
> On Fri, Feb 05, 2021 at 02:50:15PM +0800, Kai-Heng Feng wrote:
>> On Fri, Feb 5, 2021 at 2:45 PM Aaron Ma <aaron.ma@canonical.com> wrote:
>>>
>>>
>>> On 2/5/21 12:27 PM, Kai-Heng Feng wrote:
>>>> Can you please test the following patch, which should address the root cause:
>>>> https://lore.kernel.org/linux-acpi/20201201213019.1558738-1-furquan@google.com/
>>>>
>>>> It also helps another AMD laptop on S5:
>>>> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1912935
>>>>
>>>
>>> No, this patch doesn't help on ThinkPad AMD platform.
>>
>> Thanks for the confirmation!
>>
>> Acked-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
>
> Mathias, want me to take this in my tree now, or are you going to send
> me more patches for 5.12-rc1?
>
Nothing more for 5.12-rc1 from me.
Could this be a PCI quirk instead of xhci?
Maybe there is some PCI flag for this already, haven't checked yet.
We want a specific PCI device to go to PCI D3cold at PCI shutdown...
If not, then adding this to xhci is fine for me as well
Thanks
-Mathias
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xhci-pci: Set AMD Renoir USB controller to D3 when shutdown
2021-02-10 13:13 ` [PATCH] xhci-pci: Set AMD Renoir USB controller to D3 when shutdown Mathias Nyman
@ 2021-02-11 12:50 ` Greg Kroah-Hartman
2021-02-19 8:07 ` Aaron Ma
0 siblings, 1 reply; 4+ messages in thread
From: Greg Kroah-Hartman @ 2021-02-11 12:50 UTC (permalink / raw)
To: Mathias Nyman
Cc: Kai-Heng Feng, Aaron Ma, Alan Stern, Lee Jones, peter.chen,
USB list, LKML, Bjorn Helgaas, Linux PCI
On Wed, Feb 10, 2021 at 03:13:30PM +0200, Mathias Nyman wrote:
> On 9.2.2021 10.37, Greg Kroah-Hartman wrote:
> > On Fri, Feb 05, 2021 at 02:50:15PM +0800, Kai-Heng Feng wrote:
> >> On Fri, Feb 5, 2021 at 2:45 PM Aaron Ma <aaron.ma@canonical.com> wrote:
> >>>
> >>>
> >>> On 2/5/21 12:27 PM, Kai-Heng Feng wrote:
> >>>> Can you please test the following patch, which should address the root cause:
> >>>> https://lore.kernel.org/linux-acpi/20201201213019.1558738-1-furquan@google.com/
> >>>>
> >>>> It also helps another AMD laptop on S5:
> >>>> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1912935
> >>>>
> >>>
> >>> No, this patch doesn't help on ThinkPad AMD platform.
> >>
> >> Thanks for the confirmation!
> >>
> >> Acked-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> >
> > Mathias, want me to take this in my tree now, or are you going to send
> > me more patches for 5.12-rc1?
> >
>
> Nothing more for 5.12-rc1 from me.
>
> Could this be a PCI quirk instead of xhci?
> Maybe there is some PCI flag for this already, haven't checked yet.
>
> We want a specific PCI device to go to PCI D3cold at PCI shutdown...
There probably is. Kay-Heng, can you look into doing that instead?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xhci-pci: Set AMD Renoir USB controller to D3 when shutdown
2021-02-11 12:50 ` Greg Kroah-Hartman
@ 2021-02-19 8:07 ` Aaron Ma
2021-02-22 5:56 ` Kai-Heng Feng
0 siblings, 1 reply; 4+ messages in thread
From: Aaron Ma @ 2021-02-19 8:07 UTC (permalink / raw)
To: Greg Kroah-Hartman, Mathias Nyman
Cc: Kai-Heng Feng, Alan Stern, Lee Jones, peter.chen, USB list, LKML,
Bjorn Helgaas, Linux PCI
On 2/11/21 8:50 PM, Greg Kroah-Hartman wrote:
> On Wed, Feb 10, 2021 at 03:13:30PM +0200, Mathias Nyman wrote:
>> On 9.2.2021 10.37, Greg Kroah-Hartman wrote:
>>> On Fri, Feb 05, 2021 at 02:50:15PM +0800, Kai-Heng Feng wrote:
>>>> On Fri, Feb 5, 2021 at 2:45 PM Aaron Ma <aaron.ma@canonical.com> wrote:
>>>>>
>>>>>
>>>>> On 2/5/21 12:27 PM, Kai-Heng Feng wrote:
>>>>>> Can you please test the following patch, which should address the root cause:
>>>>>> https://lore.kernel.org/linux-acpi/20201201213019.1558738-1-furquan@google.com/
>>>>>>
>>>>>> It also helps another AMD laptop on S5:
>>>>>> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1912935
>>>>>>
>>>>>
>>>>> No, this patch doesn't help on ThinkPad AMD platform.
>>>>
>>>> Thanks for the confirmation!
>>>>
>>>> Acked-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
>>>
>>> Mathias, want me to take this in my tree now, or are you going to send
>>> me more patches for 5.12-rc1?
>>>
>>
>> Nothing more for 5.12-rc1 from me.
>>
>> Could this be a PCI quirk instead of xhci?
>> Maybe there is some PCI flag for this already, haven't checked yet.
>>
>> We want a specific PCI device to go to PCI D3cold at PCI shutdown...
>
> There probably is. Kay-Heng, can you look into doing that instead?
>
There is no such PCI quirk, usually it calls driver to shutdown.
Regards,
Aaron
> thanks,
>
> greg k-h
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xhci-pci: Set AMD Renoir USB controller to D3 when shutdown
2021-02-19 8:07 ` Aaron Ma
@ 2021-02-22 5:56 ` Kai-Heng Feng
0 siblings, 0 replies; 4+ messages in thread
From: Kai-Heng Feng @ 2021-02-22 5:56 UTC (permalink / raw)
To: Aaron Ma
Cc: Greg Kroah-Hartman, Mathias Nyman, Alan Stern, Lee Jones,
peter.chen, USB list, LKML, Bjorn Helgaas, Linux PCI
On Fri, Feb 19, 2021 at 4:07 PM Aaron Ma <aaron.ma@canonical.com> wrote:
>
>
>
> On 2/11/21 8:50 PM, Greg Kroah-Hartman wrote:
> > On Wed, Feb 10, 2021 at 03:13:30PM +0200, Mathias Nyman wrote:
> >> On 9.2.2021 10.37, Greg Kroah-Hartman wrote:
> >>> On Fri, Feb 05, 2021 at 02:50:15PM +0800, Kai-Heng Feng wrote:
> >>>> On Fri, Feb 5, 2021 at 2:45 PM Aaron Ma <aaron.ma@canonical.com> wrote:
> >>>>>
> >>>>>
> >>>>> On 2/5/21 12:27 PM, Kai-Heng Feng wrote:
> >>>>>> Can you please test the following patch, which should address the root cause:
> >>>>>> https://lore.kernel.org/linux-acpi/20201201213019.1558738-1-furquan@google.com/
> >>>>>>
> >>>>>> It also helps another AMD laptop on S5:
> >>>>>> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1912935
> >>>>>>
> >>>>>
> >>>>> No, this patch doesn't help on ThinkPad AMD platform.
> >>>>
> >>>> Thanks for the confirmation!
> >>>>
> >>>> Acked-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> >>>
> >>> Mathias, want me to take this in my tree now, or are you going to send
> >>> me more patches for 5.12-rc1?
> >>>
> >>
> >> Nothing more for 5.12-rc1 from me.
> >>
> >> Could this be a PCI quirk instead of xhci?
> >> Maybe there is some PCI flag for this already, haven't checked yet.
> >>
> >> We want a specific PCI device to go to PCI D3cold at PCI shutdown...
> >
> > There probably is. Kay-Heng, can you look into doing that instead?
> >
>
> There is no such PCI quirk, usually it calls driver to shutdown.
Let me work on it. There are other devices need to be in D3 for
shutdown, a generic approach across all devices will be better.
Kai-Heng
>
> Regards,
> Aaron
>
> > thanks,
> >
> > greg k-h
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-22 5:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210204051850.64857-1-aaron.ma@canonical.com>
[not found] ` <CAAd53p4euFiw7pfDnD2H8oMVeeTqQ_c+wOFDLM2xPccn5MewiA@mail.gmail.com>
[not found] ` <cd4595e6-67da-885c-1a67-6dfd71425b8c@canonical.com>
[not found] ` <CAAd53p4z1ydFi5pwOZJnsrBDPNVLKU0ygqa0+kdZdXWYocPLgQ@mail.gmail.com>
[not found] ` <YCJJrVp2DvCzigCw@kroah.com>
2021-02-10 13:13 ` [PATCH] xhci-pci: Set AMD Renoir USB controller to D3 when shutdown Mathias Nyman
2021-02-11 12:50 ` Greg Kroah-Hartman
2021-02-19 8:07 ` Aaron Ma
2021-02-22 5:56 ` Kai-Heng Feng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).