Linux-PCI Archive on lore.kernel.org
 help / Atom feed
* Re: [PATCH] drm: Require PCI for selecting VGA_ARB.
       [not found] ` <6ba074cd-bd1b-3844-8a3b-b0cfb34e24bc@linux.intel.com>
@ 2019-01-08 15:56   ` Paul Menzel
  2019-01-08 16:07     ` Sinan Kaya
  0 siblings, 1 reply; 2+ messages in thread
From: Paul Menzel @ 2019-01-08 15:56 UTC (permalink / raw)
  To: Maarten Lankhorst, Maxime Ripard, Sean Paul, David Airlie, Daniel Vetter
  Cc: dri-devel, Linux Kernel Mailing List, linux-pci,
	Christoph Hellwig, Bjorn Helgaas

[-- Attachment #1.1: Type: text/plain, Size: 4373 bytes --]

Dear Maarten,


Thank you very much for the quick response.

On 01/08/19 16:37, Maarten Lankhorst wrote:
> Op 08-01-2019 om 16:07 schreef Paul Menzel:

>> Building Linux 5.0-rc1 fails with the errors below. Please find the
>> configuration file attached.
>>
>> ```
>> $ make -j120
>> […]
>> drivers/gpu/vga/vgaarb.c: In function ‘__vga_tryget’:
>> drivers/gpu/vga/vgaarb.c:286:14: error: ‘PCI_VGA_STATE_CHANGE_DECODES’ undeclared (first use in this function); did you mean ‘PCI_SUBTRACTIVE_DECODE’?
>>      flags |= PCI_VGA_STATE_CHANGE_DECODES;
>>               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>               PCI_SUBTRACTIVE_DECODE
>> drivers/gpu/vga/vgaarb.c:286:14: note: each undeclared identifier is reported only once for each function it appears in
>>   CC [M]  net/netfilter/xt_realm.o
>>   CC      drivers/hid/hid-cherry.o
>> drivers/gpu/vga/vga_switcheroo.c: In function ‘vga_switcheroo_runtime_suspend’:
>> drivers/gpu/vga/vga_switcheroo.c:1053:2: error: implicit declaration of function ‘pci_bus_set_current_state’; did you mean ‘__set_current_state’? [-Werror=implicit-function-declaration]
>>   pci_bus_set_current_state(pdev->bus, PCI_D3cold);
>>   ^~~~~~~~~~~~~~~~~~~~~~~~~
>>   __set_current_state
>> drivers/gpu/vga/vgaarb.c:291:13: error: ‘PCI_VGA_STATE_CHANGE_BRIDGE’ undeclared (first use in this function); did you mean ‘PCI_VGA_STATE_CHANGE_DECODES’?
>>     flags |= PCI_VGA_STATE_CHANGE_BRIDGE;
>>              ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>>              PCI_VGA_STATE_CHANGE_DECODES
>>   CC      fs/reiserfs/dir.o
>>   LD [M]  net/tipc/tipc.o
>> drivers/gpu/vga/vga_switcheroo.c: In function ‘vga_switcheroo_runtime_resume’:
>> drivers/gpu/vga/vga_switcheroo.c:1067:2: error: implicit declaration of function ‘pci_wakeup_bus’; did you mean ‘__wake_up_bit’? [-Werror=implicit-function-declaration]
>>   pci_wakeup_bus(pdev->bus);
>>   ^~~~~~~~~~~~~~
>>   __wake_up_bit
>> drivers/gpu/vga/vgaarb.c:293:3: error: implicit declaration of function ‘pci_set_vga_state’; did you mean ‘pci_set_power_state’? [-Werror=implicit-function-declaration]
>>    pci_set_vga_state(conflict->pdev, false, pci_bits, flags);
>>    ^~~~~~~~~~~~~~~~~
>>    pci_set_power_state
>>   CC      fs/read_write.o
>>   CC      drivers/hid/hid-chicony.o
>>   CC      drivers/hid/hid-cypress.o
>> drivers/gpu/vga/vgaarb.c: In function ‘vga_arb_device_init’:
>> drivers/gpu/vga/vgaarb.c:1495:25: error: ‘pci_bus_type’ undeclared (first use in this function); did you mean ‘pci_pcie_type’?
>>   bus_register_notifier(&pci_bus_type, &pci_notifier);
>>                          ^~~~~~~~~~~~
>>                          pci_pcie_type
>> cc1: some warnings being treated as errors
>> make[3]: *** [scripts/Makefile.build:277: drivers/gpu/vga/vgaarb.o] Error 1
>> make[3]: *** Waiting for unfinished jobs....
>> […]
>> ```

> WARNING: unmet direct dependencies detected for VGA_ARB
>   Depends on [n]: HAS_IOMEM [=y] && PCI [=n] && !S390
>   Selected by [y]:
>   - VGA_SWITCHEROO [=y] && HAS_IOMEM [=y] && X86 [=y] && ACPI [=y]
> 
> So I guess you need to enable PCI, probably not a common config you're using. :)
> 
> Especially since you selected EXPERT.

We have the attached defconfig, which is then integrated using
`make olddefconfig`.

> Oh well, apply this with git am --scissors?
> -----8<----
> When configuring the kernel without PCI we can still enable VGA switcheroo,
> which is not possible because VGA_ARB cannot be selected.
> 
> Remove this by depending on PCI for !S390.
> 
> Reported-by: Paul Menzel <pmenzel@molgen.mpg.de>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
> diff --git a/drivers/gpu/vga/Kconfig b/drivers/gpu/vga/Kconfig
> index b677e5d524e6..ef5671475870 100644
> --- a/drivers/gpu/vga/Kconfig
> +++ b/drivers/gpu/vga/Kconfig
> @@ -21,6 +21,7 @@ config VGA_SWITCHEROO
>  	bool "Laptop Hybrid Graphics - GPU switching support"
>  	depends on X86
>  	depends on ACPI
> +	depends on (PCI && !S390) # For VGA_ARB
>  	select VGA_ARB
>  	help
>  	  Many laptops released in 2008/9/10 have two GPUs with a multiplexer

Is this an effect of commit eb01d42a (PCI: consolidate PCI config entry in
drivers/pci) as the `default y` is missing now?


Kind regards,

Paul

[-- Attachment #1.2: build-excerpt.txt --]
[-- Type: text/plain, Size: 19900 bytes --]

    cat >.config <<-EOF
	CONFIG_LOCALVERSION="$KERNELLOCAL"
	CONFIG_KERNEL_BZIP2=y
	CONFIG_SYSVIPC=y
	CONFIG_POSIX_MQUEUE=y
	CONFIG_AUDIT=y
	CONFIG_HIGH_RES_TIMERS=y
	CONFIG_BSD_PROCESS_ACCT=y
	CONFIG_BSD_PROCESS_ACCT_V3=y
	CONFIG_TASK_XACCT=y
	CONFIG_TASK_IO_ACCOUNTING=y
	CONFIG_IKCONFIG=y
	CONFIG_IKCONFIG_PROC=y
	CONFIG_CGROUPS=y
	CONFIG_MEMCG=y
	CONFIG_MEMCG_SWAP=y
	CONFIG_BLK_CGROUP=y
	CONFIG_CGROUP_SCHED=y
	CONFIG_CFS_BANDWIDTH=y
	CONFIG_RT_GROUP_SCHED=y
	CONFIG_CGROUP_PIDS=y
	CONFIG_CGROUP_FREEZER=y
	CONFIG_CGROUP_HUGETLB=y
	CONFIG_CPUSETS=y
	CONFIG_CGROUP_DEVICE=y
	CONFIG_CGROUP_CPUACCT=y
	CONFIG_CGROUP_PERF=y
	CONFIG_CGROUP_DEBUG=y
	CONFIG_USER_NS=y
	CONFIG_BLK_DEV_INITRD=y
	CONFIG_SLAB=y
	CONFIG_KPROBES=y
	CONFIG_MODULES=y
	CONFIG_MODULE_UNLOAD=y
	CONFIG_MODULE_FORCE_UNLOAD=y
	CONFIG_MODVERSIONS=y
	CONFIG_BLK_DEV_INTEGRITY=y
	CONFIG_BLK_DEV_THROTTLING=y
	CONFIG_PARTITION_ADVANCED=y
	CONFIG_MAC_PARTITION=y
	CONFIG_BSD_DISKLABEL=y
	CONFIG_LDM_PARTITION=y
	CONFIG_CFQ_GROUP_IOSCHED=y
	CONFIG_SMP=y
	CONFIG_GART_IOMMU=y
	CONFIG_NR_CPUS=256
	CONFIG_PREEMPT_VOLUNTARY=y
	CONFIG_X86_MCELOG_LEGACY=y
	CONFIG_MICROCODE_AMD=y
	CONFIG_X86_MSR=m
	CONFIG_X86_CPUID=m
	CONFIG_NUMA=y
	CONFIG_TRANSPARENT_HUGEPAGE=y
	CONFIG_EFI=y
	CONFIG_HZ_1000=y
	CONFIG_KEXEC=y
	CONFIG_KEXEC_FILE=y
	# CONFIG_RELOCATABLE is not set
	CONFIG_PHYSICAL_ALIGN=0x1000000
	CONFIG_COMPAT_VDSO=y
	# CONFIG_ACPI_AC is not set
	# CONFIG_ACPI_BATTERY is not set
	CONFIG_ACPI_DOCK=y
	CONFIG_CPU_FREQ_GOV_POWERSAVE=m
	CONFIG_X86_ACPI_CPUFREQ=m
	# CONFIG_X86_ACPI_CPUFREQ_CPB is not set
	CONFIG_CPU_IDLE_GOV_MENU=y
	CONFIG_PCI_MMCONFIG=y
	CONFIG_PCIEPORTBUS=y
	CONFIG_PCI_IOV=y
	# CONFIG_CORE_DUMP_DEFAULT_ELF_HEADERS is not set
	CONFIG_BINFMT_MISC=y
	CONFIG_IA32_EMULATION=y
	CONFIG_IA32_AOUT=y
	CONFIG_NET=y
	CONFIG_PACKET=m
	CONFIG_PACKET_DIAG=m
	CONFIG_UNIX=m
	CONFIG_UNIX_DIAG=m
	CONFIG_XFRM_USER=m
	CONFIG_INET=y
	CONFIG_IP_MULTICAST=y
	CONFIG_IP_ADVANCED_ROUTER=y
	CONFIG_IP_FIB_TRIE_STATS=y
	CONFIG_IP_MULTIPLE_TABLES=y
	CONFIG_IP_ROUTE_MULTIPATH=y
	CONFIG_IP_ROUTE_VERBOSE=y
	CONFIG_NET_IPIP=m
	CONFIG_NET_IPGRE_DEMUX=m
	CONFIG_NET_IPGRE=m
	CONFIG_NET_IPGRE_BROADCAST=y
	CONFIG_IP_MROUTE=y
	CONFIG_IP_MROUTE_MULTIPLE_TABLES=y
	CONFIG_IP_PIMSM_V1=y
	CONFIG_IP_PIMSM_V2=y
	CONFIG_NET_IPVTI=m
	CONFIG_NET_FOU_IP_TUNNELS=y
	CONFIG_INET_AH=m
	CONFIG_INET_ESP=m
	CONFIG_INET_IPCOMP=m
	CONFIG_INET_XFRM_MODE_TRANSPORT=m
	CONFIG_INET_XFRM_MODE_TUNNEL=m
	CONFIG_INET_XFRM_MODE_BEET=m
	CONFIG_INET_DIAG=m
	CONFIG_INET_UDP_DIAG=m
	CONFIG_TCP_CONG_ADVANCED=y
	CONFIG_TCP_CONG_HSTCP=m
	CONFIG_TCP_CONG_HYBLA=m
	CONFIG_TCP_CONG_SCALABLE=m
	CONFIG_TCP_CONG_LP=m
	CONFIG_TCP_CONG_VENO=m
	CONFIG_TCP_CONG_YEAH=m
	CONFIG_TCP_CONG_ILLINOIS=m
	CONFIG_TCP_CONG_DCTCP=m
	CONFIG_TCP_CONG_CDG=m
	CONFIG_TCP_MD5SIG=y
	CONFIG_IPV6=m
	CONFIG_IPV6_ROUTER_PREF=y
	CONFIG_IPV6_ROUTE_INFO=y
	CONFIG_IPV6_OPTIMISTIC_DAD=y
	CONFIG_INET6_AH=m
	CONFIG_INET6_ESP=m
	CONFIG_INET6_IPCOMP=m
	CONFIG_IPV6_MIP6=m
	CONFIG_IPV6_ILA=m
	CONFIG_INET6_XFRM_MODE_ROUTEOPTIMIZATION=m
	CONFIG_IPV6_VTI=m
	CONFIG_IPV6_SIT_6RD=y
	CONFIG_IPV6_GRE=m
	CONFIG_IPV6_MULTIPLE_TABLES=y
	CONFIG_IPV6_SUBTREES=y
	CONFIG_IPV6_MROUTE=y
	CONFIG_IPV6_MROUTE_MULTIPLE_TABLES=y
	CONFIG_IPV6_PIMSM_V2=y
	CONFIG_NETFILTER=y
	CONFIG_NF_CONNTRACK=m
	CONFIG_NF_CONNTRACK_ZONES=y
	CONFIG_NF_CONNTRACK_EVENTS=y
	CONFIG_NF_CONNTRACK_TIMEOUT=y
	CONFIG_NF_CONNTRACK_TIMESTAMP=y
	CONFIG_NF_CONNTRACK_AMANDA=m
	CONFIG_NF_CONNTRACK_FTP=m
	CONFIG_NF_CONNTRACK_H323=m
	CONFIG_NF_CONNTRACK_IRC=m
	CONFIG_NF_CONNTRACK_NETBIOS_NS=m
	CONFIG_NF_CONNTRACK_SNMP=m
	CONFIG_NF_CONNTRACK_PPTP=m
	CONFIG_NF_CONNTRACK_SANE=m
	CONFIG_NF_CONNTRACK_SIP=m
	CONFIG_NF_CONNTRACK_TFTP=m
	CONFIG_NF_CT_NETLINK=m
	CONFIG_NF_CT_NETLINK_TIMEOUT=m
	CONFIG_NF_CT_NETLINK_HELPER=m
	CONFIG_NETFILTER_NETLINK_GLUE_CT=y
	CONFIG_NF_TABLES=m
	CONFIG_NF_TABLES_INET=m
	CONFIG_NF_TABLES_NETDEV=m
	CONFIG_NFT_EXTHDR=m
	CONFIG_NFT_META=m
	CONFIG_NFT_CT=m
	CONFIG_NFT_COUNTER=m
	CONFIG_NFT_LOG=m
	CONFIG_NFT_LIMIT=m
	CONFIG_NFT_MASQ=m
	CONFIG_NFT_REDIR=m
	CONFIG_NFT_NAT=m
	CONFIG_NFT_QUEUE=m
	CONFIG_NFT_REJECT=m
	CONFIG_NFT_COMPAT=m
	CONFIG_NFT_HASH=m
	CONFIG_NETFILTER_XTABLES=y
	CONFIG_NETFILTER_XT_SET=m
	CONFIG_NETFILTER_XT_TARGET_AUDIT=m
	CONFIG_NETFILTER_XT_TARGET_CHECKSUM=m
	CONFIG_NETFILTER_XT_TARGET_CLASSIFY=m
	CONFIG_NETFILTER_XT_TARGET_CONNMARK=m
	CONFIG_NETFILTER_XT_TARGET_DSCP=m
	CONFIG_NETFILTER_XT_TARGET_HMARK=m
	CONFIG_NETFILTER_XT_TARGET_IDLETIMER=m
	CONFIG_NETFILTER_XT_TARGET_LOG=m
	CONFIG_NETFILTER_XT_TARGET_MARK=m
	CONFIG_NETFILTER_XT_TARGET_NFLOG=m
	CONFIG_NETFILTER_XT_TARGET_NFQUEUE=m
	CONFIG_NETFILTER_XT_TARGET_NOTRACK=m
	CONFIG_NETFILTER_XT_TARGET_TEE=m
	CONFIG_NETFILTER_XT_TARGET_TPROXY=m
	CONFIG_NETFILTER_XT_TARGET_TRACE=m
	CONFIG_NETFILTER_XT_TARGET_TCPMSS=m
	CONFIG_NETFILTER_XT_TARGET_TCPOPTSTRIP=m
	CONFIG_NETFILTER_XT_MATCH_ADDRTYPE=m
	CONFIG_NETFILTER_XT_MATCH_BPF=m
	CONFIG_NETFILTER_XT_MATCH_CGROUP=m
	CONFIG_NETFILTER_XT_MATCH_CLUSTER=m
	CONFIG_NETFILTER_XT_MATCH_COMMENT=m
	CONFIG_NETFILTER_XT_MATCH_CONNBYTES=m
	CONFIG_NETFILTER_XT_MATCH_CONNLABEL=m
	CONFIG_NETFILTER_XT_MATCH_CONNLIMIT=m
	CONFIG_NETFILTER_XT_MATCH_CONNMARK=m
	CONFIG_NETFILTER_XT_MATCH_CONNTRACK=m
	CONFIG_NETFILTER_XT_MATCH_CPU=m
	CONFIG_NETFILTER_XT_MATCH_DEVGROUP=m
	CONFIG_NETFILTER_XT_MATCH_DSCP=m
	CONFIG_NETFILTER_XT_MATCH_ECN=y
	CONFIG_NETFILTER_XT_MATCH_ESP=m
	CONFIG_NETFILTER_XT_MATCH_HASHLIMIT=m
	CONFIG_NETFILTER_XT_MATCH_HELPER=m
	CONFIG_NETFILTER_XT_MATCH_HL=y
	CONFIG_NETFILTER_XT_MATCH_IPCOMP=m
	CONFIG_NETFILTER_XT_MATCH_IPRANGE=m
	CONFIG_NETFILTER_XT_MATCH_IPVS=m
	CONFIG_NETFILTER_XT_MATCH_LENGTH=m
	CONFIG_NETFILTER_XT_MATCH_LIMIT=m
	CONFIG_NETFILTER_XT_MATCH_MAC=m
	CONFIG_NETFILTER_XT_MATCH_MARK=m
	CONFIG_NETFILTER_XT_MATCH_MULTIPORT=m
	CONFIG_NETFILTER_XT_MATCH_NFACCT=m
	CONFIG_NETFILTER_XT_MATCH_OSF=m
	CONFIG_NETFILTER_XT_MATCH_OWNER=m
	CONFIG_NETFILTER_XT_MATCH_POLICY=m
	CONFIG_NETFILTER_XT_MATCH_PHYSDEV=m
	CONFIG_NETFILTER_XT_MATCH_PKTTYPE=m
	CONFIG_NETFILTER_XT_MATCH_QUOTA=m
	CONFIG_NETFILTER_XT_MATCH_RATEEST=m
	CONFIG_NETFILTER_XT_MATCH_REALM=m
	CONFIG_NETFILTER_XT_MATCH_RECENT=m
	CONFIG_NETFILTER_XT_MATCH_STATE=m
	CONFIG_NETFILTER_XT_MATCH_STATISTIC=m
	CONFIG_NETFILTER_XT_MATCH_STRING=m
	CONFIG_NETFILTER_XT_MATCH_TCPMSS=m
	CONFIG_NETFILTER_XT_MATCH_TIME=m
	CONFIG_NETFILTER_XT_MATCH_U32=y
	CONFIG_IP_SET=m
	CONFIG_IP_SET_BITMAP_IP=m
	CONFIG_IP_SET_BITMAP_IPMAC=m
	CONFIG_IP_SET_BITMAP_PORT=m
	CONFIG_IP_SET_HASH_IP=m
	CONFIG_IP_SET_HASH_IPMARK=m
	CONFIG_IP_SET_HASH_IPPORT=m
	CONFIG_IP_SET_HASH_IPPORTIP=m
	CONFIG_IP_SET_HASH_IPPORTNET=m
	CONFIG_IP_SET_HASH_MAC=m
	CONFIG_IP_SET_HASH_NETPORTNET=m
	CONFIG_IP_SET_HASH_NET=m
	CONFIG_IP_SET_HASH_NETNET=m
	CONFIG_IP_SET_HASH_NETPORT=m
	CONFIG_IP_SET_HASH_NETIFACE=m
	CONFIG_IP_SET_LIST_SET=m
	CONFIG_IP_VS=m
	CONFIG_IP_VS_RR=m
	CONFIG_IP_VS_NFCT=y
	CONFIG_NF_CONNTRACK_IPV4=m
	CONFIG_NFT_CHAIN_ROUTE_IPV4=m
	CONFIG_NFT_DUP_IPV4=m
	CONFIG_NF_TABLES_ARP=m
	CONFIG_NF_LOG_ARP=m
	CONFIG_NFT_CHAIN_NAT_IPV4=m
	CONFIG_NFT_MASQ_IPV4=m
	CONFIG_NFT_REDIR_IPV4=m
	CONFIG_IP_NF_IPTABLES=m
	CONFIG_IP_NF_MATCH_AH=m
	CONFIG_IP_NF_MATCH_ECN=m
	CONFIG_IP_NF_MATCH_RPFILTER=m
	CONFIG_IP_NF_MATCH_TTL=m
	CONFIG_IP_NF_FILTER=m
	CONFIG_IP_NF_TARGET_REJECT=m
	CONFIG_IP_NF_TARGET_SYNPROXY=m
	CONFIG_IP_NF_NAT=m
	CONFIG_IP_NF_TARGET_MASQUERADE=m
	CONFIG_IP_NF_TARGET_NETMAP=m
	CONFIG_IP_NF_TARGET_REDIRECT=m
	CONFIG_IP_NF_MANGLE=m
	CONFIG_IP_NF_TARGET_CLUSTERIP=m
	CONFIG_IP_NF_TARGET_ECN=m
	CONFIG_IP_NF_TARGET_TTL=m
	CONFIG_IP_NF_RAW=m
	CONFIG_IP_NF_ARPTABLES=m
	CONFIG_IP_NF_ARPFILTER=m
	CONFIG_IP_NF_ARP_MANGLE=m
	CONFIG_NF_CONNTRACK_IPV6=m
	CONFIG_NFT_CHAIN_ROUTE_IPV6=m
	CONFIG_NFT_CHAIN_NAT_IPV6=m
	CONFIG_NFT_MASQ_IPV6=m
	CONFIG_NFT_REDIR_IPV6=m
	CONFIG_NFT_DUP_IPV6=m
	CONFIG_IP6_NF_IPTABLES=m
	CONFIG_IP6_NF_MATCH_AH=m
	CONFIG_IP6_NF_MATCH_EUI64=m
	CONFIG_IP6_NF_MATCH_FRAG=m
	CONFIG_IP6_NF_MATCH_OPTS=m
	CONFIG_IP6_NF_MATCH_HL=m
	CONFIG_IP6_NF_MATCH_IPV6HEADER=m
	CONFIG_IP6_NF_MATCH_MH=m
	CONFIG_IP6_NF_MATCH_RPFILTER=m
	CONFIG_IP6_NF_MATCH_RT=m
	CONFIG_IP6_NF_TARGET_HL=m
	CONFIG_IP6_NF_FILTER=m
	CONFIG_IP6_NF_TARGET_REJECT=m
	CONFIG_IP6_NF_TARGET_SYNPROXY=m
	CONFIG_IP6_NF_MANGLE=m
	CONFIG_IP6_NF_RAW=m
	CONFIG_IP6_NF_NAT=m
	CONFIG_IP6_NF_TARGET_MASQUERADE=m
	CONFIG_IP6_NF_TARGET_NPT=m
	CONFIG_NF_TABLES_BRIDGE=m
	CONFIG_BRIDGE_NF_EBTABLES=m
	CONFIG_IP_DCCP=m
	CONFIG_RDS=m
	CONFIG_RDS_TCP=m
	CONFIG_TIPC=m
	CONFIG_L2TP=m
	CONFIG_L2TP_V3=y
	CONFIG_L2TP_IP=m
	CONFIG_L2TP_ETH=m
	CONFIG_BRIDGE=m
	CONFIG_BRIDGE_VLAN_FILTERING=y
	CONFIG_VLAN_8021Q=m
	CONFIG_VLAN_8021Q_GVRP=y
	CONFIG_VLAN_8021Q_MVRP=y
	CONFIG_NET_SCHED=y
	CONFIG_NET_SCH_CBQ=m
	CONFIG_NET_SCH_HTB=m
	CONFIG_NET_SCH_HFSC=m
	CONFIG_NET_SCH_PRIO=m
	CONFIG_NET_SCH_MULTIQ=m
	CONFIG_NET_SCH_RED=m
	CONFIG_NET_SCH_SFB=m
	CONFIG_NET_SCH_SFQ=m
	CONFIG_NET_SCH_TEQL=m
	CONFIG_NET_SCH_TBF=m
	CONFIG_NET_SCH_GRED=m
	CONFIG_NET_SCH_DSMARK=m
	CONFIG_NET_SCH_NETEM=m
	CONFIG_NET_SCH_DRR=m
	CONFIG_NET_SCH_MQPRIO=m
	CONFIG_NET_SCH_CHOKE=m
	CONFIG_NET_SCH_QFQ=m
	CONFIG_NET_SCH_CODEL=m
	CONFIG_NET_SCH_FQ_CODEL=m
	CONFIG_NET_SCH_FQ=m
	CONFIG_NET_SCH_HHF=m
	CONFIG_NET_SCH_PIE=m
	CONFIG_NET_SCH_PLUG=m
	CONFIG_NET_CLS_BASIC=m
	CONFIG_NET_CLS_TCINDEX=m
	CONFIG_NET_CLS_ROUTE4=m
	CONFIG_NET_CLS_FW=m
	CONFIG_NET_CLS_U32=m
	CONFIG_CLS_U32_PERF=y
	CONFIG_CLS_U32_MARK=y
	CONFIG_NET_CLS_RSVP=m
	CONFIG_NET_CLS_RSVP6=m
	CONFIG_NET_CLS_FLOW=m
	CONFIG_NET_CLS_CGROUP=m
	CONFIG_NET_CLS_BPF=m
	CONFIG_NET_CLS_FLOWER=m
	CONFIG_NET_EMATCH=y
	CONFIG_NET_EMATCH_CMP=m
	CONFIG_NET_EMATCH_NBYTE=m
	CONFIG_NET_EMATCH_U32=m
	CONFIG_NET_EMATCH_META=m
	CONFIG_NET_EMATCH_TEXT=m
	CONFIG_NET_CLS_ACT=y
	CONFIG_NET_ACT_POLICE=m
	CONFIG_NET_ACT_GACT=m
	CONFIG_GACT_PROB=y
	CONFIG_NET_ACT_MIRRED=m
	CONFIG_NET_ACT_IPT=m
	CONFIG_NET_ACT_NAT=m
	CONFIG_NET_ACT_PEDIT=m
	CONFIG_NET_ACT_SIMP=m
	CONFIG_NET_ACT_SKBEDIT=m
	CONFIG_NET_ACT_CSUM=m
	CONFIG_NET_ACT_VLAN=m
	CONFIG_NET_ACT_BPF=m
	CONFIG_NET_ACT_CONNMARK=m
	CONFIG_NET_CLS_IND=y
	CONFIG_DNS_RESOLVER=y
	CONFIG_NETLINK_DIAG=m
	CONFIG_CGROUP_NET_PRIO=y
	CONFIG_BT=m
	CONFIG_BT_HCIBTUSB=m
	CONFIG_BT_HCIUART=m
	CONFIG_BT_HCIUART_BCSP=y
	CONFIG_BT_HCIUART_ATH3K=y
	CONFIG_BT_HCIUART_3WIRE=y
	CONFIG_BT_HCIUART_INTEL=y
	CONFIG_BT_HCIUART_QCA=y
	CONFIG_BT_HCIBCM203X=m
	CONFIG_BT_HCIBPA10X=m
	CONFIG_BT_HCIBFUSB=m
	CONFIG_BT_HCIVHCI=m
	CONFIG_BT_MRVL=m
	CONFIG_BT_ATH3K=m
	# CONFIG_WIRELESS is not set
	CONFIG_DEVTMPFS=y
	CONFIG_DEVTMPFS_MOUNT=y
	CONFIG_CONNECTOR=y
	CONFIG_PARPORT=y
	CONFIG_PARPORT_PC=y
	CONFIG_BLK_DEV_FD=y
	CONFIG_BLK_DEV_LOOP=y
	CONFIG_BLK_DEV_CRYPTOLOOP=y
	CONFIG_BLK_DEV_DRBD=y
	CONFIG_BLK_DEV_NBD=y
	CONFIG_BLK_DEV_RAM=y
	CONFIG_CDROM_PKTCDVD=y
	CONFIG_BLK_DEV_NVME=y
	CONFIG_ENCLOSURE_SERVICES=y
	CONFIG_IDE=y
	CONFIG_BLK_DEV_IDECD=y
	CONFIG_IDE_GENERIC=y
	CONFIG_BLK_DEV_CMD640=y
	CONFIG_BLK_DEV_GENERIC=y
	CONFIG_BLK_DEV_RZ1000=y
	CONFIG_BLK_DEV_AMD74XX=y
	CONFIG_BLK_DEV_JMICRON=y
	CONFIG_BLK_DEV_SIS5513=y
	CONFIG_BLK_DEV_SD=y
	CONFIG_BLK_DEV_SR=y
	CONFIG_BLK_DEV_SR_VENDOR=y
	CONFIG_CHR_DEV_SG=y
	CONFIG_SCSI_ENCLOSURE=y
	CONFIG_SCSI_CONSTANTS=y
	CONFIG_SCSI_LOGGING=y
	CONFIG_SCSI_SCAN_ASYNC=y
	CONFIG_SCSI_FC_ATTRS=y
	CONFIG_SCSI_SAS_LIBSAS=y
	CONFIG_SCSI_SAS_ATA=y
	CONFIG_ISCSI_TCP=m
	CONFIG_BLK_DEV_3W_XXXX_RAID=m
	CONFIG_SCSI_HPSA=y
	CONFIG_SCSI_3W_9XXX=m
	CONFIG_SCSI_3W_SAS=m
	CONFIG_SCSI_AACRAID=m
	CONFIG_SCSI_AIC7XXX=y
	CONFIG_AIC7XXX_RESET_DELAY_MS=15000
	# CONFIG_AIC7XXX_DEBUG_ENABLE is not set
	CONFIG_SCSI_AIC79XX=y
	CONFIG_AIC79XX_RESET_DELAY_MS=15000
	# CONFIG_AIC79XX_DEBUG_ENABLE is not set
	CONFIG_SCSI_AIC94XX=m
	# CONFIG_AIC94XX_DEBUG is not set
	CONFIG_SCSI_MVSAS=m
	CONFIG_SCSI_DPT_I2O=m
	CONFIG_SCSI_ARCMSR=m
	CONFIG_MEGARAID_NEWGEN=y
	CONFIG_MEGARAID_MM=y
	CONFIG_MEGARAID_MAILBOX=y
	CONFIG_MEGARAID_LEGACY=y
	CONFIG_MEGARAID_SAS=y
	CONFIG_SCSI_MPT2SAS=y
	CONFIG_SCSI_SMARTPQI=m
	CONFIG_SCSI_BUSLOGIC=y
	CONFIG_SCSI_GDTH=m
	CONFIG_SCSI_QLOGIC_1280=y
	CONFIG_SCSI_DH=y
	CONFIG_ATA=y
	CONFIG_SATA_AHCI=y
	CONFIG_SATA_SIL24=y
	CONFIG_ATA_PIIX=y
	CONFIG_SATA_NV=y
	CONFIG_SATA_PROMISE=y
	CONFIG_SATA_SIL=y
	CONFIG_SATA_SIS=y
	CONFIG_SATA_SVW=y
	CONFIG_SATA_VIA=y
	CONFIG_PATA_ATIIXP=y
	CONFIG_PATA_JMICRON=y
	CONFIG_PATA_MPIIX=y
	CONFIG_MD=y
	CONFIG_BLK_DEV_MD=y
	CONFIG_MD_LINEAR=y
	CONFIG_MD_RAID0=y
	CONFIG_MD_RAID1=y
	CONFIG_MD_RAID456=y
	CONFIG_MD_MULTIPATH=y
	CONFIG_BLK_DEV_DM=m
	CONFIG_DM_CRYPT=m
	CONFIG_DM_SNAPSHOT=m
	CONFIG_DM_THIN_PROVISIONING=m
	CONFIG_DM_MIRROR=m
	CONFIG_DM_LOG_USERSPACE=m
	CONFIG_DM_RAID=m
	CONFIG_DM_ZERO=m
	CONFIG_DM_MULTIPATH=m
	CONFIG_DM_UEVENT=y
	CONFIG_TARGET_CORE=m
	CONFIG_ISCSI_TARGET=m
	CONFIG_FUSION=y
	CONFIG_FUSION_SPI=y
	CONFIG_FUSION_FC=y
	CONFIG_FUSION_SAS=y
	CONFIG_FUSION_CTL=y
	CONFIG_NETDEVICES=y
	CONFIG_BONDING=m
	CONFIG_DUMMY=y
	CONFIG_MACVLAN=y
	CONFIG_MACVTAP=y
	CONFIG_VXLAN=m
	CONFIG_NETCONSOLE=m
	CONFIG_NETCONSOLE_DYNAMIC=y
	CONFIG_TUN=y
	CONFIG_VETH=y
	CONFIG_NLMON=m
	CONFIG_VORTEX=y
	CONFIG_TYPHOON=y
	CONFIG_ACENIC=y
	CONFIG_ATL1=y
	CONFIG_BNX2=y
	CONFIG_TIGON3=y
	CONFIG_BNX2X=y
	CONFIG_CHELSIO_T1=y
	CONFIG_CHELSIO_T3=y
	CONFIG_NET_TULIP=y
	CONFIG_DE2104X=y
	CONFIG_TULIP=y
	CONFIG_TULIP_MMIO=y
	CONFIG_TULIP_NAPI=y
	CONFIG_TULIP_NAPI_HW_MITIGATION=y
	CONFIG_DE4X5=y
	CONFIG_DL2K=y
	CONFIG_S2IO=y
	CONFIG_E100=y
	CONFIG_E1000=y
	CONFIG_E1000E=y
	CONFIG_IGB=y
	CONFIG_IGBVF=y
	CONFIG_IXGB=m
	CONFIG_IXGBE=m
	CONFIG_I40E=m
	CONFIG_SKGE=y
	CONFIG_SKY2=y
	CONFIG_FORCEDETH=y
	# CONFIG_NET_PACKET_ENGINE is not set
	CONFIG_NETXEN_NIC=m
	CONFIG_8139CP=y
	CONFIG_8139TOO=y
	CONFIG_R8169=y
	CONFIG_SIS900=y
	CONFIG_SIS190=y
	CONFIG_VIA_RHINE=y
	CONFIG_VIA_VELOCITY=y
	# CONFIG_WLAN is not set
	CONFIG_INPUT_POLLDEV=y
	CONFIG_INPUT_EVDEV=y
	# CONFIG_SERIO_SERPORT is not set
	# CONFIG_LEGACY_PTYS is not set
	CONFIG_DEVKMEM=y
	CONFIG_SERIAL_8250=y
	CONFIG_SERIAL_8250_CONSOLE=y
	CONFIG_PRINTER=y
	CONFIG_IPMI_HANDLER=y
	CONFIG_IPMI_DEVICE_INTERFACE=y
	CONFIG_IPMI_SI=y
	CONFIG_IPMI_WATCHDOG=y
	CONFIG_IPMI_POWEROFF=y
	CONFIG_HPET=y
	CONFIG_I2C_AMD756=y
	CONFIG_I2C_AMD756_S4882=y
	CONFIG_I2C_AMD8111=y
	CONFIG_I2C_ISCH=y
	CONFIG_I2C_PIIX4=y
	CONFIG_I2C_NFORCE2=y
	CONFIG_I2C_NFORCE2_S4985=y
	CONFIG_I2C_SIS5595=y
	CONFIG_I2C_SIS630=y
	CONFIG_I2C_SIS96X=y
	CONFIG_I2C_VIA=y
	CONFIG_I2C_VIAPRO=y
	CONFIG_WATCHDOG=y
	CONFIG_I6300ESB_WDT=y
	CONFIG_ITCO_WDT=y
	CONFIG_ITCO_VENDOR_SUPPORT=y
	CONFIG_HP_WATCHDOG=y
	CONFIG_NV_TCO=y
	CONFIG_MEDIA_SUPPORT=y
	CONFIG_AGP=y
	CONFIG_AGP_AMD64=y
	CONFIG_AGP_INTEL=m
	CONFIG_AGP_SIS=m
	CONFIG_AGP_VIA=m
	CONFIG_VGA_SWITCHEROO=y
	CONFIG_DRM=m
	CONFIG_DRM_AMDGPU=m
	CONFIG_DRM_AMDGPU_SI=y
	CONFIG_DRM_AMDGPU_CIK=y
	CONFIG_DRM_AMDGPU_USERPTR=y
	CONFIG_DRM_NOUVEAU=m
	CONFIG_DRM_I915=m
	CONFIG_DRM_VGEM=m
	CONFIG_DRM_UDL=m
	CONFIG_DRM_MGAG200=m
	CONFIG_DRM_CIRRUS_QEMU=m
	CONFIG_DRM_BOCHS=m
	CONFIG_DRM_TINYDRM=m
	CONFIG_FB=y
	CONFIG_FB_CIRRUS=m
	CONFIG_FB_PM2=m
	CONFIG_FB_CYBER2000=m
	CONFIG_FB_ARC=m
	CONFIG_FB_VGA16=m
	CONFIG_FB_EFI=y
	CONFIG_FB_NVIDIA=m
	CONFIG_FB_NVIDIA_I2C=y
	CONFIG_FB_NVIDIA_DEBUG=y
	CONFIG_FB_I740=m
	CONFIG_FB_LE80578=m
	CONFIG_FB_CARILLO_RANCH=m
	CONFIG_FB_MATROX=m
	CONFIG_FB_MATROX_MILLENIUM=y
	CONFIG_FB_MATROX_MYSTIQUE=y
	CONFIG_FB_MATROX_G=y
	CONFIG_FB_MATROX_I2C=m
	CONFIG_FB_RADEON=m
	CONFIG_FB_RADEON_DEBUG=y
	CONFIG_FB_SMSCUFX=m
	CONFIG_FB_UDL=m
	CONFIG_FB_IBM_GXT4500=m
	CONFIG_LCD_PLATFORM=m
	CONFIG_BACKLIGHT_CARILLO_RANCH=m
	CONFIG_BACKLIGHT_APPLE=m
	CONFIG_BACKLIGHT_PM8941_WLED=m
	CONFIG_BACKLIGHT_SAHARA=m
	CONFIG_BACKLIGHT_ADP8860=m
	CONFIG_BACKLIGHT_ADP8870=m
	CONFIG_BACKLIGHT_LM3639=m
	CONFIG_BACKLIGHT_LV5207LP=m
	CONFIG_BACKLIGHT_BD6107=m
	CONFIG_BACKLIGHT_ARCXCNN=m
	CONFIG_VGACON_SOFT_SCROLLBACK=y
	CONFIG_VGACON_SOFT_SCROLLBACK_SIZE=256
	CONFIG_SOUND=y
	CONFIG_SND=y
	CONFIG_SND_DYNAMIC_MINORS=y
	CONFIG_SND_CTXFI=y
	CONFIG_SND_EMU10K1=y
	CONFIG_SND_EMU10K1X=y
	CONFIG_SND_ENS1370=y
	CONFIG_SND_ENS1371=y
	CONFIG_SND_ES1938=y
	CONFIG_SND_ES1968=y
	CONFIG_SND_INTEL8X0=y
	CONFIG_SND_SONICVIBES=y
	CONFIG_SND_VIA82XX=y
	CONFIG_SND_VIA82XX_MODEM=y
	CONFIG_SND_YMFPCI=y
	CONFIG_SND_HDA_INTEL=y
	CONFIG_SND_HDA_CODEC_REALTEK=y
	CONFIG_SND_HDA_CODEC_ANALOG=y
	CONFIG_SND_HDA_CODEC_SIGMATEL=y
	CONFIG_SND_HDA_CODEC_VIA=y
	CONFIG_SND_HDA_CODEC_HDMI=y
	CONFIG_SND_HDA_CODEC_CIRRUS=y
	CONFIG_SND_HDA_CODEC_CONEXANT=y
	CONFIG_SND_HDA_CODEC_CA0110=y
	CONFIG_SND_HDA_CODEC_CA0132=y
	CONFIG_SND_HDA_CODEC_CMEDIA=y
	CONFIG_SND_HDA_CODEC_SI3054=y
	CONFIG_SND_USB_AUDIO=m
	CONFIG_HIDRAW=y
	CONFIG_HID_DRAGONRISE=y
	CONFIG_HID_KYE=y
	CONFIG_HID_GYRATION=y
	CONFIG_HID_TWINHAN=y
	CONFIG_HID_LED=m
	CONFIG_HID_LOGITECH_DJ=m
	CONFIG_HID_NTRIG=y
	CONFIG_HID_ORTEK=y
	CONFIG_HID_PANTHERLORD=y
	CONFIG_HID_PETALYNX=y
	CONFIG_HID_SAMSUNG=y
	CONFIG_HID_SUNPLUS=y
	CONFIG_HID_GREENASIA=y
	CONFIG_HID_SMARTJOYPLUS=y
	CONFIG_HID_TOPSEED=y
	CONFIG_HID_THRUSTMASTER=y
	CONFIG_HID_ZEROPLUS=y
	CONFIG_USB=y
	CONFIG_USB_XHCI_HCD=y
	CONFIG_USB_EHCI_HCD=y
	# CONFIG_USB_EHCI_TT_NEWSCHED is not set
	CONFIG_USB_OHCI_HCD=y
	CONFIG_USB_UHCI_HCD=y
	CONFIG_USB_SL811_HCD=y
	CONFIG_USB_STORAGE=y
	CONFIG_USB_SERIAL=y
	CONFIG_USB_SERIAL_FTDI_SIO=y
	CONFIG_USB_SERIAL_OMNINET=y
	CONFIG_USB_CHAOSKEY=m
	CONFIG_EDAC=y
	CONFIG_EDAC_AMD64=y
	CONFIG_EDAC_E752X=y
	CONFIG_EDAC_I82975X=y
	CONFIG_EDAC_I3000=y
	CONFIG_EDAC_I3200=y
	CONFIG_EDAC_IE31200=y
	CONFIG_EDAC_X38=y
	CONFIG_EDAC_I5400=y
	CONFIG_EDAC_I7CORE=y
	CONFIG_EDAC_I5000=y
	CONFIG_EDAC_I5100=y
	CONFIG_EDAC_I7300=y
	CONFIG_EDAC_SBRIDGE=y
	CONFIG_RTC_CLASS=y
	# CONFIG_RTC_INTF_PROC is not set
	CONFIG_AMD_IOMMU=y
	CONFIG_DELL_RBU=m
	CONFIG_GOOGLE_FIRMWARE=y
	CONFIG_GOOGLE_COREBOOT_TABLE_ACPI=m
	CONFIG_GOOGLE_MEMCONSOLE_COREBOOT=m
	CONFIG_EFI_VARS=y
	CONFIG_EXT2_FS=y
	CONFIG_EXT3_FS=m
	CONFIG_EXT3_FS_POSIX_ACL=y
	CONFIG_EXT4_FS_SECURITY=y
	CONFIG_REISERFS_FS=y
	CONFIG_REISERFS_PROC_INFO=y
	CONFIG_REISERFS_FS_XATTR=y
	CONFIG_REISERFS_FS_POSIX_ACL=y
	CONFIG_XFS_FS=y
	CONFIG_XFS_QUOTA=y
	CONFIG_XFS_POSIX_ACL=y
	CONFIG_XFS_RT=y
	CONFIG_BTRFS_FS=m
	CONFIG_BTRFS_FS_POSIX_ACL=y
	CONFIG_FANOTIFY=y
	CONFIG_QUOTA=y
	CONFIG_QUOTA_NETLINK_INTERFACE=y
	# CONFIG_PRINT_QUOTA_WARNING is not set
	CONFIG_QFMT_V2=m
	CONFIG_AUTOFS4_FS=m
	CONFIG_FUSE_FS=m
	CONFIG_OVERLAY_FS=m
	CONFIG_FSCACHE=y
	CONFIG_FSCACHE_STATS=y
	CONFIG_FSCACHE_HISTOGRAM=y
	CONFIG_FSCACHE_DEBUG=y
	CONFIG_CACHEFILES=y
	CONFIG_CACHEFILES_DEBUG=y
	CONFIG_CACHEFILES_HISTOGRAM=y
	CONFIG_ISO9660_FS=m
	CONFIG_JOLIET=y
	CONFIG_ZISOFS=y
	CONFIG_UDF_FS=m
	CONFIG_MSDOS_FS=m
	CONFIG_VFAT_FS=m
	CONFIG_NTFS_FS=m
	CONFIG_PROC_KCORE=y
	CONFIG_TMPFS_POSIX_ACL=y
	CONFIG_HUGETLBFS=y
	CONFIG_ECRYPT_FS=m
	CONFIG_ECRYPT_FS_MESSAGING=y
	CONFIG_SQUASHFS=m
	CONFIG_SQUASHFS_XATTR=y
	CONFIG_SQUASHFS_LZ4=y
	CONFIG_SQUASHFS_LZO=y
	CONFIG_SQUASHFS_XZ=y
	CONFIG_SQUASHFS_4K_DEVBLK_SIZE=y
	CONFIG_SQUASHFS_EMBEDDED=y
	CONFIG_NFS_FS=m
	CONFIG_NFS_V3_ACL=y
	CONFIG_NFS_V4=m
	CONFIG_NFS_SWAP=y
	CONFIG_NFS_V4_1=y
	CONFIG_NFS_FSCACHE=y
	CONFIG_NFSD=m
	CONFIG_NFSD_V3_ACL=y
	CONFIG_NFSD_V4=y
	CONFIG_CEPH_FS=m
	CONFIG_CEPH_FSCACHE=y
	CONFIG_CEPH_FS_POSIX_ACL=y
	CONFIG_CIFS=m
	CONFIG_CIFS_STATS=y
	CONFIG_CIFS_XATTR=y
	CONFIG_CIFS_POSIX=y
	CONFIG_NLS_CODEPAGE_437=m
	CONFIG_NLS_CODEPAGE_850=m
	CONFIG_NLS_CODEPAGE_852=m
	CONFIG_NLS_ISO8859_1=m
	CONFIG_NLS_UTF8=m
	CONFIG_DLM=m
	CONFIG_PRINTK_TIME=y
	CONFIG_DEBUG_INFO=y
	# CONFIG_ENABLE_WARN_DEPRECATED is not set
	CONFIG_MAGIC_SYSRQ=y
	CONFIG_DEBUG_KERNEL=y
	CONFIG_RCU_CPU_STALL_TIMEOUT=60
	CONFIG_FUNCTION_TRACER=y
	CONFIG_FTRACE_SYSCALLS=y
	CONFIG_BLK_DEV_IO_TRACE=y
	CONFIG_MEMTEST=y
	CONFIG_EARLY_PRINTK_DBGP=y
	CONFIG_SECURITYFS=y
	CONFIG_CRYPTO_GCM=m
	CONFIG_CRYPTO_ECB=y
	CONFIG_CRYPTO_PCBC=y
	CONFIG_CRYPTO_CMAC=y
	CONFIG_CRYPTO_HMAC=y
	CONFIG_CRYPTO_MD4=y
	CONFIG_CRYPTO_SHA1=y
	CONFIG_CRYPTO_SHA256=y
	CONFIG_CRYPTO_ARC4=y
	CONFIG_CRYPTO_DES=y
	CONFIG_KVM=m
	CONFIG_KVM_INTEL=m
	CONFIG_KVM_AMD=m
	CONFIG_CRC16=y
	CONFIG_CRC_ITU_T=y
	CONFIG_FONTS=y
	CONFIG_FONT_8x8=y
	CONFIG_FONT_7x14=y
	CONFIG_FONT_PEARL_8x8=y
	CONFIG_FONT_ACORN_8x8=y
	CONFIG_FONT_MINI_4x6=y
	CONFIG_FONT_10x18=y
	CONFIG_FONT_SUN8x16=y
	CONFIG_FONT_SUN12x22=y
EOF
    make olddefconfig

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5174 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm: Require PCI for selecting VGA_ARB.
  2019-01-08 15:56   ` [PATCH] drm: Require PCI for selecting VGA_ARB Paul Menzel
@ 2019-01-08 16:07     ` Sinan Kaya
  0 siblings, 0 replies; 2+ messages in thread
From: Sinan Kaya @ 2019-01-08 16:07 UTC (permalink / raw)
  To: Paul Menzel
  Cc: Maarten Lankhorst, Maxime Ripard, Sean Paul, David Airlie,
	Daniel Vetter, dri-devel, Linux Kernel Mailing List, linux-pci,
	Christoph Hellwig, Bjorn Helgaas

On 1/8/19, Paul Menzel <pmenzel@molgen.mpg.de> wrote:
> Dear Maarten,
>
>
> Thank you very much for the quick response.
>
> On 01/08/19 16:37, Maarten Lankhorst wrote:
>> Op 08-01-2019 om 16:07 schreef Paul Menzel:
>
>>> Building Linux 5.0-rc1 fails with the errors below. Please find the
>>> configuration file attached.
>>>
>>> ```
>>> $ make -j120
>>> […]
>>> drivers/gpu/vga/vgaarb.c: In function ‘__vga_tryget’:
>>> drivers/gpu/vga/vgaarb.c:286:14: error: ‘PCI_VGA_STATE_CHANGE_DECODES’
>>> undeclared (first use in this function); did you mean
>>> ‘PCI_SUBTRACTIVE_DECODE’?
>>>      flags |= PCI_VGA_STATE_CHANGE_DECODES;
>>>               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>               PCI_SUBTRACTIVE_DECODE
>>> drivers/gpu/vga/vgaarb.c:286:14: note: each undeclared identifier is
>>> reported only once for each function it appears in
>>>   CC [M]  net/netfilter/xt_realm.o
>>>   CC      drivers/hid/hid-cherry.o
>>> drivers/gpu/vga/vga_switcheroo.c: In function
>>> ‘vga_switcheroo_runtime_suspend’:
>>> drivers/gpu/vga/vga_switcheroo.c:1053:2: error: implicit declaration of
>>> function ‘pci_bus_set_current_state’; did you mean ‘__set_current_state’?
>>> [-Werror=implicit-function-declaration]
>>>   pci_bus_set_current_state(pdev->bus, PCI_D3cold);
>>>   ^~~~~~~~~~~~~~~~~~~~~~~~~
>>>   __set_current_state
>>> drivers/gpu/vga/vgaarb.c:291:13: error: ‘PCI_VGA_STATE_CHANGE_BRIDGE’
>>> undeclared (first use in this function); did you mean
>>> ‘PCI_VGA_STATE_CHANGE_DECODES’?
>>>     flags |= PCI_VGA_STATE_CHANGE_BRIDGE;
>>>              ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>              PCI_VGA_STATE_CHANGE_DECODES
>>>   CC      fs/reiserfs/dir.o
>>>   LD [M]  net/tipc/tipc.o
>>> drivers/gpu/vga/vga_switcheroo.c: In function
>>> ‘vga_switcheroo_runtime_resume’:
>>> drivers/gpu/vga/vga_switcheroo.c:1067:2: error: implicit declaration of
>>> function ‘pci_wakeup_bus’; did you mean ‘__wake_up_bit’?
>>> [-Werror=implicit-function-declaration]
>>>   pci_wakeup_bus(pdev->bus);
>>>   ^~~~~~~~~~~~~~
>>>   __wake_up_bit
>>> drivers/gpu/vga/vgaarb.c:293:3: error: implicit declaration of function
>>> ‘pci_set_vga_state’; did you mean ‘pci_set_power_state’?
>>> [-Werror=implicit-function-declaration]
>>>    pci_set_vga_state(conflict->pdev, false, pci_bits, flags);
>>>    ^~~~~~~~~~~~~~~~~
>>>    pci_set_power_state
>>>   CC      fs/read_write.o
>>>   CC      drivers/hid/hid-chicony.o
>>>   CC      drivers/hid/hid-cypress.o
>>> drivers/gpu/vga/vgaarb.c: In function ‘vga_arb_device_init’:
>>> drivers/gpu/vga/vgaarb.c:1495:25: error: ‘pci_bus_type’ undeclared (first
>>> use in this function); did you mean ‘pci_pcie_type’?
>>>   bus_register_notifier(&pci_bus_type, &pci_notifier);
>>>                          ^~~~~~~~~~~~
>>>                          pci_pcie_type
>>> cc1: some warnings being treated as errors
>>> make[3]: *** [scripts/Makefile.build:277: drivers/gpu/vga/vgaarb.o] Error
>>> 1
>>> make[3]: *** Waiting for unfinished jobs....
>>> […]
>>> ```
>
>> WARNING: unmet direct dependencies detected for VGA_ARB
>>   Depends on [n]: HAS_IOMEM [=y] && PCI [=n] && !S390
>>   Selected by [y]:
>>   - VGA_SWITCHEROO [=y] && HAS_IOMEM [=y] && X86 [=y] && ACPI [=y]
>>
>> So I guess you need to enable PCI, probably not a common config you're
>> using. :)
>>
>> Especially since you selected EXPERT.
>
> We have the attached defconfig, which is then integrated using
> `make olddefconfig`.
>
>> Oh well, apply this with git am --scissors?
>> -----8<----
>> When configuring the kernel without PCI we can still enable VGA
>> switcheroo,
>> which is not possible because VGA_ARB cannot be selected.
>>
>> Remove this by depending on PCI for !S390.
>>
>> Reported-by: Paul Menzel <pmenzel@molgen.mpg.de>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> ---
>> diff --git a/drivers/gpu/vga/Kconfig b/drivers/gpu/vga/Kconfig
>> index b677e5d524e6..ef5671475870 100644
>> --- a/drivers/gpu/vga/Kconfig
>> +++ b/drivers/gpu/vga/Kconfig
>> @@ -21,6 +21,7 @@ config VGA_SWITCHEROO
>>  	bool "Laptop Hybrid Graphics - GPU switching support"
>>  	depends on X86
>>  	depends on ACPI
>> +	depends on (PCI && !S390) # For VGA_ARB
>>  	select VGA_ARB
>>  	help
>>  	  Many laptops released in 2008/9/10 have two GPUs with a multiplexer
>
> Is this an effect of commit eb01d42a (PCI: consolidate PCI config entry in
> drivers/pci) as the `default y` is missing now?
>

See this :

https://patchwork.kernel.org/patch/10749209/

This change is about to go in.

>
> Kind regards,
>
> Paul
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <3a1c95bb-9986-663d-09a1-8c7e84d0a7a7@molgen.mpg.de>
     [not found] ` <6ba074cd-bd1b-3844-8a3b-b0cfb34e24bc@linux.intel.com>
2019-01-08 15:56   ` [PATCH] drm: Require PCI for selecting VGA_ARB Paul Menzel
2019-01-08 16:07     ` Sinan Kaya

Linux-PCI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-pci/0 linux-pci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-pci linux-pci/ https://lore.kernel.org/linux-pci \
		linux-pci@vger.kernel.org linux-pci@archiver.kernel.org
	public-inbox-index linux-pci


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-pci


AGPL code for this site: git clone https://public-inbox.org/ public-inbox