* [PATCH v2] dt-bindings: PCI: mediatek-gen3: Add support for MT8195
@ 2021-08-27 2:26 Jianjun Wang
2021-08-30 16:02 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Jianjun Wang @ 2021-08-27 2:26 UTC (permalink / raw)
To: Rob Herring, Bjorn Helgaas, Matthias Brugger, Ryder Lee
Cc: linux-pci, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Jianjun Wang, Rex-BC.Chen, TingHan.Shen
MT8195 is an ARM platform SoC which has the same PCIe IP with MT8192.
Signed-off-by: Jianjun Wang <jianjun.wang@mediatek.com>
---
Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
index 742206dbd965..93e09c3029b7 100644
--- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
+++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
@@ -48,7 +48,9 @@ allOf:
properties:
compatible:
- const: mediatek,mt8192-pcie
+ enum:
+ - mediatek,mt8192-pcie
+ - mediatek,mt8195-pcie
reg:
maxItems: 1
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] dt-bindings: PCI: mediatek-gen3: Add support for MT8195
2021-08-27 2:26 [PATCH v2] dt-bindings: PCI: mediatek-gen3: Add support for MT8195 Jianjun Wang
@ 2021-08-30 16:02 ` Rob Herring
2021-09-02 2:07 ` Jianjun Wang (王建军)
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2021-08-30 16:02 UTC (permalink / raw)
To: Jianjun Wang
Cc: Bjorn Helgaas, Matthias Brugger, Ryder Lee, PCI,
moderated list:ARM/Mediatek SoC support, devicetree,
linux-kernel, linux-arm-kernel, Rex-BC.Chen, Tinghan Shen
On Thu, Aug 26, 2021 at 9:26 PM Jianjun Wang <jianjun.wang@mediatek.com> wrote:
>
> MT8195 is an ARM platform SoC which has the same PCIe IP with MT8192.
>
> Signed-off-by: Jianjun Wang <jianjun.wang@mediatek.com>
> ---
> Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> index 742206dbd965..93e09c3029b7 100644
> --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> @@ -48,7 +48,9 @@ allOf:
>
> properties:
> compatible:
> - const: mediatek,mt8192-pcie
> + enum:
> + - mediatek,mt8192-pcie
> + - mediatek,mt8195-pcie
I thought you wanted to support 8192 as the fallback:
compatible = "mediatek,mt8195-pcie", "mediatek,mt8192-pcie";
The above schema doesn't allow this.
Rob
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] dt-bindings: PCI: mediatek-gen3: Add support for MT8195
2021-08-30 16:02 ` Rob Herring
@ 2021-09-02 2:07 ` Jianjun Wang (王建军)
0 siblings, 0 replies; 3+ messages in thread
From: Jianjun Wang (王建军) @ 2021-09-02 2:07 UTC (permalink / raw)
To: robh+dt
Cc: linux-mediatek, linux-kernel, devicetree, linux-arm-kernel,
matthias.bgg, linux-pci, bhelgaas,
Ryder Lee (李庚諺),
TingHan Shen (沈廷翰),
Rex-BC Chen (陳柏辰)
On Mon, 2021-08-30 at 11:02 -0500, Rob Herring wrote:
> On Thu, Aug 26, 2021 at 9:26 PM Jianjun Wang <
> jianjun.wang@mediatek.com> wrote:
> >
> > MT8195 is an ARM platform SoC which has the same PCIe IP with
> > MT8192.
> >
> > Signed-off-by: Jianjun Wang <jianjun.wang@mediatek.com>
> > ---
> > Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 4
> > +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-
> > gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-
> > gen3.yaml
> > index 742206dbd965..93e09c3029b7 100644
> > --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> > +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> > @@ -48,7 +48,9 @@ allOf:
> >
> > properties:
> > compatible:
> > - const: mediatek,mt8192-pcie
> > + enum:
> > + - mediatek,mt8192-pcie
> > + - mediatek,mt8195-pcie
>
> I thought you wanted to support 8192 as the fallback:
>
> compatible = "mediatek,mt8195-pcie", "mediatek,mt8192-pcie";
>
> The above schema doesn't allow this.
>
> Rob
Hi Rob,
Yes, I want this fallback to support MT8195, but there are some un-
documented warnings if I don't add its compatible string to the yaml
file.
Do you have any suggestions in this case?
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-02 2:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-27 2:26 [PATCH v2] dt-bindings: PCI: mediatek-gen3: Add support for MT8195 Jianjun Wang
2021-08-30 16:02 ` Rob Herring
2021-09-02 2:07 ` Jianjun Wang (王建军)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).