linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 0/2] PCI: Distribute resources for root buses
@ 2022-11-30 11:22 Mika Westerberg
  2022-11-30 11:22 ` [PATCH v3 1/2] PCI: Take other bus devices into account when distributing resources Mika Westerberg
                   ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: Mika Westerberg @ 2022-11-30 11:22 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: Rafael J . Wysocki, Andy Shevchenko, Jonathan Cameron,
	Lukas Wunner, Chris Chiu, linux-pci, Mika Westerberg

Hi all,

This is third iteration of the patch series trying to solve the problem
reported by Chris Chiu [1]. In summary the current resource
distribution code does not cover the initial device enumeration so if we
find unconfigured bridges they get the bare minimum.

This one tries to be slightly more generic and deal with PCI devices in
addition to PCIe. I've tried this on a system with Maple Ridge
Thunderbolt controller (the same as in the orignal bug report), on QEMU
with similar PCI topology using following parameters:

	-device pcie-pci-bridge,id=br1					\
	-device e1000,bus=br1,addr=2					\
	-device pci-bridge,chassis_nr=1,bus=br1,shpc=off,id=br2,addr=3	\
	-device e1000,bus=br1,addr=4					\
	-device e1000,bus=br2

Then on a QEMU similar to what Jonathan used when he found out the
regression with multifunction devices:

	-device pcie-root-port,port=0,id=root_port13,chassis=0,slot=2	\
	-device x3130-upstream,id=sw1,bus=root_port13,multifunction=on	\
	-device e1000,bus=root_port13,addr=0.1				\
	-device xio3130-downstream,id=fun1,bus=sw1,chassis=0,slot=3	\
	-device e1000,bus=fun1

The previous versions of the series can be found:

v2: https://lore.kernel.org/linux-pci/20221114115953.40236-1-mika.westerberg@linux.intel.com/
v1: https://lore.kernel.org/linux-pci/20221103103254.30497-1-mika.westerberg@linux.intel.com/

Changes from v2:
  * Make both patches to work with PCI devices too (do not expect that
    the bridge is always first device on the bus).
  * Allow distribution with bridges that do not have all resource
    windows programmed (thereofore the pathch 2/2 is not revert anymore)
  * I did not add the tags from Rafael and Jonathan because the code is
    not exactly the same anymore so was not sure if they still apply.

Changes from v1:
  * Re-worded the commit message to hopefully explain the problem better
  * Added Link: to the bug report
  * Update the comment according to Bjorn's suggestion
  * Dropped the ->multifunction check
  * Use %#llx in log format.

[1] https://bugzilla.kernel.org/show_bug.cgi?id=216000

Mika Westerberg (2):
  PCI: Take other bus devices into account when distributing resources
  PCI: Distribute available resources for root buses too

 drivers/pci/setup-bus.c | 122 ++++++++++++++++++++++++++++++++++++++--
 1 file changed, 117 insertions(+), 5 deletions(-)

-- 
2.35.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2022-12-05 22:46 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-30 11:22 [PATCH v3 0/2] PCI: Distribute resources for root buses Mika Westerberg
2022-11-30 11:22 ` [PATCH v3 1/2] PCI: Take other bus devices into account when distributing resources Mika Westerberg
2022-12-02 17:45   ` Jonathan Cameron
2022-12-02 23:35     ` Bjorn Helgaas
2022-12-02 23:34   ` Bjorn Helgaas
2022-12-05  7:28     ` Mika Westerberg
2022-12-05 22:46       ` Bjorn Helgaas
2022-11-30 11:22 ` [PATCH v3 2/2] PCI: Distribute available resources for root buses too Mika Westerberg
2022-12-02 18:01   ` Jonathan Cameron
2022-12-02 17:07 ` [PATCH v3 0/2] PCI: Distribute resources for root buses Jonathan Cameron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).