From: "Krzysztof Wilczyński" <kw@linux.com>
To: "Antti Järvinen" <antti.jarvinen@gmail.com>
Cc: helgaas@kernel.org, alex.williamson@redhat.com,
bhelgaas@google.com, kishon@ti.com, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, m-karicheri2@ti.com
Subject: Re: [PATCH v2] PCI: quirk for preventing bus reset on TI C667X
Date: Sun, 7 Mar 2021 01:22:32 +0100 [thread overview]
Message-ID: <YEQcyBVLIaGWb4sk@rocinante> (raw)
In-Reply-To: <20210228135311.668-1-antti.jarvinen@gmail.com>
Hi Antti,
A few nitpicks, so feel free to ignore these, of course.
If possible, capitalise the subject line. Also, perhaps "Add quirk to
prevent bus (...)" might read better.
> Some TI keystone C667X devices do no support bus/hot reset. Its PCIESS
[...]
It would be KeyStone in the above sentence.
[...]
> With this change device can be assigned to VMs with VFIO, but it will
> leak state between VMs.
Following-up on Bojrn's question about the state leak, see:
https://lore.kernel.org/linux-pci/20210129234946.GA124037@bjorn-Precision-5520/
Would there be anything else that has to be done?
Krzysztof
next prev parent reply other threads:[~2021-03-07 0:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 15:36 [PATCH] PCI: quirk for preventing bus reset on TI C667X Antti Järvinen
2021-01-21 23:55 ` Bjorn Helgaas
2021-01-26 11:22 ` Antti Järvinen
2021-01-29 23:49 ` Bjorn Helgaas
2021-02-17 21:18 ` Bjorn Helgaas
2021-02-28 13:53 ` [PATCH v2] " Antti Järvinen
2021-03-07 0:22 ` Krzysztof Wilczyński [this message]
2021-03-08 14:21 ` [PATCH v3] PCI: Add " Antti Järvinen
2021-03-12 21:09 ` Bjorn Helgaas
2021-03-15 10:26 ` [PATCH v4] " Antti Järvinen
2021-04-19 12:44 ` Kishon Vijay Abraham I
2021-05-27 23:07 ` Bjorn Helgaas
2021-03-15 10:45 ` [PATCH v3] " Antti Järvinen
2021-03-08 14:28 ` [PATCH v2] PCI: " Antti Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEQcyBVLIaGWb4sk@rocinante \
--to=kw@linux.com \
--cc=alex.williamson@redhat.com \
--cc=antti.jarvinen@gmail.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=m-karicheri2@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).