From: Thierry Reding <thierry.reding@gmail.com>
To: "Pali Rohár" <pali@kernel.org>
Cc: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: tegra: Use PCI_CONF1_EXT_ADDRESS() macro
Date: Wed, 28 Sep 2022 16:40:02 +0200 [thread overview]
Message-ID: <YzRcwkAqoiqr0VhB@orome> (raw)
In-Reply-To: <YzRbnjb6UVwrj/li@orome>
[-- Attachment #1: Type: text/plain, Size: 1145 bytes --]
On Wed, Sep 28, 2022 at 04:35:10PM +0200, Thierry Reding wrote:
> On Wed, Sep 28, 2022 at 02:19:11PM +0200, Pali Rohár wrote:
> > Simplify pci-tegra.c driver code and use new PCI_CONF1_EXT_ADDRESS() macro
> > for accessing PCI config space.
> >
> > Signed-off-by: Pali Rohár <pali@kernel.org>
> > ---
> > Please look also at this related patch:
> > https://patchwork.kernel.org/project/linux-pci/patch/20220911113216.14892-1-pali@kernel.org/
> > ---
> > drivers/pci/controller/pci-tegra.c | 11 +++--------
> > 1 file changed, 3 insertions(+), 8 deletions(-)
>
> I had to go chase down the patch that introduces PCI_CONF1_EXT_ADDRESS.
> It would've been easier if this had been part of the series that
> introduced that, or if you had provided a link to that patch here.
>
> Anyway, looks like this is equivalent to the existing inline function,
> so:
>
> Acked-by: Thierry Reding <treding@nvidia.com>
After looking at the linked patch, perhaps revise this one more time and
remove the comment above the removed helper since it's now just a
duplication of what the PCI_CONF1_EXT_ADDRESS comments say.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-09-28 14:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 12:19 [PATCH] PCI: tegra: Use PCI_CONF1_EXT_ADDRESS() macro Pali Rohár
2022-09-28 14:35 ` Thierry Reding
2022-09-28 14:40 ` Thierry Reding [this message]
2022-09-29 8:47 ` Lorenzo Pieralisi
2022-10-11 15:42 ` Jon Hunter
2022-10-11 16:16 ` Pali Rohár
2022-10-11 16:47 ` Jon Hunter
2022-10-11 16:55 ` Pali Rohár
2022-10-17 7:43 ` Lorenzo Pieralisi
2022-10-17 8:40 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzRcwkAqoiqr0VhB@orome \
--to=thierry.reding@gmail.com \
--cc=bhelgaas@google.com \
--cc=jonathanh@nvidia.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=pali@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).