* [PATCH v1] tools: PCI: Fix installation when `make tools/pci_install`
@ 2019-06-28 13:33 Andy Shevchenko
2019-07-05 16:23 ` Lorenzo Pieralisi
2019-07-09 11:45 ` Kishon Vijay Abraham I
0 siblings, 2 replies; 7+ messages in thread
From: Andy Shevchenko @ 2019-06-28 13:33 UTC (permalink / raw)
To: linux-pci
Cc: Andy Shevchenko, Jean-Jacques Hiblot, Kishon Vijay Abraham I,
Lorenzo Pieralisi, Arnaldo Carvalho de Melo
The commit c9a707875053 ("tools pci: Do not delete pcitest.sh in 'make clean'")
fixed a `make tools clean` issue and simultaneously brought a regression
to the installation process:
for script in .../tools/pci/pcitest.sh; do \
install $script .../usr/usr/bin; \
done
install: cannot stat '.../tools/pci/pcitest.sh': No such file or directory
Here is the missed part of the fix.
Cc: Jean-Jacques Hiblot <jjhiblot@ti.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
tools/pci/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/pci/Makefile b/tools/pci/Makefile
index 6876ee4bd78c..cc4a161ee2cc 100644
--- a/tools/pci/Makefile
+++ b/tools/pci/Makefile
@@ -47,10 +47,10 @@ clean:
install: $(ALL_PROGRAMS)
install -d -m 755 $(DESTDIR)$(bindir); \
- for program in $(ALL_PROGRAMS) pcitest.sh; do \
+ for program in $(ALL_PROGRAMS); do \
install $$program $(DESTDIR)$(bindir); \
done; \
- for script in $(ALL_SCRIPTS); do \
+ for script in pcitest.sh; do \
install $$script $(DESTDIR)$(bindir); \
done
--
2.20.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v1] tools: PCI: Fix installation when `make tools/pci_install`
2019-06-28 13:33 [PATCH v1] tools: PCI: Fix installation when `make tools/pci_install` Andy Shevchenko
@ 2019-07-05 16:23 ` Lorenzo Pieralisi
2019-07-05 17:08 ` Andy Shevchenko
2019-07-09 11:45 ` Kishon Vijay Abraham I
1 sibling, 1 reply; 7+ messages in thread
From: Lorenzo Pieralisi @ 2019-07-05 16:23 UTC (permalink / raw)
To: Andy Shevchenko, Kishon Vijay Abraham I
Cc: linux-pci, Jean-Jacques Hiblot, Kishon Vijay Abraham I,
Arnaldo Carvalho de Melo
On Fri, Jun 28, 2019 at 04:33:26PM +0300, Andy Shevchenko wrote:
> The commit c9a707875053 ("tools pci: Do not delete pcitest.sh in 'make clean'")
> fixed a `make tools clean` issue and simultaneously brought a regression
> to the installation process:
>
> for script in .../tools/pci/pcitest.sh; do \
> install $script .../usr/usr/bin; \
> done
> install: cannot stat '.../tools/pci/pcitest.sh': No such file or directory
>
> Here is the missed part of the fix.
Sigh, hopefully that's the last fix :), Kishon if that's OK mind
ACKing it please ?
Thanks,
Lorenzo
> Cc: Jean-Jacques Hiblot <jjhiblot@ti.com>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> tools/pci/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/pci/Makefile b/tools/pci/Makefile
> index 6876ee4bd78c..cc4a161ee2cc 100644
> --- a/tools/pci/Makefile
> +++ b/tools/pci/Makefile
> @@ -47,10 +47,10 @@ clean:
>
> install: $(ALL_PROGRAMS)
> install -d -m 755 $(DESTDIR)$(bindir); \
> - for program in $(ALL_PROGRAMS) pcitest.sh; do \
> + for program in $(ALL_PROGRAMS); do \
> install $$program $(DESTDIR)$(bindir); \
> done; \
> - for script in $(ALL_SCRIPTS); do \
> + for script in pcitest.sh; do \
> install $$script $(DESTDIR)$(bindir); \
> done
>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1] tools: PCI: Fix installation when `make tools/pci_install`
2019-07-05 16:23 ` Lorenzo Pieralisi
@ 2019-07-05 17:08 ` Andy Shevchenko
2019-07-09 11:18 ` Kishon Vijay Abraham I
0 siblings, 1 reply; 7+ messages in thread
From: Andy Shevchenko @ 2019-07-05 17:08 UTC (permalink / raw)
To: Lorenzo Pieralisi
Cc: Kishon Vijay Abraham I, linux-pci, Jean-Jacques Hiblot,
Arnaldo Carvalho de Melo
On Fri, Jul 05, 2019 at 05:23:58PM +0100, Lorenzo Pieralisi wrote:
> On Fri, Jun 28, 2019 at 04:33:26PM +0300, Andy Shevchenko wrote:
> > The commit c9a707875053 ("tools pci: Do not delete pcitest.sh in 'make clean'")
> > fixed a `make tools clean` issue and simultaneously brought a regression
> > to the installation process:
> >
> > for script in .../tools/pci/pcitest.sh; do \
> > install $script .../usr/usr/bin; \
> > done
> > install: cannot stat '.../tools/pci/pcitest.sh': No such file or directory
> >
> > Here is the missed part of the fix.
>
> Sigh, hopefully that's the last fix :), Kishon if that's OK mind
> ACKing it please ?
From my side, yes. Now it works as I expect.
Honestly, I'm puzzled how so many errors has been pushed upstream...
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1] tools: PCI: Fix installation when `make tools/pci_install`
2019-07-05 17:08 ` Andy Shevchenko
@ 2019-07-09 11:18 ` Kishon Vijay Abraham I
2019-07-09 11:38 ` Andy Shevchenko
0 siblings, 1 reply; 7+ messages in thread
From: Kishon Vijay Abraham I @ 2019-07-09 11:18 UTC (permalink / raw)
To: Andy Shevchenko, Lorenzo Pieralisi
Cc: linux-pci, Jean-Jacques Hiblot, Arnaldo Carvalho de Melo
Hi,
On 05/07/19 10:38 PM, Andy Shevchenko wrote:
> On Fri, Jul 05, 2019 at 05:23:58PM +0100, Lorenzo Pieralisi wrote:
>> On Fri, Jun 28, 2019 at 04:33:26PM +0300, Andy Shevchenko wrote:
>>> The commit c9a707875053 ("tools pci: Do not delete pcitest.sh in 'make clean'")
>>> fixed a `make tools clean` issue and simultaneously brought a regression
>>> to the installation process:
>>>
>>> for script in .../tools/pci/pcitest.sh; do \
>>> install $script .../usr/usr/bin; \
>>> done
>>> install: cannot stat '.../tools/pci/pcitest.sh': No such file or directory
>>>
>>> Here is the missed part of the fix.
>>
>> Sigh, hopefully that's the last fix :), Kishon if that's OK mind
>> ACKing it please ?
>
> From my side, yes. Now it works as I expect.
>
> Honestly, I'm puzzled how so many errors has been pushed upstream...
I'm not sure why, but I don't see any issue without this patch as well. Am I
missing something here? I'm copy pasting the steps below.
a0393678@a0393678ub:~/repos/linux/tools/pci$ make clean
rm -f pcitest
rm -rf include/
find . -name '*.o' -delete -o -name '\.*.d' -delete
a0393678@a0393678ub:~/repos/linux/tools/pci$ make
mkdir -p include/linux/ 2>&1 || true
ln -sf /home/a0393678/repos/linux/tools/pci/../../include/uapi/linux/pcitest.h
include/linux/
make -f /home/a0393678/repos/linux/tools/build/Makefile.build dir=. obj=pcitest
make[1]: Entering directory '/home/a0393678/repos/linux/tools/pci'
CC pcitest.o
LD pcitest-in.o
make[1]: Leaving directory '/home/a0393678/repos/linux/tools/pci'
LINK pcitest
a0393678@a0393678ub:~/repos/linux/tools/pci$ sudo make install
make -f /home/a0393678/repos/linux/tools/build/Makefile.build dir=. obj=pcitest
install -d -m 755 /usr/bin; \
for program in pcitest pcitest.sh; do \
install $program /usr/bin; \
done; \
for script in pcitest.sh; do \
install $script /usr/bin; \
done
a0393678@a0393678ub:~/repos/linux/tools/pci$
Thanks
Kishon
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1] tools: PCI: Fix installation when `make tools/pci_install`
2019-07-09 11:18 ` Kishon Vijay Abraham I
@ 2019-07-09 11:38 ` Andy Shevchenko
2019-07-09 11:43 ` Kishon Vijay Abraham I
0 siblings, 1 reply; 7+ messages in thread
From: Andy Shevchenko @ 2019-07-09 11:38 UTC (permalink / raw)
To: Kishon Vijay Abraham I
Cc: Lorenzo Pieralisi, linux-pci, Jean-Jacques Hiblot,
Arnaldo Carvalho de Melo
On Tue, Jul 09, 2019 at 04:48:57PM +0530, Kishon Vijay Abraham I wrote:
> Hi,
>
> On 05/07/19 10:38 PM, Andy Shevchenko wrote:
> > On Fri, Jul 05, 2019 at 05:23:58PM +0100, Lorenzo Pieralisi wrote:
> >> On Fri, Jun 28, 2019 at 04:33:26PM +0300, Andy Shevchenko wrote:
> >>> The commit c9a707875053 ("tools pci: Do not delete pcitest.sh in 'make clean'")
> >>> fixed a `make tools clean` issue and simultaneously brought a regression
> >>> to the installation process:
> >>>
> >>> for script in .../tools/pci/pcitest.sh; do \
> >>> install $script .../usr/usr/bin; \
> >>> done
> >>> install: cannot stat '.../tools/pci/pcitest.sh': No such file or directory
> >>>
> >>> Here is the missed part of the fix.
> >>
> >> Sigh, hopefully that's the last fix :), Kishon if that's OK mind
> >> ACKing it please ?
> >
> > From my side, yes. Now it works as I expect.
> >
> > Honestly, I'm puzzled how so many errors has been pushed upstream...
>
> I'm not sure why, but I don't see any issue without this patch as well. Am I
> missing something here?
Yes.
I'm not contaminate my Linux kernel tree with any build stuff, so, I'm using
the folder which is out to the build, i.e.
% make O=/xyz ...
> I'm copy pasting the steps below.
>
> a0393678@a0393678ub:~/repos/linux/tools/pci$ make clean
> rm -f pcitest
> rm -rf include/
> find . -name '*.o' -delete -o -name '\.*.d' -delete
> a0393678@a0393678ub:~/repos/linux/tools/pci$ make
> mkdir -p include/linux/ 2>&1 || true
> ln -sf /home/a0393678/repos/linux/tools/pci/../../include/uapi/linux/pcitest.h
> include/linux/
> make -f /home/a0393678/repos/linux/tools/build/Makefile.build dir=. obj=pcitest
> make[1]: Entering directory '/home/a0393678/repos/linux/tools/pci'
> CC pcitest.o
> LD pcitest-in.o
> make[1]: Leaving directory '/home/a0393678/repos/linux/tools/pci'
> LINK pcitest
> a0393678@a0393678ub:~/repos/linux/tools/pci$ sudo make install
> make -f /home/a0393678/repos/linux/tools/build/Makefile.build dir=. obj=pcitest
> install -d -m 755 /usr/bin; \
> for program in pcitest pcitest.sh; do \
> install $program /usr/bin; \
> done; \
> for script in pcitest.sh; do \
> install $script /usr/bin; \
> done
> a0393678@a0393678ub:~/repos/linux/tools/pci$
>
> Thanks
> Kishon
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1] tools: PCI: Fix installation when `make tools/pci_install`
2019-07-09 11:38 ` Andy Shevchenko
@ 2019-07-09 11:43 ` Kishon Vijay Abraham I
0 siblings, 0 replies; 7+ messages in thread
From: Kishon Vijay Abraham I @ 2019-07-09 11:43 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Lorenzo Pieralisi, linux-pci, Jean-Jacques Hiblot,
Arnaldo Carvalho de Melo
Hi,
On 09/07/19 5:08 PM, Andy Shevchenko wrote:
> On Tue, Jul 09, 2019 at 04:48:57PM +0530, Kishon Vijay Abraham I wrote:
>> Hi,
>>
>> On 05/07/19 10:38 PM, Andy Shevchenko wrote:
>>> On Fri, Jul 05, 2019 at 05:23:58PM +0100, Lorenzo Pieralisi wrote:
>>>> On Fri, Jun 28, 2019 at 04:33:26PM +0300, Andy Shevchenko wrote:
>>>>> The commit c9a707875053 ("tools pci: Do not delete pcitest.sh in 'make clean'")
>>>>> fixed a `make tools clean` issue and simultaneously brought a regression
>>>>> to the installation process:
>>>>>
>>>>> for script in .../tools/pci/pcitest.sh; do \
>>>>> install $script .../usr/usr/bin; \
>>>>> done
>>>>> install: cannot stat '.../tools/pci/pcitest.sh': No such file or directory
>>>>>
>>>>> Here is the missed part of the fix.
>>>>
>>>> Sigh, hopefully that's the last fix :), Kishon if that's OK mind
>>>> ACKing it please ?
>>>
>>> From my side, yes. Now it works as I expect.
>>>
>>> Honestly, I'm puzzled how so many errors has been pushed upstream...
>>
>> I'm not sure why, but I don't see any issue without this patch as well. Am I
>> missing something here?
>
> Yes.
> I'm not contaminate my Linux kernel tree with any build stuff, so, I'm using
> the folder which is out to the build, i.e.
>
> % make O=/xyz ...
Okay, got it.
Thanks
Kishon
>
>> I'm copy pasting the steps below.
>>
>> a0393678@a0393678ub:~/repos/linux/tools/pci$ make clean
>> rm -f pcitest
>> rm -rf include/
>> find . -name '*.o' -delete -o -name '\.*.d' -delete
>> a0393678@a0393678ub:~/repos/linux/tools/pci$ make
>> mkdir -p include/linux/ 2>&1 || true
>> ln -sf /home/a0393678/repos/linux/tools/pci/../../include/uapi/linux/pcitest.h
>> include/linux/
>> make -f /home/a0393678/repos/linux/tools/build/Makefile.build dir=. obj=pcitest
>> make[1]: Entering directory '/home/a0393678/repos/linux/tools/pci'
>> CC pcitest.o
>> LD pcitest-in.o
>> make[1]: Leaving directory '/home/a0393678/repos/linux/tools/pci'
>> LINK pcitest
>> a0393678@a0393678ub:~/repos/linux/tools/pci$ sudo make install
>> make -f /home/a0393678/repos/linux/tools/build/Makefile.build dir=. obj=pcitest
>> install -d -m 755 /usr/bin; \
>> for program in pcitest pcitest.sh; do \
>> install $program /usr/bin; \
>> done; \
>> for script in pcitest.sh; do \
>> install $script /usr/bin; \
>> done
>> a0393678@a0393678ub:~/repos/linux/tools/pci$
>>
>> Thanks
>> Kishon
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v1] tools: PCI: Fix installation when `make tools/pci_install`
2019-06-28 13:33 [PATCH v1] tools: PCI: Fix installation when `make tools/pci_install` Andy Shevchenko
2019-07-05 16:23 ` Lorenzo Pieralisi
@ 2019-07-09 11:45 ` Kishon Vijay Abraham I
1 sibling, 0 replies; 7+ messages in thread
From: Kishon Vijay Abraham I @ 2019-07-09 11:45 UTC (permalink / raw)
To: Andy Shevchenko, linux-pci
Cc: Jean-Jacques Hiblot, Lorenzo Pieralisi, Arnaldo Carvalho de Melo
Hi Andy,
On 28/06/19 7:03 PM, Andy Shevchenko wrote:
> The commit c9a707875053 ("tools pci: Do not delete pcitest.sh in 'make clean'")
> fixed a `make tools clean` issue and simultaneously brought a regression
> to the installation process:
>
> for script in .../tools/pci/pcitest.sh; do \
> install $script .../usr/usr/bin; \
> done
> install: cannot stat '.../tools/pci/pcitest.sh': No such file or directory
>
> Here is the missed part of the fix.
>
> Cc: Jean-Jacques Hiblot <jjhiblot@ti.com>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> tools/pci/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/pci/Makefile b/tools/pci/Makefile
> index 6876ee4bd78c..cc4a161ee2cc 100644
> --- a/tools/pci/Makefile
> +++ b/tools/pci/Makefile
> @@ -47,10 +47,10 @@ clean:
>
> install: $(ALL_PROGRAMS)
> install -d -m 755 $(DESTDIR)$(bindir); \
> - for program in $(ALL_PROGRAMS) pcitest.sh; do \
> + for program in $(ALL_PROGRAMS); do \
> install $$program $(DESTDIR)$(bindir); \
> done; \
> - for script in $(ALL_SCRIPTS); do \
> + for script in pcitest.sh; do \
If ALL_SCRIPTS is not used anywhere else, this patch can remove that as well.
With that fixed
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
Thanks
Kishon
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-07-09 11:48 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-28 13:33 [PATCH v1] tools: PCI: Fix installation when `make tools/pci_install` Andy Shevchenko
2019-07-05 16:23 ` Lorenzo Pieralisi
2019-07-05 17:08 ` Andy Shevchenko
2019-07-09 11:18 ` Kishon Vijay Abraham I
2019-07-09 11:38 ` Andy Shevchenko
2019-07-09 11:43 ` Kishon Vijay Abraham I
2019-07-09 11:45 ` Kishon Vijay Abraham I
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).