From: "Chuan Hua, Lei" <chuanhua.lei@linux.intel.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Dilip Kota <eswara.kota@linux.intel.com>
Cc: jingoohan1@gmail.com, gustavo.pimentel@synopsys.com,
lorenzo.pieralisi@arm.com, robh@kernel.org,
linux-pci@vger.kernel.org, hch@infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
andriy.shevchenko@intel.com, cheol.yong.kim@intel.com,
qi-ming.wu@intel.com
Subject: Re: [PATCH v3 1/2] dt-bindings: PCI: intel: Add YAML schemas for the PCIe RC controller
Date: Fri, 6 Sep 2019 11:22:26 +0800 [thread overview]
Message-ID: <ce4e04ee-9a8f-fbe1-0133-4a18c92dc136@linux.intel.com> (raw)
In-Reply-To: <CAFBinCC5SH5OSUqOkLQhE2o7g5OhSuB_PBjsv93U2P=FNS5oPw@mail.gmail.com>
On 9/6/2019 4:31 AM, Martin Blumenstingl wrote:
> Hi Dilip,
>
> On Wed, Sep 4, 2019 at 12:11 PM Dilip Kota <eswara.kota@linux.intel.com> wrote:
> [...]
>> +properties:
>> + compatible:
>> + const: intel,lgm-pcie
> should we add the "snps,dw-pcie" here (and in the example below) as well?
> (this is what for example
> Documentation/devicetree/bindings/pci/amlogic,meson-pcie.txt does)
Thanks for pointing out this. We should add this.
>
> [...]
>> + phy-names:
>> + const: pciephy
> the most popular choice in Documentation/devicetree/bindings/pci/ is "pcie-phy"
> if Rob is happy with "pciephy" (which is already part of two other
> bindings) then I'm happy with "pciephy" as well
Agree.
>
>> + num-lanes:
>> + description: Number of lanes to use for this port.
> are there SoCs with more than 2 lanes?
> you can list the allowed values in an enum so "num-lanes = <16>"
> causes an error when someone accidentally has this in their .dts (and
> runs the dt-bindings validation)
Our SoC(LGM) supports single lane or dual lane. Again this also depends
on the board. I wonder if we should put this into board specific dts.
To make multiple lanes work properly, it also depends on the phy mode.
In my internal version, I put it into board dts.
>
> [...]
>> + reset-assert-ms:
> maybe add:
> $ref: /schemas/types.yaml#/definitions/uint32
Agree
>> + description: |
>> + Device reset interval in ms.
>> + Some devices need an interval upto 500ms. By default it is 100ms.
>> +
>> +required:
>> + - compatible
>> + - device_type
>> + - reg
>> + - reg-names
>> + - ranges
>> + - resets
>> + - clocks
>> + - phys
>> + - phy-names
>> + - reset-gpios
>> + - num-lanes
>> + - linux,pci-domain
>> + - interrupts
>> + - interrupt-map
>> + - interrupt-map-mask
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + pcie10:pcie@d0e00000 {
>> + compatible = "intel,lgm-pcie";
>> + device_type = "pci";
>> + #address-cells = <3>;
>> + #size-cells = <2>;
>> + reg = <
>> + 0xd0e00000 0x1000
>> + 0xd2000000 0x800000
>> + 0xd0a41000 0x1000
>> + >;
>> + reg-names = "dbi", "config", "app";
>> + linux,pci-domain = <0>;
>> + max-link-speed = <4>;
>> + bus-range = <0x00 0x08>;
>> + interrupt-parent = <&ioapic1>;
>> + interrupts = <67 1>;
>> + #interrupt-cells = <1>;
>> + interrupt-map-mask = <0 0 0 0x7>;
>> + interrupt-map = <0 0 0 1 &ioapic1 27 1>,
>> + <0 0 0 2 &ioapic1 28 1>,
>> + <0 0 0 3 &ioapic1 29 1>,
>> + <0 0 0 4 &ioapic1 30 1>;
> is the "1" in the interrupts and interrupt-map properties IRQ_TYPE_EDGE_RISING?
> you can use these macros in this example as well, see
> Documentation/devicetree/bindings/iio/accel/adi,adxl372.yaml for
> example
No. 1 here means index from arch/x86/devicetree.c
static struct of_ioapic_type of_ioapic_type[] =
{
{
.out_type = IRQ_TYPE_EDGE_RISING,
.trigger = IOAPIC_EDGE,
.polarity = 1,
},
{
.out_type = IRQ_TYPE_LEVEL_LOW,
.trigger = IOAPIC_LEVEL,
.polarity = 0,
},
{
.out_type = IRQ_TYPE_LEVEL_HIGH,
.trigger = IOAPIC_LEVEL,
.polarity = 1,
},
{
.out_type = IRQ_TYPE_EDGE_FALLING,
.trigger = IOAPIC_EDGE,
.polarity = 0,
},
};
static int dt_irqdomain_alloc(struct irq_domain *domain, unsigned int virq,
unsigned int nr_irqs, void *arg)
{
struct irq_fwspec *fwspec = (struct irq_fwspec *)arg;
struct of_ioapic_type *it;
struct irq_alloc_info tmp;
int type_index;
if (WARN_ON(fwspec->param_count < 2))
return -EINVAL;
type_index = fwspec->param[1]; // index.
if (type_index >= ARRAY_SIZE(of_ioapic_type))
return -EINVAL;
I would not see this definition is user-friendly. But it is how x86
handles at the moment.
>
> Martin
next prev parent reply other threads:[~2019-09-06 3:22 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 10:10 [PATCH v3 0/2] PCI: Add Intel PCIe Driver and respective dt-binding yaml file Dilip Kota
2019-09-04 10:10 ` [PATCH v3 1/2] dt-bindings: PCI: intel: Add YAML schemas for the PCIe RC controller Dilip Kota
2019-09-05 2:23 ` Chuan Hua, Lei
2019-09-06 10:39 ` Dilip Kota
2019-09-05 20:31 ` Martin Blumenstingl
2019-09-06 3:22 ` Chuan Hua, Lei [this message]
2019-09-06 17:17 ` Martin Blumenstingl
2019-09-06 17:48 ` Andy Shevchenko
2019-09-07 1:48 ` Ivan Gorinov
2019-09-06 9:19 ` Andy Shevchenko
2019-09-09 6:52 ` Dilip Kota
2019-09-17 18:33 ` Rob Herring
2019-09-18 6:48 ` Dilip Kota
2019-09-17 18:40 ` Rob Herring
2019-09-18 6:56 ` Dilip Kota
[not found] ` <b7e549bb-b46c-c393-50ac-9ef3b198fd49@linux.intel.com>
2019-10-03 6:35 ` Fwd: " Dilip Kota
2019-09-04 10:10 ` [PATCH v3 2/2] dwc: PCI: intel: Intel PCIe RC controller driver Dilip Kota
2019-09-04 13:05 ` Andy Shevchenko
2019-09-06 10:39 ` Dilip Kota
2019-09-05 2:30 ` Chuan Hua, Lei
2019-09-05 10:45 ` Andrew Murray
2019-09-05 11:26 ` Christoph Hellwig
2019-09-05 11:40 ` Andy Shevchenko
2019-09-12 7:01 ` Dilip Kota
2019-09-06 10:58 ` Dilip Kota
2019-09-06 11:20 ` Andrew Murray
2019-09-09 6:51 ` Dilip Kota
2019-09-09 8:31 ` Andrew Murray
2019-09-10 8:08 ` Dilip Kota
[not found] ` <22857835-1f98-b251-c94b-16b4b0a6dba2@linux.intel.com>
2019-09-11 10:30 ` Andrew Murray
2019-09-12 6:58 ` Dilip Kota
2019-09-12 8:25 ` Andrew Murray
2019-09-12 9:23 ` Dilip Kota
2019-09-12 10:49 ` Gustavo Pimentel
2019-09-13 9:20 ` Dilip Kota
2019-09-13 10:12 ` andriy.shevchenko
2019-09-16 3:03 ` Dilip Kota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce4e04ee-9a8f-fbe1-0133-4a18c92dc136@linux.intel.com \
--to=chuanhua.lei@linux.intel.com \
--cc=andriy.shevchenko@intel.com \
--cc=cheol.yong.kim@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=eswara.kota@linux.intel.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=hch@infradead.org \
--cc=jingoohan1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=qi-ming.wu@intel.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).