linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Mike Leach <mike.leach@linaro.org>,
	linux-perf-users@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org,
	linux-kernel@vger.kernel.org, acme@kernel.org
Cc: leo.yan@linaro.org, peterz@infradead.org, mingo@redhat.com,
	will@kernel.org, john.garry@huawei.com, mark.rutland@arm.com,
	alexander.shishkin@linux.intel.com, jolsa@redhat.com,
	namhyung@kernel.org, gankulkarni@os.amperecomputing.com,
	darren@os.amperecomputing.com
Subject: Re: [PATCH v8 0/3] perf: cs-etm: Update perf to handle new Coresight Trace ID
Date: Wed, 29 Mar 2023 12:18:27 +0100	[thread overview]
Message-ID: <0ada81b0-42d7-a9fe-41ff-9476b4b68ee0@arm.com> (raw)
In-Reply-To: <20230329111422.3693-1-mike.leach@linaro.org>

Arnaldo,

On 29/03/2023 12:14, Mike Leach wrote:
> The original method for allocating trace source ID values to sources was
> to use a fixed algorithm for CPU based sources of (cpu_num * 2 + 0x10).
> The STM was allocated ID 0x1.
> 
> This mechanism is broken for systems with more than 47 cores.
> 
> The kernel related patches the provide a fixed Trace ID allocation mechanism
> are now upstreamed.
> 
> This patchset updates the perf code to handle the changes to the trace ID
> notification mechanism that now uses the PERF_RECORD_AUX_OUTPUT_HW_ID
> packet to set Trace ID in the perf ETM decoders.
> 
> Applies to perf/core
> 
> Changes since v7:
> Split from original patchset [1] to be sent separately as kernel related
> patches are now upstream.

Please could you pull this in ? This is critical for enabling the 
CoreSight perf support on systems with > 47 cores. The kernel changes
are already in.

Suzuki


> 
> [1] https://lore.kernel.org/linux-arm-kernel/20230116124928.5440-1-mike.leach@linaro.org/
> 
> Mike Leach (3):
>    perf: cs-etm: Move mapping of Trace ID and cpu into helper function
>    perf: cs-etm: Update record event to use new Trace ID protocol
>    perf: cs-etm: Handle PERF_RECORD_AUX_OUTPUT_HW_ID packet
> 
>   tools/include/linux/coresight-pmu.h           |  47 ++-
>   tools/perf/arch/arm/util/cs-etm.c             |  21 +-
>   .../perf/util/cs-etm-decoder/cs-etm-decoder.c |   7 +
>   tools/perf/util/cs-etm.c                      | 326 +++++++++++++++---
>   tools/perf/util/cs-etm.h                      |  14 +-
>   5 files changed, 350 insertions(+), 65 deletions(-)
> 


      parent reply	other threads:[~2023-03-29 11:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-29 11:14 [PATCH v8 0/3] perf: cs-etm: Update perf to handle new Coresight Trace ID Mike Leach
2023-03-29 11:14 ` [PATCH v8 1/3] perf: cs-etm: Move mapping of Trace ID and cpu into helper function Mike Leach
2023-03-29 12:41   ` Arnaldo Carvalho de Melo
2023-03-29 12:42     ` Arnaldo Carvalho de Melo
2023-03-29 12:59       ` Mike Leach
2023-03-29 13:22         ` Arnaldo Carvalho de Melo
2023-03-29 14:47           ` Mike Leach
2023-03-29 19:28             ` Arnaldo Carvalho de Melo
2023-03-29 22:14               ` Arnaldo Carvalho de Melo
2023-03-30  3:13                 ` Leo Yan
2023-03-30 10:55                   ` Suzuki K Poulose
2023-03-31  5:50                     ` Mike Leach
2023-03-29 11:14 ` [PATCH v8 2/3] perf: cs-etm: Update record event to use new Trace ID protocol Mike Leach
2023-03-29 11:14 ` [PATCH v8 3/3] perf: cs-etm: Handle PERF_RECORD_AUX_OUTPUT_HW_ID packet Mike Leach
2023-03-29 11:18 ` Suzuki K Poulose [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0ada81b0-42d7-a9fe-41ff-9476b4b68ee0@arm.com \
    --to=suzuki.poulose@arm.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=coresight@lists.linaro.org \
    --cc=darren@os.amperecomputing.com \
    --cc=gankulkarni@os.amperecomputing.com \
    --cc=john.garry@huawei.com \
    --cc=jolsa@redhat.com \
    --cc=leo.yan@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mike.leach@linaro.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).