From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Mike Leach <mike.leach@linaro.org>
Cc: linux-perf-users@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org,
linux-kernel@vger.kernel.org, suzuki.poulose@arm.com,
leo.yan@linaro.org, peterz@infradead.org, mingo@redhat.com,
will@kernel.org, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@redhat.com,
namhyung@kernel.org, gankulkarni@os.amperecomputing.com,
darren@os.amperecomputing.com, James Clark <james.clark@arm.com>
Subject: Re: [PATCH v8 1/3] perf: cs-etm: Move mapping of Trace ID and cpu into helper function
Date: Wed, 29 Mar 2023 16:28:19 -0300 [thread overview]
Message-ID: <ZCSRU8zvjjBHhq+x@kernel.org> (raw)
In-Reply-To: <CAJ9a7VhJRnRe0A43=_X463432LvjL=S5buVgeq6rB8K8nDZb6A@mail.gmail.com>
Em Wed, Mar 29, 2023 at 03:47:25PM +0100, Mike Leach escreveu:
> On Wed, 29 Mar 2023 at 14:22, Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> >
> > Em Wed, Mar 29, 2023 at 01:59:10PM +0100, Mike Leach escreveu:
> > > Sorry - my error.
> > >
> > > The same change is made in patch 3/3 of this set.
> > >
> > > Looks like I didn't do a patch by patch build check when I was testing yesterday
> >
> > np, its fixed now and pushed to tmp.perf-tools-next, please check, will
> > go to perf-tools-next later today after passing thru my set of container
> > build tests.
> >
> > - Arnaldo
>
> tmp.perf-tools-next - Builds and tests OK
Not here, I'll check after a call:
50 9.90 ubuntu:18.04-x-arm : FAIL gcc version 7.5.0 (Ubuntu/Linaro 7.5.0-3ubuntu1~18.04)
arch/arm/util/cs-etm.c: In function 'cs_etm_save_ete_header':
arch/arm/util/cs-etm.c:720:29: error: implicit declaration of function 'coresight_get_trace_id' [-Werror=implicit-function-declaration]
data[CS_ETE_TRCTRACEIDR] = coresight_get_trace_id(cpu);
^~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
/git/perf-6.3.0-rc1/tools/build/Makefile.build:140: recipe for target 'util' failed
make[5]: *** [util] Error 2
/git/perf-6.3.0-rc1/tools/build/Makefile.build:140: recipe for target 'arm' failed
make[4]: *** [arm] Error 2
/git/perf-6.3.0-rc1/tools/build/Makefile.build:140: recipe for target 'arch' failed
make[3]: *** [arch] Error 2
51 9.50 ubuntu:18.04-x-arm64 : FAIL gcc version 7.5.0 (Ubuntu/Linaro 7.5.0-3ubuntu1~18.04)
arch/arm64/util/../../arm/util/cs-etm.c: In function 'cs_etm_save_ete_header':
arch/arm64/util/../../arm/util/cs-etm.c:720:29: error: implicit declaration of function 'coresight_get_trace_id' [-Werror=implicit-function-declaration]
data[CS_ETE_TRCTRACEIDR] = coresight_get_trace_id(cpu);
^~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
/git/perf-6.3.0-rc1/tools/build/Makefile.build:140: recipe for target 'util' failed
make[5]: *** [util] Error 2
/git/perf-6.3.0-rc1/tools/build/Makefile.build:140: recipe for target 'arm64' failed
make[4]: *** [arm64] Error 2
/git/perf-6.3.0-rc1/tools/build/Makefile.build:140: recipe for target 'arch' failed
make[3]: *** [arch] Error 2
52 19.34 ubuntu:18.04-x-m68k : Ok m68k-linux-gnu-gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0
next prev parent reply other threads:[~2023-03-29 19:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 11:14 [PATCH v8 0/3] perf: cs-etm: Update perf to handle new Coresight Trace ID Mike Leach
2023-03-29 11:14 ` [PATCH v8 1/3] perf: cs-etm: Move mapping of Trace ID and cpu into helper function Mike Leach
2023-03-29 12:41 ` Arnaldo Carvalho de Melo
2023-03-29 12:42 ` Arnaldo Carvalho de Melo
2023-03-29 12:59 ` Mike Leach
2023-03-29 13:22 ` Arnaldo Carvalho de Melo
2023-03-29 14:47 ` Mike Leach
2023-03-29 19:28 ` Arnaldo Carvalho de Melo [this message]
2023-03-29 22:14 ` Arnaldo Carvalho de Melo
2023-03-30 3:13 ` Leo Yan
2023-03-30 10:55 ` Suzuki K Poulose
2023-03-31 5:50 ` Mike Leach
2023-03-29 11:14 ` [PATCH v8 2/3] perf: cs-etm: Update record event to use new Trace ID protocol Mike Leach
2023-03-29 11:14 ` [PATCH v8 3/3] perf: cs-etm: Handle PERF_RECORD_AUX_OUTPUT_HW_ID packet Mike Leach
2023-03-29 11:18 ` [PATCH v8 0/3] perf: cs-etm: Update perf to handle new Coresight Trace ID Suzuki K Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCSRU8zvjjBHhq+x@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=darren@os.amperecomputing.com \
--cc=gankulkarni@os.amperecomputing.com \
--cc=james.clark@arm.com \
--cc=jolsa@redhat.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).