linux-perf-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Leo Yan <leo.yan@linaro.org>, Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Mike Leach <mike.leach@linaro.org>,
	linux-perf-users@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org,
	linux-kernel@vger.kernel.org, peterz@infradead.org,
	mingo@redhat.com, will@kernel.org, mark.rutland@arm.com,
	alexander.shishkin@linux.intel.com, jolsa@redhat.com,
	namhyung@kernel.org, gankulkarni@os.amperecomputing.com,
	darren@os.amperecomputing.com, James Clark <james.clark@arm.com>
Subject: Re: [PATCH v8 1/3] perf: cs-etm: Move mapping of Trace ID and cpu into helper function
Date: Thu, 30 Mar 2023 11:55:17 +0100	[thread overview]
Message-ID: <20c28979-53a7-19eb-16fd-4d8535454d4e@arm.com> (raw)
In-Reply-To: <20230330031307.GD252145@leoy-yangtze.lan>

On 30/03/2023 04:13, Leo Yan wrote:
> On Wed, Mar 29, 2023 at 07:14:52PM -0300, Arnaldo Carvalho de Melo wrote:
> 
> [...]
> 
>>> Not here, I'll check after a call:
>>>
>>>    50     9.90 ubuntu:18.04-x-arm            : FAIL gcc version 7.5.0 (Ubuntu/Linaro 7.5.0-3ubuntu1~18.04)
>>>      arch/arm/util/cs-etm.c: In function 'cs_etm_save_ete_header':
>>>      arch/arm/util/cs-etm.c:720:29: error: implicit declaration of function 'coresight_get_trace_id' [-Werror=implicit-function-declaration]
>>>        data[CS_ETE_TRCTRACEIDR] = coresight_get_trace_id(cpu);
>>>                                   ^~~~~~~~~~~~~~~~~~~~~~
>>
>> This function was removed in:
>>
>> Author: Mike Leach <mike.leach@linaro.org>
>> Date:   Wed Mar 29 12:14:21 2023 +0100
>>
>>      perf cs-etm: Update record event to use new Trace ID protocol
>>
>>      Trace IDs are now dynamically allocated.
>>
>> I'm removing this series from perf-tools-next, please address this issue
>> and send a v9.
> 
> I can reproduce this building failure.  I am curious for how to verify
> building for patch wise, the link [1] gives me some hints and below
> command works for me:
> 
>    $ git rebase -i --exec "make -C tools/perf clean && \
>      make -C tools/perf VF=1 DEBUG=1 CORESIGHT=1 && \
>      make -C tools/perf clean && \
>      make -C tools/perf VF=1 DEBUG=1" HEAD~3

Looks like perf-tools-next has some changes that has not reflected 
elsewhere. The ts_source patches are queued there, which is causing
the above build failure.

Mike,

Are you able to rebase your patches on perf-tools-next branch ?

Kind regards
Suzuki

> 
> Thanks,
> Leo
> 
> [1] https://stackoverflow.com/questions/26983700/git-run-shell-command-for-each-commit


  reply	other threads:[~2023-03-30 10:55 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-29 11:14 [PATCH v8 0/3] perf: cs-etm: Update perf to handle new Coresight Trace ID Mike Leach
2023-03-29 11:14 ` [PATCH v8 1/3] perf: cs-etm: Move mapping of Trace ID and cpu into helper function Mike Leach
2023-03-29 12:41   ` Arnaldo Carvalho de Melo
2023-03-29 12:42     ` Arnaldo Carvalho de Melo
2023-03-29 12:59       ` Mike Leach
2023-03-29 13:22         ` Arnaldo Carvalho de Melo
2023-03-29 14:47           ` Mike Leach
2023-03-29 19:28             ` Arnaldo Carvalho de Melo
2023-03-29 22:14               ` Arnaldo Carvalho de Melo
2023-03-30  3:13                 ` Leo Yan
2023-03-30 10:55                   ` Suzuki K Poulose [this message]
2023-03-31  5:50                     ` Mike Leach
2023-03-29 11:14 ` [PATCH v8 2/3] perf: cs-etm: Update record event to use new Trace ID protocol Mike Leach
2023-03-29 11:14 ` [PATCH v8 3/3] perf: cs-etm: Handle PERF_RECORD_AUX_OUTPUT_HW_ID packet Mike Leach
2023-03-29 11:18 ` [PATCH v8 0/3] perf: cs-etm: Update perf to handle new Coresight Trace ID Suzuki K Poulose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20c28979-53a7-19eb-16fd-4d8535454d4e@arm.com \
    --to=suzuki.poulose@arm.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=coresight@lists.linaro.org \
    --cc=darren@os.amperecomputing.com \
    --cc=gankulkarni@os.amperecomputing.com \
    --cc=james.clark@arm.com \
    --cc=jolsa@redhat.com \
    --cc=leo.yan@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mike.leach@linaro.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).