From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Clark Williams <williams@redhat.com>,
linux-perf-users@vger.kernel.org
Subject: Re: perf probe can't remove probes
Date: Tue, 1 Dec 2020 10:43:09 -0300 [thread overview]
Message-ID: <20201201134309.GD49333@kernel.org> (raw)
In-Reply-To: <20201201132517.GC49333@kernel.org>
Em Tue, Dec 01, 2020 at 10:25:17AM -0300, Arnaldo Carvalho de Melo escreveu:
> Hi Masami,
> Any idea why listing the source code doesn't work while simply
> adding the probe works?
<SNIP>
> [root@seventh ~]# perf probe -L verify_pkcs7_signature
> Specified source line is not found.
> Error: Failed to show lines.
Yeah, those fixes you sent, when cherry-picked into this bpf-next/master
based branch, do the trick, so nevermind, you fixed this already, these
fixes were already merged by Linus, bpf-next will rebase at some point,
etc. :-)
- Arnaldo
[acme@five bpf]$ git log --oneline -4
0f3147557ea8143d (HEAD -> bpfsign) perf probe: Change function definition check due to broken DWARF
0e104f490d8f86b4 perf probe: Fix to die_entrypc() returns error correctly
9423e1f089643738 libbpf: Check if the kernel supports signatures before associating them
580616996c498b70 libbpf: Attach signature ELF sections to signed ELF program sections
[acme@five bpf]$
[root@seventh ~]# perf probe -L verify_pkcs7_signature
<verify_pkcs7_signature@/home/acme/git/bpf/certs/system_keyring.c:0>
0 int verify_pkcs7_signature(const void *data, size_t len,
const void *raw_pkcs7, size_t pkcs7_len,
struct key *trusted_keys,
enum key_being_used_for usage,
int (*view_content)(void *ctx,
const void *data, size_t len,
size_t asn1hdrlen),
void *ctx)
{
9 struct pkcs7_message *pkcs7;
int ret;
pkcs7 = pkcs7_parse_message(raw_pkcs7, pkcs7_len);
13 if (IS_ERR(pkcs7))
14 return PTR_ERR(pkcs7);
16 ret = verify_pkcs7_message_sig(data, len, pkcs7, trusted_keys, usage,
view_content, ctx);
19 pkcs7_free_message(pkcs7);
20 pr_devel("<==%s() = %d\n", __func__, ret);
return ret;
}
EXPORT_SYMBOL_GPL(verify_pkcs7_signature);
[root@seventh ~]#
prev parent reply other threads:[~2020-12-01 13:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 17:27 [BUG] perf probe can't remove probes Arnaldo Carvalho de Melo
2020-11-26 0:21 ` Masami Hiramatsu
2020-11-26 17:26 ` Arnaldo Carvalho de Melo
2020-12-16 0:16 ` Masami Hiramatsu
2020-12-16 13:59 ` Arnaldo Carvalho de Melo
2020-12-01 13:25 ` Arnaldo Carvalho de Melo
2020-12-01 13:43 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201201134309.GD49333@kernel.org \
--to=acme@kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=namhyung@kernel.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).