From: Peter Zijlstra <peterz@infradead.org>
To: Joe Perches <joe@perches.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
yuankuiz@codeaurora.org, Linux PM <linux-pm@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Frederic Weisbecker <fweisbec@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
aulmck@linux.vnet.ibm.com, Ingo Molnar <mingo@kernel.org>,
Len Brown <len.brown@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
apw@canonical.com
Subject: Re: Subject: [PATCH] [PATCH] time: tick-sched: use bool for tick_stopped
Date: Tue, 10 Apr 2018 18:30:17 +0200 [thread overview]
Message-ID: <20180410163017.GH4082@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <bece0d90535709ef39006adb5f481993d6063929.camel@perches.com>
On Tue, Apr 10, 2018 at 08:14:54AM -0700, Joe Perches wrote:
> Whinging about bool <foo> : <x> seems entirely sensible
> and straightforward to do.
>
> I'm not so sure about bool in structs as a patch context
> could be adding a bool to local stack definitions and
> there's no real ability to determine if the bool is in a
> struct or on the stack.
>
> Also, I think there's nothing really wrong with using
> bool in structs. Steven Rostedt's rationale in
> https://lkml.org/lkml/2017/11/21/207 isn't really right
> as sizeof(int) is 4 not 1 and sizeof(bool) is 1 on arches
> without alignment issues. I believe when using gcc,
> sizeof(bool) is always 1 and there may be alignment padding
> added on some arches. Dunno.
C std simply does not define sizeof(_Bool) and leaves it up to
architecture ABI, therefore I refuse to use _Bool in composite types,
because I care about layout.
Also, not all architectures can do byte addressing, see Alpha <EV56
and for those _Bool would have to be a whole word (the existence of such
architectures likely influenced the vague definition of _Bool in the
first place).
> But I think the battle is already lost anyway.
>
> git grep -P '(?<!static|extern)\s+bool\s+\w+\s*;' include | wc -l
> 1543
Yes I know, doesn't mean we shouldn't discourage it for new code; also Linus.
next prev parent reply other threads:[~2018-04-10 16:30 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 7:33 Subject: [PATCH] [PATCH] time: tick-sched: use bool for tick_stopped yuankuiz
2018-04-10 7:45 ` yuankuiz
2018-04-10 8:51 ` yuankuiz
2018-04-10 8:54 ` yuankuiz
2018-04-10 7:55 ` Subject: [PATCH] " Thomas Gleixner
2018-04-10 8:12 ` yuankuiz
2018-04-10 8:00 ` Rafael J. Wysocki
2018-04-10 8:15 ` yuankuiz
2018-04-10 9:10 ` Thomas Gleixner
2018-04-10 10:07 ` yuankuiz
2018-04-10 11:06 ` Thomas Gleixner
2018-04-10 14:08 ` yuankuiz
2018-04-10 14:49 ` yuankuiz
2018-04-10 23:09 ` yuankuiz
2018-04-10 23:20 ` yuankuiz
2018-04-20 1:47 ` yuankuiz
2018-04-20 6:44 ` yuankuiz
2018-04-20 19:24 ` Joe Perches
2018-04-25 7:01 ` yuankuiz
2018-04-10 11:26 ` Peter Zijlstra
2018-04-10 12:07 ` Thomas Gleixner
2018-04-10 12:26 ` Peter Zijlstra
2018-04-10 12:33 ` Subject: [PATCH] " Peter Zijlstra
2018-04-10 15:14 ` Joe Perches
2018-04-10 16:30 ` Peter Zijlstra [this message]
2018-04-10 15:41 ` [PATCH] checkpatch: whinge about bool bitfields Joe Perches
2018-04-10 18:19 ` [PATCH] checkpatch: Add a --strict test for structs with bool member definitions Joe Perches
2018-04-10 21:39 ` Andrew Morton
2018-04-10 21:53 ` Joe Perches
2018-04-10 22:00 ` Andrew Morton
2018-04-11 8:15 ` Peter Zijlstra
2018-04-11 16:29 ` Andrew Morton
2018-04-11 16:51 ` Joe Perches
2018-04-12 6:22 ` Julia Lawall
2018-04-12 6:42 ` Joe Perches
2018-04-12 7:03 ` Julia Lawall
2018-04-12 8:13 ` Peter Zijlstra
2018-04-14 21:19 ` Julia Lawall
2018-04-17 9:07 ` yuankuiz
2018-04-18 18:38 ` Joe Perches
2018-04-19 4:40 ` Julia Lawall
2018-04-19 4:51 ` Joe Perches
2018-04-19 5:16 ` Julia Lawall
2018-04-19 6:48 ` yuankuiz
2018-04-19 10:42 ` yuankuiz
2018-04-20 1:31 ` yuankuiz
2018-04-11 17:00 ` Peter Zijlstra
2018-04-12 7:47 ` Ingo Molnar
2018-04-12 8:11 ` Peter Zijlstra
2018-04-12 9:35 ` Andrea Parri
2018-04-12 11:50 ` Peter Zijlstra
2018-04-12 12:01 ` Joe Perches
2018-04-12 12:08 ` Peter Zijlstra
2018-04-12 12:38 ` Joe Perches
2018-04-12 16:47 ` Andrew Morton
2018-04-12 11:52 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180410163017.GH4082@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=apw@canonical.com \
--cc=aulmck@linux.vnet.ibm.com \
--cc=fweisbec@gmail.com \
--cc=joe@perches.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=yuankuiz@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).