From: Mark Brown <broonie@kernel.org>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: tony@atomide.com, lgirdwood@gmail.com,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, sboyd@kernel.org, nm@ti.com,
vireshk@kernel.org, letux-kernel@openphoenux.org
Subject: Re: [PATCH] regulator: twl: mark vdd1/2 as continuous on twl4030
Date: Mon, 17 Jun 2019 12:40:48 +0100 [thread overview]
Message-ID: <20190617114048.GN5316@sirena.org.uk> (raw)
In-Reply-To: <20190617130357.41204ff7@kemnade.info>
[-- Attachment #1: Type: text/plain, Size: 777 bytes --]
On Mon, Jun 17, 2019 at 01:03:57PM +0200, Andreas Kemnade wrote:
> Mark Brown <broonie@kernel.org> wrote:
> > On Sat, Jun 15, 2019 at 06:33:14PM +0200, Andreas Kemnade wrote:
> > Why is this a good fix and not defining the supported voltages? These
> > look like fairly standard linear range regulators.
> I am fixing the definition of the two regulators in the patch.
> I am defining them as continuous.
> Voltage ranges are defined in
> arch/arm/boot/dts/twl4030.dtsi
> Only the continuous flag is missing.
> Is there anything else do you want to be defined?
These regulators are not continuous regulators as far as I can see, they
are normal linear range regulators and so should have their voltages
enumerable like any other linear range regulator.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-06-17 11:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-15 16:33 [PATCH] regulator: twl: mark vdd1/2 as continuous on twl4030 Andreas Kemnade
2019-06-17 10:31 ` Mark Brown
2019-06-17 11:03 ` Andreas Kemnade
2019-06-17 11:40 ` Mark Brown [this message]
2019-06-17 16:27 ` Andreas Kemnade
2019-06-17 17:02 ` Mark Brown
2019-06-17 17:21 ` Andreas Kemnade
2019-06-17 16:32 ` Andreas Kemnade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190617114048.GN5316@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andreas@kemnade.info \
--cc=letux-kernel@openphoenux.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=sboyd@kernel.org \
--cc=tony@atomide.com \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).