linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Harry Pan <harry.pan@intel.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: gs0622@gmail.com, Harry Pan <harry.pan@intel.com>,
	Jacob Pan <jacob.jun.pan@linux.intel.com>,
	Len Brown <lenb@kernel.org>,
	linux-pm@vger.kernel.org
Subject: [PATCH v5] intel_idle: Add Comet Lake support
Date: Thu, 12 Mar 2020 17:25:20 +0800	[thread overview]
Message-ID: <20200312172457.1.I108734f38ade020c3e5da825839dca11d2a2ff87@changeid> (raw)
In-Reply-To: <20200304194312.1.I108734f38ade020c3e5da825839dca11d2a2ff87@changeid>

Add built-in idle states table for Comet Lake.

This patch also respects the exposed ACPI _CST objects in platform firmware
to disable those non-matching C-state by default, defer its enabling to the
userspace through sysfs.

Summary:
 - With built-in table and without _CST table, all C-states are enabled
 - With both built-in and _CST tables, matching C-states are enabled

Signed-off-by: Harry Pan <harry.pan@intel.com>

---

 drivers/idle/intel_idle.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
index d55606608ac8..49b385c36eea 100644
--- a/drivers/idle/intel_idle.c
+++ b/drivers/idle/intel_idle.c
@@ -1067,6 +1067,12 @@ static const struct idle_cpu idle_cpu_dnv = {
 	.use_acpi = true,
 };
 
+static const struct idle_cpu idle_cpu_cml = {
+	.state_table = skl_cstates,
+	.disable_promotion_to_c1e = true,
+	.use_acpi = true,
+};
+
 static const struct x86_cpu_id intel_idle_ids[] __initconst = {
 	INTEL_CPU_FAM6(NEHALEM_EP,		idle_cpu_nhx),
 	INTEL_CPU_FAM6(NEHALEM,			idle_cpu_nehalem),
@@ -1105,6 +1111,8 @@ static const struct x86_cpu_id intel_idle_ids[] __initconst = {
 	INTEL_CPU_FAM6(ATOM_GOLDMONT_PLUS,	idle_cpu_bxt),
 	INTEL_CPU_FAM6(ATOM_GOLDMONT_D,		idle_cpu_dnv),
 	INTEL_CPU_FAM6(ATOM_TREMONT_D,		idle_cpu_dnv),
+	INTEL_CPU_FAM6(COMETLAKE_L,		idle_cpu_cml),
+	INTEL_CPU_FAM6(COMETLAKE,		idle_cpu_cml),
 	{}
 };
 
-- 
2.24.1


      reply	other threads:[~2020-03-12  9:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-26 17:34 [PATCH] intel_idle: Add Comet Lake support Harry Pan
2020-02-26 21:47 ` Rafael J. Wysocki
2020-02-27 10:56   ` Rafael J. Wysocki
2020-03-03  9:09 ` [PATCH v3] " Harry Pan
2020-03-04  9:53   ` Rafael J. Wysocki
2020-03-04 11:57     ` Pan, Harry
2020-03-04 21:14       ` Rafael J. Wysocki
2020-03-09  9:02         ` Pan, Harry
2020-03-10  8:37           ` Rafael J. Wysocki
2020-03-04 11:43   ` [PATCH v4] " Harry Pan
2020-03-12  9:25     ` Harry Pan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200312172457.1.I108734f38ade020c3e5da825839dca11d2a2ff87@changeid \
    --to=harry.pan@intel.com \
    --cc=gs0622@gmail.com \
    --cc=jacob.jun.pan@linux.intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).