linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Harry Pan <harry.pan@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Harry Pan <gs0622@gmail.com>,
	Jacob Pan <jacob.jun.pan@linux.intel.com>,
	Len Brown <lenb@kernel.org>, Linux PM <linux-pm@vger.kernel.org>
Subject: Re: [PATCH] intel_idle: Add Comet Lake support
Date: Wed, 26 Feb 2020 22:47:35 +0100	[thread overview]
Message-ID: <CAJZ5v0hX-DVLPQmjVAZkQUJy8gCBPTneJvaFHmjqqbCe66F_6w@mail.gmail.com> (raw)
In-Reply-To: <20200227013411.1.Ica3bb9fa898499d94e0b0a2bfa08ec46c89d84fa@changeid>

On Wed, Feb 26, 2020 at 6:34 PM Harry Pan <harry.pan@intel.com> wrote:
>
> Add Comet Lake ID to enable intel_idle driver support.
> This is required for PC10 and S0ix.

That shouldn't be the case for Linux 5.6-rc as long as the ACPI tables
expose C10 in _CST, so have you checked that?

> Signed-off-by: Harry Pan <harry.pan@intel.com>
>
> ---
>
>  drivers/idle/intel_idle.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
> index 347b08b56042..3cf292b2b7f1 100644
> --- a/drivers/idle/intel_idle.c
> +++ b/drivers/idle/intel_idle.c
> @@ -1086,6 +1086,8 @@ static const struct x86_cpu_id intel_idle_ids[] __initconst = {
>         INTEL_CPU_FAM6(KABYLAKE_L,              idle_cpu_skl),
>         INTEL_CPU_FAM6(KABYLAKE,                idle_cpu_skl),
>         INTEL_CPU_FAM6(SKYLAKE_X,               idle_cpu_skx),
> +       INTEL_CPU_FAM6(COMETLAKE_L,             idle_cpu_skl),
> +       INTEL_CPU_FAM6(COMETLAKE,               idle_cpu_skl),
>         INTEL_CPU_FAM6(XEON_PHI_KNL,            idle_cpu_knl),
>         INTEL_CPU_FAM6(XEON_PHI_KNM,            idle_cpu_knl),
>         INTEL_CPU_FAM6(ATOM_GOLDMONT,           idle_cpu_bxt),
> --
> 2.24.1
>

  reply	other threads:[~2020-02-26 21:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-26 17:34 [PATCH] intel_idle: Add Comet Lake support Harry Pan
2020-02-26 21:47 ` Rafael J. Wysocki [this message]
2020-02-27 10:56   ` Rafael J. Wysocki
2020-03-03  9:09 ` [PATCH v3] " Harry Pan
2020-03-04  9:53   ` Rafael J. Wysocki
2020-03-04 11:57     ` Pan, Harry
2020-03-04 21:14       ` Rafael J. Wysocki
2020-03-09  9:02         ` Pan, Harry
2020-03-10  8:37           ` Rafael J. Wysocki
2020-03-04 11:43   ` [PATCH v4] " Harry Pan
2020-03-12  9:25     ` [PATCH v5] " Harry Pan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJZ5v0hX-DVLPQmjVAZkQUJy8gCBPTneJvaFHmjqqbCe66F_6w@mail.gmail.com \
    --to=rafael@kernel.org \
    --cc=gs0622@gmail.com \
    --cc=harry.pan@intel.com \
    --cc=jacob.jun.pan@linux.intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).