From: "Pan, Harry" <harry.pan@intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Harry Pan <gs0622@gmail.com>,
"Jacob Pan" <jacob.jun.pan@linux.intel.com>,
Len Brown <lenb@kernel.org>, Linux PM <linux-pm@vger.kernel.org>
Subject: Re: [PATCH v3] intel_idle: Add Comet Lake support
Date: Wed, 4 Mar 2020 11:57:33 +0000 [thread overview]
Message-ID: <F8C6368A-1537-482B-8FE5-350A18D936A8@intel.com> (raw)
In-Reply-To: <CAJZ5v0j+bx5fh1wv738MNoui_SaZ-c21rDnZkWOqi_GCVg5stQ@mail.gmail.com>
Hi Rafael,
Yes, I skipped it considering to align CML-U V0 and A0 stepping w/ the same table; I sent v4 for your review.
In the other hand, I am proposing using _CST as long term plan in CrOS dev teams.
Sincerely,
Harry
> On Mar 4, 2020, at 17:53, Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Tue, Mar 3, 2020 at 10:10 AM Harry Pan <harry.pan@intel.com> wrote:
>>
>> Add a general C-state table in order to support Comet Lake.
>>
>> Signed-off-by: Harry Pan <harry.pan@intel.com>
>>
>> ---
>>
>> drivers/idle/intel_idle.c | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
>> index d55606608ac8..05bce595fafe 100644
>> --- a/drivers/idle/intel_idle.c
>> +++ b/drivers/idle/intel_idle.c
>> @@ -1067,6 +1067,11 @@ static const struct idle_cpu idle_cpu_dnv = {
>> .use_acpi = true,
>> };
>>
>> +static const struct idle_cpu idle_cpu_cml = {
>> + .state_table = skl_cstates,
>> + .disable_promotion_to_c1e = true,
>
> .use_acpi = true,
>
> missing? Otherwise you can just use idle_cpu_skl as is, can't you?
>
>> +};
>> +
>> static const struct x86_cpu_id intel_idle_ids[] __initconst = {
>> INTEL_CPU_FAM6(NEHALEM_EP, idle_cpu_nhx),
>> INTEL_CPU_FAM6(NEHALEM, idle_cpu_nehalem),
>> @@ -1105,6 +1110,8 @@ static const struct x86_cpu_id intel_idle_ids[] __initconst = {
>> INTEL_CPU_FAM6(ATOM_GOLDMONT_PLUS, idle_cpu_bxt),
>> INTEL_CPU_FAM6(ATOM_GOLDMONT_D, idle_cpu_dnv),
>> INTEL_CPU_FAM6(ATOM_TREMONT_D, idle_cpu_dnv),
>> + INTEL_CPU_FAM6(COMETLAKE_L, idle_cpu_cml),
>> + INTEL_CPU_FAM6(COMETLAKE, idle_cpu_cml),
>> {}
>> };
>>
>> --
>> 2.24.1
>>
next prev parent reply other threads:[~2020-03-04 11:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 17:34 [PATCH] intel_idle: Add Comet Lake support Harry Pan
2020-02-26 21:47 ` Rafael J. Wysocki
2020-02-27 10:56 ` Rafael J. Wysocki
2020-03-03 9:09 ` [PATCH v3] " Harry Pan
2020-03-04 9:53 ` Rafael J. Wysocki
2020-03-04 11:57 ` Pan, Harry [this message]
2020-03-04 21:14 ` Rafael J. Wysocki
2020-03-09 9:02 ` Pan, Harry
2020-03-10 8:37 ` Rafael J. Wysocki
2020-03-04 11:43 ` [PATCH v4] " Harry Pan
2020-03-12 9:25 ` [PATCH v5] " Harry Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F8C6368A-1537-482B-8FE5-350A18D936A8@intel.com \
--to=harry.pan@intel.com \
--cc=gs0622@gmail.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).