* [PATCH] dt-bindings: thermal: rcar-thermal: Improve schema validation
@ 2020-06-19 15:15 Geert Uytterhoeven
2020-06-27 3:44 ` Niklas Söderlund
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2020-06-19 15:15 UTC (permalink / raw)
To: Zhang Rui, Daniel Lezcano, Amit Kucheria, Rob Herring,
Niklas Söderlund
Cc: linux-pm, devicetree, linux-renesas-soc, Geert Uytterhoeven
- Document missing "#thermal-sensor-cells",
- Factor out common required properties,
- "interrupts", "clocks", and "power-domains" are required on R-Mobile
APE6, too,
- Invert logic to simplify descriptions,
- Add "additionalProperties: false".
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
.../bindings/thermal/rcar-thermal.yaml | 53 ++++++++++++-------
1 file changed, 34 insertions(+), 19 deletions(-)
diff --git a/Documentation/devicetree/bindings/thermal/rcar-thermal.yaml b/Documentation/devicetree/bindings/thermal/rcar-thermal.yaml
index 0994693d240f9ff4..88787b98992fe7c9 100644
--- a/Documentation/devicetree/bindings/thermal/rcar-thermal.yaml
+++ b/Documentation/devicetree/bindings/thermal/rcar-thermal.yaml
@@ -59,25 +59,40 @@ properties:
resets:
maxItems: 1
-if:
- properties:
- compatible:
- contains:
- enum:
- - renesas,thermal-r8a73a4 # R-Mobile APE6
- - renesas,thermal-r8a7779 # R-Car H1
-then:
- required:
- - compatible
- - reg
-else:
- required:
- - compatible
- - reg
- - interrupts
- - clocks
- - power-domains
- - resets
+ '#thermal-sensor-cells':
+ const: 0
+
+required:
+ - compatible
+ - reg
+
+allOf:
+ - if:
+ not:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - renesas,thermal-r8a73a4 # R-Mobile APE6
+ - renesas,thermal-r8a7779 # R-Car H1
+ then:
+ required:
+ - resets
+ - '#thermal-sensor-cells'
+
+ - if:
+ not:
+ properties:
+ compatible:
+ contains:
+ const: renesas,thermal-r8a7779 # R-Car H1
+ then:
+ required:
+ - interrupts
+ - clocks
+ - power-domains
+
+additionalProperties: false
examples:
# Example (non interrupt support)
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: thermal: rcar-thermal: Improve schema validation
2020-06-19 15:15 [PATCH] dt-bindings: thermal: rcar-thermal: Improve schema validation Geert Uytterhoeven
@ 2020-06-27 3:44 ` Niklas Söderlund
2020-06-29 12:51 ` Amit Kucheria
2020-07-15 19:24 ` Rob Herring
2 siblings, 0 replies; 4+ messages in thread
From: Niklas Söderlund @ 2020-06-27 3:44 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Zhang Rui, Daniel Lezcano, Amit Kucheria, Rob Herring, linux-pm,
devicetree, linux-renesas-soc
Hi Geert,
Thanks for your work.
On 2020-06-19 17:15:41 +0200, Geert Uytterhoeven wrote:
> - Document missing "#thermal-sensor-cells",
> - Factor out common required properties,
> - "interrupts", "clocks", and "power-domains" are required on R-Mobile
> APE6, too,
> - Invert logic to simplify descriptions,
> - Add "additionalProperties: false".
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
> ---
> .../bindings/thermal/rcar-thermal.yaml | 53 ++++++++++++-------
> 1 file changed, 34 insertions(+), 19 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/rcar-thermal.yaml b/Documentation/devicetree/bindings/thermal/rcar-thermal.yaml
> index 0994693d240f9ff4..88787b98992fe7c9 100644
> --- a/Documentation/devicetree/bindings/thermal/rcar-thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/rcar-thermal.yaml
> @@ -59,25 +59,40 @@ properties:
> resets:
> maxItems: 1
>
> -if:
> - properties:
> - compatible:
> - contains:
> - enum:
> - - renesas,thermal-r8a73a4 # R-Mobile APE6
> - - renesas,thermal-r8a7779 # R-Car H1
> -then:
> - required:
> - - compatible
> - - reg
> -else:
> - required:
> - - compatible
> - - reg
> - - interrupts
> - - clocks
> - - power-domains
> - - resets
> + '#thermal-sensor-cells':
> + const: 0
> +
> +required:
> + - compatible
> + - reg
> +
> +allOf:
> + - if:
> + not:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - renesas,thermal-r8a73a4 # R-Mobile APE6
> + - renesas,thermal-r8a7779 # R-Car H1
> + then:
> + required:
> + - resets
> + - '#thermal-sensor-cells'
> +
> + - if:
> + not:
> + properties:
> + compatible:
> + contains:
> + const: renesas,thermal-r8a7779 # R-Car H1
> + then:
> + required:
> + - interrupts
> + - clocks
> + - power-domains
> +
> +additionalProperties: false
>
> examples:
> # Example (non interrupt support)
> --
> 2.17.1
>
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: thermal: rcar-thermal: Improve schema validation
2020-06-19 15:15 [PATCH] dt-bindings: thermal: rcar-thermal: Improve schema validation Geert Uytterhoeven
2020-06-27 3:44 ` Niklas Söderlund
@ 2020-06-29 12:51 ` Amit Kucheria
2020-07-15 19:24 ` Rob Herring
2 siblings, 0 replies; 4+ messages in thread
From: Amit Kucheria @ 2020-06-29 12:51 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Zhang Rui, Daniel Lezcano, Rob Herring, Niklas Söderlund,
Linux PM list,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-renesas-soc
On Fri, Jun 19, 2020 at 8:45 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
> - Document missing "#thermal-sensor-cells",
> - Factor out common required properties,
> - "interrupts", "clocks", and "power-domains" are required on R-Mobile
> APE6, too,
> - Invert logic to simplify descriptions,
> - Add "additionalProperties: false".
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>
> ---
> .../bindings/thermal/rcar-thermal.yaml | 53 ++++++++++++-------
> 1 file changed, 34 insertions(+), 19 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/rcar-thermal.yaml b/Documentation/devicetree/bindings/thermal/rcar-thermal.yaml
> index 0994693d240f9ff4..88787b98992fe7c9 100644
> --- a/Documentation/devicetree/bindings/thermal/rcar-thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/rcar-thermal.yaml
> @@ -59,25 +59,40 @@ properties:
> resets:
> maxItems: 1
>
> -if:
> - properties:
> - compatible:
> - contains:
> - enum:
> - - renesas,thermal-r8a73a4 # R-Mobile APE6
> - - renesas,thermal-r8a7779 # R-Car H1
> -then:
> - required:
> - - compatible
> - - reg
> -else:
> - required:
> - - compatible
> - - reg
> - - interrupts
> - - clocks
> - - power-domains
> - - resets
> + '#thermal-sensor-cells':
> + const: 0
> +
> +required:
> + - compatible
> + - reg
> +
> +allOf:
> + - if:
> + not:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - renesas,thermal-r8a73a4 # R-Mobile APE6
> + - renesas,thermal-r8a7779 # R-Car H1
> + then:
> + required:
> + - resets
> + - '#thermal-sensor-cells'
> +
> + - if:
> + not:
> + properties:
> + compatible:
> + contains:
> + const: renesas,thermal-r8a7779 # R-Car H1
> + then:
> + required:
> + - interrupts
> + - clocks
> + - power-domains
> +
> +additionalProperties: false
>
> examples:
> # Example (non interrupt support)
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: thermal: rcar-thermal: Improve schema validation
2020-06-19 15:15 [PATCH] dt-bindings: thermal: rcar-thermal: Improve schema validation Geert Uytterhoeven
2020-06-27 3:44 ` Niklas Söderlund
2020-06-29 12:51 ` Amit Kucheria
@ 2020-07-15 19:24 ` Rob Herring
2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2020-07-15 19:24 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: devicetree, Daniel Lezcano, Niklas Söderlund, Zhang Rui,
linux-pm, Amit Kucheria, Rob Herring, linux-renesas-soc
On Fri, 19 Jun 2020 17:15:41 +0200, Geert Uytterhoeven wrote:
> - Document missing "#thermal-sensor-cells",
> - Factor out common required properties,
> - "interrupts", "clocks", and "power-domains" are required on R-Mobile
> APE6, too,
> - Invert logic to simplify descriptions,
> - Add "additionalProperties: false".
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> .../bindings/thermal/rcar-thermal.yaml | 53 ++++++++++++-------
> 1 file changed, 34 insertions(+), 19 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-15 19:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-19 15:15 [PATCH] dt-bindings: thermal: rcar-thermal: Improve schema validation Geert Uytterhoeven
2020-06-27 3:44 ` Niklas Söderlund
2020-06-29 12:51 ` Amit Kucheria
2020-07-15 19:24 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).