From: Lee Jones <lee.jones@linaro.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Viresh Kumar <viresh.kumar@linaro.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
Andreas Herrmann <herrmann.der.user@googlemail.com>,
Dominik Brodowski <linux@brodo.de>, Pavel Machek <pavel@ucw.cz>,
Paul Devriendt <paul.devriendt@amd.com>,
Mark Langsdorf <mark.langsdorf@amd.com>
Subject: Re: [PATCH 10/13] cpufreq: powernow-k8: Make use of known set but not used variables
Date: Tue, 14 Jul 2020 22:01:35 +0100 [thread overview]
Message-ID: <20200714210135.GG1398296@dell> (raw)
In-Reply-To: <CAJZ5v0jXjtZ0=ZnOZm2LNR32TwWSrq4C4bwhNh5tOOChfpWZxw@mail.gmail.com>
On Tue, 14 Jul 2020, Rafael J. Wysocki wrote:
> On Tue, Jul 14, 2020 at 4:51 PM Lee Jones <lee.jones@linaro.org> wrote:
> >
> > If we fail to use a variable, even a 'dummy' one, then the compiler
> > complains that it is set but not used. We know this is fine, so we
> > set it to its own value here.
> >
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/cpufreq/powernow-k8.c: In function ‘pending_bit_stuck’:
> > drivers/cpufreq/powernow-k8.c:89:10: warning: variable ‘hi’ set but not used [-Wunused-but-set-variable]
> > 89 | u32 lo, hi;
> > | ^~
> > drivers/cpufreq/powernow-k8.c: In function ‘core_voltage_pre_transition’:
> > drivers/cpufreq/powernow-k8.c:285:14: warning: variable ‘lo’ set but not used [-Wunused-but-set-variable]
> > 285 | u32 maxvid, lo, rvomult = 1;
> > | ^~
> >
> > Cc: Andreas Herrmann <herrmann.der.user@googlemail.com>
> > Cc: Dominik Brodowski <linux@brodo.de>
> > Cc: Pavel Machek <pavel@ucw.cz>
> > Cc: Paul Devriendt <paul.devriendt@amd.com>
> > Cc: Mark Langsdorf <mark.langsdorf@amd.com>
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> > drivers/cpufreq/powernow-k8.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/cpufreq/powernow-k8.c b/drivers/cpufreq/powernow-k8.c
> > index 3984959eed1d5..b76df81044c4f 100644
> > --- a/drivers/cpufreq/powernow-k8.c
> > +++ b/drivers/cpufreq/powernow-k8.c
> > @@ -89,6 +89,7 @@ static int pending_bit_stuck(void)
> > u32 lo, hi;
> >
> > rdmsr(MSR_FIDVID_STATUS, lo, hi);
> > + hi &= hi; /* Silence set but not used warning */
>
> Hmm.
>
> What about using __always_unused for this?
I didn't know you could use that for standard variables.
Will fix.
> > return lo & MSR_S_LO_CHANGE_PENDING ? 1 : 0;
> > }
> >
> > @@ -292,6 +293,7 @@ static int core_voltage_pre_transition(struct powernow_k8_data *data,
> > rvomult = 2;
> > rvosteps *= rvomult;
> > rdmsr(MSR_FIDVID_STATUS, lo, maxvid);
> > + lo &= lo; /* Silence set but not used warning */
> > maxvid = 0x1f & (maxvid >> 16);
> > pr_debug("ph1 maxvid=0x%x\n", maxvid);
> > if (reqvid < maxvid) /* lower numbers are higher voltages */
> >
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-07-14 21:01 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 14:50 [PATCH 00/13] Rid W=1 warnings in CPUFreq Lee Jones
2020-07-14 14:50 ` [PATCH 01/13] cpufreq: freq_table: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-15 2:44 ` Viresh Kumar
2020-07-14 14:50 ` [PATCH 02/13] cpufreq: cpufreq: Demote lots of function headers unworthy of kerneldoc status Lee Jones
2020-07-15 2:49 ` Viresh Kumar
2020-07-15 6:47 ` Lee Jones
2020-07-15 7:09 ` Viresh Kumar
2020-07-14 14:50 ` [PATCH 03/13] cpufreq: cpufreq_governor: Demote store_sampling_rate() header to standard comment block Lee Jones
2020-07-15 2:52 ` Viresh Kumar
2020-07-15 6:45 ` Lee Jones
2020-07-15 7:08 ` Viresh Kumar
2020-07-15 7:31 ` Lee Jones
2020-07-15 8:02 ` Viresh Kumar
2020-07-15 8:15 ` Lee Jones
2020-07-14 14:50 ` [PATCH 04/13] cpufreq: sti-cpufreq: Fix some formatting and misspelling issues Lee Jones
2020-07-15 2:58 ` Viresh Kumar
2020-07-14 14:50 ` [PATCH 05/13] cpufreq/arch: powerpc: pasemi: Move prototypes to shared header Lee Jones
2020-07-15 3:07 ` Viresh Kumar
2020-07-15 3:49 ` Olof Johansson
2020-07-15 3:51 ` Viresh Kumar
2020-07-15 6:36 ` Lee Jones
2020-07-15 6:39 ` Viresh Kumar
2020-07-15 3:26 ` Olof Johansson
2020-07-15 6:33 ` Lee Jones
2020-07-15 6:46 ` Olof Johansson
2020-07-15 7:33 ` Lee Jones
2020-07-14 14:50 ` [PATCH 06/13] cpufreq: powernv-cpufreq: Functions only used in call-backs should be static Lee Jones
2020-07-15 3:07 ` Viresh Kumar
2020-07-14 14:50 ` [PATCH 07/13] cpufreq: powernv-cpufreq: Fix a bunch of kerneldoc related issues Lee Jones
2020-07-15 3:09 ` Viresh Kumar
2020-07-14 14:50 ` [PATCH 08/13] cpufreq: acpi-cpufreq: Take 'dummy' principle one stage further Lee Jones
2020-07-14 16:03 ` Rafael J. Wysocki
2020-07-14 16:20 ` Robin Murphy
2020-07-14 21:00 ` Lee Jones
2020-07-14 14:50 ` [PATCH 09/13] cpufreq: acpi-cpufreq: Remove unused ID structs Lee Jones
2020-07-14 15:58 ` Rafael J. Wysocki
2020-07-14 21:03 ` Lee Jones
2020-07-15 3:24 ` Viresh Kumar
2020-07-15 3:27 ` Viresh Kumar
2020-07-15 6:37 ` Lee Jones
2020-07-15 11:27 ` Rafael J. Wysocki
2020-07-15 11:34 ` Lee Jones
2020-07-15 11:44 ` Rafael J. Wysocki
2020-07-15 11:50 ` Lee Jones
2020-07-15 12:07 ` Lee Jones
2020-07-15 12:11 ` Rafael J. Wysocki
2020-07-15 12:09 ` Rafael J. Wysocki
2020-07-15 12:16 ` Lee Jones
2020-07-15 12:30 ` Robin Murphy
2020-07-15 12:38 ` Lee Jones
2020-07-14 14:50 ` [PATCH 10/13] cpufreq: powernow-k8: Make use of known set but not used variables Lee Jones
2020-07-14 17:43 ` Rafael J. Wysocki
2020-07-14 21:01 ` Lee Jones [this message]
2020-07-14 14:50 ` [PATCH 11/13] cpufreq: pcc-cpufreq: Remove unused ID structs Lee Jones
2020-07-14 17:42 ` Rafael J. Wysocki
2020-07-14 14:50 ` [PATCH 12/13] cpufreq: intel_pstate: Supply struct attribute description for get_aperf_mperf_shift() Lee Jones
2020-07-14 16:35 ` Rafael J. Wysocki
2020-07-14 21:03 ` Lee Jones
2020-07-15 12:38 ` Rafael J. Wysocki
2020-07-14 14:50 ` [PATCH 13/13] cpufreq: amd_freq_sensitivity: Remove unused ID structs Lee Jones
2020-07-14 17:15 ` Kim Phillips
2020-07-14 21:02 ` Lee Jones
2020-07-14 21:13 ` Kim Phillips
2020-07-15 6:47 ` Lee Jones
2020-07-15 3:36 ` [PATCH 00/13] Rid W=1 warnings in CPUFreq Viresh Kumar
2020-07-15 6:32 ` Lee Jones
2020-07-15 6:38 ` Viresh Kumar
2020-07-15 7:34 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714210135.GG1398296@dell \
--to=lee.jones@linaro.org \
--cc=herrmann.der.user@googlemail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@brodo.de \
--cc=mark.langsdorf@amd.com \
--cc=paul.devriendt@amd.com \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).