* [PATCH] power: supply: smb347-charger: Drop unused include
@ 2021-05-29 0:19 Linus Walleij
2021-05-29 15:28 ` Dmitry Osipenko
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Linus Walleij @ 2021-05-29 0:19 UTC (permalink / raw)
To: Sebastian Reichel
Cc: linux-pm, Linus Walleij, David Heidelberg, Dmitry Osipenko
This driver is including the legacy GPIO header <linux/gpio.h>
but not using any symbols from it. Delete the include.
Cc: David Heidelberg <david@ixit.cz>
Cc: Dmitry Osipenko <digetx@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/power/supply/smb347-charger.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/power/supply/smb347-charger.c b/drivers/power/supply/smb347-charger.c
index 3376f42d46c3..df240420f2de 100644
--- a/drivers/power/supply/smb347-charger.c
+++ b/drivers/power/supply/smb347-charger.c
@@ -10,7 +10,6 @@
#include <linux/delay.h>
#include <linux/err.h>
-#include <linux/gpio.h>
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/init.h>
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] power: supply: smb347-charger: Drop unused include
2021-05-29 0:19 [PATCH] power: supply: smb347-charger: Drop unused include Linus Walleij
@ 2021-05-29 15:28 ` Dmitry Osipenko
2021-05-29 18:34 ` David Heidelberg
2021-06-03 17:05 ` Sebastian Reichel
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Osipenko @ 2021-05-29 15:28 UTC (permalink / raw)
To: Linus Walleij, Sebastian Reichel; +Cc: linux-pm, David Heidelberg
29.05.2021 03:19, Linus Walleij пишет:
> This driver is including the legacy GPIO header <linux/gpio.h>
> but not using any symbols from it. Delete the include.
>
> Cc: David Heidelberg <david@ixit.cz>
> Cc: Dmitry Osipenko <digetx@gmail.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/power/supply/smb347-charger.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/power/supply/smb347-charger.c b/drivers/power/supply/smb347-charger.c
> index 3376f42d46c3..df240420f2de 100644
> --- a/drivers/power/supply/smb347-charger.c
> +++ b/drivers/power/supply/smb347-charger.c
> @@ -10,7 +10,6 @@
>
> #include <linux/delay.h>
> #include <linux/err.h>
> -#include <linux/gpio.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/init.h>
>
Good catch, GPIO usage was gone with the removal of legacy platform data
from the driver, which Sebastian did not so long time ago.
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] power: supply: smb347-charger: Drop unused include
2021-05-29 0:19 [PATCH] power: supply: smb347-charger: Drop unused include Linus Walleij
2021-05-29 15:28 ` Dmitry Osipenko
@ 2021-05-29 18:34 ` David Heidelberg
2021-06-03 17:05 ` Sebastian Reichel
2 siblings, 0 replies; 4+ messages in thread
From: David Heidelberg @ 2021-05-29 18:34 UTC (permalink / raw)
To: Linus Walleij; +Cc: Sebastian Reichel, linux-pm, Dmitry Osipenko
Acked-by: David Heidelberg <david@ixit.cz>
Best regards
David Heidelberg
On Sat, May 29 2021 at 02:19:02 +0200, Linus Walleij
<linus.walleij@linaro.org> wrote:
> This driver is including the legacy GPIO header <linux/gpio.h>
> but not using any symbols from it. Delete the include.
>
> Cc: David Heidelberg <david@ixit.cz>
> Cc: Dmitry Osipenko <digetx@gmail.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/power/supply/smb347-charger.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/power/supply/smb347-charger.c
> b/drivers/power/supply/smb347-charger.c
> index 3376f42d46c3..df240420f2de 100644
> --- a/drivers/power/supply/smb347-charger.c
> +++ b/drivers/power/supply/smb347-charger.c
> @@ -10,7 +10,6 @@
>
> #include <linux/delay.h>
> #include <linux/err.h>
> -#include <linux/gpio.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/init.h>
> --
> 2.31.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] power: supply: smb347-charger: Drop unused include
2021-05-29 0:19 [PATCH] power: supply: smb347-charger: Drop unused include Linus Walleij
2021-05-29 15:28 ` Dmitry Osipenko
2021-05-29 18:34 ` David Heidelberg
@ 2021-06-03 17:05 ` Sebastian Reichel
2 siblings, 0 replies; 4+ messages in thread
From: Sebastian Reichel @ 2021-06-03 17:05 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-pm, David Heidelberg, Dmitry Osipenko
[-- Attachment #1: Type: text/plain, Size: 920 bytes --]
Hi,
On Sat, May 29, 2021 at 02:19:02AM +0200, Linus Walleij wrote:
> This driver is including the legacy GPIO header <linux/gpio.h>
> but not using any symbols from it. Delete the include.
>
> Cc: David Heidelberg <david@ixit.cz>
> Cc: Dmitry Osipenko <digetx@gmail.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
Thanks, queued.
-- Sebastian
> drivers/power/supply/smb347-charger.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/power/supply/smb347-charger.c b/drivers/power/supply/smb347-charger.c
> index 3376f42d46c3..df240420f2de 100644
> --- a/drivers/power/supply/smb347-charger.c
> +++ b/drivers/power/supply/smb347-charger.c
> @@ -10,7 +10,6 @@
>
> #include <linux/delay.h>
> #include <linux/err.h>
> -#include <linux/gpio.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/init.h>
> --
> 2.31.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-03 17:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-29 0:19 [PATCH] power: supply: smb347-charger: Drop unused include Linus Walleij
2021-05-29 15:28 ` Dmitry Osipenko
2021-05-29 18:34 ` David Heidelberg
2021-06-03 17:05 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).