From: Jonathan Cameron <jic23@kernel.org>
To: ChiaEn Wu <peterwu.pub@gmail.com>
Cc: lars@metafoo.de, matthias.bgg@gmail.com, lee.jones@linaro.org,
daniel.thompson@linaro.org, jingoohan1@gmail.com, pavel@ucw.cz,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org,
szunichen@gmail.com, ChiYuan Huang <cy_huang@richtek.com>
Subject: Re: [PATCH v2 08/15] mfd: mt6370: Add Mediatek MT6370 support
Date: Sat, 18 Jun 2022 16:55:33 +0100 [thread overview]
Message-ID: <20220618165533.5669e288@jic23-huawei> (raw)
In-Reply-To: <20220613111146.25221-9-peterwu.pub@gmail.com>
On Mon, 13 Jun 2022 19:11:39 +0800
ChiaEn Wu <peterwu.pub@gmail.com> wrote:
> From: ChiYuan Huang <cy_huang@richtek.com>
>
> Add Mediatek MT6370 MFD support.
>
> Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
Hi.
A few trivial things that probably overlap with other reviewer
comments.
> +static int mt6370_check_vendor_info(struct mt6370_info *info)
> +{
> + unsigned int devinfo;
> + int ret;
> +
> + ret = regmap_read(info->regmap, MT6370_REG_DEV_INFO, &devinfo);
> + if (ret)
> + return ret;
> +
> + switch (FIELD_GET(MT6370_VENID_MASK, devinfo)) {
> + case 0x8: /* RT5081 */
> + case 0xA: /* RT5081A */
> + case 0xE: /* MT6370 */
> + case 0xF: /* MT6371 */
> + case 0x9: /* MT6372P */
> + case 0xB: /* MT6372CP */
> + break;
> + default:
> + dev_err(info->dev, "Not invalid value 0x%02x\n", devinfo);
Double negative... You mean "Invalid value"
though you probably want to say something more specific such as
"Unknown Vendor ID 0x%02x\n")
> + return -ENODEV;
> + }
> +
> + return 0;
> +}
> +
> +static int mt6370_regmap_read(void *context, const void *reg_buf,
> + size_t reg_size, void *val_buf, size_t val_size)
> +{
> + struct mt6370_info *info = context;
> + u8 bank_idx = *(u8 *)reg_buf, bank_addr = *(u8 *)(reg_buf + 1);
> + int ret;
> +
> + ret = i2c_smbus_read_i2c_block_data(info->i2c[bank_idx], bank_addr,
> + val_size, val_buf);
> + if (ret != val_size)
> + return ret;
If it's positive , that is probably not what regmap expects.
See handling in here
https://elixir.bootlin.com/linux/latest/source/drivers/base/regmap/regmap-i2c.c#L222
> +
> + return 0;
> +}
> +
> +static int mt6370_probe(struct i2c_client *i2c)
> +{
> + struct mt6370_info *info;
> + struct i2c_client *usbc_i2c;
> + int ret;
> +
> + info = devm_kzalloc(&i2c->dev, sizeof(*info), GFP_KERNEL);
> + if (!info)
> + return -ENOMEM;
> +
> + info->dev = &i2c->dev;
> +
> + usbc_i2c = devm_i2c_new_dummy_device(&i2c->dev, i2c->adapter,
> + MT6370_USBC_I2CADDR);
> + if (IS_ERR(usbc_i2c)) {
> + ret = PTR_ERR(usbc_i2c);
> + dev_err(&i2c->dev, "Failed to register usbc i2c client %d\n", ret);
Might as well use
return dev_err_probe(&i2c->dev, PTR_ERR(usb_i2c),
"Failed to register USBC I2C client\n");
Whilst the defer handling isn't relevant, it is safe to use throughout probe
and tidier in this case at least.
> + return ret;
> + }
> +
> + /* Assign I2C client for PMU and TypeC */
> + info->i2c[MT6370_PMU_I2C] = i2c;
> + info->i2c[MT6370_USBC_I2C] = usbc_i2c;
> +
> + info->regmap = devm_regmap_init(&i2c->dev, &mt6370_regmap_bus, info,
> + &mt6370_regmap_config);
> + if (IS_ERR(info->regmap)) {
> + ret = PTR_ERR(info->regmap);
> + dev_err(&i2c->dev, "Failed to register regmap (%d)\n", ret);
as above dev_err_probe() will tidy this and following cases up for you.
> + return ret;
> + }
> +
> + ret = mt6370_check_vendor_info(info);
> + if (ret) {
> + dev_err(&i2c->dev, "Failed to check vendor info (%d)\n", ret);
> + return ret;
> + }
> +
> + ret = devm_regmap_add_irq_chip(&i2c->dev, info->regmap, i2c->irq,
> + IRQF_ONESHOT, -1, &mt6370_irq_chip,
> + &info->irq_data);
> + if (ret) {
> + dev_err(&i2c->dev, "Failed to add irq chip (%d)\n", ret);
> + return ret;
> + }
> +
> + return devm_mfd_add_devices(&i2c->dev, PLATFORM_DEVID_AUTO,
> + mt6370_devices, ARRAY_SIZE(mt6370_devices),
> + NULL, 0,
> + regmap_irq_get_domain(info->irq_data));
> +}
next prev parent reply other threads:[~2022-06-18 15:46 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-13 11:11 [PATCH v2 00/15] Add Mediatek MT6370 PMIC support ChiaEn Wu
2022-06-13 11:11 ` [PATCH v2 01/15] dt-bindings: usb: Add Mediatek MT6370 TCPC ChiaEn Wu
2022-06-16 21:06 ` Krzysztof Kozlowski
2022-06-13 11:11 ` [PATCH v2 02/15] dt-bindings: power: supply: Add Mediatek MT6370 Charger ChiaEn Wu
2022-06-16 21:05 ` Krzysztof Kozlowski
2022-06-17 10:19 ` ChiaEn Wu
2022-06-17 23:12 ` Krzysztof Kozlowski
2022-06-13 11:11 ` [PATCH v2 03/15] dt-bindings: leds: mt6370: Add Mediatek mt6370 current sink type LED indicator ChiaEn Wu
2022-06-16 21:09 ` Krzysztof Kozlowski
2022-06-20 3:07 ` szuni chen
2022-06-21 12:03 ` Krzysztof Kozlowski
2022-06-13 11:11 ` [PATCH v2 04/15] dt-bindings: leds: Add Mediatek MT6370 flashlight ChiaEn Wu
2022-06-16 21:10 ` Krzysztof Kozlowski
2022-06-13 11:11 ` [PATCH v2 05/15] dt-bindings: backlight: Add Mediatek MT6370 backlight ChiaEn Wu
2022-06-16 21:13 ` Krzysztof Kozlowski
2022-06-17 10:35 ` ChiaEn Wu
2022-06-17 23:13 ` Krzysztof Kozlowski
2022-06-13 11:11 ` [PATCH v2 06/15] dt-bindings: mfd: Add Mediatek MT6370 ChiaEn Wu
2022-06-13 13:33 ` Rob Herring
2022-06-17 11:15 ` ChiaEn Wu
2022-06-17 22:43 ` Rob Herring
2022-06-16 21:15 ` Krzysztof Kozlowski
2022-06-17 11:26 ` ChiaEn Wu
2022-06-13 11:11 ` [PATCH v2 07/15] Documentation: ABI: testing: mt6370: Add ADC sysfs guideline ChiaEn Wu
2022-06-18 15:48 ` Jonathan Cameron
2022-06-20 6:00 ` ChiaEn Wu
2022-06-20 18:35 ` Jonathan Cameron
2022-06-21 2:42 ` ChiaEn Wu
2022-06-13 11:11 ` [PATCH v2 08/15] mfd: mt6370: Add Mediatek MT6370 support ChiaEn Wu
2022-06-13 20:14 ` Randy Dunlap
2022-06-15 22:49 ` Lee Jones
2022-06-17 17:15 ` ChiaEn Wu
2022-06-27 14:14 ` Lee Jones
2022-06-27 15:35 ` ChiaEn Wu
2022-06-27 16:28 ` Lee Jones
2022-06-18 15:55 ` Jonathan Cameron [this message]
2022-06-13 11:11 ` [PATCH v2 09/15] usb: typec: tcpci_mt6370: Add Mediatek MT6370 tcpci driver ChiaEn Wu
2022-06-13 11:11 ` [PATCH v2 10/15] regulator: mt6370: Add mt6370 DisplayBias and VibLDO support ChiaEn Wu
2022-06-13 20:15 ` Randy Dunlap
2022-06-17 9:06 ` ChiaEn Wu
2022-06-13 11:11 ` [PATCH v2 11/15] iio: adc: mt6370: Add Mediatek MT6370 support ChiaEn Wu
2022-06-13 20:17 ` Randy Dunlap
2022-06-17 9:15 ` ChiaEn Wu
2022-06-18 16:09 ` Jonathan Cameron
2022-06-13 11:11 ` [PATCH v2 12/15] power: supply: mt6370: Add Mediatek MT6370 charger driver ChiaEn Wu
2022-06-13 11:11 ` [PATCH v2 13/15] leds: mt6370: Add Mediatek MT6370 current sink type LED Indicator support ChiaEn Wu
2022-06-13 20:20 ` Randy Dunlap
2022-06-13 11:11 ` [PATCH v2 14/15] leds: flashlight: mt6370: Add Mediatek MT6370 flashlight support ChiaEn Wu
2022-06-13 11:11 ` [PATCH v2 15/15] video: backlight: mt6370: Add Mediatek MT6370 support ChiaEn Wu
2022-06-13 17:08 ` Daniel Thompson
2022-06-17 9:34 ` ChiaEn Wu
2022-06-13 20:21 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220618165533.5669e288@jic23-huawei \
--to=jic23@kernel.org \
--cc=cy_huang@richtek.com \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=pavel@ucw.cz \
--cc=peterwu.pub@gmail.com \
--cc=robh+dt@kernel.org \
--cc=szunichen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).