From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: ChiaEn Wu <peterwu.pub@gmail.com>
Cc: jic23@kernel.org, lars@metafoo.de, matthias.bgg@gmail.com,
lee.jones@linaro.org,
Daniel Thompson <daniel.thompson@linaro.org>,
jingoohan1@gmail.com, pavel@ucw.cz, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-iio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org,
szunichen@gmail.com, ChiaEn Wu <chiaen_wu@richtek.com>
Subject: Re: [PATCH v2 02/15] dt-bindings: power: supply: Add Mediatek MT6370 Charger
Date: Fri, 17 Jun 2022 16:12:01 -0700 [thread overview]
Message-ID: <b59237c7-fb60-35e2-66f9-668d9946bd3c@linaro.org> (raw)
In-Reply-To: <CABtFH5+5Y5Tq3vO6Sg3kf98CWm9Aijv7qkdBcpm2SB0JZ1gCiA@mail.gmail.com>
On 17/06/2022 03:19, ChiaEn Wu wrote:
> Hi Krzysztof,
>
> Thanks for your helpful comments! I have so some questions want to ask
> you below.
>
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> 於 2022年6月17日 週五 清晨5:05寫道:
>>
>> On 13/06/2022 04:11, ChiaEn Wu wrote:
>>> From: ChiaEn Wu <chiaen_wu@richtek.com>
>>>
>>> Add Mediatek MT6370 Charger binding documentation.
>>>
>>> Signed-off-by: ChiaEn Wu <chiaen_wu@richtek.com>
>>> ---
>>> .../power/supply/mediatek,mt6370-charger.yaml | 60 +++++++++++++++++++
>>> 1 file changed, 60 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml b/Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml
>>> new file mode 100644
>>> index 000000000000..b63553ebb15b
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml
>>> @@ -0,0 +1,60 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/power/supply/mediatek,mt6370-charger.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Mediatek MT6370 Battery Charger
>>> +
>>> +maintainers:
>>> + - ChiaEn Wu <chiaen_wu@richtek.com>
>>> +
>>> +description: |
>>> + This module is part of the MT6370 MFD device.
>>> + Provides Battery Charger, Boost for OTG devices and BC1.2 detection.
>>> +
>>> +properties:
>>> + compatible:
>>> + const: mediatek,mt6370-charger
>>> +
>>> + interrupts:
>>> + description: |
>>> + Specify what irqs are needed to be handled by MT6370 Charger driver. IRQ
>>> + "MT6370_IRQ_CHG_MIVR", "MT6370_IRQ_ATTACH" and "MT6370_IRQ_OVPCTRL_UVP_D"
>>> + are required.
>>> + items:
>>> + - description: BC1.2 done irq
>>> + - description: usb plug in irq
>>> + - description: mivr irq
>>> +
>>> + interrupt-names:
>>> + items:
>>> + - const: attach_i
>>> + - const: uvp_d_evt
>>> + - const: mivr
>>> +
>>> + io-channels:
>>> + description: |
>>> + Use ADC channel to read vbus, ibus, ibat, etc., info. Ibus ADC channel
>>> + is required.
>>
>> Add io-channel-names and describe each item - what type of ADC it is
>> expected to be.
>>
>
> I'm afraid I might not be understanding what you mean.
> I will try to add some text in "description" and "io-channel-names", like below
> ----------------------------------
> io-channels:
> description: |
> Use ADC channel to read VBUS, IBUS, IBAT, etc., info. Ibus ADC channel
> is required. It can be seen in
> include/dt-bindings/iio/adc/mediatek,mt6370_adc.h
> minItems: 1
> maxItems: 9
>
> io-channel-names:
> items:
> - const: vbusdiv5
> - const: vbusdiv2
Almost. The best would be something like this:
Documentation/devicetree/bindings/power/supply/cpcap-charger.yaml
so also "items" with description under "io-channels". You need to skip
maxItems in such case (keep minItems).
> - ...
> ----------------------------------
> Did these modifications meet your expectations?
>
>>> + minItems: 1
>>> + maxItems: 9
>>> +
>>> + usb-otg-vbus-regulator:
>>> + type: object
>>> + description: OTG boost regulator.
>>> + $ref: /schemas/regulator/regulator.yaml#
>>
>> unevaluatedProperties: false
>
> I will add this in the next patch.
>
>>
>>> +
>>> + properties:
>>> + enable-gpio:
>>
>> "gpios", so:
>> enable-gpios
>
> If this otg regulator only uses one GPIO Pin, do I still need to
> change to "gpios"?
Yes, because "gpios" is the preferred suffix. This is requirement for
all such properties. enable-gpios are also documented here:
Documentation/devicetree/bindings/gpio/gpio-consumer-common.yaml
> If so, I will refine it along with the regulator "enable-gpio" in MFD
> dt-binding.
Yes, there it should be "enable-gpios" as well.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-06-17 23:12 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-13 11:11 [PATCH v2 00/15] Add Mediatek MT6370 PMIC support ChiaEn Wu
2022-06-13 11:11 ` [PATCH v2 01/15] dt-bindings: usb: Add Mediatek MT6370 TCPC ChiaEn Wu
2022-06-16 21:06 ` Krzysztof Kozlowski
2022-06-13 11:11 ` [PATCH v2 02/15] dt-bindings: power: supply: Add Mediatek MT6370 Charger ChiaEn Wu
2022-06-16 21:05 ` Krzysztof Kozlowski
2022-06-17 10:19 ` ChiaEn Wu
2022-06-17 23:12 ` Krzysztof Kozlowski [this message]
2022-06-13 11:11 ` [PATCH v2 03/15] dt-bindings: leds: mt6370: Add Mediatek mt6370 current sink type LED indicator ChiaEn Wu
2022-06-16 21:09 ` Krzysztof Kozlowski
2022-06-20 3:07 ` szuni chen
2022-06-21 12:03 ` Krzysztof Kozlowski
2022-06-13 11:11 ` [PATCH v2 04/15] dt-bindings: leds: Add Mediatek MT6370 flashlight ChiaEn Wu
2022-06-16 21:10 ` Krzysztof Kozlowski
2022-06-13 11:11 ` [PATCH v2 05/15] dt-bindings: backlight: Add Mediatek MT6370 backlight ChiaEn Wu
2022-06-16 21:13 ` Krzysztof Kozlowski
2022-06-17 10:35 ` ChiaEn Wu
2022-06-17 23:13 ` Krzysztof Kozlowski
2022-06-13 11:11 ` [PATCH v2 06/15] dt-bindings: mfd: Add Mediatek MT6370 ChiaEn Wu
2022-06-13 13:33 ` Rob Herring
2022-06-17 11:15 ` ChiaEn Wu
2022-06-17 22:43 ` Rob Herring
2022-06-16 21:15 ` Krzysztof Kozlowski
2022-06-17 11:26 ` ChiaEn Wu
2022-06-13 11:11 ` [PATCH v2 07/15] Documentation: ABI: testing: mt6370: Add ADC sysfs guideline ChiaEn Wu
2022-06-18 15:48 ` Jonathan Cameron
2022-06-20 6:00 ` ChiaEn Wu
2022-06-20 18:35 ` Jonathan Cameron
2022-06-21 2:42 ` ChiaEn Wu
2022-06-13 11:11 ` [PATCH v2 08/15] mfd: mt6370: Add Mediatek MT6370 support ChiaEn Wu
2022-06-13 20:14 ` Randy Dunlap
2022-06-15 22:49 ` Lee Jones
2022-06-17 17:15 ` ChiaEn Wu
2022-06-27 14:14 ` Lee Jones
2022-06-27 15:35 ` ChiaEn Wu
2022-06-27 16:28 ` Lee Jones
2022-06-18 15:55 ` Jonathan Cameron
2022-06-13 11:11 ` [PATCH v2 09/15] usb: typec: tcpci_mt6370: Add Mediatek MT6370 tcpci driver ChiaEn Wu
2022-06-13 11:11 ` [PATCH v2 10/15] regulator: mt6370: Add mt6370 DisplayBias and VibLDO support ChiaEn Wu
2022-06-13 20:15 ` Randy Dunlap
2022-06-17 9:06 ` ChiaEn Wu
2022-06-13 11:11 ` [PATCH v2 11/15] iio: adc: mt6370: Add Mediatek MT6370 support ChiaEn Wu
2022-06-13 20:17 ` Randy Dunlap
2022-06-17 9:15 ` ChiaEn Wu
2022-06-18 16:09 ` Jonathan Cameron
2022-06-13 11:11 ` [PATCH v2 12/15] power: supply: mt6370: Add Mediatek MT6370 charger driver ChiaEn Wu
2022-06-13 11:11 ` [PATCH v2 13/15] leds: mt6370: Add Mediatek MT6370 current sink type LED Indicator support ChiaEn Wu
2022-06-13 20:20 ` Randy Dunlap
2022-06-13 11:11 ` [PATCH v2 14/15] leds: flashlight: mt6370: Add Mediatek MT6370 flashlight support ChiaEn Wu
2022-06-13 11:11 ` [PATCH v2 15/15] video: backlight: mt6370: Add Mediatek MT6370 support ChiaEn Wu
2022-06-13 17:08 ` Daniel Thompson
2022-06-17 9:34 ` ChiaEn Wu
2022-06-13 20:21 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b59237c7-fb60-35e2-66f9-668d9946bd3c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=chiaen_wu@richtek.com \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jic23@kernel.org \
--cc=jingoohan1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=pavel@ucw.cz \
--cc=peterwu.pub@gmail.com \
--cc=robh+dt@kernel.org \
--cc=szunichen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).