linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: ChiaEn Wu <peterwu.pub@gmail.com>
Cc: jic23@kernel.org, lars@metafoo.de, matthias.bgg@gmail.com,
	lee.jones@linaro.org,
	Daniel Thompson <daniel.thompson@linaro.org>,
	jingoohan1@gmail.com, pavel@ucw.cz, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, linux-iio@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org,
	devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org,
	szunichen@gmail.com, ChiYuan Huang <cy_huang@richtek.com>
Subject: Re: [PATCH v2 05/15] dt-bindings: backlight: Add Mediatek MT6370 backlight
Date: Fri, 17 Jun 2022 16:13:42 -0700	[thread overview]
Message-ID: <9b567f78-e12b-d665-2f11-96436fe9ed08@linaro.org> (raw)
In-Reply-To: <CABtFH5KhijZDRA+K=stpOV0t8K3cqCMoLXpLShcdm9F8emrKCA@mail.gmail.com>

On 17/06/2022 03:35, ChiaEn Wu wrote:
> +        - 3: 6
>>
>> Nope, I said last time:
>> "In any case you cannot have values mapping"
>>
>> Please use proper real world value, not some register bits. The property
>> name also needs fixing.
> 
> I so apologized for misunderstanding your meaning...
> I try to modify it like below.
> --------
> mediatek,bled-pwm-hys-input-threshold-steps:
>   $ref: /schemas/types.yaml#/definitions/uint8
>   enum: [1, 4, 16, 64]
>   description: |
>     The selection of the upper and lower bounds threshold of backlight
>     PWM resolution. If we choose selection 64, the variation of PWM
>     resolution needs over 64 steps.
> --------
> If these changes meet your expectations, I will try to modify
> "bled-ovp-microvolt" and "bled-ocp-microamp" in the same way.
> Thank you so much.
> 

This looks good. Thank you.


Best regards,
Krzysztof

  reply	other threads:[~2022-06-17 23:15 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-13 11:11 [PATCH v2 00/15] Add Mediatek MT6370 PMIC support ChiaEn Wu
2022-06-13 11:11 ` [PATCH v2 01/15] dt-bindings: usb: Add Mediatek MT6370 TCPC ChiaEn Wu
2022-06-16 21:06   ` Krzysztof Kozlowski
2022-06-13 11:11 ` [PATCH v2 02/15] dt-bindings: power: supply: Add Mediatek MT6370 Charger ChiaEn Wu
2022-06-16 21:05   ` Krzysztof Kozlowski
2022-06-17 10:19     ` ChiaEn Wu
2022-06-17 23:12       ` Krzysztof Kozlowski
2022-06-13 11:11 ` [PATCH v2 03/15] dt-bindings: leds: mt6370: Add Mediatek mt6370 current sink type LED indicator ChiaEn Wu
2022-06-16 21:09   ` Krzysztof Kozlowski
2022-06-20  3:07     ` szuni chen
2022-06-21 12:03       ` Krzysztof Kozlowski
2022-06-13 11:11 ` [PATCH v2 04/15] dt-bindings: leds: Add Mediatek MT6370 flashlight ChiaEn Wu
2022-06-16 21:10   ` Krzysztof Kozlowski
2022-06-13 11:11 ` [PATCH v2 05/15] dt-bindings: backlight: Add Mediatek MT6370 backlight ChiaEn Wu
2022-06-16 21:13   ` Krzysztof Kozlowski
2022-06-17 10:35     ` ChiaEn Wu
2022-06-17 23:13       ` Krzysztof Kozlowski [this message]
2022-06-13 11:11 ` [PATCH v2 06/15] dt-bindings: mfd: Add Mediatek MT6370 ChiaEn Wu
2022-06-13 13:33   ` Rob Herring
2022-06-17 11:15     ` ChiaEn Wu
2022-06-17 22:43       ` Rob Herring
2022-06-16 21:15   ` Krzysztof Kozlowski
2022-06-17 11:26     ` ChiaEn Wu
2022-06-13 11:11 ` [PATCH v2 07/15] Documentation: ABI: testing: mt6370: Add ADC sysfs guideline ChiaEn Wu
2022-06-18 15:48   ` Jonathan Cameron
2022-06-20  6:00     ` ChiaEn Wu
2022-06-20 18:35       ` Jonathan Cameron
2022-06-21  2:42         ` ChiaEn Wu
2022-06-13 11:11 ` [PATCH v2 08/15] mfd: mt6370: Add Mediatek MT6370 support ChiaEn Wu
2022-06-13 20:14   ` Randy Dunlap
2022-06-15 22:49   ` Lee Jones
2022-06-17 17:15     ` ChiaEn Wu
2022-06-27 14:14       ` Lee Jones
2022-06-27 15:35         ` ChiaEn Wu
2022-06-27 16:28           ` Lee Jones
2022-06-18 15:55   ` Jonathan Cameron
2022-06-13 11:11 ` [PATCH v2 09/15] usb: typec: tcpci_mt6370: Add Mediatek MT6370 tcpci driver ChiaEn Wu
2022-06-13 11:11 ` [PATCH v2 10/15] regulator: mt6370: Add mt6370 DisplayBias and VibLDO support ChiaEn Wu
2022-06-13 20:15   ` Randy Dunlap
2022-06-17  9:06     ` ChiaEn Wu
2022-06-13 11:11 ` [PATCH v2 11/15] iio: adc: mt6370: Add Mediatek MT6370 support ChiaEn Wu
2022-06-13 20:17   ` Randy Dunlap
2022-06-17  9:15     ` ChiaEn Wu
2022-06-18 16:09   ` Jonathan Cameron
2022-06-13 11:11 ` [PATCH v2 12/15] power: supply: mt6370: Add Mediatek MT6370 charger driver ChiaEn Wu
2022-06-13 11:11 ` [PATCH v2 13/15] leds: mt6370: Add Mediatek MT6370 current sink type LED Indicator support ChiaEn Wu
2022-06-13 20:20   ` Randy Dunlap
2022-06-13 11:11 ` [PATCH v2 14/15] leds: flashlight: mt6370: Add Mediatek MT6370 flashlight support ChiaEn Wu
2022-06-13 11:11 ` [PATCH v2 15/15] video: backlight: mt6370: Add Mediatek MT6370 support ChiaEn Wu
2022-06-13 17:08   ` Daniel Thompson
2022-06-17  9:34     ` ChiaEn Wu
2022-06-13 20:21   ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9b567f78-e12b-d665-2f11-96436fe9ed08@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=cy_huang@richtek.com \
    --cc=daniel.thompson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jic23@kernel.org \
    --cc=jingoohan1@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lars@metafoo.de \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=pavel@ucw.cz \
    --cc=peterwu.pub@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=szunichen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).