From: Mikko Perttunen <mikko.perttunen@kapsi.fi>
To: Thierry Reding <thierry.reding@gmail.com>,
Mikko Perttunen <cyndis@kapsi.fi>
Cc: edubezval@gmail.com, swarren@wwwdotorg.org,
linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, juha-matti.tilli@iki.fi
Subject: Re: [PATCH v6 0/4] Tegra124 soctherm driver
Date: Fri, 26 Sep 2014 13:22:52 +0300 [thread overview]
Message-ID: <54253E7C.9080704@kapsi.fi> (raw)
In-Reply-To: <20140926101918.GM31106@ulmo>
On 09/26/2014 01:19 PM, Thierry Reding wrote:
> On Fri, Sep 26, 2014 at 12:43:09PM +0300, Mikko Perttunen wrote:
>> Hi,
>>
>> this series adds support for the thermal monitoring features of the
>> soctherm unit on the Tegra124 SoC.
>>
>> The branch is also available in my github repo,
>> git://github.com/cyndis/linux.git soctherm-v6
>>
>> Thanks,
>> Mikko
>>
>> Mikko Perttunen (4):
>> of: Add bindings for nvidia,tegra124-soctherm
>> ARM: tegra: Add soctherm and thermal zones to Tegra124 device tree
>> ARM: tegra: Add thermal trip points for Jetson TK1
>> thermal: Add Tegra SOCTHERM thermal management driver
>>
>> .../devicetree/bindings/thermal/tegra-soctherm.txt | 53 +++
>> arch/arm/boot/dts/tegra124-jetson-tk1.dts | 44 ++
>> arch/arm/boot/dts/tegra124.dtsi | 47 ++
>> drivers/thermal/Kconfig | 10 +
>> drivers/thermal/Makefile | 1 +
>> drivers/thermal/tegra_soctherm.c | 471 +++++++++++++++++++++
>> include/dt-bindings/thermal/tegra124-soctherm.h | 13 +
>> 7 files changed, 639 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/thermal/tegra-soctherm.txt
>> create mode 100644 drivers/thermal/tegra_soctherm.c
>> create mode 100644 include/dt-bindings/thermal/tegra124-soctherm.h
>
> One thing that I've wanted to start doing for a while now is request
> patch submissions like this to come accompanied with a way on how to
> test them. Ideally this would be in a scripted way that can test for
> success programatically, but it doesn't necessarily have to be if it
> turns out too difficult or impractical to do.
Indeed, that would be very useful.
>
> The goal is to eventually come up with a test suite that can run the
> majority of test cases automatically to make it easy to test for any
> regressions. And even if tests can't be run automatically it'd still
> be an advantage to have them all collected in some repository, since
> it saves a lot of typing and time to run tests, and it will give us
> a standard set of tests that everybody can verify changes against.
>
> I realize that it's somewhat unfair to start requesting this from you
> now, but we've got to start somewhere. Could you give a short summary
> of how you test this? What are the interfaces that the kernel exposes
> for these thermal drivers?
You need to enable the driver in Device Drivers -> Generic Thermal sysfs
driver -> Tegra SOCTHERM thermal management. Then, you should see
directories appear in /sys/class/thermal. You can also use the `tmon'
tool included in the kernel tree to quickly see values; that's what I
use for testing.
>
> Thierry
>
Mikko
next prev parent reply other threads:[~2014-09-26 10:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 9:43 [PATCH v6 0/4] Tegra124 soctherm driver Mikko Perttunen
[not found] ` <1411724593-4037-1-git-send-email-cyndis-/1wQRMveznE@public.gmane.org>
2014-09-26 9:43 ` [PATCH v6 1/4] of: Add bindings for nvidia,tegra124-soctherm Mikko Perttunen
2014-09-26 9:43 ` [PATCH v6 2/4] ARM: tegra: Add soctherm and thermal zones to Tegra124 device tree Mikko Perttunen
2014-09-26 9:43 ` [PATCH v6 3/4] ARM: tegra: Add thermal trip points for Jetson TK1 Mikko Perttunen
2014-09-26 9:43 ` [PATCH v6 4/4] thermal: Add Tegra SOCTHERM thermal management driver Mikko Perttunen
2014-09-26 11:45 ` Thierry Reding
2014-09-26 20:28 ` Mikko Perttunen
2014-09-27 12:06 ` Juha-Matti Tilli
[not found] ` <20140927120649.GA70809-Xv4IVSKz7SWQi9Q/X01l6/UpdFzICT1y@public.gmane.org>
2014-09-29 13:42 ` Mikko Perttunen
2014-09-29 8:14 ` Peter De Schrijver
[not found] ` <5425CC6F.2020309-/1wQRMveznE@public.gmane.org>
2014-09-29 8:29 ` Thierry Reding
2014-09-29 13:37 ` Mikko Perttunen
2014-09-29 14:17 ` [PATCH v7 " Mikko Perttunen
2014-10-15 10:05 ` Mikko Perttunen
[not found] ` <543E46DF.8060705-/1wQRMveznE@public.gmane.org>
2014-11-07 15:54 ` Eduardo Valentin
2014-11-08 1:11 ` Mikko Perttunen
2014-09-26 10:19 ` [PATCH v6 0/4] Tegra124 soctherm driver Thierry Reding
2014-09-26 10:22 ` Mikko Perttunen [this message]
[not found] ` <54253E7C.9080704-/1wQRMveznE@public.gmane.org>
2014-09-26 11:48 ` Thierry Reding
2014-09-26 12:00 ` Mikko Perttunen
[not found] ` <5425554B.7060102-/1wQRMveznE@public.gmane.org>
2014-09-26 12:05 ` Thierry Reding
2014-09-26 12:09 ` Mikko Perttunen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54253E7C.9080704@kapsi.fi \
--to=mikko.perttunen@kapsi.fi \
--cc=cyndis@kapsi.fi \
--cc=edubezval@gmail.com \
--cc=juha-matti.tilli@iki.fi \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).