From: Mikko Perttunen <mikko.perttunen@kapsi.fi>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Mikko Perttunen <cyndis@kapsi.fi>,
edubezval@gmail.com, swarren@wwwdotorg.org,
linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, juha-matti.tilli@iki.fi,
Mikko Perttunen <mperttunen@nvidia.com>
Subject: Re: [PATCH v6 4/4] thermal: Add Tegra SOCTHERM thermal management driver
Date: Mon, 29 Sep 2014 16:37:54 +0300 [thread overview]
Message-ID: <542960B2.1010200@kapsi.fi> (raw)
In-Reply-To: <20140929082904.GF12506@ulmo>
On 09/29/2014 11:29 AM, Thierry Reding wrote:
> On Fri, Sep 26, 2014 at 11:28:31PM +0300, Mikko Perttunen wrote:
>> On 09/26/2014 02:45 PM, Thierry Reding wrote:
> [...]
>>> I think a more idiomatic way to write this would be:
>>>
>>> static int
>>> calculate_tsensor_calibration(const struct tegra_tsensor *sensor,
>>> struct tsensor_shared_calibration shared,
>>> u32 *calib)
>>
>> If I do that, it will go over the 80 character limit by quite a few
>> characters, which is why I didn't use that style. Personally I'm fine with
>> either style.
>
> The above doesn't exceed the 80 character limit. Putting the return
> value and the static keyword on a separate line is a pretty common way
> to reduce line length.
Good point, I didn't think of doing that. I usually never use the above
style, but clearly here it is the best choice.
>
>>>
>>> While at it, perhaps make shared a const * instead of passing it in by
>>> value?
>>
>> That is possible, but I'm not sure what the difference would be. Is there a
>> style rule forbidding by-value compound types? (Also if I change the style,
>> it would go over 80 characters by even more.)
>
> No it doesn't. The below fits within 80 characters per line just fine:
>
> static int
> calculate_tsensor_calibration(const struct tegra_tsensor *sensor,
> const struct tsensor_shared_calibration *shared,
> u32 *calib)
>
> Thierry
>
next prev parent reply other threads:[~2014-09-29 13:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 9:43 [PATCH v6 0/4] Tegra124 soctherm driver Mikko Perttunen
[not found] ` <1411724593-4037-1-git-send-email-cyndis-/1wQRMveznE@public.gmane.org>
2014-09-26 9:43 ` [PATCH v6 1/4] of: Add bindings for nvidia,tegra124-soctherm Mikko Perttunen
2014-09-26 9:43 ` [PATCH v6 2/4] ARM: tegra: Add soctherm and thermal zones to Tegra124 device tree Mikko Perttunen
2014-09-26 9:43 ` [PATCH v6 3/4] ARM: tegra: Add thermal trip points for Jetson TK1 Mikko Perttunen
2014-09-26 9:43 ` [PATCH v6 4/4] thermal: Add Tegra SOCTHERM thermal management driver Mikko Perttunen
2014-09-26 11:45 ` Thierry Reding
2014-09-26 20:28 ` Mikko Perttunen
2014-09-27 12:06 ` Juha-Matti Tilli
[not found] ` <20140927120649.GA70809-Xv4IVSKz7SWQi9Q/X01l6/UpdFzICT1y@public.gmane.org>
2014-09-29 13:42 ` Mikko Perttunen
2014-09-29 8:14 ` Peter De Schrijver
[not found] ` <5425CC6F.2020309-/1wQRMveznE@public.gmane.org>
2014-09-29 8:29 ` Thierry Reding
2014-09-29 13:37 ` Mikko Perttunen [this message]
2014-09-29 14:17 ` [PATCH v7 " Mikko Perttunen
2014-10-15 10:05 ` Mikko Perttunen
[not found] ` <543E46DF.8060705-/1wQRMveznE@public.gmane.org>
2014-11-07 15:54 ` Eduardo Valentin
2014-11-08 1:11 ` Mikko Perttunen
2014-09-26 10:19 ` [PATCH v6 0/4] Tegra124 soctherm driver Thierry Reding
2014-09-26 10:22 ` Mikko Perttunen
[not found] ` <54253E7C.9080704-/1wQRMveznE@public.gmane.org>
2014-09-26 11:48 ` Thierry Reding
2014-09-26 12:00 ` Mikko Perttunen
[not found] ` <5425554B.7060102-/1wQRMveznE@public.gmane.org>
2014-09-26 12:05 ` Thierry Reding
2014-09-26 12:09 ` Mikko Perttunen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542960B2.1010200@kapsi.fi \
--to=mikko.perttunen@kapsi.fi \
--cc=cyndis@kapsi.fi \
--cc=edubezval@gmail.com \
--cc=juha-matti.tilli@iki.fi \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).