* [PATCH -next] power: supply: mt6370: Fix Kconfig dependency
@ 2022-09-22 2:33 Ren Zhijie
2022-09-22 9:58 ` ChiaEn Wu
0 siblings, 1 reply; 4+ messages in thread
From: Ren Zhijie @ 2022-09-22 2:33 UTC (permalink / raw)
To: sre, andy.shevchenko, chiaen_wu; +Cc: linux-pm, linux-kernel, Ren Zhijie
If CONFIG_IIO is not set,
make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-,
will be failed, like this:
drivers/power/supply/mt6370-charger.o: In function `mt6370_chg_mivr_dwork_func':
mt6370-charger.c:(.text+0x670): undefined reference to `iio_read_channel_processed'
drivers/power/supply/mt6370-charger.o: In function `mt6370_chg_probe':
mt6370-charger.c:(.text+0xb43): undefined reference to `devm_iio_channel_get_all'
make: *** [vmlinux] Error 1
To fix this build error, add depends on IIO to config CHARGER_MT6370 dependency.
Fixes: 233cb8a47d65 ("power: supply: mt6370: Add MediaTek MT6370 charger driver")
Signed-off-by: Ren Zhijie <renzhijie2@huawei.com>
---
drivers/power/supply/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
index 591deb82e2c6..62111f4bb093 100644
--- a/drivers/power/supply/Kconfig
+++ b/drivers/power/supply/Kconfig
@@ -623,6 +623,7 @@ config CHARGER_MT6370
tristate "MediaTek MT6370 Charger Driver"
depends on MFD_MT6370
depends on REGULATOR
+ depends on IIO
select LINEAR_RANGES
help
Say Y here to enable MT6370 Charger Part.
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH -next] power: supply: mt6370: Fix Kconfig dependency
2022-09-22 2:33 [PATCH -next] power: supply: mt6370: Fix Kconfig dependency Ren Zhijie
@ 2022-09-22 9:58 ` ChiaEn Wu
2022-10-09 13:34 ` Ren Zhijie
0 siblings, 1 reply; 4+ messages in thread
From: ChiaEn Wu @ 2022-09-22 9:58 UTC (permalink / raw)
To: Ren Zhijie, sre, andy.shevchenko, chiaen_wu; +Cc: linux-pm, linux-kernel
On 9/22/2022 10:33 AM, Ren Zhijie wrote:
> If CONFIG_IIO is not set,
> make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-,
> will be failed, like this:
>
> drivers/power/supply/mt6370-charger.o: In function `mt6370_chg_mivr_dwork_func':
> mt6370-charger.c:(.text+0x670): undefined reference to `iio_read_channel_processed'
> drivers/power/supply/mt6370-charger.o: In function `mt6370_chg_probe':
> mt6370-charger.c:(.text+0xb43): undefined reference to `devm_iio_channel_get_all'
> make: *** [vmlinux] Error 1
>
> To fix this build error, add depends on IIO to config CHARGER_MT6370 dependency.
>
> Fixes: 233cb8a47d65 ("power: supply: mt6370: Add MediaTek MT6370 charger driver")
> Signed-off-by: Ren Zhijie <renzhijie2@huawei.com>
> ---
> drivers/power/supply/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
> index 591deb82e2c6..62111f4bb093 100644
> --- a/drivers/power/supply/Kconfig
> +++ b/drivers/power/supply/Kconfig
> @@ -623,6 +623,7 @@ config CHARGER_MT6370
> tristate "MediaTek MT6370 Charger Driver"
> depends on MFD_MT6370
> depends on REGULATOR
> + depends on IIO
> select LINEAR_RANGES
> help
> Say Y here to enable MT6370 Charger Part.
Hi Ren,
Thanks for catching this!
Reviewed-by: ChiaEn Wu <chiaen_wu@richtek.com>
--
Best Regards,
ChiaEn Wu
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] power: supply: mt6370: Fix Kconfig dependency
2022-09-22 9:58 ` ChiaEn Wu
@ 2022-10-09 13:34 ` Ren Zhijie
2022-10-11 2:02 ` ChiaEn Wu
0 siblings, 1 reply; 4+ messages in thread
From: Ren Zhijie @ 2022-10-09 13:34 UTC (permalink / raw)
To: ChiaEn Wu, sre, andy.shevchenko, chiaen_wu; +Cc: linux-pm, linux-kernel
Hi,
just a friendly ping...
Ren
在 2022/9/22 17:58, ChiaEn Wu 写道:
> On 9/22/2022 10:33 AM, Ren Zhijie wrote:
>> If CONFIG_IIO is not set,
>> make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-,
>> will be failed, like this:
>>
>> drivers/power/supply/mt6370-charger.o: In function
>> `mt6370_chg_mivr_dwork_func':
>> mt6370-charger.c:(.text+0x670): undefined reference to
>> `iio_read_channel_processed'
>> drivers/power/supply/mt6370-charger.o: In function `mt6370_chg_probe':
>> mt6370-charger.c:(.text+0xb43): undefined reference to
>> `devm_iio_channel_get_all'
>> make: *** [vmlinux] Error 1
>>
>> To fix this build error, add depends on IIO to config CHARGER_MT6370
>> dependency.
>>
>> Fixes: 233cb8a47d65 ("power: supply: mt6370: Add MediaTek MT6370
>> charger driver")
>> Signed-off-by: Ren Zhijie <renzhijie2@huawei.com>
>> ---
>> drivers/power/supply/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
>> index 591deb82e2c6..62111f4bb093 100644
>> --- a/drivers/power/supply/Kconfig
>> +++ b/drivers/power/supply/Kconfig
>> @@ -623,6 +623,7 @@ config CHARGER_MT6370
>> tristate "MediaTek MT6370 Charger Driver"
>> depends on MFD_MT6370
>> depends on REGULATOR
>> + depends on IIO
>> select LINEAR_RANGES
>> help
>> Say Y here to enable MT6370 Charger Part.
>
> Hi Ren,
>
> Thanks for catching this!
>
> Reviewed-by: ChiaEn Wu <chiaen_wu@richtek.com>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] power: supply: mt6370: Fix Kconfig dependency
2022-10-09 13:34 ` Ren Zhijie
@ 2022-10-11 2:02 ` ChiaEn Wu
0 siblings, 0 replies; 4+ messages in thread
From: ChiaEn Wu @ 2022-10-11 2:02 UTC (permalink / raw)
To: Ren Zhijie; +Cc: sre, andy.shevchenko, chiaen_wu, linux-pm, linux-kernel
On Sun, Oct 9, 2022 at 9:34 PM Ren Zhijie <renzhijie2@huawei.com> wrote:
...
> >> diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
> >> index 591deb82e2c6..62111f4bb093 100644
> >> --- a/drivers/power/supply/Kconfig
> >> +++ b/drivers/power/supply/Kconfig
> >> @@ -623,6 +623,7 @@ config CHARGER_MT6370
> >> tristate "MediaTek MT6370 Charger Driver"
> >> depends on MFD_MT6370
> >> depends on REGULATOR
> >> + depends on IIO
> >> select LINEAR_RANGES
> >> help
> >> Say Y here to enable MT6370 Charger Part.
> >
> > Hi Ren,
> >
> > Thanks for catching this!
> >
> > Reviewed-by: ChiaEn Wu <chiaen_wu@richtek.com>
> >
Hi Ren,
There is the same patch that Sebastian already applies.
(https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git/commit/?h=for-next&id=d8be4fe92433ad905eedc7d877099685eb2eaaa1)
Thanks.
--
Best Regards,
ChiaEn Wu
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-11 2:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-22 2:33 [PATCH -next] power: supply: mt6370: Fix Kconfig dependency Ren Zhijie
2022-09-22 9:58 ` ChiaEn Wu
2022-10-09 13:34 ` Ren Zhijie
2022-10-11 2:02 ` ChiaEn Wu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).