linux-ppp.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 00/12] net: constify struct device_type usage
@ 2024-02-17 20:13 Ricardo B. Marliere
  2024-02-17 20:13 ` [PATCH 01/12] net: usbnet: constify the " Ricardo B. Marliere
                   ` (12 more replies)
  0 siblings, 13 replies; 28+ messages in thread
From: Ricardo B. Marliere @ 2024-02-17 20:13 UTC (permalink / raw)
  To: Oliver Neukum, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Andrew Lunn, Florian Fainelli, Vladimir Oltean,
	Roopa Prabhu, Nikolay Aleksandrov, Loic Poulain, Sergey Ryazanov,
	Johannes Berg
  Cc: netdev, linux-usb, linux-kernel, bridge, linux-ppp,
	Greg Kroah-Hartman, Ricardo B. Marliere

This is a simple and straight forward cleanup series that makes all device
types in the net subsystem constants. This has been possible since 2011 [1]
but not all occurrences were cleaned. I have been sweeping the tree to fix
them all.

I was not sure if I should send these squashed, but there are quite a few
changes so I decided to send them separately. Please let me know if that is
not desirable.

---
[1] https://lore.kernel.org/all/1305850262-9575-5-git-send-email-gregkh@suse.de/

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>

---
Ricardo B. Marliere (12):
      net: usbnet: constify the struct device_type usage
      net: dsa: constify the struct device_type usage
      net: bridge: constify the struct device_type usage
      net: vxlan: constify the struct device_type usage
      net: ppp: constify the struct device_type usage
      net: geneve: constify the struct device_type usage
      net: hsr: constify the struct device_type usage
      net: l2tp: constify the struct device_type usage
      net: vlan: constify the struct device_type usage
      net: netdevsim: constify the struct device_type usage
      net: wwan: core: constify the struct device_type usage
      net: hso: constify the struct device_type usage

 drivers/net/geneve.c           | 2 +-
 drivers/net/netdevsim/bus.c    | 2 +-
 drivers/net/ppp/ppp_generic.c  | 2 +-
 drivers/net/usb/hso.c          | 2 +-
 drivers/net/usb/usbnet.c       | 4 ++--
 drivers/net/vxlan/vxlan_core.c | 2 +-
 drivers/net/wwan/wwan_core.c   | 2 +-
 net/8021q/vlan_dev.c           | 2 +-
 net/bridge/br_device.c         | 2 +-
 net/dsa/user.c                 | 2 +-
 net/hsr/hsr_device.c           | 2 +-
 net/l2tp/l2tp_eth.c            | 2 +-
 12 files changed, 13 insertions(+), 13 deletions(-)
---
base-commit: a6e0cb150c514efba4aaba4069927de43d80bb59
change-id: 20240217-device_cleanup-net-878960951968

Best regards,
-- 
Ricardo B. Marliere <ricardo@marliere.net>


^ permalink raw reply	[flat|nested] 28+ messages in thread

* [PATCH 01/12] net: usbnet: constify the struct device_type usage
  2024-02-17 20:13 [PATCH 00/12] net: constify struct device_type usage Ricardo B. Marliere
@ 2024-02-17 20:13 ` Ricardo B. Marliere
  2024-02-20 11:18   ` Simon Horman
  2024-02-17 20:13 ` [PATCH 02/12] net: dsa: " Ricardo B. Marliere
                   ` (11 subsequent siblings)
  12 siblings, 1 reply; 28+ messages in thread
From: Ricardo B. Marliere @ 2024-02-17 20:13 UTC (permalink / raw)
  To: Oliver Neukum, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Andrew Lunn, Florian Fainelli, Vladimir Oltean,
	Roopa Prabhu, Nikolay Aleksandrov, Loic Poulain, Sergey Ryazanov,
	Johannes Berg
  Cc: netdev, linux-usb, linux-kernel, bridge, linux-ppp,
	Greg Kroah-Hartman, Ricardo B. Marliere

Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
core can properly handle constant struct device_type. Move the wlan_type
and wwan_type variables to be constant structures as well, placing it into
read-only memory which can not be modified at runtime.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
---
 drivers/net/usb/usbnet.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index 2d14b0d78541..b21ebe24057f 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c
@@ -1654,11 +1654,11 @@ static const struct net_device_ops usbnet_netdev_ops = {
 
 // precondition: never called in_interrupt
 
-static struct device_type wlan_type = {
+static const struct device_type wlan_type = {
 	.name	= "wlan",
 };
 
-static struct device_type wwan_type = {
+static const struct device_type wwan_type = {
 	.name	= "wwan",
 };
 

-- 
2.43.0


^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [PATCH 02/12] net: dsa: constify the struct device_type usage
  2024-02-17 20:13 [PATCH 00/12] net: constify struct device_type usage Ricardo B. Marliere
  2024-02-17 20:13 ` [PATCH 01/12] net: usbnet: constify the " Ricardo B. Marliere
@ 2024-02-17 20:13 ` Ricardo B. Marliere
  2024-02-18 21:46   ` Florian Fainelli
  2024-02-17 20:13 ` [PATCH 03/12] net: bridge: " Ricardo B. Marliere
                   ` (10 subsequent siblings)
  12 siblings, 1 reply; 28+ messages in thread
From: Ricardo B. Marliere @ 2024-02-17 20:13 UTC (permalink / raw)
  To: Oliver Neukum, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Andrew Lunn, Florian Fainelli, Vladimir Oltean,
	Roopa Prabhu, Nikolay Aleksandrov, Loic Poulain, Sergey Ryazanov,
	Johannes Berg
  Cc: netdev, linux-usb, linux-kernel, bridge, linux-ppp,
	Greg Kroah-Hartman, Ricardo B. Marliere

Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
core can properly handle constant struct device_type. Move the dsa_type
variable to be a constant structure as well, placing it into read-only
memory which can not be modified at runtime.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
---
 net/dsa/user.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/dsa/user.c b/net/dsa/user.c
index 5d666dfb317d..4d53c76a9840 100644
--- a/net/dsa/user.c
+++ b/net/dsa/user.c
@@ -2429,7 +2429,7 @@ static const struct net_device_ops dsa_user_netdev_ops = {
 	.ndo_fill_forward_path	= dsa_user_fill_forward_path,
 };
 
-static struct device_type dsa_type = {
+static const struct device_type dsa_type = {
 	.name	= "dsa",
 };
 

-- 
2.43.0


^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [PATCH 03/12] net: bridge: constify the struct device_type usage
  2024-02-17 20:13 [PATCH 00/12] net: constify struct device_type usage Ricardo B. Marliere
  2024-02-17 20:13 ` [PATCH 01/12] net: usbnet: constify the " Ricardo B. Marliere
  2024-02-17 20:13 ` [PATCH 02/12] net: dsa: " Ricardo B. Marliere
@ 2024-02-17 20:13 ` Ricardo B. Marliere
  2024-02-20 11:20   ` Simon Horman
  2024-02-17 20:13 ` [PATCH 04/12] net: vxlan: " Ricardo B. Marliere
                   ` (9 subsequent siblings)
  12 siblings, 1 reply; 28+ messages in thread
From: Ricardo B. Marliere @ 2024-02-17 20:13 UTC (permalink / raw)
  To: Oliver Neukum, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Andrew Lunn, Florian Fainelli, Vladimir Oltean,
	Roopa Prabhu, Nikolay Aleksandrov, Loic Poulain, Sergey Ryazanov,
	Johannes Berg
  Cc: netdev, linux-usb, linux-kernel, bridge, linux-ppp,
	Greg Kroah-Hartman, Ricardo B. Marliere

Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
core can properly handle constant struct device_type. Move the br_type
variable to be a constant structure as well, placing it into read-only
memory which can not be modified at runtime.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
---
 net/bridge/br_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bridge/br_device.c b/net/bridge/br_device.c
index 717e9750614c..874cec75a818 100644
--- a/net/bridge/br_device.c
+++ b/net/bridge/br_device.c
@@ -474,7 +474,7 @@ static const struct net_device_ops br_netdev_ops = {
 	.ndo_fill_forward_path	 = br_fill_forward_path,
 };
 
-static struct device_type br_type = {
+static const struct device_type br_type = {
 	.name	= "bridge",
 };
 

-- 
2.43.0


^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [PATCH 04/12] net: vxlan: constify the struct device_type usage
  2024-02-17 20:13 [PATCH 00/12] net: constify struct device_type usage Ricardo B. Marliere
                   ` (2 preceding siblings ...)
  2024-02-17 20:13 ` [PATCH 03/12] net: bridge: " Ricardo B. Marliere
@ 2024-02-17 20:13 ` Ricardo B. Marliere
  2024-02-19 11:43   ` Guillaume Nault
  2024-02-17 20:13 ` [PATCH 05/12] net: ppp: " Ricardo B. Marliere
                   ` (8 subsequent siblings)
  12 siblings, 1 reply; 28+ messages in thread
From: Ricardo B. Marliere @ 2024-02-17 20:13 UTC (permalink / raw)
  To: Oliver Neukum, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Andrew Lunn, Florian Fainelli, Vladimir Oltean,
	Roopa Prabhu, Nikolay Aleksandrov, Loic Poulain, Sergey Ryazanov,
	Johannes Berg
  Cc: netdev, linux-usb, linux-kernel, bridge, linux-ppp,
	Greg Kroah-Hartman, Ricardo B. Marliere

Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
core can properly handle constant struct device_type. Move the vxlan_type
variable to be a constant structure as well, placing it into read-only
memory which can not be modified at runtime.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
---
 drivers/net/vxlan/vxlan_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c
index 705a6fd6ab6c..386cbe4d3327 100644
--- a/drivers/net/vxlan/vxlan_core.c
+++ b/drivers/net/vxlan/vxlan_core.c
@@ -3254,7 +3254,7 @@ static const struct net_device_ops vxlan_netdev_raw_ops = {
 };
 
 /* Info for udev, that this is a virtual tunnel endpoint */
-static struct device_type vxlan_type = {
+static const struct device_type vxlan_type = {
 	.name = "vxlan",
 };
 

-- 
2.43.0


^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [PATCH 05/12] net: ppp: constify the struct device_type usage
  2024-02-17 20:13 [PATCH 00/12] net: constify struct device_type usage Ricardo B. Marliere
                   ` (3 preceding siblings ...)
  2024-02-17 20:13 ` [PATCH 04/12] net: vxlan: " Ricardo B. Marliere
@ 2024-02-17 20:13 ` Ricardo B. Marliere
  2024-02-19 11:44   ` Guillaume Nault
  2024-02-17 20:13 ` [PATCH 06/12] net: geneve: " Ricardo B. Marliere
                   ` (7 subsequent siblings)
  12 siblings, 1 reply; 28+ messages in thread
From: Ricardo B. Marliere @ 2024-02-17 20:13 UTC (permalink / raw)
  To: Oliver Neukum, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Andrew Lunn, Florian Fainelli, Vladimir Oltean,
	Roopa Prabhu, Nikolay Aleksandrov, Loic Poulain, Sergey Ryazanov,
	Johannes Berg
  Cc: netdev, linux-usb, linux-kernel, bridge, linux-ppp,
	Greg Kroah-Hartman, Ricardo B. Marliere

Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
core can properly handle constant struct device_type. Move the ppp_type
variable to be a constant structure as well, placing it into read-only
memory which can not be modified at runtime.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
---
 drivers/net/ppp/ppp_generic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c
index 3dd52bf28f15..db1d11ae817b 100644
--- a/drivers/net/ppp/ppp_generic.c
+++ b/drivers/net/ppp/ppp_generic.c
@@ -1607,7 +1607,7 @@ static const struct net_device_ops ppp_netdev_ops = {
 	.ndo_fill_forward_path = ppp_fill_forward_path,
 };
 
-static struct device_type ppp_type = {
+static const struct device_type ppp_type = {
 	.name = "ppp",
 };
 

-- 
2.43.0


^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [PATCH 06/12] net: geneve: constify the struct device_type usage
  2024-02-17 20:13 [PATCH 00/12] net: constify struct device_type usage Ricardo B. Marliere
                   ` (4 preceding siblings ...)
  2024-02-17 20:13 ` [PATCH 05/12] net: ppp: " Ricardo B. Marliere
@ 2024-02-17 20:13 ` Ricardo B. Marliere
  2024-02-19 11:45   ` Guillaume Nault
  2024-02-17 20:13 ` [PATCH 07/12] net: hsr: " Ricardo B. Marliere
                   ` (6 subsequent siblings)
  12 siblings, 1 reply; 28+ messages in thread
From: Ricardo B. Marliere @ 2024-02-17 20:13 UTC (permalink / raw)
  To: Oliver Neukum, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Andrew Lunn, Florian Fainelli, Vladimir Oltean,
	Roopa Prabhu, Nikolay Aleksandrov, Loic Poulain, Sergey Ryazanov,
	Johannes Berg
  Cc: netdev, linux-usb, linux-kernel, bridge, linux-ppp,
	Greg Kroah-Hartman, Ricardo B. Marliere

Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
core can properly handle constant struct device_type. Move the geneve_type
variable to be a constant structure as well, placing it into read-only
memory which can not be modified at runtime.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
---
 drivers/net/geneve.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c
index 256602a72356..6f3f9b446b1d 100644
--- a/drivers/net/geneve.c
+++ b/drivers/net/geneve.c
@@ -1142,7 +1142,7 @@ static const struct ethtool_ops geneve_ethtool_ops = {
 };
 
 /* Info for udev, that this is a virtual tunnel endpoint */
-static struct device_type geneve_type = {
+static const struct device_type geneve_type = {
 	.name = "geneve",
 };
 

-- 
2.43.0


^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [PATCH 07/12] net: hsr: constify the struct device_type usage
  2024-02-17 20:13 [PATCH 00/12] net: constify struct device_type usage Ricardo B. Marliere
                   ` (5 preceding siblings ...)
  2024-02-17 20:13 ` [PATCH 06/12] net: geneve: " Ricardo B. Marliere
@ 2024-02-17 20:13 ` Ricardo B. Marliere
  2024-02-20 11:21   ` Simon Horman
  2024-02-17 20:13 ` [PATCH 08/12] net: l2tp: " Ricardo B. Marliere
                   ` (5 subsequent siblings)
  12 siblings, 1 reply; 28+ messages in thread
From: Ricardo B. Marliere @ 2024-02-17 20:13 UTC (permalink / raw)
  To: Oliver Neukum, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Andrew Lunn, Florian Fainelli, Vladimir Oltean,
	Roopa Prabhu, Nikolay Aleksandrov, Loic Poulain, Sergey Ryazanov,
	Johannes Berg
  Cc: netdev, linux-usb, linux-kernel, bridge, linux-ppp,
	Greg Kroah-Hartman, Ricardo B. Marliere

Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
core can properly handle constant struct device_type. Move the hsr_type
variable to be a constant structure as well, placing it into read-only
memory which can not be modified at runtime.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
---
 net/hsr/hsr_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/hsr/hsr_device.c b/net/hsr/hsr_device.c
index 5ef6d437db72..c98b5b71ad7c 100644
--- a/net/hsr/hsr_device.c
+++ b/net/hsr/hsr_device.c
@@ -467,7 +467,7 @@ static const struct net_device_ops hsr_device_ops = {
 	.ndo_set_rx_mode = hsr_set_rx_mode,
 };
 
-static struct device_type hsr_type = {
+static const struct device_type hsr_type = {
 	.name = "hsr",
 };
 

-- 
2.43.0


^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [PATCH 08/12] net: l2tp: constify the struct device_type usage
  2024-02-17 20:13 [PATCH 00/12] net: constify struct device_type usage Ricardo B. Marliere
                   ` (6 preceding siblings ...)
  2024-02-17 20:13 ` [PATCH 07/12] net: hsr: " Ricardo B. Marliere
@ 2024-02-17 20:13 ` Ricardo B. Marliere
  2024-02-19 11:46   ` Guillaume Nault
  2024-02-17 20:13 ` [PATCH 09/12] net: vlan: " Ricardo B. Marliere
                   ` (4 subsequent siblings)
  12 siblings, 1 reply; 28+ messages in thread
From: Ricardo B. Marliere @ 2024-02-17 20:13 UTC (permalink / raw)
  To: Oliver Neukum, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Andrew Lunn, Florian Fainelli, Vladimir Oltean,
	Roopa Prabhu, Nikolay Aleksandrov, Loic Poulain, Sergey Ryazanov,
	Johannes Berg
  Cc: netdev, linux-usb, linux-kernel, bridge, linux-ppp,
	Greg Kroah-Hartman, Ricardo B. Marliere

Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
core can properly handle constant struct device_type. Move the l2tpeth_type
variable to be a constant structure as well, placing it into read-only
memory which can not be modified at runtime.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
---
 net/l2tp/l2tp_eth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/l2tp/l2tp_eth.c b/net/l2tp/l2tp_eth.c
index 25ca89f80414..39e487ccc468 100644
--- a/net/l2tp/l2tp_eth.c
+++ b/net/l2tp/l2tp_eth.c
@@ -100,7 +100,7 @@ static const struct net_device_ops l2tp_eth_netdev_ops = {
 	.ndo_set_mac_address	= eth_mac_addr,
 };
 
-static struct device_type l2tpeth_type = {
+static const struct device_type l2tpeth_type = {
 	.name = "l2tpeth",
 };
 

-- 
2.43.0


^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [PATCH 09/12] net: vlan: constify the struct device_type usage
  2024-02-17 20:13 [PATCH 00/12] net: constify struct device_type usage Ricardo B. Marliere
                   ` (7 preceding siblings ...)
  2024-02-17 20:13 ` [PATCH 08/12] net: l2tp: " Ricardo B. Marliere
@ 2024-02-17 20:13 ` Ricardo B. Marliere
  2024-02-20 11:21   ` Simon Horman
  2024-02-17 20:13 ` [PATCH 10/12] net: netdevsim: " Ricardo B. Marliere
                   ` (3 subsequent siblings)
  12 siblings, 1 reply; 28+ messages in thread
From: Ricardo B. Marliere @ 2024-02-17 20:13 UTC (permalink / raw)
  To: Oliver Neukum, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Andrew Lunn, Florian Fainelli, Vladimir Oltean,
	Roopa Prabhu, Nikolay Aleksandrov, Loic Poulain, Sergey Ryazanov,
	Johannes Berg
  Cc: netdev, linux-usb, linux-kernel, bridge, linux-ppp,
	Greg Kroah-Hartman, Ricardo B. Marliere

Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
core can properly handle constant struct device_type. Move the vlan_type
variable to be a constant structure as well, placing it into read-only
memory which can not be modified at runtime.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
---
 net/8021q/vlan_dev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c
index 790b54a7cbe3..df5552518251 100644
--- a/net/8021q/vlan_dev.c
+++ b/net/8021q/vlan_dev.c
@@ -537,7 +537,7 @@ static const struct header_ops vlan_passthru_header_ops = {
 	.parse_protocol = vlan_parse_protocol,
 };
 
-static struct device_type vlan_type = {
+static const struct device_type vlan_type = {
 	.name	= "vlan",
 };
 

-- 
2.43.0


^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [PATCH 10/12] net: netdevsim: constify the struct device_type usage
  2024-02-17 20:13 [PATCH 00/12] net: constify struct device_type usage Ricardo B. Marliere
                   ` (8 preceding siblings ...)
  2024-02-17 20:13 ` [PATCH 09/12] net: vlan: " Ricardo B. Marliere
@ 2024-02-17 20:13 ` Ricardo B. Marliere
  2024-02-20 11:22   ` Simon Horman
  2024-02-17 20:13 ` [PATCH 11/12] net: wwan: core: " Ricardo B. Marliere
                   ` (2 subsequent siblings)
  12 siblings, 1 reply; 28+ messages in thread
From: Ricardo B. Marliere @ 2024-02-17 20:13 UTC (permalink / raw)
  To: Oliver Neukum, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Andrew Lunn, Florian Fainelli, Vladimir Oltean,
	Roopa Prabhu, Nikolay Aleksandrov, Loic Poulain, Sergey Ryazanov,
	Johannes Berg
  Cc: netdev, linux-usb, linux-kernel, bridge, linux-ppp,
	Greg Kroah-Hartman, Ricardo B. Marliere

Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
core can properly handle constant struct device_type. Move the
nsim_bus_dev_type variable to be a constant structure as well, placing it
into read-only memory which can not be modified at runtime.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
---
 drivers/net/netdevsim/bus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/netdevsim/bus.c b/drivers/net/netdevsim/bus.c
index aedab1d9623a..0c5aff63d242 100644
--- a/drivers/net/netdevsim/bus.c
+++ b/drivers/net/netdevsim/bus.c
@@ -129,7 +129,7 @@ static void nsim_bus_dev_release(struct device *dev)
 		complete(&nsim_bus_devs_released);
 }
 
-static struct device_type nsim_bus_dev_type = {
+static const struct device_type nsim_bus_dev_type = {
 	.groups = nsim_bus_dev_attr_groups,
 	.release = nsim_bus_dev_release,
 };

-- 
2.43.0


^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [PATCH 11/12] net: wwan: core: constify the struct device_type usage
  2024-02-17 20:13 [PATCH 00/12] net: constify struct device_type usage Ricardo B. Marliere
                   ` (9 preceding siblings ...)
  2024-02-17 20:13 ` [PATCH 10/12] net: netdevsim: " Ricardo B. Marliere
@ 2024-02-17 20:13 ` Ricardo B. Marliere
  2024-02-20 11:22   ` Simon Horman
  2024-02-21  0:07   ` Sergey Ryazanov
  2024-02-17 20:13 ` [PATCH 12/12] net: hso: " Ricardo B. Marliere
  2024-02-21  9:50 ` [PATCH 00/12] net: constify " patchwork-bot+netdevbpf
  12 siblings, 2 replies; 28+ messages in thread
From: Ricardo B. Marliere @ 2024-02-17 20:13 UTC (permalink / raw)
  To: Oliver Neukum, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Andrew Lunn, Florian Fainelli, Vladimir Oltean,
	Roopa Prabhu, Nikolay Aleksandrov, Loic Poulain, Sergey Ryazanov,
	Johannes Berg
  Cc: netdev, linux-usb, linux-kernel, bridge, linux-ppp,
	Greg Kroah-Hartman, Ricardo B. Marliere

Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
core can properly handle constant struct device_type. Move the wwan_type
variable to be a constant structure as well, placing it into read-only
memory which can not be modified at runtime.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
---
 drivers/net/wwan/wwan_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wwan/wwan_core.c b/drivers/net/wwan/wwan_core.c
index 2ed20b20e7fc..b0030f3ed0f0 100644
--- a/drivers/net/wwan/wwan_core.c
+++ b/drivers/net/wwan/wwan_core.c
@@ -920,7 +920,7 @@ static int wwan_rtnl_validate(struct nlattr *tb[], struct nlattr *data[],
 	return 0;
 }
 
-static struct device_type wwan_type = { .name = "wwan" };
+static const struct device_type wwan_type = { .name = "wwan" };
 
 static struct net_device *wwan_rtnl_alloc(struct nlattr *tb[],
 					  const char *ifname,

-- 
2.43.0


^ permalink raw reply related	[flat|nested] 28+ messages in thread

* [PATCH 12/12] net: hso: constify the struct device_type usage
  2024-02-17 20:13 [PATCH 00/12] net: constify struct device_type usage Ricardo B. Marliere
                   ` (10 preceding siblings ...)
  2024-02-17 20:13 ` [PATCH 11/12] net: wwan: core: " Ricardo B. Marliere
@ 2024-02-17 20:13 ` Ricardo B. Marliere
  2024-02-20 11:22   ` Simon Horman
  2024-02-21  9:50 ` [PATCH 00/12] net: constify " patchwork-bot+netdevbpf
  12 siblings, 1 reply; 28+ messages in thread
From: Ricardo B. Marliere @ 2024-02-17 20:13 UTC (permalink / raw)
  To: Oliver Neukum, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Andrew Lunn, Florian Fainelli, Vladimir Oltean,
	Roopa Prabhu, Nikolay Aleksandrov, Loic Poulain, Sergey Ryazanov,
	Johannes Berg
  Cc: netdev, linux-usb, linux-kernel, bridge, linux-ppp,
	Greg Kroah-Hartman, Ricardo B. Marliere

Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
core can properly handle constant struct device_type. Move the hso_type
variable to be a constant structure as well, placing it into read-only
memory which can not be modified at runtime.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
---
 drivers/net/usb/hso.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index f088ea2ba6f3..1aeb36119d3f 100644
--- a/drivers/net/usb/hso.c
+++ b/drivers/net/usb/hso.c
@@ -2465,7 +2465,7 @@ static void hso_create_rfkill(struct hso_device *hso_dev,
 	}
 }
 
-static struct device_type hso_type = {
+static const struct device_type hso_type = {
 	.name	= "wwan",
 };
 

-- 
2.43.0


^ permalink raw reply related	[flat|nested] 28+ messages in thread

* Re: [PATCH 02/12] net: dsa: constify the struct device_type usage
  2024-02-17 20:13 ` [PATCH 02/12] net: dsa: " Ricardo B. Marliere
@ 2024-02-18 21:46   ` Florian Fainelli
  0 siblings, 0 replies; 28+ messages in thread
From: Florian Fainelli @ 2024-02-18 21:46 UTC (permalink / raw)
  To: Ricardo B. Marliere, Oliver Neukum, David S. Miller,
	Eric Dumazet, Jakub Kicinski, Paolo Abeni, Andrew Lunn,
	Vladimir Oltean, Roopa Prabhu, Nikolay Aleksandrov, Loic Poulain,
	Sergey Ryazanov, Johannes Berg
  Cc: netdev, linux-usb, linux-kernel, bridge, linux-ppp, Greg Kroah-Hartman



On 2/17/2024 12:13 PM, Ricardo B. Marliere wrote:
> Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
> core can properly handle constant struct device_type. Move the dsa_type
> variable to be a constant structure as well, placing it into read-only
> memory which can not be modified at runtime.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>

Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
-- 
Florian

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PATCH 04/12] net: vxlan: constify the struct device_type usage
  2024-02-17 20:13 ` [PATCH 04/12] net: vxlan: " Ricardo B. Marliere
@ 2024-02-19 11:43   ` Guillaume Nault
  2024-02-19 11:49     ` Ricardo B. Marliere
  0 siblings, 1 reply; 28+ messages in thread
From: Guillaume Nault @ 2024-02-19 11:43 UTC (permalink / raw)
  To: Ricardo B. Marliere
  Cc: Oliver Neukum, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Andrew Lunn, Florian Fainelli, Vladimir Oltean,
	Roopa Prabhu, Nikolay Aleksandrov, Loic Poulain, Sergey Ryazanov,
	Johannes Berg, netdev, linux-usb, linux-kernel, bridge,
	linux-ppp, Greg Kroah-Hartman

On Sat, Feb 17, 2024 at 05:13:26PM -0300, Ricardo B. Marliere wrote:
> Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
> core can properly handle constant struct device_type. Move the vxlan_type
> variable to be a constant structure as well, placing it into read-only
> memory which can not be modified at runtime.

Reviewed-by: Guillaume Nault <gnault@redhat.com>

Note: To help maintainers (and potentially reviewers) work please
write in the subject prefix which tree you're targetting. For this
series, it should be "[PATCH net-next xx/yy]".


^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PATCH 05/12] net: ppp: constify the struct device_type usage
  2024-02-17 20:13 ` [PATCH 05/12] net: ppp: " Ricardo B. Marliere
@ 2024-02-19 11:44   ` Guillaume Nault
  0 siblings, 0 replies; 28+ messages in thread
From: Guillaume Nault @ 2024-02-19 11:44 UTC (permalink / raw)
  To: Ricardo B. Marliere
  Cc: Oliver Neukum, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Andrew Lunn, Florian Fainelli, Vladimir Oltean,
	Roopa Prabhu, Nikolay Aleksandrov, Loic Poulain, Sergey Ryazanov,
	Johannes Berg, netdev, linux-usb, linux-kernel, bridge,
	linux-ppp, Greg Kroah-Hartman

On Sat, Feb 17, 2024 at 05:13:27PM -0300, Ricardo B. Marliere wrote:
> Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
> core can properly handle constant struct device_type. Move the ppp_type
> variable to be a constant structure as well, placing it into read-only
> memory which can not be modified at runtime.

Reviewed-by: Guillaume Nault <gnault@redhat.com>


^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PATCH 06/12] net: geneve: constify the struct device_type usage
  2024-02-17 20:13 ` [PATCH 06/12] net: geneve: " Ricardo B. Marliere
@ 2024-02-19 11:45   ` Guillaume Nault
  0 siblings, 0 replies; 28+ messages in thread
From: Guillaume Nault @ 2024-02-19 11:45 UTC (permalink / raw)
  To: Ricardo B. Marliere
  Cc: Oliver Neukum, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Andrew Lunn, Florian Fainelli, Vladimir Oltean,
	Roopa Prabhu, Nikolay Aleksandrov, Loic Poulain, Sergey Ryazanov,
	Johannes Berg, netdev, linux-usb, linux-kernel, bridge,
	linux-ppp, Greg Kroah-Hartman

On Sat, Feb 17, 2024 at 05:13:28PM -0300, Ricardo B. Marliere wrote:
> Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
> core can properly handle constant struct device_type. Move the geneve_type
> variable to be a constant structure as well, placing it into read-only
> memory which can not be modified at runtime.

Reviewed-by: Guillaume Nault <gnault@redhat.com>


^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PATCH 08/12] net: l2tp: constify the struct device_type usage
  2024-02-17 20:13 ` [PATCH 08/12] net: l2tp: " Ricardo B. Marliere
@ 2024-02-19 11:46   ` Guillaume Nault
  0 siblings, 0 replies; 28+ messages in thread
From: Guillaume Nault @ 2024-02-19 11:46 UTC (permalink / raw)
  To: Ricardo B. Marliere
  Cc: Oliver Neukum, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Andrew Lunn, Florian Fainelli, Vladimir Oltean,
	Roopa Prabhu, Nikolay Aleksandrov, Loic Poulain, Sergey Ryazanov,
	Johannes Berg, netdev, linux-usb, linux-kernel, bridge,
	linux-ppp, Greg Kroah-Hartman

On Sat, Feb 17, 2024 at 05:13:30PM -0300, Ricardo B. Marliere wrote:
> Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
> core can properly handle constant struct device_type. Move the l2tpeth_type
> variable to be a constant structure as well, placing it into read-only
> memory which can not be modified at runtime.

Reviewed-by: Guillaume Nault <gnault@redhat.com>


^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PATCH 04/12] net: vxlan: constify the struct device_type usage
  2024-02-19 11:43   ` Guillaume Nault
@ 2024-02-19 11:49     ` Ricardo B. Marliere
  0 siblings, 0 replies; 28+ messages in thread
From: Ricardo B. Marliere @ 2024-02-19 11:49 UTC (permalink / raw)
  To: Guillaume Nault
  Cc: Oliver Neukum, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Andrew Lunn, Florian Fainelli, Vladimir Oltean,
	Roopa Prabhu, Nikolay Aleksandrov, Loic Poulain, Sergey Ryazanov,
	Johannes Berg, netdev, linux-usb, linux-kernel, bridge,
	linux-ppp, Greg Kroah-Hartman

Hi Guillaume,

On 19 Feb 12:43, Guillaume Nault wrote:
> On Sat, Feb 17, 2024 at 05:13:26PM -0300, Ricardo B. Marliere wrote:
> > Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
> > core can properly handle constant struct device_type. Move the vxlan_type
> > variable to be a constant structure as well, placing it into read-only
> > memory which can not be modified at runtime.
> 
> Reviewed-by: Guillaume Nault <gnault@redhat.com>
> 
> Note: To help maintainers (and potentially reviewers) work please
> write in the subject prefix which tree you're targetting. For this
> series, it should be "[PATCH net-next xx/yy]".

Makes sense, will keep this in mind next time!

Thanks for reviewing,
-	Ricardo.



^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PATCH 01/12] net: usbnet: constify the struct device_type usage
  2024-02-17 20:13 ` [PATCH 01/12] net: usbnet: constify the " Ricardo B. Marliere
@ 2024-02-20 11:18   ` Simon Horman
  0 siblings, 0 replies; 28+ messages in thread
From: Simon Horman @ 2024-02-20 11:18 UTC (permalink / raw)
  To: Ricardo B. Marliere
  Cc: Oliver Neukum, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Andrew Lunn, Florian Fainelli, Vladimir Oltean,
	Roopa Prabhu, Nikolay Aleksandrov, Loic Poulain, Sergey Ryazanov,
	Johannes Berg, netdev, linux-usb, linux-kernel, bridge,
	linux-ppp, Greg Kroah-Hartman

On Sat, Feb 17, 2024 at 05:13:23PM -0300, Ricardo B. Marliere wrote:
> Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
> core can properly handle constant struct device_type. Move the wlan_type
> and wwan_type variables to be constant structures as well, placing it into
> read-only memory which can not be modified at runtime.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>

Reviewed-by: Simon Horman <horms@kernel.org>


^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PATCH 03/12] net: bridge: constify the struct device_type usage
  2024-02-17 20:13 ` [PATCH 03/12] net: bridge: " Ricardo B. Marliere
@ 2024-02-20 11:20   ` Simon Horman
  0 siblings, 0 replies; 28+ messages in thread
From: Simon Horman @ 2024-02-20 11:20 UTC (permalink / raw)
  To: Ricardo B. Marliere
  Cc: Oliver Neukum, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Andrew Lunn, Florian Fainelli, Vladimir Oltean,
	Roopa Prabhu, Nikolay Aleksandrov, Loic Poulain, Sergey Ryazanov,
	Johannes Berg, netdev, linux-usb, linux-kernel, bridge,
	linux-ppp, Greg Kroah-Hartman

On Sat, Feb 17, 2024 at 05:13:25PM -0300, Ricardo B. Marliere wrote:
> Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
> core can properly handle constant struct device_type. Move the br_type
> variable to be a constant structure as well, placing it into read-only
> memory which can not be modified at runtime.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>

Reviewed-by: Simon Horman <horms@kernel.org>


^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PATCH 07/12] net: hsr: constify the struct device_type usage
  2024-02-17 20:13 ` [PATCH 07/12] net: hsr: " Ricardo B. Marliere
@ 2024-02-20 11:21   ` Simon Horman
  0 siblings, 0 replies; 28+ messages in thread
From: Simon Horman @ 2024-02-20 11:21 UTC (permalink / raw)
  To: Ricardo B. Marliere
  Cc: Oliver Neukum, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Andrew Lunn, Florian Fainelli, Vladimir Oltean,
	Roopa Prabhu, Nikolay Aleksandrov, Loic Poulain, Sergey Ryazanov,
	Johannes Berg, netdev, linux-usb, linux-kernel, bridge,
	linux-ppp, Greg Kroah-Hartman

On Sat, Feb 17, 2024 at 05:13:29PM -0300, Ricardo B. Marliere wrote:
> Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
> core can properly handle constant struct device_type. Move the hsr_type
> variable to be a constant structure as well, placing it into read-only
> memory which can not be modified at runtime.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>

Reviewed-by: Simon Horman <horms@kernel.org>


^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PATCH 09/12] net: vlan: constify the struct device_type usage
  2024-02-17 20:13 ` [PATCH 09/12] net: vlan: " Ricardo B. Marliere
@ 2024-02-20 11:21   ` Simon Horman
  0 siblings, 0 replies; 28+ messages in thread
From: Simon Horman @ 2024-02-20 11:21 UTC (permalink / raw)
  To: Ricardo B. Marliere
  Cc: Oliver Neukum, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Andrew Lunn, Florian Fainelli, Vladimir Oltean,
	Roopa Prabhu, Nikolay Aleksandrov, Loic Poulain, Sergey Ryazanov,
	Johannes Berg, netdev, linux-usb, linux-kernel, bridge,
	linux-ppp, Greg Kroah-Hartman

On Sat, Feb 17, 2024 at 05:13:31PM -0300, Ricardo B. Marliere wrote:
> Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
> core can properly handle constant struct device_type. Move the vlan_type
> variable to be a constant structure as well, placing it into read-only
> memory which can not be modified at runtime.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>

Reviewed-by: Simon Horman <horms@kernel.org>

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PATCH 10/12] net: netdevsim: constify the struct device_type usage
  2024-02-17 20:13 ` [PATCH 10/12] net: netdevsim: " Ricardo B. Marliere
@ 2024-02-20 11:22   ` Simon Horman
  0 siblings, 0 replies; 28+ messages in thread
From: Simon Horman @ 2024-02-20 11:22 UTC (permalink / raw)
  To: Ricardo B. Marliere
  Cc: Oliver Neukum, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Andrew Lunn, Florian Fainelli, Vladimir Oltean,
	Roopa Prabhu, Nikolay Aleksandrov, Loic Poulain, Sergey Ryazanov,
	Johannes Berg, netdev, linux-usb, linux-kernel, bridge,
	linux-ppp, Greg Kroah-Hartman

On Sat, Feb 17, 2024 at 05:13:32PM -0300, Ricardo B. Marliere wrote:
> Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
> core can properly handle constant struct device_type. Move the
> nsim_bus_dev_type variable to be a constant structure as well, placing it
> into read-only memory which can not be modified at runtime.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>

Reviewed-by: Simon Horman <horms@kernel.org>


^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PATCH 11/12] net: wwan: core: constify the struct device_type usage
  2024-02-17 20:13 ` [PATCH 11/12] net: wwan: core: " Ricardo B. Marliere
@ 2024-02-20 11:22   ` Simon Horman
  2024-02-21  0:07   ` Sergey Ryazanov
  1 sibling, 0 replies; 28+ messages in thread
From: Simon Horman @ 2024-02-20 11:22 UTC (permalink / raw)
  To: Ricardo B. Marliere
  Cc: Oliver Neukum, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Andrew Lunn, Florian Fainelli, Vladimir Oltean,
	Roopa Prabhu, Nikolay Aleksandrov, Loic Poulain, Sergey Ryazanov,
	Johannes Berg, netdev, linux-usb, linux-kernel, bridge,
	linux-ppp, Greg Kroah-Hartman

On Sat, Feb 17, 2024 at 05:13:33PM -0300, Ricardo B. Marliere wrote:
> Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
> core can properly handle constant struct device_type. Move the wwan_type
> variable to be a constant structure as well, placing it into read-only
> memory which can not be modified at runtime.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>

Reviewed-by: Simon Horman <horms@kernel.org>


^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PATCH 12/12] net: hso: constify the struct device_type usage
  2024-02-17 20:13 ` [PATCH 12/12] net: hso: " Ricardo B. Marliere
@ 2024-02-20 11:22   ` Simon Horman
  0 siblings, 0 replies; 28+ messages in thread
From: Simon Horman @ 2024-02-20 11:22 UTC (permalink / raw)
  To: Ricardo B. Marliere
  Cc: Oliver Neukum, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Andrew Lunn, Florian Fainelli, Vladimir Oltean,
	Roopa Prabhu, Nikolay Aleksandrov, Loic Poulain, Sergey Ryazanov,
	Johannes Berg, netdev, linux-usb, linux-kernel, bridge,
	linux-ppp, Greg Kroah-Hartman

On Sat, Feb 17, 2024 at 05:13:34PM -0300, Ricardo B. Marliere wrote:
> Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
> core can properly handle constant struct device_type. Move the hso_type
> variable to be a constant structure as well, placing it into read-only
> memory which can not be modified at runtime.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>

Reviewed-by: Simon Horman <horms@kernel.org>


^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PATCH 11/12] net: wwan: core: constify the struct device_type usage
  2024-02-17 20:13 ` [PATCH 11/12] net: wwan: core: " Ricardo B. Marliere
  2024-02-20 11:22   ` Simon Horman
@ 2024-02-21  0:07   ` Sergey Ryazanov
  1 sibling, 0 replies; 28+ messages in thread
From: Sergey Ryazanov @ 2024-02-21  0:07 UTC (permalink / raw)
  To: Ricardo B. Marliere, Oliver Neukum, David S. Miller,
	Eric Dumazet, Jakub Kicinski, Paolo Abeni, Andrew Lunn,
	Florian Fainelli, Vladimir Oltean, Roopa Prabhu,
	Nikolay Aleksandrov, Loic Poulain, Johannes Berg
  Cc: netdev, linux-usb, linux-kernel, bridge, linux-ppp, Greg Kroah-Hartman

On 17.02.2024 22:13, Ricardo B. Marliere wrote:
> Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
> core can properly handle constant struct device_type. Move the wwan_type
> variable to be a constant structure as well, placing it into read-only
> memory which can not be modified at runtime.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>

Reviewed-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>

^ permalink raw reply	[flat|nested] 28+ messages in thread

* Re: [PATCH 00/12] net: constify struct device_type usage
  2024-02-17 20:13 [PATCH 00/12] net: constify struct device_type usage Ricardo B. Marliere
                   ` (11 preceding siblings ...)
  2024-02-17 20:13 ` [PATCH 12/12] net: hso: " Ricardo B. Marliere
@ 2024-02-21  9:50 ` patchwork-bot+netdevbpf
  12 siblings, 0 replies; 28+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-02-21  9:50 UTC (permalink / raw)
  To: Ricardo B. Marliere
  Cc: oneukum, davem, edumazet, kuba, pabeni, andrew, f.fainelli,
	olteanv, roopa, razor, loic.poulain, ryazanov.s.a, johannes,
	netdev, linux-usb, linux-kernel, bridge, linux-ppp, gregkh

Hello:

This series was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Sat, 17 Feb 2024 17:13:22 -0300 you wrote:
> This is a simple and straight forward cleanup series that makes all device
> types in the net subsystem constants. This has been possible since 2011 [1]
> but not all occurrences were cleaned. I have been sweeping the tree to fix
> them all.
> 
> I was not sure if I should send these squashed, but there are quite a few
> changes so I decided to send them separately. Please let me know if that is
> not desirable.
> 
> [...]

Here is the summary with links:
  - [01/12] net: usbnet: constify the struct device_type usage
    https://git.kernel.org/netdev/net-next/c/3ce7caee3af0
  - [02/12] net: dsa: constify the struct device_type usage
    https://git.kernel.org/netdev/net-next/c/7e0acba3b49e
  - [03/12] net: bridge: constify the struct device_type usage
    https://git.kernel.org/netdev/net-next/c/bbc7e4cc21a4
  - [04/12] net: vxlan: constify the struct device_type usage
    https://git.kernel.org/netdev/net-next/c/c7170e7672e5
  - [05/12] net: ppp: constify the struct device_type usage
    https://git.kernel.org/netdev/net-next/c/908ada0da6d4
  - [06/12] net: geneve: constify the struct device_type usage
    https://git.kernel.org/netdev/net-next/c/e443f3acbc6d
  - [07/12] net: hsr: constify the struct device_type usage
    https://git.kernel.org/netdev/net-next/c/0072b2c1ffd0
  - [08/12] net: l2tp: constify the struct device_type usage
    https://git.kernel.org/netdev/net-next/c/43820fd1ddb5
  - [09/12] net: vlan: constify the struct device_type usage
    https://git.kernel.org/netdev/net-next/c/7ae9d3423f1d
  - [10/12] net: netdevsim: constify the struct device_type usage
    https://git.kernel.org/netdev/net-next/c/52042e092ba9
  - [11/12] net: wwan: core: constify the struct device_type usage
    https://git.kernel.org/netdev/net-next/c/7eccf41b3bac
  - [12/12] net: hso: constify the struct device_type usage
    https://git.kernel.org/netdev/net-next/c/55fad9c4a3c4

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 28+ messages in thread

end of thread, other threads:[~2024-02-21  9:50 UTC | newest]

Thread overview: 28+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-17 20:13 [PATCH 00/12] net: constify struct device_type usage Ricardo B. Marliere
2024-02-17 20:13 ` [PATCH 01/12] net: usbnet: constify the " Ricardo B. Marliere
2024-02-20 11:18   ` Simon Horman
2024-02-17 20:13 ` [PATCH 02/12] net: dsa: " Ricardo B. Marliere
2024-02-18 21:46   ` Florian Fainelli
2024-02-17 20:13 ` [PATCH 03/12] net: bridge: " Ricardo B. Marliere
2024-02-20 11:20   ` Simon Horman
2024-02-17 20:13 ` [PATCH 04/12] net: vxlan: " Ricardo B. Marliere
2024-02-19 11:43   ` Guillaume Nault
2024-02-19 11:49     ` Ricardo B. Marliere
2024-02-17 20:13 ` [PATCH 05/12] net: ppp: " Ricardo B. Marliere
2024-02-19 11:44   ` Guillaume Nault
2024-02-17 20:13 ` [PATCH 06/12] net: geneve: " Ricardo B. Marliere
2024-02-19 11:45   ` Guillaume Nault
2024-02-17 20:13 ` [PATCH 07/12] net: hsr: " Ricardo B. Marliere
2024-02-20 11:21   ` Simon Horman
2024-02-17 20:13 ` [PATCH 08/12] net: l2tp: " Ricardo B. Marliere
2024-02-19 11:46   ` Guillaume Nault
2024-02-17 20:13 ` [PATCH 09/12] net: vlan: " Ricardo B. Marliere
2024-02-20 11:21   ` Simon Horman
2024-02-17 20:13 ` [PATCH 10/12] net: netdevsim: " Ricardo B. Marliere
2024-02-20 11:22   ` Simon Horman
2024-02-17 20:13 ` [PATCH 11/12] net: wwan: core: " Ricardo B. Marliere
2024-02-20 11:22   ` Simon Horman
2024-02-21  0:07   ` Sergey Ryazanov
2024-02-17 20:13 ` [PATCH 12/12] net: hso: " Ricardo B. Marliere
2024-02-20 11:22   ` Simon Horman
2024-02-21  9:50 ` [PATCH 00/12] net: constify " patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).