* [PATCH 0/4] Fix a bunch of W=1 warnings in PWM
@ 2020-06-29 12:47 Lee Jones
2020-06-29 12:47 ` [PATCH 1/4] pwm: bcm-iproc: Remove impossible comparison when validating duty cycle Lee Jones
` (4 more replies)
0 siblings, 5 replies; 13+ messages in thread
From: Lee Jones @ 2020-06-29 12:47 UTC (permalink / raw)
To: thierry.reding, u.kleine-koenig, linux-pwm
Cc: linux-arm-kernel, linux-kernel, Lee Jones
Attempting to clean-up W=1 kernel builds, which are currently
overwhelmingly riddled with niggly little warnings.
Lee Jones (4):
pwm: bcm-iproc: Remove impossible comparison when validating duty
cycle
pwm: bcm-kona: Remove impossible comparison when validating duty cycle
pwm: mediatek: Provide missing kerneldoc description for 'soc' arg
pwm: omap-dmtimer: Repair pwm_omap_dmtimer_chip's broken kerneldoc
header
drivers/pwm/pwm-bcm-iproc.c | 3 +--
drivers/pwm/pwm-bcm-kona.c | 2 +-
drivers/pwm/pwm-mediatek.c | 1 +
drivers/pwm/pwm-omap-dmtimer.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 1/4] pwm: bcm-iproc: Remove impossible comparison when validating duty cycle
2020-06-29 12:47 [PATCH 0/4] Fix a bunch of W=1 warnings in PWM Lee Jones
@ 2020-06-29 12:47 ` Lee Jones
2020-06-29 16:45 ` Florian Fainelli
2020-06-29 19:45 ` Uwe Kleine-König
2020-06-29 12:47 ` [PATCH 2/4] pwm: bcm-kona: " Lee Jones
` (3 subsequent siblings)
4 siblings, 2 replies; 13+ messages in thread
From: Lee Jones @ 2020-06-29 12:47 UTC (permalink / raw)
To: thierry.reding, u.kleine-koenig, linux-pwm
Cc: linux-arm-kernel, linux-kernel, Lee Jones, Ray Jui,
Scott Branden, Yendapally Reddy Dhananjaya Reddy,
bcm-kernel-feedback-list
'duty' here is an unsigned int, thus checking for <0 will always
evaluate to false.
Fixes the following W=1 warning:
drivers/pwm/pwm-bcm-iproc.c:147:12: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
Cc: Ray Jui <rjui@broadcom.com>
Cc: Scott Branden <sbranden@broadcom.com>
Cc: Yendapally Reddy Dhananjaya Reddy <yendapally.reddy@broadcom.com>
Cc: bcm-kernel-feedback-list@broadcom.com
Cc: linux-pwm@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/pwm/pwm-bcm-iproc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/pwm/pwm-bcm-iproc.c b/drivers/pwm/pwm-bcm-iproc.c
index 1f829edd8ee70..46f0a45e9049c 100644
--- a/drivers/pwm/pwm-bcm-iproc.c
+++ b/drivers/pwm/pwm-bcm-iproc.c
@@ -143,8 +143,7 @@ static int iproc_pwmc_apply(struct pwm_chip *chip, struct pwm_device *pwm,
value = rate * state->duty_cycle;
duty = div64_u64(value, div);
- if (period < IPROC_PWM_PERIOD_MIN ||
- duty < IPROC_PWM_DUTY_CYCLE_MIN)
+ if (period < IPROC_PWM_PERIOD_MIN)
return -EINVAL;
if (period <= IPROC_PWM_PERIOD_MAX &&
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 2/4] pwm: bcm-kona: Remove impossible comparison when validating duty cycle
2020-06-29 12:47 [PATCH 0/4] Fix a bunch of W=1 warnings in PWM Lee Jones
2020-06-29 12:47 ` [PATCH 1/4] pwm: bcm-iproc: Remove impossible comparison when validating duty cycle Lee Jones
@ 2020-06-29 12:47 ` Lee Jones
2020-06-29 16:45 ` Florian Fainelli
2020-06-29 12:47 ` [PATCH 3/4] pwm: mediatek: Provide missing kerneldoc description for 'soc' arg Lee Jones
` (2 subsequent siblings)
4 siblings, 1 reply; 13+ messages in thread
From: Lee Jones @ 2020-06-29 12:47 UTC (permalink / raw)
To: thierry.reding, u.kleine-koenig, linux-pwm
Cc: linux-arm-kernel, linux-kernel, Lee Jones, Florian Fainelli,
Ray Jui, Scott Branden, bcm-kernel-feedback-list
'dc' here is an unsigned long, thus checking for <0 will always
evaluate to false.
Fixes the following W=1 warning:
drivers/pwm/pwm-bcm-kona.c:141:35: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: Ray Jui <rjui@broadcom.com>
Cc: Scott Branden <sbranden@broadcom.com>
Cc: bcm-kernel-feedback-list@broadcom.com
Cc: linux-pwm@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/pwm/pwm-bcm-kona.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pwm/pwm-bcm-kona.c b/drivers/pwm/pwm-bcm-kona.c
index 81da91df2529a..16c5898b934a8 100644
--- a/drivers/pwm/pwm-bcm-kona.c
+++ b/drivers/pwm/pwm-bcm-kona.c
@@ -138,7 +138,7 @@ static int kona_pwmc_config(struct pwm_chip *chip, struct pwm_device *pwm,
dc = div64_u64(val, div);
/* If duty_ns or period_ns are not achievable then return */
- if (pc < PERIOD_COUNT_MIN || dc < DUTY_CYCLE_HIGH_MIN)
+ if (pc < PERIOD_COUNT_MIN)
return -EINVAL;
/* If pc and dc are in bounds, the calculation is done */
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 3/4] pwm: mediatek: Provide missing kerneldoc description for 'soc' arg
2020-06-29 12:47 [PATCH 0/4] Fix a bunch of W=1 warnings in PWM Lee Jones
2020-06-29 12:47 ` [PATCH 1/4] pwm: bcm-iproc: Remove impossible comparison when validating duty cycle Lee Jones
2020-06-29 12:47 ` [PATCH 2/4] pwm: bcm-kona: " Lee Jones
@ 2020-06-29 12:47 ` Lee Jones
2020-06-29 19:47 ` Uwe Kleine-König
2020-06-29 12:47 ` [PATCH 4/4] pwm: omap-dmtimer: Repair pwm_omap_dmtimer_chip's broken kerneldoc header Lee Jones
2020-07-27 7:50 ` [PATCH 0/4] Fix a bunch of W=1 warnings in PWM Thierry Reding
4 siblings, 1 reply; 13+ messages in thread
From: Lee Jones @ 2020-06-29 12:47 UTC (permalink / raw)
To: thierry.reding, u.kleine-koenig, linux-pwm
Cc: linux-arm-kernel, linux-kernel, Lee Jones, Matthias Brugger,
John Crispin, Zhi Mao, linux-mediatek
Kerneldoc syntax is used, but not complete.
Descriptions are required for all arguments.
Fixes the following W=1 build warning:
drivers/pwm/pwm-mediatek.c:57: warning: Function parameter or member 'soc' not described in 'pwm_mediatek_chip'
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: John Crispin <blogic@openwrt.org>
Cc: Zhi Mao <zhi.mao@mediatek.com>
Cc: linux-pwm@vger.kernel.org
Cc: linux-mediatek@lists.infradead.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/pwm/pwm-mediatek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pwm/pwm-mediatek.c b/drivers/pwm/pwm-mediatek.c
index b94e0d09c300f..ab001ce55178e 100644
--- a/drivers/pwm/pwm-mediatek.c
+++ b/drivers/pwm/pwm-mediatek.c
@@ -46,6 +46,7 @@ struct pwm_mediatek_of_data {
* @clk_main: the clock used by PWM core
* @clk_pwms: the clock used by each PWM channel
* @clk_freq: the fix clock frequency of legacy MIPS SoC
+ * @soc: pointer to chip's platform data
*/
struct pwm_mediatek_chip {
struct pwm_chip chip;
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 4/4] pwm: omap-dmtimer: Repair pwm_omap_dmtimer_chip's broken kerneldoc header
2020-06-29 12:47 [PATCH 0/4] Fix a bunch of W=1 warnings in PWM Lee Jones
` (2 preceding siblings ...)
2020-06-29 12:47 ` [PATCH 3/4] pwm: mediatek: Provide missing kerneldoc description for 'soc' arg Lee Jones
@ 2020-06-29 12:47 ` Lee Jones
2020-06-29 19:39 ` Uwe Kleine-König
2020-07-27 7:50 ` [PATCH 0/4] Fix a bunch of W=1 warnings in PWM Thierry Reding
4 siblings, 1 reply; 13+ messages in thread
From: Lee Jones @ 2020-06-29 12:47 UTC (permalink / raw)
To: thierry.reding, u.kleine-koenig, linux-pwm
Cc: linux-arm-kernel, linux-kernel, Lee Jones, Tony Lindgren,
Joachim Eastwood, NeilBrown, Grant Erickson
Argument descriptions must be prepended with a '@' to be understood
by the kerneldoc tooling/parsers/validators.
Fixes the following W=1 warning:
drivers/pwm/pwm-omap-dmtimer.c:70: warning: Function parameter or member 'dm_timer_pdev' not described in 'pwm_omap_dmtimer_chip'
Cc: Tony Lindgren <tony@atomide.com>
Cc: Joachim Eastwood <manabian@gmail.com>
Cc: NeilBrown <neilb@suse.de>
Cc: Grant Erickson <marathon96@gmail.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/pwm/pwm-omap-dmtimer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pwm/pwm-omap-dmtimer.c b/drivers/pwm/pwm-omap-dmtimer.c
index 0d31833db2e2c..75cea7f2aff5e 100644
--- a/drivers/pwm/pwm-omap-dmtimer.c
+++ b/drivers/pwm/pwm-omap-dmtimer.c
@@ -58,7 +58,7 @@
* @mutex: Mutex to protect pwm apply state
* @dm_timer: Pointer to omap dm timer.
* @pdata: Pointer to omap dm timer ops.
- * dm_timer_pdev: Pointer to omap dm timer platform device
+ * @dm_timer_pdev: Pointer to omap dm timer platform device
*/
struct pwm_omap_dmtimer_chip {
struct pwm_chip chip;
--
2.25.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH 1/4] pwm: bcm-iproc: Remove impossible comparison when validating duty cycle
2020-06-29 12:47 ` [PATCH 1/4] pwm: bcm-iproc: Remove impossible comparison when validating duty cycle Lee Jones
@ 2020-06-29 16:45 ` Florian Fainelli
2020-06-29 16:54 ` Scott Branden
2020-06-29 19:45 ` Uwe Kleine-König
1 sibling, 1 reply; 13+ messages in thread
From: Florian Fainelli @ 2020-06-29 16:45 UTC (permalink / raw)
To: Lee Jones, thierry.reding, u.kleine-koenig, linux-pwm
Cc: linux-arm-kernel, linux-kernel, Ray Jui, Scott Branden,
Yendapally Reddy Dhananjaya Reddy, bcm-kernel-feedback-list
On 6/29/2020 5:47 AM, Lee Jones wrote:
> 'duty' here is an unsigned int, thus checking for <0 will always
> evaluate to false.
>
> Fixes the following W=1 warning:
>
> drivers/pwm/pwm-bcm-iproc.c:147:12: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
>
> Cc: Ray Jui <rjui@broadcom.com>
> Cc: Scott Branden <sbranden@broadcom.com>
> Cc: Yendapally Reddy Dhananjaya Reddy <yendapally.reddy@broadcom.com>
> Cc: bcm-kernel-feedback-list@broadcom.com
> Cc: linux-pwm@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
And IPROC_PWM_DUTY_CYCLE_MIN is unused after remove this single use of
the define, if you also remove it you can add:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/4] pwm: bcm-kona: Remove impossible comparison when validating duty cycle
2020-06-29 12:47 ` [PATCH 2/4] pwm: bcm-kona: " Lee Jones
@ 2020-06-29 16:45 ` Florian Fainelli
2020-06-29 19:41 ` Uwe Kleine-König
0 siblings, 1 reply; 13+ messages in thread
From: Florian Fainelli @ 2020-06-29 16:45 UTC (permalink / raw)
To: Lee Jones, thierry.reding, u.kleine-koenig, linux-pwm
Cc: linux-arm-kernel, linux-kernel, Ray Jui, Scott Branden,
bcm-kernel-feedback-list
On 6/29/2020 5:47 AM, Lee Jones wrote:
> 'dc' here is an unsigned long, thus checking for <0 will always
> evaluate to false.
>
> Fixes the following W=1 warning:
>
> drivers/pwm/pwm-bcm-kona.c:141:35: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Ray Jui <rjui@broadcom.com>
> Cc: Scott Branden <sbranden@broadcom.com>
> Cc: bcm-kernel-feedback-list@broadcom.com
> Cc: linux-pwm@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
And similar to patch #1, DUTY_CYCLE_HIGH_MIN now gets unused, so if you
remove it as well, you can add:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/4] pwm: bcm-iproc: Remove impossible comparison when validating duty cycle
2020-06-29 16:45 ` Florian Fainelli
@ 2020-06-29 16:54 ` Scott Branden
0 siblings, 0 replies; 13+ messages in thread
From: Scott Branden @ 2020-06-29 16:54 UTC (permalink / raw)
To: Florian Fainelli, Lee Jones, thierry.reding, u.kleine-koenig, linux-pwm
Cc: linux-arm-kernel, linux-kernel, Ray Jui, Scott Branden,
Yendapally Reddy Dhananjaya Reddy, bcm-kernel-feedback-list
On 2020-06-29 9:45 a.m., Florian Fainelli wrote:
>
> On 6/29/2020 5:47 AM, Lee Jones wrote:
>> 'duty' here is an unsigned int, thus checking for <0 will always
>> evaluate to false.
>>
>> Fixes the following W=1 warning:
>>
>> drivers/pwm/pwm-bcm-iproc.c:147:12: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
>>
>> Cc: Ray Jui <rjui@broadcom.com>
>> Cc: Scott Branden <sbranden@broadcom.com>
>> Cc: Yendapally Reddy Dhananjaya Reddy <yendapally.reddy@broadcom.com>
>> Cc: bcm-kernel-feedback-list@broadcom.com
>> Cc: linux-pwm@vger.kernel.org
>> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> And IPROC_PWM_DUTY_CYCLE_MIN is unused after remove this single use of
> the define, if you also remove it you can add:
>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
We actually made this same change internally recently but hadn't
upstreamed it yet.
Tested-by: Scott Branden <scott.branden@broadcom.com>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 4/4] pwm: omap-dmtimer: Repair pwm_omap_dmtimer_chip's broken kerneldoc header
2020-06-29 12:47 ` [PATCH 4/4] pwm: omap-dmtimer: Repair pwm_omap_dmtimer_chip's broken kerneldoc header Lee Jones
@ 2020-06-29 19:39 ` Uwe Kleine-König
0 siblings, 0 replies; 13+ messages in thread
From: Uwe Kleine-König @ 2020-06-29 19:39 UTC (permalink / raw)
To: Lee Jones
Cc: thierry.reding, linux-pwm, linux-arm-kernel, linux-kernel,
Tony Lindgren, NeilBrown, Grant Erickson
[-- Attachment #1: Type: text/plain, Size: 1588 bytes --]
Hello,
[dropped Joachim Eastwood <manabian@gmail.com> from recipents as his
address bounces]
On Mon, Jun 29, 2020 at 01:47:52PM +0100, Lee Jones wrote:
> Argument descriptions must be prepended with a '@' to be understood
> by the kerneldoc tooling/parsers/validators.
>
> Fixes the following W=1 warning:
>
> drivers/pwm/pwm-omap-dmtimer.c:70: warning: Function parameter or member 'dm_timer_pdev' not described in 'pwm_omap_dmtimer_chip'
>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Joachim Eastwood <manabian@gmail.com>
> Cc: NeilBrown <neilb@suse.de>
> Cc: Grant Erickson <marathon96@gmail.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/pwm/pwm-omap-dmtimer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pwm/pwm-omap-dmtimer.c b/drivers/pwm/pwm-omap-dmtimer.c
> index 0d31833db2e2c..75cea7f2aff5e 100644
> --- a/drivers/pwm/pwm-omap-dmtimer.c
> +++ b/drivers/pwm/pwm-omap-dmtimer.c
> @@ -58,7 +58,7 @@
> * @mutex: Mutex to protect pwm apply state
> * @dm_timer: Pointer to omap dm timer.
> * @pdata: Pointer to omap dm timer ops.
> - * dm_timer_pdev: Pointer to omap dm timer platform device
> + * @dm_timer_pdev: Pointer to omap dm timer platform device
> */
> struct pwm_omap_dmtimer_chip {
> struct pwm_chip chip;
LGTM,
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/4] pwm: bcm-kona: Remove impossible comparison when validating duty cycle
2020-06-29 16:45 ` Florian Fainelli
@ 2020-06-29 19:41 ` Uwe Kleine-König
0 siblings, 0 replies; 13+ messages in thread
From: Uwe Kleine-König @ 2020-06-29 19:41 UTC (permalink / raw)
To: Lee Jones
Cc: Florian Fainelli, thierry.reding, linux-pwm, linux-arm-kernel,
linux-kernel, Ray Jui, Scott Branden, bcm-kernel-feedback-list
[-- Attachment #1: Type: text/plain, Size: 1161 bytes --]
On Mon, Jun 29, 2020 at 09:45:31AM -0700, Florian Fainelli wrote:
>
>
> On 6/29/2020 5:47 AM, Lee Jones wrote:
> > 'dc' here is an unsigned long, thus checking for <0 will always
> > evaluate to false.
> >
> > Fixes the following W=1 warning:
> >
> > drivers/pwm/pwm-bcm-kona.c:141:35: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
> >
> > Cc: Florian Fainelli <f.fainelli@gmail.com>
> > Cc: Ray Jui <rjui@broadcom.com>
> > Cc: Scott Branden <sbranden@broadcom.com>
> > Cc: bcm-kernel-feedback-list@broadcom.com
> > Cc: linux-pwm@vger.kernel.org
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
>
> And similar to patch #1, DUTY_CYCLE_HIGH_MIN now gets unused, so if you
> remove it as well, you can add:
>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Even without removing DUTY_CYCLE_HIGH_MIN (which might still serve as
documentation):
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/4] pwm: bcm-iproc: Remove impossible comparison when validating duty cycle
2020-06-29 12:47 ` [PATCH 1/4] pwm: bcm-iproc: Remove impossible comparison when validating duty cycle Lee Jones
2020-06-29 16:45 ` Florian Fainelli
@ 2020-06-29 19:45 ` Uwe Kleine-König
1 sibling, 0 replies; 13+ messages in thread
From: Uwe Kleine-König @ 2020-06-29 19:45 UTC (permalink / raw)
To: Lee Jones
Cc: thierry.reding, linux-pwm, linux-arm-kernel, linux-kernel,
Ray Jui, Scott Branden, Yendapally Reddy Dhananjaya Reddy,
bcm-kernel-feedback-list
[-- Attachment #1: Type: text/plain, Size: 1509 bytes --]
On Mon, Jun 29, 2020 at 01:47:49PM +0100, Lee Jones wrote:
> 'duty' here is an unsigned int, thus checking for <0 will always
> evaluate to false.
>
> Fixes the following W=1 warning:
>
> drivers/pwm/pwm-bcm-iproc.c:147:12: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
>
> Cc: Ray Jui <rjui@broadcom.com>
> Cc: Scott Branden <sbranden@broadcom.com>
> Cc: Yendapally Reddy Dhananjaya Reddy <yendapally.reddy@broadcom.com>
> Cc: bcm-kernel-feedback-list@broadcom.com
> Cc: linux-pwm@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/pwm/pwm-bcm-iproc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pwm/pwm-bcm-iproc.c b/drivers/pwm/pwm-bcm-iproc.c
> index 1f829edd8ee70..46f0a45e9049c 100644
> --- a/drivers/pwm/pwm-bcm-iproc.c
> +++ b/drivers/pwm/pwm-bcm-iproc.c
> @@ -143,8 +143,7 @@ static int iproc_pwmc_apply(struct pwm_chip *chip, struct pwm_device *pwm,
> value = rate * state->duty_cycle;
> duty = div64_u64(value, div);
>
> - if (period < IPROC_PWM_PERIOD_MIN ||
> - duty < IPROC_PWM_DUTY_CYCLE_MIN)
> + if (period < IPROC_PWM_PERIOD_MIN)
> return -EINVAL;
>
> if (period <= IPROC_PWM_PERIOD_MAX &&
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 3/4] pwm: mediatek: Provide missing kerneldoc description for 'soc' arg
2020-06-29 12:47 ` [PATCH 3/4] pwm: mediatek: Provide missing kerneldoc description for 'soc' arg Lee Jones
@ 2020-06-29 19:47 ` Uwe Kleine-König
0 siblings, 0 replies; 13+ messages in thread
From: Uwe Kleine-König @ 2020-06-29 19:47 UTC (permalink / raw)
To: Lee Jones
Cc: thierry.reding, linux-pwm, linux-arm-kernel, linux-kernel,
Matthias Brugger, John Crispin, Zhi Mao, linux-mediatek
[-- Attachment #1: Type: text/plain, Size: 1442 bytes --]
Hello Lee,
On Mon, Jun 29, 2020 at 01:47:51PM +0100, Lee Jones wrote:
> Kerneldoc syntax is used, but not complete.
>
> Descriptions are required for all arguments.
>
> Fixes the following W=1 build warning:
>
> drivers/pwm/pwm-mediatek.c:57: warning: Function parameter or member 'soc' not described in 'pwm_mediatek_chip'
>
> Cc: Matthias Brugger <matthias.bgg@gmail.com>
> Cc: John Crispin <blogic@openwrt.org>
> Cc: Zhi Mao <zhi.mao@mediatek.com>
> Cc: linux-pwm@vger.kernel.org
> Cc: linux-mediatek@lists.infradead.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/pwm/pwm-mediatek.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pwm/pwm-mediatek.c b/drivers/pwm/pwm-mediatek.c
> index b94e0d09c300f..ab001ce55178e 100644
> --- a/drivers/pwm/pwm-mediatek.c
> +++ b/drivers/pwm/pwm-mediatek.c
> @@ -46,6 +46,7 @@ struct pwm_mediatek_of_data {
> * @clk_main: the clock used by PWM core
> * @clk_pwms: the clock used by each PWM channel
> * @clk_freq: the fix clock frequency of legacy MIPS SoC
> + * @soc: pointer to chip's platform data
> */
> struct pwm_mediatek_chip {
> struct pwm_chip chip;
LGTM:
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 0/4] Fix a bunch of W=1 warnings in PWM
2020-06-29 12:47 [PATCH 0/4] Fix a bunch of W=1 warnings in PWM Lee Jones
` (3 preceding siblings ...)
2020-06-29 12:47 ` [PATCH 4/4] pwm: omap-dmtimer: Repair pwm_omap_dmtimer_chip's broken kerneldoc header Lee Jones
@ 2020-07-27 7:50 ` Thierry Reding
4 siblings, 0 replies; 13+ messages in thread
From: Thierry Reding @ 2020-07-27 7:50 UTC (permalink / raw)
To: Lee Jones; +Cc: u.kleine-koenig, linux-pwm, linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 776 bytes --]
On Mon, Jun 29, 2020 at 01:47:48PM +0100, Lee Jones wrote:
> Attempting to clean-up W=1 kernel builds, which are currently
> overwhelmingly riddled with niggly little warnings.
>
> Lee Jones (4):
> pwm: bcm-iproc: Remove impossible comparison when validating duty
> cycle
> pwm: bcm-kona: Remove impossible comparison when validating duty cycle
> pwm: mediatek: Provide missing kerneldoc description for 'soc' arg
> pwm: omap-dmtimer: Repair pwm_omap_dmtimer_chip's broken kerneldoc
> header
>
> drivers/pwm/pwm-bcm-iproc.c | 3 +--
> drivers/pwm/pwm-bcm-kona.c | 2 +-
> drivers/pwm/pwm-mediatek.c | 1 +
> drivers/pwm/pwm-omap-dmtimer.c | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2020-07-27 7:50 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-29 12:47 [PATCH 0/4] Fix a bunch of W=1 warnings in PWM Lee Jones
2020-06-29 12:47 ` [PATCH 1/4] pwm: bcm-iproc: Remove impossible comparison when validating duty cycle Lee Jones
2020-06-29 16:45 ` Florian Fainelli
2020-06-29 16:54 ` Scott Branden
2020-06-29 19:45 ` Uwe Kleine-König
2020-06-29 12:47 ` [PATCH 2/4] pwm: bcm-kona: " Lee Jones
2020-06-29 16:45 ` Florian Fainelli
2020-06-29 19:41 ` Uwe Kleine-König
2020-06-29 12:47 ` [PATCH 3/4] pwm: mediatek: Provide missing kerneldoc description for 'soc' arg Lee Jones
2020-06-29 19:47 ` Uwe Kleine-König
2020-06-29 12:47 ` [PATCH 4/4] pwm: omap-dmtimer: Repair pwm_omap_dmtimer_chip's broken kerneldoc header Lee Jones
2020-06-29 19:39 ` Uwe Kleine-König
2020-07-27 7:50 ` [PATCH 0/4] Fix a bunch of W=1 warnings in PWM Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).