* [PATCH 1/7] dt-bindings: phy: intel,combo-phy: restrict node name suffixes
2023-05-30 14:48 [PATCH 0/7] dt-bindings: restrict node name suffixes Krzysztof Kozlowski
@ 2023-05-30 14:48 ` Krzysztof Kozlowski
2023-05-31 4:27 ` Tony Lindgren
` (2 more replies)
2023-05-30 14:48 ` [PATCH 2/7] dt-bindings: pwm: " Krzysztof Kozlowski
` (9 subsequent siblings)
10 siblings, 3 replies; 32+ messages in thread
From: Krzysztof Kozlowski @ 2023-05-30 14:48 UTC (permalink / raw)
To: Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Uwe Kleine-König, Alessandro Zummo, Alexandre Belloni,
Srinivas Kandagatla, Mark Brown, Dipen Patel, Wim Van Sebroeck,
Guenter Roeck, Dilip Kota, linux-phy, devicetree, linux-kernel,
linux-pwm, linux-rtc, alsa-devel, linux-spi, timestamp,
linux-watchdog
Cc: Krzysztof Kozlowski, Rob Herring, Tony Lindgren, Oleksij Rempel
Make the pattern matching node names a bit stricter to improve DTS
consistency. The pattern is restricted to:
1. Only one unit address or one -N suffix,
2. -N suffixes to decimal numbers.
Suggested-by: Rob Herring <robh@kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Cc: Tony Lindgren <tony@atomide.com>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>
---
Documentation/devicetree/bindings/phy/intel,combo-phy.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/phy/intel,combo-phy.yaml b/Documentation/devicetree/bindings/phy/intel,combo-phy.yaml
index 5d54b0a0e873..7dd6a4d94b48 100644
--- a/Documentation/devicetree/bindings/phy/intel,combo-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/intel,combo-phy.yaml
@@ -15,7 +15,7 @@ description: |
properties:
$nodename:
- pattern: "combophy(@.*|-[0-9a-f])*$"
+ pattern: "combophy(@.*|-([0-9]|[1-9][0-9]+))?$"
compatible:
items:
--
2.34.1
^ permalink raw reply related [flat|nested] 32+ messages in thread* Re: [PATCH 1/7] dt-bindings: phy: intel,combo-phy: restrict node name suffixes
2023-05-30 14:48 ` [PATCH 1/7] dt-bindings: phy: intel,combo-phy: " Krzysztof Kozlowski
@ 2023-05-31 4:27 ` Tony Lindgren
2023-06-09 15:10 ` Rob Herring
2023-06-21 17:32 ` Vinod Koul
2 siblings, 0 replies; 32+ messages in thread
From: Tony Lindgren @ 2023-05-31 4:27 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Uwe Kleine-König, Alessandro Zummo, Alexandre Belloni,
Srinivas Kandagatla, Mark Brown, Dipen Patel, Wim Van Sebroeck,
Guenter Roeck, Dilip Kota, linux-phy, devicetree, linux-kernel,
linux-pwm, linux-rtc, alsa-devel, linux-spi, timestamp,
linux-watchdog, Rob Herring, Oleksij Rempel
* Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> [230530 14:49]:
> Make the pattern matching node names a bit stricter to improve DTS
> consistency. The pattern is restricted to:
> 1. Only one unit address or one -N suffix,
> 2. -N suffixes to decimal numbers.
Reviewed-by: Tony Lindgren <tony@atomide.com>
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH 1/7] dt-bindings: phy: intel,combo-phy: restrict node name suffixes
2023-05-30 14:48 ` [PATCH 1/7] dt-bindings: phy: intel,combo-phy: " Krzysztof Kozlowski
2023-05-31 4:27 ` Tony Lindgren
@ 2023-06-09 15:10 ` Rob Herring
2023-06-21 17:32 ` Vinod Koul
2 siblings, 0 replies; 32+ messages in thread
From: Rob Herring @ 2023-06-09 15:10 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Alexandre Belloni, Mark Brown, linux-watchdog, Alessandro Zummo,
linux-spi, Tony Lindgren, Oleksij Rempel, Rob Herring,
devicetree, linux-pwm, Srinivas Kandagatla, Dipen Patel,
Wim Van Sebroeck, Guenter Roeck, Krzysztof Kozlowski, alsa-devel,
Kishon Vijay Abraham I, Dilip Kota, Conor Dooley,
Uwe Kleine-König, linux-rtc, Vinod Koul, linux-kernel,
linux-phy, Thierry Reding, timestamp
On Tue, 30 May 2023 16:48:45 +0200, Krzysztof Kozlowski wrote:
> Make the pattern matching node names a bit stricter to improve DTS
> consistency. The pattern is restricted to:
> 1. Only one unit address or one -N suffix,
> 2. -N suffixes to decimal numbers.
>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> Documentation/devicetree/bindings/phy/intel,combo-phy.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH 1/7] dt-bindings: phy: intel,combo-phy: restrict node name suffixes
2023-05-30 14:48 ` [PATCH 1/7] dt-bindings: phy: intel,combo-phy: " Krzysztof Kozlowski
2023-05-31 4:27 ` Tony Lindgren
2023-06-09 15:10 ` Rob Herring
@ 2023-06-21 17:32 ` Vinod Koul
2 siblings, 0 replies; 32+ messages in thread
From: Vinod Koul @ 2023-06-21 17:32 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Thierry Reding, Uwe Kleine-König,
Alessandro Zummo, Alexandre Belloni, Srinivas Kandagatla,
Mark Brown, Dipen Patel, Wim Van Sebroeck, Guenter Roeck,
Dilip Kota, linux-phy, devicetree, linux-kernel, linux-pwm,
linux-rtc, alsa-devel, linux-spi, timestamp, linux-watchdog,
Rob Herring, Tony Lindgren, Oleksij Rempel
On 30-05-23, 16:48, Krzysztof Kozlowski wrote:
> Make the pattern matching node names a bit stricter to improve DTS
> consistency. The pattern is restricted to:
> 1. Only one unit address or one -N suffix,
> 2. -N suffixes to decimal numbers.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH 2/7] dt-bindings: pwm: restrict node name suffixes
2023-05-30 14:48 [PATCH 0/7] dt-bindings: restrict node name suffixes Krzysztof Kozlowski
2023-05-30 14:48 ` [PATCH 1/7] dt-bindings: phy: intel,combo-phy: " Krzysztof Kozlowski
@ 2023-05-30 14:48 ` Krzysztof Kozlowski
2023-05-31 4:25 ` Tony Lindgren
` (2 more replies)
2023-05-30 14:48 ` [PATCH 3/7] dt-bindings: rtc: " Krzysztof Kozlowski
` (8 subsequent siblings)
10 siblings, 3 replies; 32+ messages in thread
From: Krzysztof Kozlowski @ 2023-05-30 14:48 UTC (permalink / raw)
To: Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Uwe Kleine-König, Alessandro Zummo, Alexandre Belloni,
Srinivas Kandagatla, Mark Brown, Dipen Patel, Wim Van Sebroeck,
Guenter Roeck, Dilip Kota, linux-phy, devicetree, linux-kernel,
linux-pwm, linux-rtc, alsa-devel, linux-spi, timestamp,
linux-watchdog
Cc: Krzysztof Kozlowski, Rob Herring, Tony Lindgren, Oleksij Rempel
Make the pattern matching node names a bit stricter to improve DTS
consistency. The pattern is restricted to:
1. Only one unit address or one -N suffix,
2. -N suffixes to decimal numbers.
Suggested-by: Rob Herring <robh@kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Cc: Tony Lindgren <tony@atomide.com>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>
---
Documentation/devicetree/bindings/pwm/pwm.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pwm/pwm.yaml b/Documentation/devicetree/bindings/pwm/pwm.yaml
index 3c01f85029e5..abd9fa873354 100644
--- a/Documentation/devicetree/bindings/pwm/pwm.yaml
+++ b/Documentation/devicetree/bindings/pwm/pwm.yaml
@@ -13,7 +13,7 @@ select: false
properties:
$nodename:
- pattern: "^pwm(@.*|-[0-9a-f])*$"
+ pattern: "^pwm(@.*|-([0-9]|[1-9][0-9]+))?$"
"#pwm-cells":
description:
--
2.34.1
^ permalink raw reply related [flat|nested] 32+ messages in thread* Re: [PATCH 2/7] dt-bindings: pwm: restrict node name suffixes
2023-05-30 14:48 ` [PATCH 2/7] dt-bindings: pwm: " Krzysztof Kozlowski
@ 2023-05-31 4:25 ` Tony Lindgren
2023-06-07 7:36 ` Uwe Kleine-König
2023-06-09 15:11 ` Rob Herring
2 siblings, 0 replies; 32+ messages in thread
From: Tony Lindgren @ 2023-05-31 4:25 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Uwe Kleine-König, Alessandro Zummo, Alexandre Belloni,
Srinivas Kandagatla, Mark Brown, Dipen Patel, Wim Van Sebroeck,
Guenter Roeck, Dilip Kota, linux-phy, devicetree, linux-kernel,
linux-pwm, linux-rtc, alsa-devel, linux-spi, timestamp,
linux-watchdog, Rob Herring, Oleksij Rempel
* Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> [230530 14:49]:
> Make the pattern matching node names a bit stricter to improve DTS
> consistency. The pattern is restricted to:
> 1. Only one unit address or one -N suffix,
> 2. -N suffixes to decimal numbers.
>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Tony Lindgren <tony@atomide.com>
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH 2/7] dt-bindings: pwm: restrict node name suffixes
2023-05-30 14:48 ` [PATCH 2/7] dt-bindings: pwm: " Krzysztof Kozlowski
2023-05-31 4:25 ` Tony Lindgren
@ 2023-06-07 7:36 ` Uwe Kleine-König
2023-06-07 7:40 ` Krzysztof Kozlowski
2023-06-09 15:11 ` Rob Herring
2 siblings, 1 reply; 32+ messages in thread
From: Uwe Kleine-König @ 2023-06-07 7:36 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Alessandro Zummo, Alexandre Belloni, Srinivas Kandagatla,
Mark Brown, Dipen Patel, Wim Van Sebroeck, Guenter Roeck,
Dilip Kota, linux-phy, devicetree, linux-kernel, linux-pwm,
linux-rtc, alsa-devel, linux-spi, timestamp, linux-watchdog,
Rob Herring, Tony Lindgren, Oleksij Rempel
[-- Attachment #1: Type: text/plain, Size: 2688 bytes --]
On Tue, May 30, 2023 at 04:48:46PM +0200, Krzysztof Kozlowski wrote:
> Make the pattern matching node names a bit stricter to improve DTS
> consistency. The pattern is restricted to:
> 1. Only one unit address or one -N suffix,
> 2. -N suffixes to decimal numbers.
>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> Documentation/devicetree/bindings/pwm/pwm.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/pwm/pwm.yaml b/Documentation/devicetree/bindings/pwm/pwm.yaml
> index 3c01f85029e5..abd9fa873354 100644
> --- a/Documentation/devicetree/bindings/pwm/pwm.yaml
> +++ b/Documentation/devicetree/bindings/pwm/pwm.yaml
> @@ -13,7 +13,7 @@ select: false
>
> properties:
> $nodename:
> - pattern: "^pwm(@.*|-[0-9a-f])*$"
> + pattern: "^pwm(@.*|-([0-9]|[1-9][0-9]+))?$"
With this patch we forbid now the following patterns:
pwm-[0-9a-f][@-].*
pwm-0[0-9a-f]+
pwm-[a-f]([@-].*)?
Checking for such names:
$ git grep -oP '\bpwm-([0-9a-f][@-].*|0[0-9a-f]+|[0-9]*[a-f][0-9a-f]*)(*pla:\s*\{)' arch/*/boot/dts
arch/arm/boot/dts/meson8.dtsi:pwm-f-ao
arch/arm/boot/dts/meson8.dtsi:pwm-e
arch/arm/boot/dts/meson8b.dtsi:pwm-d
arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-a
arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-b-x7
arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-b-x19
arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-c-c
arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-c-x5
arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-c-x8
arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-d-x3
arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-d-x6
arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-e
arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-f-z
arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-f-a
arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-f-x
arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-f-h
arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-a-e
These are all pinmux-settings and no pwm nodes, so the change is fine.
(But arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi isn't properly
sorted alphabetically.)
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Best regards and Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: [PATCH 2/7] dt-bindings: pwm: restrict node name suffixes
2023-06-07 7:36 ` Uwe Kleine-König
@ 2023-06-07 7:40 ` Krzysztof Kozlowski
0 siblings, 0 replies; 32+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-07 7:40 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Alessandro Zummo, Alexandre Belloni, Srinivas Kandagatla,
Mark Brown, Dipen Patel, Wim Van Sebroeck, Guenter Roeck,
Dilip Kota, linux-phy, devicetree, linux-kernel, linux-pwm,
linux-rtc, alsa-devel, linux-spi, timestamp, linux-watchdog,
Rob Herring, Tony Lindgren, Oleksij Rempel
On 07/06/2023 09:36, Uwe Kleine-König wrote:
> On Tue, May 30, 2023 at 04:48:46PM +0200, Krzysztof Kozlowski wrote:
>> Make the pattern matching node names a bit stricter to improve DTS
>> consistency. The pattern is restricted to:
>> 1. Only one unit address or one -N suffix,
>> 2. -N suffixes to decimal numbers.
>>
>> Suggested-by: Rob Herring <robh@kernel.org>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
>>
>> ---
>>
>> Cc: Tony Lindgren <tony@atomide.com>
>> Cc: Oleksij Rempel <o.rempel@pengutronix.de>
>> ---
>> Documentation/devicetree/bindings/pwm/pwm.yaml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pwm/pwm.yaml b/Documentation/devicetree/bindings/pwm/pwm.yaml
>> index 3c01f85029e5..abd9fa873354 100644
>> --- a/Documentation/devicetree/bindings/pwm/pwm.yaml
>> +++ b/Documentation/devicetree/bindings/pwm/pwm.yaml
>> @@ -13,7 +13,7 @@ select: false
>>
>> properties:
>> $nodename:
>> - pattern: "^pwm(@.*|-[0-9a-f])*$"
>> + pattern: "^pwm(@.*|-([0-9]|[1-9][0-9]+))?$"
>
> With this patch we forbid now the following patterns:
>
> pwm-[0-9a-f][@-].*
> pwm-0[0-9a-f]+
> pwm-[a-f]([@-].*)?
Yes, this was discussed last time:
https://lore.kernel.org/all/20221127182232.GA128974-robh@kernel.org/
>
> Checking for such names:
>
> $ git grep -oP '\bpwm-([0-9a-f][@-].*|0[0-9a-f]+|[0-9]*[a-f][0-9a-f]*)(*pla:\s*\{)' arch/*/boot/dts
> arch/arm/boot/dts/meson8.dtsi:pwm-f-ao
> arch/arm/boot/dts/meson8.dtsi:pwm-e
> arch/arm/boot/dts/meson8b.dtsi:pwm-d
> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-a
> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-b-x7
> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-b-x19
> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-c-c
> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-c-x5
> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-c-x8
> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-d-x3
> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-d-x6
> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-e
> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-f-z
> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-f-a
> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-f-x
> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-f-h
> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi:pwm-a-e
Are you sure these are pwms, not pins?
>
> These are all pinmux-settings and no pwm nodes, so the change is fine.
> (But arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi isn't properly
> sorted alphabetically.)
Exactly...
>
> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH 2/7] dt-bindings: pwm: restrict node name suffixes
2023-05-30 14:48 ` [PATCH 2/7] dt-bindings: pwm: " Krzysztof Kozlowski
2023-05-31 4:25 ` Tony Lindgren
2023-06-07 7:36 ` Uwe Kleine-König
@ 2023-06-09 15:11 ` Rob Herring
2 siblings, 0 replies; 32+ messages in thread
From: Rob Herring @ 2023-06-09 15:11 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: alsa-devel, linux-spi, Conor Dooley, Guenter Roeck,
Kishon Vijay Abraham I, linux-kernel, linux-watchdog,
Tony Lindgren, Alexandre Belloni, Oleksij Rempel, linux-phy,
Dipen Patel, devicetree, Thierry Reding, linux-pwm, Mark Brown,
Vinod Koul, Uwe Kleine-König, Rob Herring, Wim Van Sebroeck,
Alessandro Zummo, linux-rtc, Krzysztof Kozlowski,
Srinivas Kandagatla, timestamp, Dilip Kota
On Tue, 30 May 2023 16:48:46 +0200, Krzysztof Kozlowski wrote:
> Make the pattern matching node names a bit stricter to improve DTS
> consistency. The pattern is restricted to:
> 1. Only one unit address or one -N suffix,
> 2. -N suffixes to decimal numbers.
>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> Documentation/devicetree/bindings/pwm/pwm.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH 3/7] dt-bindings: rtc: restrict node name suffixes
2023-05-30 14:48 [PATCH 0/7] dt-bindings: restrict node name suffixes Krzysztof Kozlowski
2023-05-30 14:48 ` [PATCH 1/7] dt-bindings: phy: intel,combo-phy: " Krzysztof Kozlowski
2023-05-30 14:48 ` [PATCH 2/7] dt-bindings: pwm: " Krzysztof Kozlowski
@ 2023-05-30 14:48 ` Krzysztof Kozlowski
2023-05-31 4:25 ` Tony Lindgren
2023-06-06 21:38 ` (subset) " Alexandre Belloni
2023-05-30 14:48 ` [PATCH 4/7] dt-bindings: slimbus: " Krzysztof Kozlowski
` (7 subsequent siblings)
10 siblings, 2 replies; 32+ messages in thread
From: Krzysztof Kozlowski @ 2023-05-30 14:48 UTC (permalink / raw)
To: Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Uwe Kleine-König, Alessandro Zummo, Alexandre Belloni,
Srinivas Kandagatla, Mark Brown, Dipen Patel, Wim Van Sebroeck,
Guenter Roeck, Dilip Kota, linux-phy, devicetree, linux-kernel,
linux-pwm, linux-rtc, alsa-devel, linux-spi, timestamp,
linux-watchdog
Cc: Krzysztof Kozlowski, Rob Herring, Tony Lindgren, Oleksij Rempel
Make the pattern matching node names a bit stricter to improve DTS
consistency. The pattern is restricted to:
1. Only one unit address or one -N suffix,
2. -N suffixes to decimal numbers.
Suggested-by: Rob Herring <robh@kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Cc: Tony Lindgren <tony@atomide.com>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>
---
Documentation/devicetree/bindings/rtc/rtc.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/rtc/rtc.yaml b/Documentation/devicetree/bindings/rtc/rtc.yaml
index c6fff5486fe6..efb66df82782 100644
--- a/Documentation/devicetree/bindings/rtc/rtc.yaml
+++ b/Documentation/devicetree/bindings/rtc/rtc.yaml
@@ -15,7 +15,7 @@ description: |
properties:
$nodename:
- pattern: "^rtc(@.*|-[0-9a-f])*$"
+ pattern: "^rtc(@.*|-([0-9]|[1-9][0-9]+))?$"
aux-voltage-chargeable:
$ref: /schemas/types.yaml#/definitions/uint32
--
2.34.1
^ permalink raw reply related [flat|nested] 32+ messages in thread* Re: [PATCH 3/7] dt-bindings: rtc: restrict node name suffixes
2023-05-30 14:48 ` [PATCH 3/7] dt-bindings: rtc: " Krzysztof Kozlowski
@ 2023-05-31 4:25 ` Tony Lindgren
2023-06-06 21:38 ` (subset) " Alexandre Belloni
1 sibling, 0 replies; 32+ messages in thread
From: Tony Lindgren @ 2023-05-31 4:25 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Uwe Kleine-König, Alessandro Zummo, Alexandre Belloni,
Srinivas Kandagatla, Mark Brown, Dipen Patel, Wim Van Sebroeck,
Guenter Roeck, Dilip Kota, linux-phy, devicetree, linux-kernel,
linux-pwm, linux-rtc, alsa-devel, linux-spi, timestamp,
linux-watchdog, Rob Herring, Oleksij Rempel
* Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> [230530 14:49]:
> Make the pattern matching node names a bit stricter to improve DTS
> consistency. The pattern is restricted to:
> 1. Only one unit address or one -N suffix,
> 2. -N suffixes to decimal numbers.
Reviewed-by: Tony Lindgren <tony@atomide.com>
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: (subset) [PATCH 3/7] dt-bindings: rtc: restrict node name suffixes
2023-05-30 14:48 ` [PATCH 3/7] dt-bindings: rtc: " Krzysztof Kozlowski
2023-05-31 4:25 ` Tony Lindgren
@ 2023-06-06 21:38 ` Alexandre Belloni
1 sibling, 0 replies; 32+ messages in thread
From: Alexandre Belloni @ 2023-06-06 21:38 UTC (permalink / raw)
To: Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Uwe Kleine-König, Alessandro Zummo, Srinivas Kandagatla,
Mark Brown, Dipen Patel, Wim Van Sebroeck, Guenter Roeck,
Dilip Kota, linux-phy, devicetree, linux-kernel, linux-pwm,
linux-rtc, alsa-devel, linux-spi, timestamp, linux-watchdog,
Krzysztof Kozlowski
Cc: Rob Herring, Tony Lindgren, Oleksij Rempel
On Tue, 30 May 2023 16:48:47 +0200, Krzysztof Kozlowski wrote:
> Make the pattern matching node names a bit stricter to improve DTS
> consistency. The pattern is restricted to:
> 1. Only one unit address or one -N suffix,
> 2. -N suffixes to decimal numbers.
>
>
Applied, thanks!
[3/7] dt-bindings: rtc: restrict node name suffixes
commit: 93eff1e0e67a0b54fc16f07f0ca88f8b5afd9f89
Best regards,
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH 4/7] dt-bindings: slimbus: restrict node name suffixes
2023-05-30 14:48 [PATCH 0/7] dt-bindings: restrict node name suffixes Krzysztof Kozlowski
` (2 preceding siblings ...)
2023-05-30 14:48 ` [PATCH 3/7] dt-bindings: rtc: " Krzysztof Kozlowski
@ 2023-05-30 14:48 ` Krzysztof Kozlowski
2023-05-31 4:26 ` Tony Lindgren
2023-06-09 15:13 ` Rob Herring
2023-05-30 14:48 ` [PATCH 5/7] spi: dt-bindings: " Krzysztof Kozlowski
` (6 subsequent siblings)
10 siblings, 2 replies; 32+ messages in thread
From: Krzysztof Kozlowski @ 2023-05-30 14:48 UTC (permalink / raw)
To: Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Uwe Kleine-König, Alessandro Zummo, Alexandre Belloni,
Srinivas Kandagatla, Mark Brown, Dipen Patel, Wim Van Sebroeck,
Guenter Roeck, Dilip Kota, linux-phy, devicetree, linux-kernel,
linux-pwm, linux-rtc, alsa-devel, linux-spi, timestamp,
linux-watchdog
Cc: Krzysztof Kozlowski, Rob Herring, Tony Lindgren, Oleksij Rempel
Make the pattern matching node names a bit stricter to improve DTS
consistency. The pattern is restricted to:
1. Only one unit address or one -N suffix,
2. -N suffixes to decimal numbers.
Suggested-by: Rob Herring <robh@kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Cc: Tony Lindgren <tony@atomide.com>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>
---
Documentation/devicetree/bindings/slimbus/slimbus.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/slimbus/slimbus.yaml b/Documentation/devicetree/bindings/slimbus/slimbus.yaml
index 22513fb7c59a..3b8cae9d1016 100644
--- a/Documentation/devicetree/bindings/slimbus/slimbus.yaml
+++ b/Documentation/devicetree/bindings/slimbus/slimbus.yaml
@@ -15,7 +15,7 @@ description:
properties:
$nodename:
- pattern: "^slim(@.*|-[0-9a-f])*$"
+ pattern: "^slim(@.*|-([0-9]|[1-9][0-9]+))?$"
"#address-cells":
const: 2
--
2.34.1
^ permalink raw reply related [flat|nested] 32+ messages in thread* Re: [PATCH 4/7] dt-bindings: slimbus: restrict node name suffixes
2023-05-30 14:48 ` [PATCH 4/7] dt-bindings: slimbus: " Krzysztof Kozlowski
@ 2023-05-31 4:26 ` Tony Lindgren
2023-06-09 15:13 ` Rob Herring
1 sibling, 0 replies; 32+ messages in thread
From: Tony Lindgren @ 2023-05-31 4:26 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Uwe Kleine-König, Alessandro Zummo, Alexandre Belloni,
Srinivas Kandagatla, Mark Brown, Dipen Patel, Wim Van Sebroeck,
Guenter Roeck, Dilip Kota, linux-phy, devicetree, linux-kernel,
linux-pwm, linux-rtc, alsa-devel, linux-spi, timestamp,
linux-watchdog, Rob Herring, Oleksij Rempel
* Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> [230530 14:49]:
> Make the pattern matching node names a bit stricter to improve DTS
> consistency. The pattern is restricted to:
> 1. Only one unit address or one -N suffix,
> 2. -N suffixes to decimal numbers.
Reviewed-by: Tony Lindgren <tony@atomide.com>
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH 4/7] dt-bindings: slimbus: restrict node name suffixes
2023-05-30 14:48 ` [PATCH 4/7] dt-bindings: slimbus: " Krzysztof Kozlowski
2023-05-31 4:26 ` Tony Lindgren
@ 2023-06-09 15:13 ` Rob Herring
1 sibling, 0 replies; 32+ messages in thread
From: Rob Herring @ 2023-06-09 15:13 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Conor Dooley, Thierry Reding, Kishon Vijay Abraham I, Mark Brown,
Dipen Patel, linux-rtc, Dilip Kota, alsa-devel, Guenter Roeck,
Oleksij Rempel, Alessandro Zummo, linux-spi, Alexandre Belloni,
Srinivas Kandagatla, devicetree, linux-phy, Krzysztof Kozlowski,
Rob Herring, linux-watchdog, Tony Lindgren, linux-kernel,
Wim Van Sebroeck, Vinod Koul, linux-pwm, timestamp,
Uwe Kleine-König
On Tue, 30 May 2023 16:48:48 +0200, Krzysztof Kozlowski wrote:
> Make the pattern matching node names a bit stricter to improve DTS
> consistency. The pattern is restricted to:
> 1. Only one unit address or one -N suffix,
> 2. -N suffixes to decimal numbers.
>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> Documentation/devicetree/bindings/slimbus/slimbus.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH 5/7] spi: dt-bindings: restrict node name suffixes
2023-05-30 14:48 [PATCH 0/7] dt-bindings: restrict node name suffixes Krzysztof Kozlowski
` (3 preceding siblings ...)
2023-05-30 14:48 ` [PATCH 4/7] dt-bindings: slimbus: " Krzysztof Kozlowski
@ 2023-05-30 14:48 ` Krzysztof Kozlowski
2023-05-31 4:26 ` Tony Lindgren
2023-05-30 14:48 ` [PATCH 6/7] dt-bindings: timestamp: " Krzysztof Kozlowski
` (5 subsequent siblings)
10 siblings, 1 reply; 32+ messages in thread
From: Krzysztof Kozlowski @ 2023-05-30 14:48 UTC (permalink / raw)
To: Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Uwe Kleine-König, Alessandro Zummo, Alexandre Belloni,
Srinivas Kandagatla, Mark Brown, Dipen Patel, Wim Van Sebroeck,
Guenter Roeck, Dilip Kota, linux-phy, devicetree, linux-kernel,
linux-pwm, linux-rtc, alsa-devel, linux-spi, timestamp,
linux-watchdog
Cc: Krzysztof Kozlowski, Rob Herring, Tony Lindgren, Oleksij Rempel
Make the pattern matching node names a bit stricter to improve DTS
consistency. The pattern is restricted to:
1. Only one unit address or one -N suffix,
2. -N suffixes to decimal numbers.
Suggested-by: Rob Herring <robh@kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Cc: Tony Lindgren <tony@atomide.com>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>
---
Documentation/devicetree/bindings/spi/spi-controller.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/spi/spi-controller.yaml b/Documentation/devicetree/bindings/spi/spi-controller.yaml
index 90945f59b7e8..524f6fe8c27b 100644
--- a/Documentation/devicetree/bindings/spi/spi-controller.yaml
+++ b/Documentation/devicetree/bindings/spi/spi-controller.yaml
@@ -17,7 +17,7 @@ description: |
properties:
$nodename:
- pattern: "^spi(@.*|-[0-9a-f])*$"
+ pattern: "^spi(@.*|-([0-9]|[1-9][0-9]+))?$"
"#address-cells":
enum: [0, 1]
--
2.34.1
^ permalink raw reply related [flat|nested] 32+ messages in thread* Re: [PATCH 5/7] spi: dt-bindings: restrict node name suffixes
2023-05-30 14:48 ` [PATCH 5/7] spi: dt-bindings: " Krzysztof Kozlowski
@ 2023-05-31 4:26 ` Tony Lindgren
0 siblings, 0 replies; 32+ messages in thread
From: Tony Lindgren @ 2023-05-31 4:26 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Uwe Kleine-König, Alessandro Zummo, Alexandre Belloni,
Srinivas Kandagatla, Mark Brown, Dipen Patel, Wim Van Sebroeck,
Guenter Roeck, Dilip Kota, linux-phy, devicetree, linux-kernel,
linux-pwm, linux-rtc, alsa-devel, linux-spi, timestamp,
linux-watchdog, Rob Herring, Oleksij Rempel
* Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> [230530 14:49]:
> Make the pattern matching node names a bit stricter to improve DTS
> consistency. The pattern is restricted to:
> 1. Only one unit address or one -N suffix,
> 2. -N suffixes to decimal numbers.
Reviewed-by: Tony Lindgren <tony@atomide.com>
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH 6/7] dt-bindings: timestamp: restrict node name suffixes
2023-05-30 14:48 [PATCH 0/7] dt-bindings: restrict node name suffixes Krzysztof Kozlowski
` (4 preceding siblings ...)
2023-05-30 14:48 ` [PATCH 5/7] spi: dt-bindings: " Krzysztof Kozlowski
@ 2023-05-30 14:48 ` Krzysztof Kozlowski
2023-05-31 4:26 ` Tony Lindgren
` (2 more replies)
2023-05-30 14:48 ` [PATCH 7/7] dt-bindings: watchdog: " Krzysztof Kozlowski
` (4 subsequent siblings)
10 siblings, 3 replies; 32+ messages in thread
From: Krzysztof Kozlowski @ 2023-05-30 14:48 UTC (permalink / raw)
To: Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Uwe Kleine-König, Alessandro Zummo, Alexandre Belloni,
Srinivas Kandagatla, Mark Brown, Dipen Patel, Wim Van Sebroeck,
Guenter Roeck, Dilip Kota, linux-phy, devicetree, linux-kernel,
linux-pwm, linux-rtc, alsa-devel, linux-spi, timestamp,
linux-watchdog
Cc: Krzysztof Kozlowski, Rob Herring, Tony Lindgren, Oleksij Rempel
Make the pattern matching node names a bit stricter to improve DTS
consistency. The pattern is restricted to -N suffixes to decimal
numbers.
Suggested-by: Rob Herring <robh@kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Cc: Tony Lindgren <tony@atomide.com>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>
---
.../bindings/timestamp/hardware-timestamps-common.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.yaml b/Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.yaml
index fd6a7b51f571..95f42acd0c54 100644
--- a/Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.yaml
+++ b/Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.yaml
@@ -17,7 +17,7 @@ description:
properties:
$nodename:
- pattern: "^timestamp(@.*|-[0-9a-f])?$"
+ pattern: "^timestamp(@.*|-([0-9]|[1-9][0-9]+))?$"
"#timestamp-cells":
description:
--
2.34.1
^ permalink raw reply related [flat|nested] 32+ messages in thread* Re: [PATCH 6/7] dt-bindings: timestamp: restrict node name suffixes
2023-05-30 14:48 ` [PATCH 6/7] dt-bindings: timestamp: " Krzysztof Kozlowski
@ 2023-05-31 4:26 ` Tony Lindgren
2023-06-09 15:13 ` Rob Herring
2023-06-30 17:34 ` Rob Herring
2 siblings, 0 replies; 32+ messages in thread
From: Tony Lindgren @ 2023-05-31 4:26 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Uwe Kleine-König, Alessandro Zummo, Alexandre Belloni,
Srinivas Kandagatla, Mark Brown, Dipen Patel, Wim Van Sebroeck,
Guenter Roeck, Dilip Kota, linux-phy, devicetree, linux-kernel,
linux-pwm, linux-rtc, alsa-devel, linux-spi, timestamp,
linux-watchdog, Rob Herring, Oleksij Rempel
* Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> [230530 14:49]:
> Make the pattern matching node names a bit stricter to improve DTS
> consistency. The pattern is restricted to -N suffixes to decimal
> numbers.
Reviewed-by: Tony Lindgren <tony@atomide.com>
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH 6/7] dt-bindings: timestamp: restrict node name suffixes
2023-05-30 14:48 ` [PATCH 6/7] dt-bindings: timestamp: " Krzysztof Kozlowski
2023-05-31 4:26 ` Tony Lindgren
@ 2023-06-09 15:13 ` Rob Herring
2023-06-30 17:34 ` Rob Herring
2 siblings, 0 replies; 32+ messages in thread
From: Rob Herring @ 2023-06-09 15:13 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Conor Dooley, Alessandro Zummo, linux-kernel, linux-watchdog,
Mark Brown, Krzysztof Kozlowski, Thierry Reding, Tony Lindgren,
Dilip Kota, Kishon Vijay Abraham I, Vinod Koul, alsa-devel,
Srinivas Kandagatla, devicetree, Alexandre Belloni, linux-pwm,
linux-rtc, linux-spi, Uwe Kleine-König, timestamp,
Wim Van Sebroeck, linux-phy, Oleksij Rempel, Guenter Roeck,
Dipen Patel, Rob Herring
On Tue, 30 May 2023 16:48:50 +0200, Krzysztof Kozlowski wrote:
> Make the pattern matching node names a bit stricter to improve DTS
> consistency. The pattern is restricted to -N suffixes to decimal
> numbers.
>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> .../bindings/timestamp/hardware-timestamps-common.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH 6/7] dt-bindings: timestamp: restrict node name suffixes
2023-05-30 14:48 ` [PATCH 6/7] dt-bindings: timestamp: " Krzysztof Kozlowski
2023-05-31 4:26 ` Tony Lindgren
2023-06-09 15:13 ` Rob Herring
@ 2023-06-30 17:34 ` Rob Herring
2 siblings, 0 replies; 32+ messages in thread
From: Rob Herring @ 2023-06-30 17:34 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-phy, linux-rtc, devicetree, linux-kernel, Alessandro Zummo,
Oleksij Rempel, Rob Herring, linux-watchdog, Conor Dooley,
Srinivas Kandagatla, linux-spi, Mark Brown, Tony Lindgren,
Krzysztof Kozlowski, Dilip Kota, Kishon Vijay Abraham I,
Thierry Reding, timestamp, Vinod Koul, alsa-devel,
Alexandre Belloni, Guenter Roeck, Wim Van Sebroeck,
Uwe Kleine-König, Dipen Patel, linux-pwm
On Tue, 30 May 2023 16:48:50 +0200, Krzysztof Kozlowski wrote:
> Make the pattern matching node names a bit stricter to improve DTS
> consistency. The pattern is restricted to -N suffixes to decimal
> numbers.
>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> .../bindings/timestamp/hardware-timestamps-common.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH 7/7] dt-bindings: watchdog: restrict node name suffixes
2023-05-30 14:48 [PATCH 0/7] dt-bindings: restrict node name suffixes Krzysztof Kozlowski
` (5 preceding siblings ...)
2023-05-30 14:48 ` [PATCH 6/7] dt-bindings: timestamp: " Krzysztof Kozlowski
@ 2023-05-30 14:48 ` Krzysztof Kozlowski
2023-05-30 17:47 ` Guenter Roeck
` (3 more replies)
2023-05-30 15:27 ` [PATCH 0/7] dt-bindings: " Uwe Kleine-König
` (3 subsequent siblings)
10 siblings, 4 replies; 32+ messages in thread
From: Krzysztof Kozlowski @ 2023-05-30 14:48 UTC (permalink / raw)
To: Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Uwe Kleine-König, Alessandro Zummo, Alexandre Belloni,
Srinivas Kandagatla, Mark Brown, Dipen Patel, Wim Van Sebroeck,
Guenter Roeck, Dilip Kota, linux-phy, devicetree, linux-kernel,
linux-pwm, linux-rtc, alsa-devel, linux-spi, timestamp,
linux-watchdog
Cc: Krzysztof Kozlowski, Rob Herring, Tony Lindgren, Oleksij Rempel
Make the pattern matching node names a bit stricter to improve DTS
consistency. The pattern is restricted to -N suffixes to decimal
numbers.
Suggested-by: Rob Herring <robh@kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Cc: Tony Lindgren <tony@atomide.com>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>
---
Documentation/devicetree/bindings/watchdog/watchdog.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/watchdog/watchdog.yaml b/Documentation/devicetree/bindings/watchdog/watchdog.yaml
index 519b48889eb1..f0a584af1223 100644
--- a/Documentation/devicetree/bindings/watchdog/watchdog.yaml
+++ b/Documentation/devicetree/bindings/watchdog/watchdog.yaml
@@ -17,11 +17,11 @@ description: |
select:
properties:
$nodename:
- pattern: "^watchdog(@.*|-[0-9a-f])?$"
+ pattern: "^watchdog(@.*|-([0-9]|[1-9][0-9]+))?$"
properties:
$nodename:
- pattern: "^(timer|watchdog)(@.*|-[0-9a-f])?$"
+ pattern: "^(timer|watchdog)(@.*|-([0-9]|[1-9][0-9]+))?$"
timeout-sec:
description:
--
2.34.1
^ permalink raw reply related [flat|nested] 32+ messages in thread* Re: [PATCH 7/7] dt-bindings: watchdog: restrict node name suffixes
2023-05-30 14:48 ` [PATCH 7/7] dt-bindings: watchdog: " Krzysztof Kozlowski
@ 2023-05-30 17:47 ` Guenter Roeck
2023-05-31 4:26 ` Tony Lindgren
` (2 subsequent siblings)
3 siblings, 0 replies; 32+ messages in thread
From: Guenter Roeck @ 2023-05-30 17:47 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Uwe Kleine-König, Alessandro Zummo, Alexandre Belloni,
Srinivas Kandagatla, Mark Brown, Dipen Patel, Wim Van Sebroeck,
Dilip Kota, linux-phy, devicetree, linux-kernel, linux-pwm,
linux-rtc, alsa-devel, linux-spi, timestamp, linux-watchdog,
Rob Herring, Tony Lindgren, Oleksij Rempel
On Tue, May 30, 2023 at 04:48:51PM +0200, Krzysztof Kozlowski wrote:
> Make the pattern matching node names a bit stricter to improve DTS
> consistency. The pattern is restricted to -N suffixes to decimal
> numbers.
>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
> ---
>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> Documentation/devicetree/bindings/watchdog/watchdog.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/watchdog.yaml b/Documentation/devicetree/bindings/watchdog/watchdog.yaml
> index 519b48889eb1..f0a584af1223 100644
> --- a/Documentation/devicetree/bindings/watchdog/watchdog.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/watchdog.yaml
> @@ -17,11 +17,11 @@ description: |
> select:
> properties:
> $nodename:
> - pattern: "^watchdog(@.*|-[0-9a-f])?$"
> + pattern: "^watchdog(@.*|-([0-9]|[1-9][0-9]+))?$"
>
> properties:
> $nodename:
> - pattern: "^(timer|watchdog)(@.*|-[0-9a-f])?$"
> + pattern: "^(timer|watchdog)(@.*|-([0-9]|[1-9][0-9]+))?$"
>
> timeout-sec:
> description:
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: [PATCH 7/7] dt-bindings: watchdog: restrict node name suffixes
2023-05-30 14:48 ` [PATCH 7/7] dt-bindings: watchdog: " Krzysztof Kozlowski
2023-05-30 17:47 ` Guenter Roeck
@ 2023-05-31 4:26 ` Tony Lindgren
2023-06-09 15:14 ` Rob Herring
2023-06-30 17:04 ` Rob Herring
3 siblings, 0 replies; 32+ messages in thread
From: Tony Lindgren @ 2023-05-31 4:26 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Uwe Kleine-König, Alessandro Zummo, Alexandre Belloni,
Srinivas Kandagatla, Mark Brown, Dipen Patel, Wim Van Sebroeck,
Guenter Roeck, Dilip Kota, linux-phy, devicetree, linux-kernel,
linux-pwm, linux-rtc, alsa-devel, linux-spi, timestamp,
linux-watchdog, Rob Herring, Oleksij Rempel
* Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> [230530 14:49]:
> Make the pattern matching node names a bit stricter to improve DTS
> consistency. The pattern is restricted to -N suffixes to decimal
> numbers.
Reviewed-by: Tony Lindgren <tony@atomide.com>
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH 7/7] dt-bindings: watchdog: restrict node name suffixes
2023-05-30 14:48 ` [PATCH 7/7] dt-bindings: watchdog: " Krzysztof Kozlowski
2023-05-30 17:47 ` Guenter Roeck
2023-05-31 4:26 ` Tony Lindgren
@ 2023-06-09 15:14 ` Rob Herring
2023-06-30 17:04 ` Rob Herring
3 siblings, 0 replies; 32+ messages in thread
From: Rob Herring @ 2023-06-09 15:14 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Alexandre Belloni, linux-spi, Alessandro Zummo, Vinod Koul,
linux-kernel, Dilip Kota, Guenter Roeck, Uwe Kleine-König,
Rob Herring, Mark Brown, alsa-devel, linux-pwm, linux-watchdog,
timestamp, Tony Lindgren, Kishon Vijay Abraham I, devicetree,
linux-rtc, Conor Dooley, Srinivas Kandagatla, linux-phy,
Wim Van Sebroeck, Krzysztof Kozlowski, Oleksij Rempel,
Dipen Patel, Thierry Reding
On Tue, 30 May 2023 16:48:51 +0200, Krzysztof Kozlowski wrote:
> Make the pattern matching node names a bit stricter to improve DTS
> consistency. The pattern is restricted to -N suffixes to decimal
> numbers.
>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> Documentation/devicetree/bindings/watchdog/watchdog.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH 7/7] dt-bindings: watchdog: restrict node name suffixes
2023-05-30 14:48 ` [PATCH 7/7] dt-bindings: watchdog: " Krzysztof Kozlowski
` (2 preceding siblings ...)
2023-06-09 15:14 ` Rob Herring
@ 2023-06-30 17:04 ` Rob Herring
3 siblings, 0 replies; 32+ messages in thread
From: Rob Herring @ 2023-06-30 17:04 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Wim Van Sebroeck, Dipen Patel, Tony Lindgren,
Srinivas Kandagatla, Vinod Koul, Guenter Roeck, Alessandro Zummo,
Krzysztof Kozlowski, Rob Herring, Dilip Kota, Mark Brown,
timestamp, alsa-devel, linux-watchdog, linux-pwm, devicetree,
Alexandre Belloni, Thierry Reding, Oleksij Rempel,
Uwe Kleine-König, linux-phy, linux-spi, linux-rtc,
Conor Dooley, Kishon Vijay Abraham I, linux-kernel
On Tue, 30 May 2023 16:48:51 +0200, Krzysztof Kozlowski wrote:
> Make the pattern matching node names a bit stricter to improve DTS
> consistency. The pattern is restricted to -N suffixes to decimal
> numbers.
>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> Documentation/devicetree/bindings/watchdog/watchdog.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Seems watchdog patches aren't getting applied... Applied, thanks!
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH 0/7] dt-bindings: restrict node name suffixes
2023-05-30 14:48 [PATCH 0/7] dt-bindings: restrict node name suffixes Krzysztof Kozlowski
` (6 preceding siblings ...)
2023-05-30 14:48 ` [PATCH 7/7] dt-bindings: watchdog: " Krzysztof Kozlowski
@ 2023-05-30 15:27 ` Uwe Kleine-König
2023-05-30 17:11 ` Conor Dooley
` (2 subsequent siblings)
10 siblings, 0 replies; 32+ messages in thread
From: Uwe Kleine-König @ 2023-05-30 15:27 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Alessandro Zummo, Alexandre Belloni, Srinivas Kandagatla,
Mark Brown, Dipen Patel, Wim Van Sebroeck, Guenter Roeck,
Dilip Kota, linux-phy, devicetree, linux-kernel, linux-pwm,
linux-rtc, alsa-devel, linux-spi, timestamp, linux-watchdog,
Tony Lindgren, Oleksij Rempel
[-- Attachment #1: Type: text/plain, Size: 585 bytes --]
Hello,
On Tue, May 30, 2023 at 04:48:44PM +0200, Krzysztof Kozlowski wrote:
> Hi,
>
> Tree-wide cleanup of DTS node name suffixes "-N", e.g. "pwm-5", so we allow
> only decimal numbers. In few cases narrow the pattern to also disallow
> multiple suffixes, e.g. "pwm-5-5".
>
> No dependencies, can be applied by individual subsystems.
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: [PATCH 0/7] dt-bindings: restrict node name suffixes
2023-05-30 14:48 [PATCH 0/7] dt-bindings: restrict node name suffixes Krzysztof Kozlowski
` (7 preceding siblings ...)
2023-05-30 15:27 ` [PATCH 0/7] dt-bindings: " Uwe Kleine-König
@ 2023-05-30 17:11 ` Conor Dooley
2023-05-31 6:57 ` Krzysztof Kozlowski
2023-05-30 18:28 ` (subset) " Mark Brown
2023-06-23 14:51 ` Thierry Reding
10 siblings, 1 reply; 32+ messages in thread
From: Conor Dooley @ 2023-05-30 17:11 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Uwe Kleine-König, Alessandro Zummo, Alexandre Belloni,
Srinivas Kandagatla, Mark Brown, Dipen Patel, Wim Van Sebroeck,
Guenter Roeck, Dilip Kota, linux-phy, devicetree, linux-kernel,
linux-pwm, linux-rtc, alsa-devel, linux-spi, timestamp,
linux-watchdog, Tony Lindgren, Oleksij Rempel
[-- Attachment #1: Type: text/plain, Size: 1706 bytes --]
On Tue, May 30, 2023 at 04:48:44PM +0200, Krzysztof Kozlowski wrote:
> Hi,
>
> Tree-wide cleanup of DTS node name suffixes "-N", e.g. "pwm-5", so we allow
> only decimal numbers. In few cases narrow the pattern to also disallow
> multiple suffixes, e.g. "pwm-5-5".
I figure there'll be quite a bit of stuff to fix up afterwards?
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
>
> No dependencies, can be applied by individual subsystems.
>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Oleksij Rempel <o.rempel@pengutronix.de>
>
> Link: https://lore.kernel.org/all/20221127182232.GA128974-robh@kernel.org/
>
> Best regards,
> Krzysztof
>
> Krzysztof Kozlowski (7):
> dt-bindings: phy: intel,combo-phy: restrict node name suffixes
> dt-bindings: pwm: restrict node name suffixes
> dt-bindings: rtc: restrict node name suffixes
> dt-bindings: slimbus: restrict node name suffixes
> spi: dt-bindings: restrict node name suffixes
> dt-bindings: timestamp: restrict node name suffixes
> dt-bindings: watchdog: restrict node name suffixes
>
> Documentation/devicetree/bindings/phy/intel,combo-phy.yaml | 2 +-
> Documentation/devicetree/bindings/pwm/pwm.yaml | 2 +-
> Documentation/devicetree/bindings/rtc/rtc.yaml | 2 +-
> Documentation/devicetree/bindings/slimbus/slimbus.yaml | 2 +-
> Documentation/devicetree/bindings/spi/spi-controller.yaml | 2 +-
> .../bindings/timestamp/hardware-timestamps-common.yaml | 2 +-
> Documentation/devicetree/bindings/watchdog/watchdog.yaml | 4 ++--
> 7 files changed, 8 insertions(+), 8 deletions(-)
>
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: [PATCH 0/7] dt-bindings: restrict node name suffixes
2023-05-30 17:11 ` Conor Dooley
@ 2023-05-31 6:57 ` Krzysztof Kozlowski
0 siblings, 0 replies; 32+ messages in thread
From: Krzysztof Kozlowski @ 2023-05-31 6:57 UTC (permalink / raw)
To: Conor Dooley
Cc: Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Uwe Kleine-König, Alessandro Zummo, Alexandre Belloni,
Srinivas Kandagatla, Mark Brown, Dipen Patel, Wim Van Sebroeck,
Guenter Roeck, Dilip Kota, linux-phy, devicetree, linux-kernel,
linux-pwm, linux-rtc, alsa-devel, linux-spi, timestamp,
linux-watchdog, Tony Lindgren, Oleksij Rempel
On 30/05/2023 19:11, Conor Dooley wrote:
> On Tue, May 30, 2023 at 04:48:44PM +0200, Krzysztof Kozlowski wrote:
>> Hi,
>>
>> Tree-wide cleanup of DTS node name suffixes "-N", e.g. "pwm-5", so we allow
>> only decimal numbers. In few cases narrow the pattern to also disallow
>> multiple suffixes, e.g. "pwm-5-5".
>
> I figure there'll be quite a bit of stuff to fix up afterwards?
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Quick grep shown zero fixes needed.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: (subset) [PATCH 0/7] dt-bindings: restrict node name suffixes
2023-05-30 14:48 [PATCH 0/7] dt-bindings: restrict node name suffixes Krzysztof Kozlowski
` (8 preceding siblings ...)
2023-05-30 17:11 ` Conor Dooley
@ 2023-05-30 18:28 ` Mark Brown
2023-06-23 14:51 ` Thierry Reding
10 siblings, 0 replies; 32+ messages in thread
From: Mark Brown @ 2023-05-30 18:28 UTC (permalink / raw)
To: Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Uwe Kleine-König, Alessandro Zummo, Alexandre Belloni,
Srinivas Kandagatla, Dipen Patel, Wim Van Sebroeck,
Guenter Roeck, Dilip Kota, linux-phy, devicetree, linux-kernel,
linux-pwm, linux-rtc, alsa-devel, linux-spi, timestamp,
linux-watchdog, Krzysztof Kozlowski
Cc: Tony Lindgren, Oleksij Rempel
On Tue, 30 May 2023 16:48:44 +0200, Krzysztof Kozlowski wrote:
> Tree-wide cleanup of DTS node name suffixes "-N", e.g. "pwm-5", so we allow
> only decimal numbers. In few cases narrow the pattern to also disallow
> multiple suffixes, e.g. "pwm-5-5".
>
> No dependencies, can be applied by individual subsystems.
>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Oleksij Rempel <o.rempel@pengutronix.de>
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[5/7] spi: dt-bindings: restrict node name suffixes
commit: c4fb6880edc15866a530c7b8f2698ae65f80cfab
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: (subset) [PATCH 0/7] dt-bindings: restrict node name suffixes
2023-05-30 14:48 [PATCH 0/7] dt-bindings: restrict node name suffixes Krzysztof Kozlowski
` (9 preceding siblings ...)
2023-05-30 18:28 ` (subset) " Mark Brown
@ 2023-06-23 14:51 ` Thierry Reding
10 siblings, 0 replies; 32+ messages in thread
From: Thierry Reding @ 2023-06-23 14:51 UTC (permalink / raw)
To: Vinod Koul, Kishon Vijay Abraham I, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Uwe Kleine-König,
Alessandro Zummo, Alexandre Belloni, Srinivas Kandagatla,
Mark Brown, Dipen Patel, Wim Van Sebroeck, Guenter Roeck,
Dilip Kota, linux-phy, devicetree, linux-kernel, linux-pwm,
linux-rtc, alsa-devel, linux-spi, timestamp, linux-watchdog,
Krzysztof Kozlowski
Cc: Tony Lindgren, Oleksij Rempel
On Tue, 30 May 2023 16:48:44 +0200, Krzysztof Kozlowski wrote:
> Tree-wide cleanup of DTS node name suffixes "-N", e.g. "pwm-5", so we allow
> only decimal numbers. In few cases narrow the pattern to also disallow
> multiple suffixes, e.g. "pwm-5-5".
>
> No dependencies, can be applied by individual subsystems.
>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Oleksij Rempel <o.rempel@pengutronix.de>
>
> [...]
Applied, thanks!
[2/7] dt-bindings: pwm: restrict node name suffixes
commit: 05b743db9d8cc4e51b3eb77889d24ab9aa2bf169
Best regards,
--
Thierry Reding <thierry.reding@gmail.com>
^ permalink raw reply [flat|nested] 32+ messages in thread