* mdadm test suite improvements
@ 2022-05-16 14:09 Mariusz Tkaczyk
2022-05-16 14:28 ` Coly Li
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Mariusz Tkaczyk @ 2022-05-16 14:09 UTC (permalink / raw)
To: Nigel Croxon, Coly Li, Xiao Ni, Jes Sorensen, linux-raid
Hello All,
I'm working on names handling in mdadm and I need to add some new test to
the mdadm scope - to verify that it is working as desired.
Bash is not best choice for testing and in current form, our tests are not
friendly for developers. I would like to introduce another python based test
scope and add it to repository. I will integrate it with current framework.
I can see that currently test are not well used and they aren't often updated.
I want to bring new life to them. Adopting more modern approach seems to be good
start point.
Any thoughts?
Thanks in advance,
Mariusz
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: mdadm test suite improvements 2022-05-16 14:09 mdadm test suite improvements Mariusz Tkaczyk @ 2022-05-16 14:28 ` Coly Li 2022-05-16 18:26 ` Nigel Croxon ` (2 subsequent siblings) 3 siblings, 0 replies; 7+ messages in thread From: Coly Li @ 2022-05-16 14:28 UTC (permalink / raw) To: Mariusz Tkaczyk; +Cc: linux-raid, Nigel Croxon, Jes Sorensen, Xiao Ni On 5/16/22 10:09 PM, Mariusz Tkaczyk wrote: > Hello All, > I'm working on names handling in mdadm and I need to add some new test to > the mdadm scope - to verify that it is working as desired. > Bash is not best choice for testing and in current form, our tests are not > friendly for developers. I would like to introduce another python based test > scope and add it to repository. I will integrate it with current framework. > > I can see that currently test are not well used and they aren't often updated. > I want to bring new life to them. Adopting more modern approach seems to be good > start point. > Any thoughts? Hi Mariusz, Yes IMHO python is more ideal than bash. Personally I am supportive to this idea. Thanks. Coly Li ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: mdadm test suite improvements 2022-05-16 14:09 mdadm test suite improvements Mariusz Tkaczyk 2022-05-16 14:28 ` Coly Li @ 2022-05-16 18:26 ` Nigel Croxon 2022-05-16 18:58 ` Himanshu Madhani 2022-05-17 1:48 ` Xiao Ni 3 siblings, 0 replies; 7+ messages in thread From: Nigel Croxon @ 2022-05-16 18:26 UTC (permalink / raw) To: Mariusz Tkaczyk, Coly Li, Xiao Ni, Jes Sorensen, linux-raid On 5/16/22 10:09 AM, Mariusz Tkaczyk wrote: > Hello All, > I'm working on names handling in mdadm and I need to add some new test to > the mdadm scope - to verify that it is working as desired. > Bash is not best choice for testing and in current form, our tests are not > friendly for developers. I would like to introduce another python based test > scope and add it to repository. I will integrate it with current framework. > > I can see that currently test are not well used and they aren't often updated. > I want to bring new life to them. Adopting more modern approach seems to be good > start point. > Any thoughts? > > Thanks in advance, > Mariusz > Hello Mariusz, Python is a great choice. Good with me. -Nigel ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: mdadm test suite improvements 2022-05-16 14:09 mdadm test suite improvements Mariusz Tkaczyk 2022-05-16 14:28 ` Coly Li 2022-05-16 18:26 ` Nigel Croxon @ 2022-05-16 18:58 ` Himanshu Madhani 2022-05-17 1:48 ` Xiao Ni 3 siblings, 0 replies; 7+ messages in thread From: Himanshu Madhani @ 2022-05-16 18:58 UTC (permalink / raw) To: Mariusz Tkaczyk; +Cc: Nigel Croxon, Coly Li, Xiao Ni, Jes Sorensen, linux-raid Mariusz, > On May 16, 2022, at 7:09 AM, Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com> wrote: > > Hello All, > I'm working on names handling in mdadm and I need to add some new test to > the mdadm scope - to verify that it is working as desired. > Bash is not best choice for testing and in current form, our tests are not > friendly for developers. I would like to introduce another python based test > scope and add it to repository. I will integrate it with current framework. > > I can see that currently test are not well used and they aren't often updated. > I want to bring new life to them. Adopting more modern approach seems to be good > start point. > Any thoughts? > > Thanks in advance, > Mariusz FWIW, Python is the right choice to modernize the framework. I recently ran the test suite and sent out a series [1] addressing issues we found with the test cases. I would agree that python would be more helpful in the wider adoption of the test framework. [1] https://marc.info/?l=linux-raid&m=165220252031480&w=2 -- Himanshu Madhani Oracle Linux Engineering ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: mdadm test suite improvements 2022-05-16 14:09 mdadm test suite improvements Mariusz Tkaczyk ` (2 preceding siblings ...) 2022-05-16 18:58 ` Himanshu Madhani @ 2022-05-17 1:48 ` Xiao Ni [not found] ` <-laavsfgtlo10lebdsj460ptakf7ob3swf0up-4xyanlxfob29oebwn0um9140l133r8-rukduq-tekz50-og1qjp-za66of-qnod9a-cdghzt8enrbc-ei4sg9-7sa12trdyicp-e03x62jcjj2j-h0xih6.1652752832458@email.android.com> 3 siblings, 1 reply; 7+ messages in thread From: Xiao Ni @ 2022-05-17 1:48 UTC (permalink / raw) To: Mariusz Tkaczyk; +Cc: Nigel Croxon, Coly Li, Jes Sorensen, linux-raid Hi Mariusz Thanks for the effort. Have you init the git project to start this? If so, you can send it, so we can work together about this. Best Regards Xiao On Mon, May 16, 2022 at 10:09 PM Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com> wrote: > > Hello All, > I'm working on names handling in mdadm and I need to add some new test to > the mdadm scope - to verify that it is working as desired. > Bash is not best choice for testing and in current form, our tests are not > friendly for developers. I would like to introduce another python based test > scope and add it to repository. I will integrate it with current framework. > > I can see that currently test are not well used and they aren't often updated. > I want to bring new life to them. Adopting more modern approach seems to be good > start point. > Any thoughts? > > Thanks in advance, > Mariusz > ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <-laavsfgtlo10lebdsj460ptakf7ob3swf0up-4xyanlxfob29oebwn0um9140l133r8-rukduq-tekz50-og1qjp-za66of-qnod9a-cdghzt8enrbc-ei4sg9-7sa12trdyicp-e03x62jcjj2j-h0xih6.1652752832458@email.android.com>]
* Re: 回复：mdadm test suite improvements [not found] ` <-laavsfgtlo10lebdsj460ptakf7ob3swf0up-4xyanlxfob29oebwn0um9140l133r8-rukduq-tekz50-og1qjp-za66of-qnod9a-cdghzt8enrbc-ei4sg9-7sa12trdyicp-e03x62jcjj2j-h0xih6.1652752832458@email.android.com> @ 2022-05-17 7:54 ` Mariusz Tkaczyk 2022-05-17 8:16 ` Coly Li 0 siblings, 1 reply; 7+ messages in thread From: Mariusz Tkaczyk @ 2022-05-17 7:54 UTC (permalink / raw) To: Coly Li; +Cc: Xiao Ni, Nigel Croxon, Jes Sorensen, linux-raid Hi, I wanted to add it to the mdadm repo, let say under directory "python_tests". I didn't started work yet. Those tests should stay with mdadm, so we can develop them with Coly using mdadm-ci and later ask Jes to merge the branch. I don't have any details, I just asked to gather feedback. Seems that there is big interest in this change. If there is any volunteer to take this topic and prepare python API for testing and first tests- I will be pleased to help. I could take long time before I will start this topic. Thanks, Mariusz On Tue, 17 May 2022 10:00:32 +0800 Coly Li <colyli@suse.de> wrote: > Hi Xiao, > > Yes there is a git repo specific for test scripts, to test the mdadm-ci repo. > It is located on kernel.org git server, which currently only contains bash > scripts copied from mdadm. > > Coly > > From my phone > > > > -------- 原始邮件 -------- > 发件人： Xiao Ni <xni@redhat.com> > 日期： 2022年5月17日周二 上午9:48 > 收件人： Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com> > 抄送： Nigel Croxon <ncroxon@redhat.com>, Coly Li <colyli@suse.de>, Jes > Sorensen <jes@trained-monkey.org>, linux-raid <linux-raid@vger.kernel.org> 主 > 题： Re: mdadm test suite improvements Hi Mariusz > > > > Thanks for the effort. Have you init the git project to start this? If > > so, you can send it, so we can > > work together about this. > > > > Best Regards > > Xiao > > > > On Mon, May 16, 2022 at 10:09 PM Mariusz Tkaczyk > > <mariusz.tkaczyk@linux.intel.com> wrote: > > > > > > Hello All, > > > I'm working on names handling in mdadm and I need to add some new test to > > > the mdadm scope - to verify that it is working as desired. > > > Bash is not best choice for testing and in current form, our tests are not > > > friendly for developers. I would like to introduce another python based > > > test scope and add it to repository. I will integrate it with current > > > framework. > > > > > > I can see that currently test are not well used and they aren't often > > > updated. I want to bring new life to them. Adopting more modern approach > > > seems to be good start point. > > > Any thoughts? > > > > > > Thanks in advance, > > > Mariusz > > > > > > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: 回复：mdadm test suite improvements 2022-05-17 7:54 ` 回复：mdadm " Mariusz Tkaczyk @ 2022-05-17 8:16 ` Coly Li 0 siblings, 0 replies; 7+ messages in thread From: Coly Li @ 2022-05-17 8:16 UTC (permalink / raw) To: Mariusz Tkaczyk; +Cc: Xiao Ni, Nigel Croxon, Jes Sorensen, linux-raid On 5/17/22 3:54 PM, Mariusz Tkaczyk wrote: > Hi, > I wanted to add it to the mdadm repo, let say under directory > "python_tests". I didn't started work yet. Those tests should stay with mdadm, > so we can develop them with Coly using mdadm-ci and later ask Jes to merge the > branch. I am fine and supportive to this idea. mdadm-tests is from the ci testing itself, I can copy python_tests to it time to time. > > I don't have any details, I just asked to gather feedback. Seems that there is > big interest in this change. If there is any volunteer to take this topic and > prepare python API for testing and first tests- I will be pleased to help. > > I could take long time before I will start this topic. Let's wait for response. If no one response for a while, then the person should be me LOL. I am learning Python now, and the progress might take time anyway. Thanks. Coly Li > > Thanks, > Mariusz > > On Tue, 17 May 2022 10:00:32 +0800 > Coly Li <colyli@suse.de> wrote: > >> Hi Xiao, >> >> Yes there is a git repo specific for test scripts, to test the mdadm-ci repo. >> It is located on kernel.org git server, which currently only contains bash >> scripts copied from mdadm. >> >> Coly >> >> From my phone >> >> >> >> -------- 原始邮件 -------- >> 发件人： Xiao Ni <xni@redhat.com> >> 日期： 2022年5月17日周二 上午9:48 >> 收件人： Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com> >> 抄送： Nigel Croxon <ncroxon@redhat.com>, Coly Li <colyli@suse.de>, Jes >> Sorensen <jes@trained-monkey.org>, linux-raid <linux-raid@vger.kernel.org> 主 >> 题： Re: mdadm test suite improvements Hi Mariusz >>> Thanks for the effort. Have you init the git project to start this? If >>> so, you can send it, so we can >>> work together about this. >>> >>> Best Regards >>> Xiao >>> >>> On Mon, May 16, 2022 at 10:09 PM Mariusz Tkaczyk >>> <mariusz.tkaczyk@linux.intel.com> wrote: >>>> Hello All, >>>> I'm working on names handling in mdadm and I need to add some new test to >>>> the mdadm scope - to verify that it is working as desired. >>>> Bash is not best choice for testing and in current form, our tests are not >>>> friendly for developers. I would like to introduce another python based >>>> test scope and add it to repository. I will integrate it with current >>>> framework. >>>> >>>> I can see that currently test are not well used and they aren't often >>>> updated. I want to bring new life to them. Adopting more modern approach >>>> seems to be good start point. >>>> Any thoughts? >>>> >>>> Thanks in advance, >>>> Mariusz >>>> >>> ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-05-17 8:17 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-16 14:09 mdadm test suite improvements Mariusz Tkaczyk
2022-05-16 14:28 ` Coly Li
2022-05-16 18:26 ` Nigel Croxon
2022-05-16 18:58 ` Himanshu Madhani
2022-05-17 1:48 ` Xiao Ni
[not found] ` <-laavsfgtlo10lebdsj460ptakf7ob3swf0up-4xyanlxfob29oebwn0um9140l133r8-rukduq-tekz50-og1qjp-za66of-qnod9a-cdghzt8enrbc-ei4sg9-7sa12trdyicp-e03x62jcjj2j-h0xih6.1652752832458@email.android.com>
2022-05-17 7:54 ` 回复：mdadm " Mariusz Tkaczyk
2022-05-17 8:16 ` Coly Li
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).