mdadm test suite improvements

mdadm test suite improvements

[Mariusz Tkaczyk]

Hello All,
I'm working on names handling in mdadm and I need to add some new test to
the mdadm scope - to verify that it is working as desired.
Bash is not best choice for testing and in current form, our tests are not
friendly for developers. I would like to introduce another python based test
scope and add it to repository. I will integrate it with current framework.

I can see that currently test are not well used and they aren't often updated.
I want to bring new life to them. Adopting more modern approach seems to be good
start point.
Any thoughts?

Thanks in advance,
Mariusz

Re: mdadm test suite improvements

[Coly Li]

On 5/16/22 10:09 PM, Mariusz Tkaczyk wrote:
> Hello All,
> I'm working on names handling in mdadm and I need to add some new test to
> the mdadm scope - to verify that it is working as desired.
> Bash is not best choice for testing and in current form, our tests are not
> friendly for developers. I would like to introduce another python based test
> scope and add it to repository. I will integrate it with current framework.
>
> I can see that currently test are not well used and they aren't often updated.
> I want to bring new life to them. Adopting more modern approach seems to be good
> start point.
> Any thoughts?


Hi Mariusz,

Yes IMHO python is more ideal than bash. Personally I am supportive to 
this idea.

Thanks.

Coly Li

Re: mdadm test suite improvements

[Nigel Croxon]

On 5/16/22 10:09 AM, Mariusz Tkaczyk wrote:
> Hello All,
> I'm working on names handling in mdadm and I need to add some new test to
> the mdadm scope - to verify that it is working as desired.
> Bash is not best choice for testing and in current form, our tests are not
> friendly for developers. I would like to introduce another python based test
> scope and add it to repository. I will integrate it with current framework.
> 
> I can see that currently test are not well used and they aren't often updated.
> I want to bring new life to them. Adopting more modern approach seems to be good
> start point.
> Any thoughts?
> 
> Thanks in advance,
> Mariusz
> 

Hello Mariusz,

Python is a great choice. Good with me.

-Nigel

Re: mdadm test suite improvements

[Himanshu Madhani]

Mariusz, 

> On May 16, 2022, at 7:09 AM, Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com> wrote:
> 
> Hello All,
> I'm working on names handling in mdadm and I need to add some new test to
> the mdadm scope - to verify that it is working as desired.
> Bash is not best choice for testing and in current form, our tests are not
> friendly for developers. I would like to introduce another python based test
> scope and add it to repository. I will integrate it with current framework.
> 
> I can see that currently test are not well used and they aren't often updated.
> I want to bring new life to them. Adopting more modern approach seems to be good
> start point.
> Any thoughts?
> 
> Thanks in advance,
> Mariusz

FWIW, Python is the right choice to modernize the framework. I recently ran the test suite and sent out a series [1] addressing issues we found with the test cases. I would agree that python would be more helpful in the wider adoption of the test framework.

[1] https://marc.info/?l=linux-raid&m=165220252031480&w=2

--
Himanshu Madhani	Oracle Linux Engineering

Re: mdadm test suite improvements

[Xiao Ni]

Hi Mariusz

Thanks for the effort. Have you init the git project to start this? If
so, you can send it, so we can
work together about this.

Best Regards
Xiao

On Mon, May 16, 2022 at 10:09 PM Mariusz Tkaczyk
<mariusz.tkaczyk@linux.intel.com> wrote:
>
> Hello All,
> I'm working on names handling in mdadm and I need to add some new test to
> the mdadm scope - to verify that it is working as desired.
> Bash is not best choice for testing and in current form, our tests are not
> friendly for developers. I would like to introduce another python based test
> scope and add it to repository. I will integrate it with current framework.
>
> I can see that currently test are not well used and they aren't often updated.
> I want to bring new life to them. Adopting more modern approach seems to be good
> start point.
> Any thoughts?
>
> Thanks in advance,
> Mariusz
>

Re: 回复：mdadm test suite improvements

[Mariusz Tkaczyk]

Hi,
I wanted to add it to the mdadm repo, let say under directory
"python_tests". I didn't started work yet. Those tests should stay with mdadm,
so we can develop them with Coly using mdadm-ci and later ask Jes to merge the
branch.

I don't have any details, I just asked to gather feedback. Seems that there is
big interest in this change. If there is any volunteer to take this topic and
prepare python API for testing and first tests- I will be pleased to help.

I could take long time before I will start this topic.

Thanks,
Mariusz

On Tue, 17 May 2022 10:00:32 +0800
‪Coly Li‬ <colyli@suse.de> wrote:

> Hi Xiao,
> 
> Yes there is a git repo specific for test scripts, to test the mdadm-ci repo.
> It is located on kernel.org git server, which currently only contains bash
> scripts copied from mdadm.
> 
> Coly
> 
> From my phone
> 
> 
> 
> -------- 原始邮件 --------
> 发件人： Xiao Ni <xni@redhat.com>
> 日期： 2022年5月17日周二 上午9:48
> 收件人： Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
> 抄送： Nigel Croxon <ncroxon@redhat.com>, Coly Li <colyli@suse.de>, Jes
> Sorensen <jes@trained-monkey.org>, linux-raid <linux-raid@vger.kernel.org> 主
> 题： Re: mdadm test suite improvements Hi Mariusz
> > 
> > Thanks for the effort. Have you init the git project to start this? If
> > so, you can send it, so we can
> > work together about this.
> > 
> > Best Regards
> > Xiao
> > 
> > On Mon, May 16, 2022 at 10:09 PM Mariusz Tkaczyk
> > <mariusz.tkaczyk@linux.intel.com> wrote:
> > >
> > > Hello All,
> > > I'm working on names handling in mdadm and I need to add some new test to
> > > the mdadm scope - to verify that it is working as desired.
> > > Bash is not best choice for testing and in current form, our tests are not
> > > friendly for developers. I would like to introduce another python based
> > > test scope and add it to repository. I will integrate it with current
> > > framework.
> > >
> > > I can see that currently test are not well used and they aren't often
> > > updated. I want to bring new life to them. Adopting more modern approach
> > > seems to be good start point.
> > > Any thoughts?
> > >
> > > Thanks in advance,
> > > Mariusz
> > >
> > 
> > 

Re: 回复：mdadm test suite improvements

[Coly Li]

On 5/17/22 3:54 PM, Mariusz Tkaczyk wrote:
> Hi,
> I wanted to add it to the mdadm repo, let say under directory
> "python_tests". I didn't started work yet. Those tests should stay with mdadm,
> so we can develop them with Coly using mdadm-ci and later ask Jes to merge the
> branch.

I am fine and supportive to this idea. mdadm-tests is from the ci 
testing itself, I can copy python_tests to it time to time.

>
> I don't have any details, I just asked to gather feedback. Seems that there is
> big interest in this change. If there is any volunteer to take this topic and
> prepare python API for testing and first tests- I will be pleased to help.
>
> I could take long time before I will start this topic.


Let's wait for response. If no one response for a while, then the person 
should be me LOL. I am learning Python now, and the progress might take 
time anyway.


Thanks.


Coly Li


>
> Thanks,
> Mariusz
>
> On Tue, 17 May 2022 10:00:32 +0800
> ‪Coly Li‬ <colyli@suse.de> wrote:
>
>> Hi Xiao,
>>
>> Yes there is a git repo specific for test scripts, to test the mdadm-ci repo.
>> It is located on kernel.org git server, which currently only contains bash
>> scripts copied from mdadm.
>>
>> Coly
>>
>>  From my phone
>>
>>
>>
>> -------- 原始邮件 --------
>> 发件人： Xiao Ni <xni@redhat.com>
>> 日期： 2022年5月17日周二 上午9:48
>> 收件人： Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
>> 抄送： Nigel Croxon <ncroxon@redhat.com>, Coly Li <colyli@suse.de>, Jes
>> Sorensen <jes@trained-monkey.org>, linux-raid <linux-raid@vger.kernel.org> 主
>> 题： Re: mdadm test suite improvements Hi Mariusz
>>> Thanks for the effort. Have you init the git project to start this? If
>>> so, you can send it, so we can
>>> work together about this.
>>>
>>> Best Regards
>>> Xiao
>>>
>>> On Mon, May 16, 2022 at 10:09 PM Mariusz Tkaczyk
>>> <mariusz.tkaczyk@linux.intel.com> wrote:
>>>> Hello All,
>>>> I'm working on names handling in mdadm and I need to add some new test to
>>>> the mdadm scope - to verify that it is working as desired.
>>>> Bash is not best choice for testing and in current form, our tests are not
>>>> friendly for developers. I would like to introduce another python based
>>>> test scope and add it to repository. I will integrate it with current
>>>> framework.
>>>>
>>>> I can see that currently test are not well used and they aren't often
>>>> updated. I want to bring new life to them. Adopting more modern approach
>>>> seems to be good start point.
>>>> Any thoughts?
>>>>
>>>> Thanks in advance,
>>>> Mariusz
>>>>
>>>