[PATCH rdma-rc] IB/core: Fix wrong iterating on ports

[PATCH rdma-rc] IB/core: Fix wrong iterating on ports

[Leon Romanovsky]

From: Mohamad Heib <mohamadh@mellanox.com>

rdma_for_each_port is already incrementing the iterator's value
it receives therefore, after the first iteration the iterator is
increased by 2 which eventually causing wrong queries
and possible traces.

Fix the above by removing the old redundant incrementation that
was used before rdma_for_each_port() macro.

Fixes: ea1075edcbab ("RDMA: Add and use rdma_for_each_port")
Signed-off-by: Mohamad Heib <mohamadh@mellanox.com>
Reviewed-by: Erez Alfasi <ereza@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
---
 drivers/infiniband/core/security.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/core/security.c b/drivers/infiniband/core/security.c
index 1ab423b19f77..6eb6d2717ca5 100644
--- a/drivers/infiniband/core/security.c
+++ b/drivers/infiniband/core/security.c
@@ -426,7 +426,7 @@ int ib_create_qp_security(struct ib_qp *qp, struct ib_device *dev)
 	int ret;
 
 	rdma_for_each_port (dev, i) {
-		is_ib = rdma_protocol_ib(dev, i++);
+		is_ib = rdma_protocol_ib(dev, i);
 		if (is_ib)
 			break;
 	}
-- 
2.20.1

Re: [PATCH rdma-rc] IB/core: Fix wrong iterating on ports

[Jason Gunthorpe]

On Wed, Oct 02, 2019 at 03:21:27PM +0300, Leon Romanovsky wrote:
> From: Mohamad Heib <mohamadh@mellanox.com>
> 
> rdma_for_each_port is already incrementing the iterator's value
> it receives therefore, after the first iteration the iterator is
> increased by 2 which eventually causing wrong queries
> and possible traces.
> 
> Fix the above by removing the old redundant incrementation that
> was used before rdma_for_each_port() macro.
> 
> Fixes: ea1075edcbab ("RDMA: Add and use rdma_for_each_port")
> Signed-off-by: Mohamad Heib <mohamadh@mellanox.com>
> Reviewed-by: Erez Alfasi <ereza@mellanox.com>
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> ---
>  drivers/infiniband/core/security.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to for-rc, thanks

Jason