From: Guo Zhi <qtxuning1999@sjtu.edu.cn>
To: "Marciniszyn, Mike" <mike.marciniszyn@cornelisnetworks.com>,
Bart Van Assche <bvanassche@acm.org>
Cc: "Dalessandro, Dennis" <dennis.dalessandro@cornelisnetworks.com>,
"dledford@redhat.com" <dledford@redhat.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Leon Romanovsky <leon@kernel.org>,
Jason Gunthorpe <jgg@nvidia.com>
Subject: Re: [PATCH] infiniband hfi1: fix misuse of %x in ipoib_tx.c
Date: Sat, 25 Sep 2021 08:20:46 +0800 [thread overview]
Message-ID: <9439f81a-9bcb-816e-4187-2b37a388db19@sjtu.edu.cn> (raw)
In-Reply-To: <CH0PR01MB71533CD295D5799DC26CF857F2A49@CH0PR01MB7153.prod.exchangelabs.com>
On 2021/9/24 22:43, Marciniszyn, Mike wrote:
>> On 9/22/21 23:45, Leon Romanovsky wrote:
>>> Isn't kptr_restrict sysctl is for that?
>> Hi Leon,
>>
>> After I sent my email I discovered the following commit: 5ead723a20e0
>> ("lib/vsprintf: no_hash_pointers prints all addresses as unhashed"; v5.12).
>> I think that commit does what we need?
>>
> Thanks Bart,
>
> I agree.
>
> Jason, as to traces, I suspect we need to do the same %p thing there for existing code and any new work.
>
> For situations for debugging in the wild, a command line arg can show the actual value. I'm ok with that.
>
> Mike
Can this patch which changes %llx to %p in infiniband hfi1 to avoid
kernel pointer release be applied?
Thanks.
Guo
next prev parent reply other threads:[~2021-09-25 0:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 13:48 [PATCH] infiniband hfi1: fix misuse of %x in ipoib_tx.c Guo Zhi
2021-09-22 17:51 ` Marciniszyn, Mike
2021-09-22 18:05 ` Bart Van Assche
2021-09-23 6:45 ` Leon Romanovsky
2021-09-23 11:04 ` Marciniszyn, Mike
2021-09-23 11:44 ` Leon Romanovsky
2021-09-23 12:18 ` Marciniszyn, Mike
2021-09-24 2:46 ` Bart Van Assche
2021-09-24 14:43 ` Marciniszyn, Mike
2021-09-25 0:20 ` Guo Zhi [this message]
2021-09-23 11:03 ` Marciniszyn, Mike
2021-09-23 13:15 ` Jason Gunthorpe
2021-09-23 2:03 ` 郭志
2021-09-23 12:51 ` 郭志
2021-09-27 13:05 ` Marciniszyn, Mike
2021-09-27 17:42 ` Jason Gunthorpe
-- strict thread matches above, loose matches on Subject: below --
2021-09-22 12:33 Guo Zhi
2021-09-22 12:37 ` Dennis Dalessandro
2021-09-24 14:46 ` Marciniszyn, Mike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9439f81a-9bcb-816e-4187-2b37a388db19@sjtu.edu.cn \
--to=qtxuning1999@sjtu.edu.cn \
--cc=bvanassche@acm.org \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=dledford@redhat.com \
--cc=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@cornelisnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).