From: "Marciniszyn, Mike" <mike.marciniszyn@cornelisnetworks.com>
To: Guo Zhi <qtxuning1999@sjtu.edu.cn>,
"Dalessandro, Dennis" <dennis.dalessandro@cornelisnetworks.com>,
"dledford@redhat.com" <dledford@redhat.com>
Cc: "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] infiniband hfi1: fix misuse of %x in ipoib_tx.c
Date: Fri, 24 Sep 2021 14:46:09 +0000 [thread overview]
Message-ID: <CH0PR01MB71538BE2332867B20A4A77BEF2A49@CH0PR01MB7153.prod.exchangelabs.com> (raw)
In-Reply-To: <20210922123341.601450-1-qtxuning1999@sjtu.edu.cn>
> Subject: [PATCH] infiniband hfi1: fix misuse of %x in ipoib_tx.c
>
> Pointers should be printed with %p or %px rather than cast to (unsigned long
> long) and printed with %llx.
> Change %llx to %p to print the pointer.
>
> Signed-off-by: Guo Zhi <qtxuning1999@sjtu.edu.cn>
> ---
> drivers/infiniband/hw/hfi1/ipoib_tx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/hw/hfi1/ipoib_tx.c
> b/drivers/infiniband/hw/hfi1/ipoib_tx.c
> index e74ddbe4658..7381f352311 100644
> --- a/drivers/infiniband/hw/hfi1/ipoib_tx.c
> +++ b/drivers/infiniband/hw/hfi1/ipoib_tx.c
> @@ -876,13 +876,13 @@ void hfi1_ipoib_tx_timeout(struct net_device
> *dev, unsigned int q)
> struct hfi1_ipoib_txq *txq = &priv->txqs[q];
> u64 completed = atomic64_read(&txq->complete_txreqs);
>
> - dd_dev_info(priv->dd, "timeout txq %llx q %u stopped %u stops %d
> no_desc %d ring_full %d\n",
> + dd_dev_info(priv->dd, "timeout txq %p q %u stopped %u stops %d
> no_desc
> +%d ring_full %d\n",
> (unsigned long long)txq, q,
> __netif_subqueue_stopped(dev, txq->q_idx),
> atomic_read(&txq->stops),
> atomic_read(&txq->no_desc),
> atomic_read(&txq->ring_full));
> - dd_dev_info(priv->dd, "sde %llx engine %u\n",
> + dd_dev_info(priv->dd, "sde %p engine %u\n",
> (unsigned long long)txq->sde,
Gho,
As Denny mentioned, I'm assuming that the case is no longer required?
Submit a v2 with that change and I will Ack.
Mike
next prev parent reply other threads:[~2021-09-24 14:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 12:33 [PATCH] infiniband hfi1: fix misuse of %x in ipoib_tx.c Guo Zhi
2021-09-22 12:37 ` Dennis Dalessandro
2021-09-24 14:46 ` Marciniszyn, Mike [this message]
2021-09-22 13:48 Guo Zhi
2021-09-22 17:51 ` Marciniszyn, Mike
2021-09-22 18:05 ` Bart Van Assche
2021-09-23 6:45 ` Leon Romanovsky
2021-09-23 11:04 ` Marciniszyn, Mike
2021-09-23 11:44 ` Leon Romanovsky
2021-09-23 12:18 ` Marciniszyn, Mike
2021-09-24 2:46 ` Bart Van Assche
2021-09-24 14:43 ` Marciniszyn, Mike
2021-09-25 0:20 ` Guo Zhi
2021-09-23 11:03 ` Marciniszyn, Mike
2021-09-23 13:15 ` Jason Gunthorpe
2021-09-23 2:03 ` 郭志
2021-09-23 12:51 ` 郭志
2021-09-27 13:05 ` Marciniszyn, Mike
2021-09-27 17:42 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CH0PR01MB71538BE2332867B20A4A77BEF2A49@CH0PR01MB7153.prod.exchangelabs.com \
--to=mike.marciniszyn@cornelisnetworks.com \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=dledford@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=qtxuning1999@sjtu.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).